[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

2022-07-25 Thread GitBox


lordcheng10 commented on PR #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1195033458

   > Can you please explain the problem you want to solve?
   
   Sorry, I didn't describe the problem clearly. @eolivelli 
   
   The lastLogMark update here should be updated after forceWrite is executed. 
Because it is possible that some data is still not flushed to the disk in the 
page cache, if the lastLogMark is updated at this time, when the node goes 
down, data may be lost.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

2022-07-22 Thread GitBox


lordcheng10 commented on PR #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1193020611

   @dlg99 PTAL,thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

2022-07-22 Thread GitBox


lordcheng10 commented on PR #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1193020309

   ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

2022-07-20 Thread GitBox


lordcheng10 commented on PR #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1191011344

   ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

2022-07-19 Thread GitBox


lordcheng10 commented on PR #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1189842103

   @dlg99 @eolivelli @merlimat PTAL,thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

2022-07-17 Thread GitBox


lordcheng10 commented on PR #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1186457833

   ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

2022-07-08 Thread GitBox


lordcheng10 commented on PR #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1178870850

   @eolivelli PTAL,thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

2022-02-17 Thread GitBox


lordcheng10 commented on pull request #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1044018150


   ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

2022-01-13 Thread GitBox


lordcheng10 commented on pull request #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1012325606


   ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

2022-01-12 Thread GitBox


lordcheng10 commented on pull request #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1010938470


   ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

2022-01-11 Thread GitBox


lordcheng10 commented on pull request #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1010382516


   ping


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [bookkeeper] lordcheng10 commented on pull request #2983: fix bug : update lastLogMark after journal file forceWrite

2022-01-11 Thread GitBox


lordcheng10 commented on pull request #2983:
URL: https://github.com/apache/bookkeeper/pull/2983#issuecomment-1009871603


   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org