[GitHub] reddycharan commented on issue #1281: Issue #570: Introducing EntryLogManager.

2018-04-12 Thread GitBox 
reddycharan commented on issue #1281: Issue #570: Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#issuecomment-380903513
 
 
   Discussed with @sijie and decided to revert back some of the changes which 
are not completely related to introduction of EntryLogManager. Will try to 
address those issues in separate Issues/PRs.
   
   @sijie added new commit for this PR, made changes as we discussed yesterday.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] reddycharan commented on issue #1281: Issue #570: Introducing EntryLogManager.

2018-04-10 Thread GitBox 
reddycharan commented on issue #1281: Issue #570: Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#issuecomment-380157141
 
 
   Hey @sijie I think I addressed all of your comments and tests are looking 
good.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services