[jira] [Created] (CALCITE-1206) Push HAVING, ORDER BY and LIMIT into Druid
Julian Hyde created CALCITE-1206: Summary: Push HAVING, ORDER BY and LIMIT into Druid Key: CALCITE-1206 URL: https://issues.apache.org/jira/browse/CALCITE-1206 Project: Calcite Issue Type: Bug Reporter: Julian Hyde Assignee: Julian Hyde Push HAVING, ORDER BY and LIMIT into Druid. This extends the basic Druid adapter added in CALCITE-1121. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1192) Document protobuf and json REP types with examples
[ https://issues.apache.org/jira/browse/CALCITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246665#comment-15246665 ] Francis Chuang commented on CALCITE-1192: - Looks great! :) > Document protobuf and json REP types with examples > -- > > Key: CALCITE-1192 > URL: https://issues.apache.org/jira/browse/CALCITE-1192 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > It would be nice to have the documentation for the Rep types here > (https://calcite.apache.org/docs/avatica_protobuf_reference.html#rep) > documented with examples to show what the serialized representation looks > like. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1192) Document protobuf and json REP types with examples
[ https://issues.apache.org/jira/browse/CALCITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245857#comment-15245857 ] Josh Elser commented on CALCITE-1192: - CALCITE-1205 has the fix to the field name in TypedValue to correct that. I just pushed https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=commit;h=6ddd7821222f1a3e9480c205fdcfa8119b1277c3 which makes the json and protobuf docs consistent about how those date/type datatypes are serialized as numbers. Thanks for taking a look, Francis. > Document protobuf and json REP types with examples > -- > > Key: CALCITE-1192 > URL: https://issues.apache.org/jira/browse/CALCITE-1192 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > It would be nice to have the documentation for the Rep types here > (https://calcite.apache.org/docs/avatica_protobuf_reference.html#rep) > documented with examples to show what the serialized representation looks > like. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CALCITE-1205) Inconsistency in protobuf TypedValue field names
[ https://issues.apache.org/jira/browse/CALCITE-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved CALCITE-1205. - Resolution: Fixed Fixed in https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=commit;h=e010b1b207d8cfbba9d1ff88c65a489fbdeeba40 > Inconsistency in protobuf TypedValue field names > - > > Key: CALCITE-1205 > URL: https://issues.apache.org/jira/browse/CALCITE-1205 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Minor > Fix For: avatica-1.8.0 > > > [~francischuang] pointed out over in CALCITE-1192 that the "byte array" field > in the protobuf TypedValue message has the name "bytes_values" instead of > "bytes_value". Plural here does not make sense (as it is a single collection > of bytes, not multiple collections of bytes). > Changing the field name will not have an affect on binary compatibility, so > I'm going to go ahead and make that change. The java API will change > ever-so-slightly, but we haven't defined what our Java API is truly comprised > of and to what degree we are providing stability, so we'll just ignore that > for now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CALCITE-1205) Inconsistency in protobuf TypedValue field names
Josh Elser created CALCITE-1205: --- Summary: Inconsistency in protobuf TypedValue field names Key: CALCITE-1205 URL: https://issues.apache.org/jira/browse/CALCITE-1205 Project: Calcite Issue Type: Bug Components: avatica Reporter: Josh Elser Assignee: Josh Elser Priority: Minor Fix For: avatica-1.8.0 [~francischuang] pointed out over in CALCITE-1192 that the "byte array" field in the protobuf TypedValue message has the name "bytes_values" instead of "bytes_value". Plural here does not make sense (as it is a single collection of bytes, not multiple collections of bytes). Changing the field name will not have an affect on binary compatibility, so I'm going to go ahead and make that change. The java API will change ever-so-slightly, but we haven't defined what our Java API is truly comprised of and to what degree we are providing stability, so we'll just ignore that for now. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1192) Document protobuf and json REP types with examples
[ https://issues.apache.org/jira/browse/CALCITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245812#comment-15245812 ] Josh Elser commented on CALCITE-1192: - bq. For the bytes_value field, I believe it should be bytes_values as per Ugh, that is extremely unfortunate. That's a typo in the proto definition, rather than a documentation issue. I'm not sure if that's something we can change without breaking protobuf compat, but that's going to be how I'd like to fix it. bq. Also, I think it would be useful to have some notes regarding the time values, for example: Ahh, I had added this for the JSON docs, but forgot to do it for the Protobuf docs. I will amend that. > Document protobuf and json REP types with examples > -- > > Key: CALCITE-1192 > URL: https://issues.apache.org/jira/browse/CALCITE-1192 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Francis Chuang >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > It would be nice to have the documentation for the Rep types here > (https://calcite.apache.org/docs/avatica_protobuf_reference.html#rep) > documented with examples to show what the serialized representation looks > like. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CALCITE-1204) Fix the build
[ https://issues.apache.org/jira/browse/CALCITE-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved CALCITE-1204. - Resolution: Fixed Fixed in https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=commit;h=825acf1e4f728e906ced0b17c4d53d71a121c3e6 > Fix the build > - > > Key: CALCITE-1204 > URL: https://issues.apache.org/jira/browse/CALCITE-1204 > Project: Calcite > Issue Type: Bug > Components: build >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 1.8.0 > > > The JDK8 build has been broken due some invalid javadoc for a while now. I > also noticed that some Avatica additions broke the checkstyle on the Calcite > build. > Fix 'em. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
