[jira] [Commented] (CALCITE-2457) Upgrade to JUnit 5
[ https://issues.apache.org/jira/browse/CALCITE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776018#comment-16776018 ] Andrei Sereda commented on CALCITE-2457: [~vladimirsitnikov] do you think it is time to upgrade to JUnit5 ? Current version is [5.4.0|https://junit.org/junit5/docs/5.4.0/release-notes/] > Upgrade to JUnit 5 > -- > > Key: CALCITE-2457 > URL: https://issues.apache.org/jira/browse/CALCITE-2457 > Project: Calcite > Issue Type: Improvement >Reporter: Vladimir Sitnikov >Priority: Major > Attachments: assert_equals.png, truth_assertmap.png > > > JUnit 5 brings multiple useful features so tests are easier to read and write. > Is there something that blocks upgrading to JUnit 5? > By upgrade I mean bumping up the dependency version and creating new tests > with JUnit 5 features. > Relevant features of JUnit 5: dynamic test, nested tests, parameterized tests > https://twitter.com/nipafx/status/1027095088059559936 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CALCITE-2863) ElasticSearch adapter. Query fails when filtering directly on _MAP
[
https://issues.apache.org/jira/browse/CALCITE-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Sereda resolved CALCITE-2863.
Resolution: Fixed
> ElasticSearch adapter. Query fails when filtering directly on _MAP
> --
>
> Key: CALCITE-2863
> URL: https://issues.apache.org/jira/browse/CALCITE-2863
> Project: Calcite
> Issue Type: Bug
> Components: elasticsearch-adapter
>Reporter: Andrei Sereda
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The following query fails:
> {code:sql}
> select * from elastic where _MAP['state'] = 'NY' order by _MAP['city']
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2863) ElasticSearch adapter. Query fails when filtering directly on _MAP
[
https://issues.apache.org/jira/browse/CALCITE-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CALCITE-2863:
Labels: pull-request-available (was: )
> ElasticSearch adapter. Query fails when filtering directly on _MAP
> --
>
> Key: CALCITE-2863
> URL: https://issues.apache.org/jira/browse/CALCITE-2863
> Project: Calcite
> Issue Type: Bug
> Components: elasticsearch-adapter
>Reporter: Andrei Sereda
>Priority: Major
> Labels: pull-request-available
>
> The following query fails:
> {code:sql}
> select * from elastic where _MAP['state'] = 'NY' order by _MAP['city']
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (CALCITE-2862) Deprecating ExprSimplifier causes some operands not being simplified
[
https://issues.apache.org/jira/browse/CALCITE-2862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rong Rong closed CALCITE-2862.
--
Resolution: Duplicate
> Deprecating ExprSimplifier causes some operands not being simplified
>
>
> Key: CALCITE-2862
> URL: https://issues.apache.org/jira/browse/CALCITE-2862
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Rong Rong
>Priority: Major
>
> This might not be a bug or the original intention of CALCITE-2726 since it is
> not part of the [PR|https://github.com/apache/calcite/pull/956/files].
> The reduction of ExprSimplifier (RexShuttle) actually causes some of the
> chained operations not being simplified. For example:
> {code:java}
> AS(
> +(
> someAggFunc($2, $0),
> CAST(1):BIGINT NOT NULL
> ),
> someName'
> )
> {code}
> Somehow did not get simplified (e.g. the CAST(1) still remains instead of
> being simplified as a Literal.
> My initial feeling is that {{AS}} is not one of the kinds in the case-switch
> code in RexSimplify.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (CALCITE-2863) ElasticSearch adapter. Query fails when filtering directly on _MAP
Andrei Sereda created CALCITE-2863:
--
Summary: ElasticSearch adapter. Query fails when filtering
directly on _MAP
Key: CALCITE-2863
URL: https://issues.apache.org/jira/browse/CALCITE-2863
Project: Calcite
Issue Type: Bug
Components: elasticsearch-adapter
Reporter: Andrei Sereda
The following query fails:
{code:sql}
select * from elastic where _MAP['state'] = 'NY' order by _MAP['city']
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2862) Deprecated ExprSimplifier causes some operands not being simplified
[
https://issues.apache.org/jira/browse/CALCITE-2862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775937#comment-16775937
]
Rong Rong commented on CALCITE-2862:
Thanks for the quick reply [~kgyrtkirk] :-). as you mentioned in the JIRA yeah
this doesn't seem to be limited to just to UDFs I will try some test and will
close as duplicate if our problem is resolved by your patch.
> Deprecated ExprSimplifier causes some operands not being simplified
> ---
>
> Key: CALCITE-2862
> URL: https://issues.apache.org/jira/browse/CALCITE-2862
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Rong Rong
>Priority: Major
>
> This might not be a bug or the original intention of CALCITE-2726 since it is
> not part of the [PR|https://github.com/apache/calcite/pull/956/files].
> The reduction of ExprSimplifier (RexShuttle) actually causes some of the
> chained operations not being simplified. For example:
> {code:java}
> AS(
> +(
> someAggFunc($2, $0),
> CAST(1):BIGINT NOT NULL
> ),
> someName'
> )
> {code}
> Somehow did not get simplified (e.g. the CAST(1) still remains instead of
> being simplified as a Literal.
> My initial feeling is that {{AS}} is not one of the kinds in the case-switch
> code in RexSimplify.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2862) Deprecated ExprSimplifier causes some operands not being simplified
[
https://issues.apache.org/jira/browse/CALCITE-2862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775933#comment-16775933
]
Zoltan Haindrich commented on CALCITE-2862:
---
ExprSimplifier was doing some questionable things (and possibly re-running
simplifications on alterady visited nodes)
I think CALCITE-2852 will probably help with this
> Deprecated ExprSimplifier causes some operands not being simplified
> ---
>
> Key: CALCITE-2862
> URL: https://issues.apache.org/jira/browse/CALCITE-2862
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Rong Rong
>Priority: Major
>
> This might not be a bug or the original intention of CALCITE-2726 since it is
> not part of the [PR|https://github.com/apache/calcite/pull/956/files].
> The reduction of ExprSimplifier (RexShuttle) actually causes some of the
> chained operations not being simplified. For example:
> {code:java}
> AS(
> +(
> someAggFunc($2, $0),
> CAST(1):BIGINT NOT NULL
> ),
> someName'
> )
> {code}
> Somehow did not get simplified (e.g. the CAST(1) still remains instead of
> being simplified as a Literal.
> My initial feeling is that {{AS}} is not one of the kinds in the case-switch
> code in RexSimplify.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (CALCITE-2838) Simplification: Remove redundant IS TRUE checks
[
https://issues.apache.org/jira/browse/CALCITE-2838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoltan Haindrich resolved CALCITE-2838.
---
Resolution: Fixed
fixed in
[c462838f37f02b490088a216773415926688e9f3|https://github.com/apache/calcite/commit/c462838f37f02b490088a216773415926688e9f3]
> Simplification: Remove redundant IS TRUE checks
> ---
>
> Key: CALCITE-2838
> URL: https://issues.apache.org/jira/browse/CALCITE-2838
> Project: Calcite
> Issue Type: Improvement
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> In case simplifcation is already processing in unknownAsFalse mode, {{expr IS
> TRUE}} is redundant - and may just prevent further optimizations from
> happening:
> {code}
> @Test public void testRedundantIsTrue() {
> // in case of unknownAsFalse
> // x is TRUE <=> x
> checkSimplify3(isTrue(vBool(1)),
> "IS TRUE(?0.bool1)",
> "?0.bool1",
> "IS TRUE(?0.bool1)");
> }
> {code}
> there are some further possibilities
> {code}
> (unknownAsTrue) x is NOT FALSE <=> x
> (unknownAsTrue) x is FALSE <=> not x
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2862) Deprecated ExprSimplifier causes some operands not being simplified
[
https://issues.apache.org/jira/browse/CALCITE-2862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rong Rong updated CALCITE-2862:
---
Description:
This might not be a bug or the original intention of CALCITE-2726 since it is
not part of the [PR|https://github.com/apache/calcite/pull/956/files].
The reduction of ExprSimplifier (RexShuttle) actually causes some of the
chained operations not being simplified. For example:
{code:java}
AS(
+(
someAggFunc($2, $0),
CAST(1):BIGINT NOT NULL
),
someName'
)
{code}
Somehow did not get simplified (e.g. the CAST(1) still remains instead of being
simplified as a Literal.
My initial feeling is that {{AS}} is not one of the kinds in the case-switch
code in RexSimplify.
was:
This might not be a bug or the original intention of CALCITE-2726 since it is
not part of the [PR|https://github.com/apache/calcite/pull/956/files].
The reduction of ExprSimplifier (RexShuttle) actually causes some of the
chained operations not being simplified. For example:
{code:java}
AS(
+(
someAggFunc($2, $0),
CAST(1):BIGINT NOT NULL
),
someName'
)
{code}
Somehow did not get simplified. My initial feeling is that {{AS}} is not one of
the kinds in the case-switch code in RexSimplify.
> Deprecated ExprSimplifier causes some operands not being simplified
> ---
>
> Key: CALCITE-2862
> URL: https://issues.apache.org/jira/browse/CALCITE-2862
> Project: Calcite
> Issue Type: Bug
> Components: core
>Reporter: Rong Rong
>Priority: Major
>
> This might not be a bug or the original intention of CALCITE-2726 since it is
> not part of the [PR|https://github.com/apache/calcite/pull/956/files].
> The reduction of ExprSimplifier (RexShuttle) actually causes some of the
> chained operations not being simplified. For example:
> {code:java}
> AS(
> +(
> someAggFunc($2, $0),
> CAST(1):BIGINT NOT NULL
> ),
> someName'
> )
> {code}
> Somehow did not get simplified (e.g. the CAST(1) still remains instead of
> being simplified as a Literal.
> My initial feeling is that {{AS}} is not one of the kinds in the case-switch
> code in RexSimplify.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (CALCITE-2862) Deprecated ExprSimplifier causes some operands not being simplified
Rong Rong created CALCITE-2862:
--
Summary: Deprecated ExprSimplifier causes some operands not being
simplified
Key: CALCITE-2862
URL: https://issues.apache.org/jira/browse/CALCITE-2862
Project: Calcite
Issue Type: Bug
Components: core
Reporter: Rong Rong
This might not be a bug or the original intention of CALCITE-2726 since it is
not part of the [PR|https://github.com/apache/calcite/pull/956/files].
The reduction of ExprSimplifier (RexShuttle) actually causes some of the
chained operations not being simplified. For example:
{code:java}
AS(
+(
someAggFunc($2, $0),
CAST(1):BIGINT NOT NULL
),
someName'
)
{code}
Somehow did not get simplified. My initial feeling is that {{AS}} is not one of
the kinds in the case-switch code in RexSimplify.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
