[jira] [Commented] (CALCITE-6075) Site: Cloning source code from GitHub using git protocol fails

2023-10-26 Thread Jira


[ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780136#comment-17780136
 ] 

蔡灿材 commented on CALCITE-6075:
--

So you need to create a link in the corresponding file

>  Site: Cloning source code from GitHub using git protocol fails
> ---
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Assignee: 蔡灿材
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.36.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be [https://github.com/apache/calcite.git] or 
> g...@github.com:apache/calcite.git
> GitHub removed the unecrypted git protocol a while ago:
> [https://github.blog/changelog/2022-03-15-removed-unencrypted-git-protocol-and-certain-ssh-keys/]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6077) Add FACTORIAL functions (enabled in Hive and Spark library)

2023-10-26 Thread Runkang He (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780133#comment-17780133
 ] 

Runkang He commented on CALCITE-6077:
-

[~julianhyde] thanks for the advice. The combinations and permutations have a 
wider range of use, but currently there are no such functions after I checked 
the main dialects includes MySQL/PostgreSQL/Oracle/BigQuery/Spark/Hive.

> Add FACTORIAL functions (enabled in Hive and Spark library)
> ---
>
> Key: CALCITE-6077
> URL: https://issues.apache.org/jira/browse/CALCITE-6077
> Project: Calcite
>  Issue Type: New Feature
>  Components: core
>Affects Versions: 1.35.0
>Reporter: Runkang He
>Assignee: Runkang He
>Priority: Major
>
> Add FACTORIAL functions (enabled in Hive and Spark library)
> FACTORIAL(expr): Returns the factorial of expr. expr is [0..20]. Otherwise, 
> returns NULL.
> For example:
> {code:sql}
> SELECT factorial(5); 
> >120
> {code}
> See more at 
> [Hive|https://cwiki.apache.org/confluence/display/hive/languagemanual+udf#LanguageManualUDF-MathematicalFunctions]
>  and 
> [Spark|https://spark.apache.org/docs/latest/api/sql/index.html#factorial] doc.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (CALCITE-6078) Explicit cast to DECIMAL types do not check for overflow

2023-10-26 Thread Mihai Budiu (Jira)
Mihai Budiu created CALCITE-6078:


 Summary: Explicit cast to DECIMAL types do not check for overflow
 Key: CALCITE-6078
 URL: https://issues.apache.org/jira/browse/CALCITE-6078
 Project: Calcite
  Issue Type: Bug
  Components: core
Affects Versions: 1.35.0
Reporter: Mihai Budiu


This is a follow-up from [CALCITE-5990]
That issue dealt with integers and floating point.
This issue is about casts to DECIMAL in which the cast value exceeds the scale 
of the target result. Apparently Calcite does not handle such casts properly. 
There are multiple disabled SqlOperatorTests for this condition.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6075) Site: Cloning source code from GitHub using git protocol fails

2023-10-26 Thread Julian Hyde (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780052#comment-17780052
 ] 

Julian Hyde commented on CALCITE-6075:
--

There are a few more:
{noformat}
$ git ls-files |xargs grep -n '\https://gitbox.apache.org/repos/asf/calcite.git;)
build.gradle.kts:987:                            
developerConnection.set("scm:git:https://gitbox.apache.org/repos/asf/calcite.git;)
site/_docs/howto.md:61:$ git clone git://github.com/apache/calcite.git
site/develop/index.md:57:$ git clone git://github.com/apache/calcite.git 
{noformat}

>  Site: Cloning source code from GitHub using git protocol fails
> ---
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Assignee: 蔡灿材
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.36.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be [https://github.com/apache/calcite.git] or 
> g...@github.com:apache/calcite.git
> GitHub removed the unecrypted git protocol a while ago:
> [https://github.blog/changelog/2022-03-15-removed-unencrypted-git-protocol-and-certain-ssh-keys/]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6075) Site: Cloning source code from GitHub using git protocol fails

2023-10-26 Thread Julian Hyde (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780050#comment-17780050
 ] 

Julian Hyde commented on CALCITE-6075:
--

[~zabetak] Please create links rather than pasting URLs. The link in your 
previous comment doesn't work.

>  Site: Cloning source code from GitHub using git protocol fails
> ---
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Assignee: 蔡灿材
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.36.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be [https://github.com/apache/calcite.git] or 
> g...@github.com:apache/calcite.git
> GitHub removed the unecrypted git protocol a while ago:
> [https://github.blog/changelog/2022-03-15-removed-unencrypted-git-protocol-and-certain-ssh-keys/]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (CALCITE-6077) Add FACTORIAL functions (enabled in Hive and Spark library)

2023-10-26 Thread Julian Hyde (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780045#comment-17780045
 ] 

Julian Hyde edited comment on CALCITE-6077 at 10/26/23 6:07 PM:


Do these dialects have functions for combinations and permutations?
{quote}
p(n, r) = n! / (n - r)!
c(n, r) = n! / (r! . (n - r)!)
{quote}

These are related to factorial but are more useful because, by dividing 
factorials by factorials, they tend to stay in a useful range of values.

If there are well-established SQL functions for permutations and combinations I 
think we should do them at the same time as factorial.


was (Author: julianhyde):
Do these dialects have functions for combinations and permutations?
{quote}
p(n, r) = n! / (n - r)!
c(n, r) = n! / (r! . (n - r)!)
{quote}

These are related to factorial but are more useful because, by dividing 
factorials by factorials, they tend to stay in a useful range of values. 

> Add FACTORIAL functions (enabled in Hive and Spark library)
> ---
>
> Key: CALCITE-6077
> URL: https://issues.apache.org/jira/browse/CALCITE-6077
> Project: Calcite
>  Issue Type: New Feature
>  Components: core
>Affects Versions: 1.35.0
>Reporter: Runkang He
>Assignee: Runkang He
>Priority: Major
>
> Add FACTORIAL functions (enabled in Hive and Spark library)
> FACTORIAL(expr): Returns the factorial of expr. expr is [0..20]. Otherwise, 
> returns NULL.
> For example:
> {code:sql}
> SELECT factorial(5); 
> >120
> {code}
> See more at 
> [Hive|https://cwiki.apache.org/confluence/display/hive/languagemanual+udf#LanguageManualUDF-MathematicalFunctions]
>  and 
> [Spark|https://spark.apache.org/docs/latest/api/sql/index.html#factorial] doc.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6077) Add FACTORIAL functions (enabled in Hive and Spark library)

2023-10-26 Thread Julian Hyde (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780045#comment-17780045
 ] 

Julian Hyde commented on CALCITE-6077:
--

Do these dialects have functions for combinations and permutations?
{quote}
p(n, r) = n! / (n - r)!
c(n, r) = n! / (r! . (n - r)!)
{quote}

These are related to factorial but are more useful because, by dividing 
factorials by factorials, they tend to stay in a useful range of values. 

> Add FACTORIAL functions (enabled in Hive and Spark library)
> ---
>
> Key: CALCITE-6077
> URL: https://issues.apache.org/jira/browse/CALCITE-6077
> Project: Calcite
>  Issue Type: New Feature
>  Components: core
>Affects Versions: 1.35.0
>Reporter: Runkang He
>Assignee: Runkang He
>Priority: Major
>
> Add FACTORIAL functions (enabled in Hive and Spark library)
> FACTORIAL(expr): Returns the factorial of expr. expr is [0..20]. Otherwise, 
> returns NULL.
> For example:
> {code:sql}
> SELECT factorial(5); 
> >120
> {code}
> See more at 
> [Hive|https://cwiki.apache.org/confluence/display/hive/languagemanual+udf#LanguageManualUDF-MathematicalFunctions]
>  and 
> [Spark|https://spark.apache.org/docs/latest/api/sql/index.html#factorial] doc.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6028) Join on with more than 20 in conditions will report a null pointer error.

2023-10-26 Thread Ran Tao (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780032#comment-17780032
 ] 

Ran Tao commented on CALCITE-6028:
--

I'm working on this now. almost done, maybe we can add it in 1.36.

> Join on with more than 20 in conditions will report a null pointer error.
> -
>
> Key: CALCITE-6028
> URL: https://issues.apache.org/jira/browse/CALCITE-6028
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Reporter: loukey_j
>Assignee: Ran Tao
>Priority: Critical
> Attachments: image-2023-09-27-20-59-27-654.png, 
> image-2023-09-27-21-03-21-074.png, image-2023-09-27-21-10-43-760.png
>
>
> final String sql = "select t1.x from (values (1, 'a'), (2, 'b')) as t1(x, y) 
> left join (values (1, 'a'), (2, 'b')) as t2(x, y) on t1.x=t2.x and t1.x in 
> (1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21)";   
>  
>  
> java.lang.RuntimeException: while converting `T1`.`X` = `T2`.`X` AND `T1`.`X` 
> IN (1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21)
> at 
> org.apache.calcite.sql2rel.ReflectiveConvertletTable.lambda$registerNodeTypeMethod$1(ReflectiveConvertletTable.java:99)
> at 
> org.apache.calcite.sql2rel.SqlNodeToRexConverterImpl.convertCall(SqlNodeToRexConverterImpl.java:59)
> at 
> org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:5656)
> at 
> org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.visit(SqlToRelConverter.java:4827)
> at org.apache.calcite.sql.SqlCall.accept(SqlCall.java:166)
> at 
> org.apache.calcite.sql2rel.SqlToRelConverter$Blackboard.convertExpression(SqlToRelConverter.java:5469)
> at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertOnCondition(SqlToRelConverter.java:3261)
> at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertJoin(SqlToRelConverter.java:3182)
> at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertFrom(SqlToRelConverter.java:2401)
> at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertFrom(SqlToRelConverter.java:2285)
> at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertSelectImpl(SqlToRelConverter.java:698)
> at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertSelect(SqlToRelConverter.java:679)
> at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertQueryRecursive(SqlToRelConverter.java:3748)
> at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:599)
> at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:257)
> at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:220)
> at 
> org.apache.calcite.prepare.CalcitePrepareImpl.prepare2_(CalcitePrepareImpl.java:666)
> at 
> org.apache.calcite.prepare.CalcitePrepareImpl.prepare_(CalcitePrepareImpl.java:519)
> at 
> org.apache.calcite.prepare.CalcitePrepareImpl.prepareSql(CalcitePrepareImpl.java:487)
> at 
> org.apache.calcite.jdbc.CalciteConnectionImpl.parseQuery(CalciteConnectionImpl.java:236)
> at 
> org.apache.calcite.jdbc.CalciteMetaImpl.prepareAndExecute(CalciteMetaImpl.java:630)
> at 
> org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:677)
> at 
> org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:157)
> at 
> org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:228)
> at 
> org.apache.calcite.examples.foodmart.java.JdbcExample.run(JdbcExample.java:52)
> at 
> org.apache.calcite.examples.foodmart.java.JdbcExample.main(JdbcExample.java:36)
> Caused by: java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> Caused by: java.lang.reflect.InvocationTargetException
>  
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.apache.calcite.sql2rel.ReflectiveConvertletTable.lambda$registerNodeTypeMethod$1(ReflectiveConvertletTable.java:95)
> ... 25 more
> Caused by: java.lang.NullPointerException
> at java.util.Objects.requireNonNull(Objects.java:203)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (CALCITE-6077) Add FACTORIAL functions (enabled in Hive and Spark library)

2023-10-26 Thread Runkang He (Jira)


 [ 
https://issues.apache.org/jira/browse/CALCITE-6077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Runkang He reassigned CALCITE-6077:
---

Assignee: Runkang He

> Add FACTORIAL functions (enabled in Hive and Spark library)
> ---
>
> Key: CALCITE-6077
> URL: https://issues.apache.org/jira/browse/CALCITE-6077
> Project: Calcite
>  Issue Type: New Feature
>  Components: core
>Affects Versions: 1.35.0
>Reporter: Runkang He
>Assignee: Runkang He
>Priority: Major
>
> Add FACTORIAL functions (enabled in Hive and Spark library)
> FACTORIAL(expr): Returns the factorial of expr. expr is [0..20]. Otherwise, 
> returns NULL.
> For example:
> {code:sql}
> SELECT factorial(5); 
> >120
> {code}
> See more at 
> [Hive|https://cwiki.apache.org/confluence/display/hive/languagemanual+udf#LanguageManualUDF-MathematicalFunctions]
>  and 
> [Spark|https://spark.apache.org/docs/latest/api/sql/index.html#factorial] doc.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (CALCITE-6077) Add FACTORIAL functions (enabled in Hive and Spark library)

2023-10-26 Thread Runkang He (Jira)
Runkang He created CALCITE-6077:
---

 Summary: Add FACTORIAL functions (enabled in Hive and Spark 
library)
 Key: CALCITE-6077
 URL: https://issues.apache.org/jira/browse/CALCITE-6077
 Project: Calcite
  Issue Type: New Feature
  Components: core
Affects Versions: 1.35.0
Reporter: Runkang He


Add FACTORIAL functions (enabled in Hive and Spark library)
FACTORIAL(expr): Returns the factorial of expr. expr is [0..20]. Otherwise, 
returns NULL.
For example:

{code:sql}
SELECT factorial(5); 
>120
{code}

See more at 
[Hive|https://cwiki.apache.org/confluence/display/hive/languagemanual+udf#LanguageManualUDF-MathematicalFunctions]
 and [Spark|https://spark.apache.org/docs/latest/api/sql/index.html#factorial] 
doc.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6076) Table function can not refer other table columns

2023-10-26 Thread hongyu guo (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779891#comment-17779891
 ] 

hongyu guo commented on CALCITE-6076:
-

I have dug into the code and git history and found that CALCITE-1309 provides a 
solution by simply using the LATERAL TABLE keyword.

I will close this case.

> Table function can not refer other table columns
> 
>
> Key: CALCITE-6076
> URL: https://issues.apache.org/jira/browse/CALCITE-6076
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.35.0
>Reporter: hongyu guo
>Assignee: hongyu guo
>Priority: Major
>
> SQL
> {code:java}
> select rmp.i from emp, table(ramp(emp.deptno)) as rmp {code}
> will throw an error:
> {code:java}
> Table 'EMP' not found {code}
> during the validation. 
> this SQL fails because the scope of the table function during the validation 
> is {{{}CatalogScope{}}}, not {{{}JoinScope{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (CALCITE-6076) Table function can not refer other table columns

2023-10-26 Thread hongyu guo (Jira)


 [ 
https://issues.apache.org/jira/browse/CALCITE-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongyu guo closed CALCITE-6076.
---
Resolution: Not A Problem

> Table function can not refer other table columns
> 
>
> Key: CALCITE-6076
> URL: https://issues.apache.org/jira/browse/CALCITE-6076
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.35.0
>Reporter: hongyu guo
>Assignee: hongyu guo
>Priority: Major
>
> SQL
> {code:java}
> select rmp.i from emp, table(ramp(emp.deptno)) as rmp {code}
> will throw an error:
> {code:java}
> Table 'EMP' not found {code}
> during the validation. 
> this SQL fails because the scope of the table function during the validation 
> is {{{}CatalogScope{}}}, not {{{}JoinScope{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (CALCITE-5949) RexExecutable should return unchanged original expressions when it fails

2023-10-26 Thread Ruben Q L (Jira)


 [ 
https://issues.apache.org/jira/browse/CALCITE-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ruben Q L reassigned CALCITE-5949:
--

Assignee: Ruben Q L

> RexExecutable should return unchanged original expressions when it fails
> 
>
> Key: CALCITE-5949
> URL: https://issues.apache.org/jira/browse/CALCITE-5949
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.35.0
>Reporter: Claude Brisson
>Assignee: Ruben Q L
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.36.0
>
>
> While reducing, when encountering an invalid expression in the list of 
> constant expressions, RexExecutor is meant to return all initial expressions 
> unchanged.
> It fails to do so, because already handled correct expressions have already 
> been added to the returned list, which can be greater than the input list.
> For instance, when given the list \{ LN(2), LN(-2) }, the RexExecutor will 
> output a list of length 3.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (CALCITE-6076) Table function can not refer other table columns

2023-10-26 Thread hongyu guo (Jira)


 [ 
https://issues.apache.org/jira/browse/CALCITE-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongyu guo updated CALCITE-6076:

Description: 
SQL
{code:java}
select rmp.i from emp, table(ramp(emp.deptno)) as rmp {code}
will throw an error:
{code:java}
Table 'EMP' not found {code}
during the validation. 

this SQL fails because the scope of the table function during the validation is 
{{{}CatalogScope{}}}, not {{{}JoinScope{}}}.

  was:
SQL
{code:java}
select rmp.i from emp, table(ramp(emp.deptno)) as rmp {code}
will throw an error:
{code:java}
Table 'EMP' not found {code}
during the validation. 

this SQL fails because the scope of the table function during the verification 
is CatalogScope, not JoinScope.


> Table function can not refer other table columns
> 
>
> Key: CALCITE-6076
> URL: https://issues.apache.org/jira/browse/CALCITE-6076
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.35.0
>Reporter: hongyu guo
>Assignee: hongyu guo
>Priority: Major
>
> SQL
> {code:java}
> select rmp.i from emp, table(ramp(emp.deptno)) as rmp {code}
> will throw an error:
> {code:java}
> Table 'EMP' not found {code}
> during the validation. 
> this SQL fails because the scope of the table function during the validation 
> is {{{}CatalogScope{}}}, not {{{}JoinScope{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (CALCITE-6076) Table function can not refer other table columns

2023-10-26 Thread hongyu guo (Jira)


 [ 
https://issues.apache.org/jira/browse/CALCITE-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongyu guo updated CALCITE-6076:

Description: 
SQL
{code:java}
select rmp.i from emp, table(ramp(emp.deptno)) as rmp {code}
will throw an error:
{code:java}
Table 'EMP' not found {code}
during the validation. 

this SQL fails because the scope of the table function during the verification 
is CatalogScope, not JoinScope.

  was:
SQL:
{code:java}
select rmp.i from emp, table(ramp(emp.deptno)) as rmp {code}
will throw an error:
{code:java}
Table 'EMP' not found {code}
during the validation. 

this SQL fails because the scope of the table function during the verification 
is CatalogScope, not JoinScope.


> Table function can not refer other table columns
> 
>
> Key: CALCITE-6076
> URL: https://issues.apache.org/jira/browse/CALCITE-6076
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.35.0
>Reporter: hongyu guo
>Assignee: hongyu guo
>Priority: Major
>
> SQL
> {code:java}
> select rmp.i from emp, table(ramp(emp.deptno)) as rmp {code}
> will throw an error:
> {code:java}
> Table 'EMP' not found {code}
> during the validation. 
> this SQL fails because the scope of the table function during the 
> verification is CatalogScope, not JoinScope.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (CALCITE-6076) Table function can not refer other table columns

2023-10-26 Thread hongyu guo (Jira)


 [ 
https://issues.apache.org/jira/browse/CALCITE-6076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

hongyu guo reassigned CALCITE-6076:
---

Assignee: hongyu guo

> Table function can not refer other table columns
> 
>
> Key: CALCITE-6076
> URL: https://issues.apache.org/jira/browse/CALCITE-6076
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.35.0
>Reporter: hongyu guo
>Assignee: hongyu guo
>Priority: Major
>
> SQL:
> {code:java}
> select rmp.i from emp, table(ramp(emp.deptno)) as rmp {code}
> will throw an error:
> {code:java}
> Table 'EMP' not found {code}
> during the validation. 
> this SQL fails because the scope of the table function during the 
> verification is CatalogScope, not JoinScope.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (CALCITE-6076) Table function can not refer other table columns

2023-10-26 Thread hongyu guo (Jira)
hongyu guo created CALCITE-6076:
---

 Summary: Table function can not refer other table columns
 Key: CALCITE-6076
 URL: https://issues.apache.org/jira/browse/CALCITE-6076
 Project: Calcite
  Issue Type: Bug
  Components: core
Affects Versions: 1.35.0
Reporter: hongyu guo


SQL:
{code:java}
select rmp.i from emp, table(ramp(emp.deptno)) as rmp {code}
will throw an error:
{code:java}
Table 'EMP' not found {code}
during the validation. 

this SQL fails because the scope of the table function during the verification 
is CatalogScope, not JoinScope.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (CALCITE-6075) Site: Cloning source code from GitHub using git protocol fails

2023-10-26 Thread Stamatis Zampetakis (Jira)


 [ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stamatis Zampetakis reassigned CALCITE-6075:


Assignee: 蔡灿材

>  Site: Cloning source code from GitHub using git protocol fails
> ---
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Assignee: 蔡灿材
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.36.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be [https://github.com/apache/calcite.git] or 
> g...@github.com:apache/calcite.git
> GitHub removed the unecrypted git protocol a while ago:
> [https://github.blog/changelog/2022-03-15-removed-unencrypted-git-protocol-and-certain-ssh-keys/]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (CALCITE-6075) Site: Cloning source code from GitHub using git protocol fails

2023-10-26 Thread Stamatis Zampetakis (Jira)


 [ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stamatis Zampetakis resolved CALCITE-6075.
--
Fix Version/s: 1.36.0
   (was: 1.35.0)
   Resolution: Fixed

Fixed in 
[https://github.com/apache/calcite/commit/8821eaf94b08dd5c55074b900201da7c386c1635.]
 Thanks [~caicancai] for the contribution and [~taoran]  for the review!

>  Site: Cloning source code from GitHub using git protocol fails
> ---
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.36.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be [https://github.com/apache/calcite.git] or 
> g...@github.com:apache/calcite.git
> GitHub removed the unecrypted git protocol a while ago:
> [https://github.blog/changelog/2022-03-15-removed-unencrypted-git-protocol-and-certain-ssh-keys/]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (CALCITE-6075) Site: Cloning source code from GitHub using git protocol fails

2023-10-26 Thread Stamatis Zampetakis (Jira)


 [ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stamatis Zampetakis updated CALCITE-6075:
-
Description: 
git clone git://github.com/apache/calcite.git does not have this writing 
method. It should be [https://github.com/apache/calcite.git] or 
g...@github.com:apache/calcite.git

GitHub removed the unecrypted git protocol a while ago:

[https://github.blog/changelog/2022-03-15-removed-unencrypted-git-protocol-and-certain-ssh-keys/]

 

  was:
 
git clone git://github.com/apache/calcite.git does not have this writing 
method. It should be https://github.com/apache/calcite.git or 
g...@github.com:apache/calcite.git


>  Site: Cloning source code from GitHub using git protocol fails
> ---
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.35.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be [https://github.com/apache/calcite.git] or 
> g...@github.com:apache/calcite.git
> GitHub removed the unecrypted git protocol a while ago:
> [https://github.blog/changelog/2022-03-15-removed-unencrypted-git-protocol-and-certain-ssh-keys/]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (CALCITE-6075) Site: Cloning source code from GitHub using git protocol fails

2023-10-26 Thread Stamatis Zampetakis (Jira)


 [ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stamatis Zampetakis updated CALCITE-6075:
-
Summary:  Site: Cloning source code from GitHub using git protocol fails  
(was: The git link to download the source code is incorrect)

>  Site: Cloning source code from GitHub using git protocol fails
> ---
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.35.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
>  
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be https://github.com/apache/calcite.git or 
> g...@github.com:apache/calcite.git



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6075) The git link to download the source code is incorrect

2023-10-26 Thread Jira


[ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779806#comment-17779806
 ] 

蔡灿材 commented on CALCITE-6075:
--

Thank you for correcting the error

> The git link to download the source code is incorrect
> -
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.35.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
>  
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be https://github.com/apache/calcite.git or 
> g...@github.com:apache/calcite.git



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (CALCITE-6075) The git link to download the source code is incorrect

2023-10-26 Thread Jira


 [ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

蔡灿材 updated CALCITE-6075:
-
Summary: The git link to download the source code is incorrect  (was: There 
is a problem with the git clone address link)

> The git link to download the source code is incorrect
> -
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.35.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
>  
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be https://github.com/apache/calcite.git or 
> g...@github.com:apache/calcite.git



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6075) There is a problem with the git clone address link

2023-10-26 Thread Ran Tao (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779804#comment-17779804
 ] 

Ran Tao commented on CALCITE-6075:
--

[~caicancai]thanks for reporting this. sounds good.

just a little tip: Generally we need to keep the commit name and jira name 
consistent, and the jira name should try to describe the problem clearly. 

can to remove "There is a problem" try to use a name like 'The git link to 
download the source code is incorrect' or other similar names

> There is a problem with the git clone address link
> --
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.35.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
>  
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be https://github.com/apache/calcite.git or 
> g...@github.com:apache/calcite.git



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (CALCITE-6075) There is a problem with the git clone address link

2023-10-26 Thread Ran Tao (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779804#comment-17779804
 ] 

Ran Tao edited comment on CALCITE-6075 at 10/26/23 8:51 AM:


hi [~caicancai] thanks for reporting this. sounds good.

just a little tip: Generally we need to keep the commit name and jira name 
consistent, and the jira name should try to describe the problem clearly. 

can to remove "There is a problem" try to use a name like 'The git link to 
download the source code is incorrect' or other similar names


was (Author: lemonjing):
[~caicancai]thanks for reporting this. sounds good.

just a little tip: Generally we need to keep the commit name and jira name 
consistent, and the jira name should try to describe the problem clearly. 

can to remove "There is a problem" try to use a name like 'The git link to 
download the source code is incorrect' or other similar names

> There is a problem with the git clone address link
> --
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.35.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
>  
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be https://github.com/apache/calcite.git or 
> g...@github.com:apache/calcite.git



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (CALCITE-6075) There is a problem with the git clone address link

2023-10-26 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated CALCITE-6075:

Labels: pull-request-available  (was: )

> There is a problem with the git clone address link
> --
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.35.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
>  
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be https://github.com/apache/calcite.git or 
> g...@github.com:apache/calcite.git



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (CALCITE-6075) There is a problem with the git clone address link

2023-10-26 Thread Jira


 [ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

蔡灿材 updated CALCITE-6075:
-
Description: 
 
git clone git://github.com/apache/calcite.git does not have this writing 
method. It should be https://github.com/apache/calcite.git or 
g...@github.com:apache/calcite.git

  was:git clone 
git://github.com/apache/calcite.git并没有这种写法,应该是https://github.com/apache/calcite.git或者g...@github.com:apache/calcite.git


> There is a problem with the git clone address link
> --
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Priority: Minor
> Fix For: 1.35.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
>  
> git clone git://github.com/apache/calcite.git does not have this writing 
> method. It should be https://github.com/apache/calcite.git or 
> g...@github.com:apache/calcite.git



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (CALCITE-6075) There is a problem with the git clone address link

2023-10-26 Thread Jira
蔡灿材 created CALCITE-6075:


 Summary: There is a problem with the git clone address link
 Key: CALCITE-6075
 URL: https://issues.apache.org/jira/browse/CALCITE-6075
 Project: Calcite
  Issue Type: Improvement
  Components: site
Affects Versions: 1.35.0
Reporter: 蔡灿材
 Fix For: 1.35.0
 Attachments: 2023-10-26 16-28-15屏幕截图.png

git clone 
git://github.com/apache/calcite.git并没有这种写法,应该是https://github.com/apache/calcite.git或者g...@github.com:apache/calcite.git



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6075) There is a problem with the git clone address link

2023-10-26 Thread Jira


[ 
https://issues.apache.org/jira/browse/CALCITE-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779799#comment-17779799
 ] 

蔡灿材 commented on CALCITE-6075:
--

I will subimit pr

> There is a problem with the git clone address link
> --
>
> Key: CALCITE-6075
> URL: https://issues.apache.org/jira/browse/CALCITE-6075
> Project: Calcite
>  Issue Type: Improvement
>  Components: site
>Affects Versions: 1.35.0
>Reporter: 蔡灿材
>Priority: Minor
> Fix For: 1.35.0
>
> Attachments: 2023-10-26 16-28-15屏幕截图.png
>
>
> git clone 
> git://github.com/apache/calcite.git并没有这种写法,应该是https://github.com/apache/calcite.git或者g...@github.com:apache/calcite.git



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-129) Support recursive WITH queries

2023-10-26 Thread Ruben Q L (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779781#comment-17779781
 ] 

Ruben Q L commented on CALCITE-129:
---

I agree with [~julianhyde].

I have started to take a look at the PR, I have left some minor comments but 
IMO it is in a pretty good shape, with plenty of new tests for this 
improvement. However, I'm not the most expert on the SQL parser & validator, so 
I'd appreciate if someone else could help on that part. 

> Support recursive WITH queries
> --
>
> Key: CALCITE-129
> URL: https://issues.apache.org/jira/browse/CALCITE-129
> Project: Calcite
>  Issue Type: Improvement
>Reporter: GitHub Import
>Assignee: Hanumath Rao Maduri
>Priority: Major
>  Labels: github-import, pull-request-available
> Fix For: 1.36.0
>
>
> Building on https://github.com/julianhyde/optiq/issues/128, enable the 
> RECURSIVE keyword.
> This feature allows relations to be computed iteratively. Whereas 
> ([#128|https://github.com/JulianHyde/optiq/issues/128] | 
> [FLINK-128|https://issues.apache.org/jira/browse/OPTIQ-128]) was mainly a 
> parser/validator change, this feature requires significant changes to the 
> planner and runtime.
>  Imported from GitHub 
> Url: https://github.com/julianhyde/optiq/issues/129
> Created by: [julianhyde|https://github.com/julianhyde]
> Labels: enhancement, 
> Created at: Tue Feb 11 20:29:35 CET 2014
> State: open



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (CALCITE-6072) OpenTelemetry Trace Context Propagation for Avatica

2023-10-26 Thread Istvan Toth (Jira)


 [ 
https://issues.apache.org/jira/browse/CALCITE-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Istvan Toth reassigned CALCITE-6072:


Assignee: Istvan Toth

> OpenTelemetry Trace Context Propagation for Avatica
> ---
>
> Key: CALCITE-6072
> URL: https://issues.apache.org/jira/browse/CALCITE-6072
> Project: Calcite
>  Issue Type: New Feature
>  Components: avatica
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
>
> It would be super useful to be able to propagate the trace context via 
> Avatica.
> Investigate whether the existing Opentelemetry agent can provide this 
> functionality transparently, and if not, what do we need to add to Avatica to 
> enable this.
> Can/does opentelemetry-agent add instrumentation to add the context as HTTP 
> headers in httpclient ?
> Can/does opentelemetry-agent add instrumentation to retrieve the context in 
> Jetty ?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6072) OpenTelemetry Trace Context Propagation for Avatica

2023-10-26 Thread Istvan Toth (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779759#comment-17779759
 ] 

Istvan Toth commented on CALCITE-6072:
--

Opentelemetry seems to have agent-based instrumentation for HttpClient 5:

[https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/apache-httpclient/apache-httpclient-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v5_0]

It doesn't seem to have instrumentation for Jetty server, but context 
propagation could possibly be added to Jetty when setting up the Avatica server 
object.
Keeping this open until I have a working POC at least.

> OpenTelemetry Trace Context Propagation for Avatica
> ---
>
> Key: CALCITE-6072
> URL: https://issues.apache.org/jira/browse/CALCITE-6072
> Project: Calcite
>  Issue Type: New Feature
>  Components: avatica
>Reporter: Istvan Toth
>Priority: Major
>
> It would be super useful to be able to propagate the trace context via 
> Avatica.
> Investigate whether the existing Opentelemetry agent can provide this 
> functionality transparently, and if not, what do we need to add to Avatica to 
> enable this.
> Can/does opentelemetry-agent add instrumentation to add the context as HTTP 
> headers in httpclient ?
> Can/does opentelemetry-agent add instrumentation to retrieve the context in 
> Jetty ?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)