[jira] [Commented] (CALCITE-6108) SQL request to Avatica-Go returns 0s for float types
[
https://issues.apache.org/jira/browse/CALCITE-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785263#comment-17785263
]
Egor Ryashin commented on CALCITE-6108:
---
!image-2023-11-12-10-56-10-382.png!
> SQL request to Avatica-Go returns 0s for float types
>
>
> Key: CALCITE-6108
> URL: https://issues.apache.org/jira/browse/CALCITE-6108
> Project: Calcite
> Issue Type: Bug
> Components: avatica, avatica-go, druid-adapter
>Affects Versions: 1.35.0
>Reporter: Egor Ryashin
>Assignee: Francis Chuang
>Priority: Major
> Attachments: image-2023-11-11-20-42-55-846.png,
> image-2023-11-11-20-43-33-198.png, image-2023-11-11-20-43-49-485.png,
> image-2023-11-12-10-56-10-382.png
>
>
> I have zeros for float types in Go client result set with Calcite 1.35 update
> in Apache Druid. It worked with an older version. From what I see in the
> debugger TypedValue.NumberValue = 0 but DoubleValue = 1. Not sure where's the
> bug exactly - Druid/Avatica.
> This is how it can be reproduced:
> {code:java}
> package main
> import (
> "database/sql"
> "fmt"
> _ "github.com/apache/calcite-avatica-go/v5"
> )
> func main() {
> jdbcUrl := "https://localhost/druid/v2/sql/avatica-protobuf";
> db, err := sql.Open("avatica", jdbcUrl)
> if err != nil {
> panic(err)
> }
> defer db.Close()
> sql4 := `
> SELECT
> cast(1.0 as double) m3
> `
> rows, err := db.Query(sql4)
> if err != nil {
> panic(err)
> }
> defer rows.Close()
> var m1 float32
> for rows.Next() {
> err := rows.Scan(&m1)
> if err != nil {
> panic(err)
> }
> fmt.Println(m1)
> }
> } {code}
> What I see in the debugger right now:
> !image-2023-11-11-20-43-49-485.png!
> This is what I see in the Druid debugger:
> !image-2023-11-11-20-42-55-846.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-6108) SQL request to Avatica-Go returns 0s for float types
[
https://issues.apache.org/jira/browse/CALCITE-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Egor Ryashin updated CALCITE-6108:
--
Attachment: image-2023-11-12-10-56-10-382.png
> SQL request to Avatica-Go returns 0s for float types
>
>
> Key: CALCITE-6108
> URL: https://issues.apache.org/jira/browse/CALCITE-6108
> Project: Calcite
> Issue Type: Bug
> Components: avatica, avatica-go, druid-adapter
>Affects Versions: 1.35.0
>Reporter: Egor Ryashin
>Assignee: Francis Chuang
>Priority: Major
> Attachments: image-2023-11-11-20-42-55-846.png,
> image-2023-11-11-20-43-33-198.png, image-2023-11-11-20-43-49-485.png,
> image-2023-11-12-10-56-10-382.png
>
>
> I have zeros for float types in Go client result set with Calcite 1.35 update
> in Apache Druid. It worked with an older version. From what I see in the
> debugger TypedValue.NumberValue = 0 but DoubleValue = 1. Not sure where's the
> bug exactly - Druid/Avatica.
> This is how it can be reproduced:
> {code:java}
> package main
> import (
> "database/sql"
> "fmt"
> _ "github.com/apache/calcite-avatica-go/v5"
> )
> func main() {
> jdbcUrl := "https://localhost/druid/v2/sql/avatica-protobuf";
> db, err := sql.Open("avatica", jdbcUrl)
> if err != nil {
> panic(err)
> }
> defer db.Close()
> sql4 := `
> SELECT
> cast(1.0 as double) m3
> `
> rows, err := db.Query(sql4)
> if err != nil {
> panic(err)
> }
> defer rows.Close()
> var m1 float32
> for rows.Next() {
> err := rows.Scan(&m1)
> if err != nil {
> panic(err)
> }
> fmt.Println(m1)
> }
> } {code}
> What I see in the debugger right now:
> !image-2023-11-11-20-43-49-485.png!
> This is what I see in the Druid debugger:
> !image-2023-11-11-20-42-55-846.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CALCITE-6100) The equalsDeep of SqlRowTypeNameSpec should use equalsDeep for fieldTypes rather than reference comparison
[
https://issues.apache.org/jira/browse/CALCITE-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785221#comment-17785221
]
Dmitry Sysolyatin commented on CALCITE-6100:
Fixed in
[{{816edd1}}|https://github.com/apache/calcite/commit/816edd1fa1a1d6af7e72416d791eb01d8c66b6ea].
Thanks for review [~julianhyde], [~mbudiu]!
> The equalsDeep of SqlRowTypeNameSpec should use equalsDeep for fieldTypes
> rather than reference comparison
> --
>
> Key: CALCITE-6100
> URL: https://issues.apache.org/jira/browse/CALCITE-6100
> Project: Calcite
> Issue Type: Bug
> Components: core
>Affects Versions: 1.35.0, 1.36.0
>Reporter: Dmitry Sysolyatin
>Assignee: Dmitry Sysolyatin
>Priority: Major
> Labels: pull-request-available
>
> SqlRowTypeNameSpec#equalsDeep method uses reference comparison for objects
> inside fieldTypes list instead of using SqlDataTypeSpec#equalsDeep.
> Testcase: Add to `SqlEqualsDeepTest` the following lines of code:
> {code:java}
> @Test
> void testRowEqualsDeep() throws SqlParseException {
> assertEqualsDeep("CAST(a AS ROW(field INTEGER))",
> "CAST(a AS ROW(field INTEGER))", true);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (CALCITE-6100) The equalsDeep of SqlRowTypeNameSpec should use equalsDeep for fieldTypes rather than reference comparison
[
https://issues.apache.org/jira/browse/CALCITE-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Sysolyatin resolved CALCITE-6100.
Fix Version/s: 1.37.0
Resolution: Fixed
> The equalsDeep of SqlRowTypeNameSpec should use equalsDeep for fieldTypes
> rather than reference comparison
> --
>
> Key: CALCITE-6100
> URL: https://issues.apache.org/jira/browse/CALCITE-6100
> Project: Calcite
> Issue Type: Bug
> Components: core
>Affects Versions: 1.35.0, 1.36.0
>Reporter: Dmitry Sysolyatin
>Assignee: Dmitry Sysolyatin
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.37.0
>
>
> SqlRowTypeNameSpec#equalsDeep method uses reference comparison for objects
> inside fieldTypes list instead of using SqlDataTypeSpec#equalsDeep.
> Testcase: Add to `SqlEqualsDeepTest` the following lines of code:
> {code:java}
> @Test
> void testRowEqualsDeep() throws SqlParseException {
> assertEqualsDeep("CAST(a AS ROW(field INTEGER))",
> "CAST(a AS ROW(field INTEGER))", true);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (CALCITE-6108) SQL request to Avatica-Go returns 0s for float types
Egor Ryashin created CALCITE-6108:
-
Summary: SQL request to Avatica-Go returns 0s for float types
Key: CALCITE-6108
URL: https://issues.apache.org/jira/browse/CALCITE-6108
Project: Calcite
Issue Type: Bug
Components: avatica, avatica-go, druid-adapter
Affects Versions: 1.35.0
Reporter: Egor Ryashin
Assignee: Francis Chuang
Attachments: image-2023-11-11-20-42-55-846.png,
image-2023-11-11-20-43-33-198.png, image-2023-11-11-20-43-49-485.png
I have zeros for float types in Go client result set with Calcite 1.35 update
in Apache Druid. It worked with an older version. From what I see in the
debugger TypedValue.NumberValue = 0 but DoubleValue = 1. Not sure where's the
bug exactly - Druid/Avatica.
This is how it can be reproduced:
{code:java}
package main
import (
"database/sql"
"fmt"
_ "github.com/apache/calcite-avatica-go/v5"
)
func main() {
jdbcUrl := "https://localhost/druid/v2/sql/avatica-protobuf";
db, err := sql.Open("avatica", jdbcUrl)
if err != nil {
panic(err)
}
defer db.Close()
sql4 := `
SELECT
cast(1.0 as double) m3
`
rows, err := db.Query(sql4)
if err != nil {
panic(err)
}
defer rows.Close()
var m1 float32
for rows.Next() {
err := rows.Scan(&m1)
if err != nil {
panic(err)
}
fmt.Println(m1)
}
} {code}
What I see in the debugger right now:
!image-2023-11-11-20-43-49-485.png!
This is what I see in the Druid debugger:
!image-2023-11-11-20-42-55-846.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CALCITE-5584) Publish website action only triggers for the last commit in the chain
[ https://issues.apache.org/jira/browse/CALCITE-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785176#comment-17785176 ] Benchao Li commented on CALCITE-5584: - I ran into the very same situation while releasing 1.36.0, I plan to add a few improvements to the documentation, and this one will be one of them. > Publish website action only triggers for the last commit in the chain > -- > > Key: CALCITE-5584 > URL: https://issues.apache.org/jira/browse/CALCITE-5584 > Project: Calcite > Issue Type: Bug > Components: build >Affects Versions: 1.34.0 >Reporter: Stamatis Zampetakis >Priority: Major > > At some point, towards the end of the 1.34.0 release process, I pushed two > commits together from my local repository to the remote: > * > [https://github.com/apache/calcite/commit/de305074f4dad5f157abb149319d1664fa2fe68d] > * > [https://github.com/apache/calcite/commit/421c871e5f9f3ea7c660bea48f2099d0cd41ffcf] > The [publish website > action|https://github.com/apache/calcite/actions/runs/4416430449/jobs/7740705842] > was triggered only for the last commit, > 421c871e5f9f3ea7c660bea48f2099d0cd41ffcf, which doesn't have any changes to > the site thus the changes in de305074f4dad5f157abb149319d1664fa2fe68d are not > reflected to calcite.apache.org. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6107) Upgrade vlsi-release-plugins to 1.90
[ https://issues.apache.org/jira/browse/CALCITE-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6107. - Resolution: Fixed > Upgrade vlsi-release-plugins to 1.90 > > > Key: CALCITE-6107 > URL: https://issues.apache.org/jira/browse/CALCITE-6107 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6107) Upgrade vlsi-release-plugins to 1.90
[ https://issues.apache.org/jira/browse/CALCITE-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang updated CALCITE-6107: Component/s: (was: core) > Upgrade vlsi-release-plugins to 1.90 > > > Key: CALCITE-6107 > URL: https://issues.apache.org/jira/browse/CALCITE-6107 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6107) Upgrade vlsi-release-plugins to 1.90
Francis Chuang created CALCITE-6107: --- Summary: Upgrade vlsi-release-plugins to 1.90 Key: CALCITE-6107 URL: https://issues.apache.org/jira/browse/CALCITE-6107 Project: Calcite Issue Type: New Feature Components: avatica, core Reporter: Francis Chuang Assignee: Francis Chuang -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6106) Switch from gradle to eclipse-temurin image for avatica docker-compose release commands
[ https://issues.apache.org/jira/browse/CALCITE-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francis Chuang resolved CALCITE-6106. - Resolution: Fixed > Switch from gradle to eclipse-temurin image for avatica docker-compose > release commands > --- > > Key: CALCITE-6106 > URL: https://issues.apache.org/jira/browse/CALCITE-6106 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Switch to the eclipse-temurin image and call ./gradlew instead of gradle, so > the gradle version used is never out of sync. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-6103) Use eclipse-temurin image to build and publish javadocs for the website
[
https://issues.apache.org/jira/browse/CALCITE-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francis Chuang resolved CALCITE-6103.
-
Resolution: Fixed
> Use eclipse-temurin image to build and publish javadocs for the website
> ---
>
> Key: CALCITE-6103
> URL: https://issues.apache.org/jira/browse/CALCITE-6103
> Project: Calcite
> Issue Type: New Feature
> Components: core, site
>Reporter: Francis Chuang
>Assignee: Francis Chuang
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.37.0
>
>
> Javadoc builds currently fail in GitHub Actions:
> {code:java}
> Run docker-compose run generate-javadoc
>
> Pulling generate-javadoc (openjdk:17)...
> 17: Pulling from library/openjdk
> Digest:
> sha256:528707081fdb9562eb819128a9f85ae7fe000e2fbaeaf9f87662e7b3f38cb7d8
> Status: Downloaded newer image for openjdk:17
> Creating site_generate-javadoc_run ...
> Creating site_generate-javadoc_run ... done
> xargs is not available
> mv: cannot stat 'build/docs/javadocAggregate': No such file or directory
> 1
> Error: Process completed with exit code 1.
> {code}
> There was probably a change in the openjdk:17 image, which has since been
> deprecated. As a fix, we should move to the eclipse-temurin, which is a
> direct replacement.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-6100) The equalsDeep of SqlRowTypeNameSpec should use equalsDeep for fieldTypes rather than reference comparison
[
https://issues.apache.org/jira/browse/CALCITE-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Sysolyatin updated CALCITE-6100:
---
Summary: The equalsDeep of SqlRowTypeNameSpec should use equalsDeep for
fieldTypes rather than reference comparison (was: The equalsDeep of
SqlRowTypeNameSpec should return true if two SqlRowTypeNameSpecs are
structurally equivalent)
> The equalsDeep of SqlRowTypeNameSpec should use equalsDeep for fieldTypes
> rather than reference comparison
> --
>
> Key: CALCITE-6100
> URL: https://issues.apache.org/jira/browse/CALCITE-6100
> Project: Calcite
> Issue Type: Bug
> Components: core
>Affects Versions: 1.35.0, 1.36.0
>Reporter: Dmitry Sysolyatin
>Assignee: Dmitry Sysolyatin
>Priority: Major
> Labels: pull-request-available
>
> SqlRowTypeNameSpec#equalsDeep method uses reference comparison for objects
> inside fieldTypes list instead of using SqlDataTypeSpec#equalsDeep.
> Testcase: Add to `SqlEqualsDeepTest` the following lines of code:
> {code:java}
> @Test
> void testRowEqualsDeep() throws SqlParseException {
> assertEqualsDeep("CAST(a AS ROW(field INTEGER))",
> "CAST(a AS ROW(field INTEGER))", true);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-6106) Switch from gradle to eclipse-temurin image for avatica docker-compose release commands
[ https://issues.apache.org/jira/browse/CALCITE-6106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-6106: Labels: pull-request-available (was: ) > Switch from gradle to eclipse-temurin image for avatica docker-compose > release commands > --- > > Key: CALCITE-6106 > URL: https://issues.apache.org/jira/browse/CALCITE-6106 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Francis Chuang >Assignee: Francis Chuang >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Switch to the eclipse-temurin image and call ./gradlew instead of gradle, so > the gradle version used is never out of sync. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-6106) Switch from gradle to eclipse-temurin image for avatica docker-compose release commands
Francis Chuang created CALCITE-6106: --- Summary: Switch from gradle to eclipse-temurin image for avatica docker-compose release commands Key: CALCITE-6106 URL: https://issues.apache.org/jira/browse/CALCITE-6106 Project: Calcite Issue Type: New Feature Components: avatica Reporter: Francis Chuang Assignee: Francis Chuang Switch to the eclipse-temurin image and call ./gradlew instead of gradle, so the gradle version used is never out of sync. -- This message was sent by Atlassian Jira (v8.20.10#820010)
