[jira] [Commented] (CALCITE-6175) Upgrade OpenCSV to version 5
[ https://issues.apache.org/jira/browse/CALCITE-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811708#comment-17811708 ] Jiajun Xie commented on CALCITE-6175: - Look good. [~ymlai87416] , I am very interested in the reasons why you upgraded OpenCSV. How do you use CsvEnumerator.java for production data? > Upgrade OpenCSV to version 5 > > > Key: CALCITE-6175 > URL: https://issues.apache.org/jira/browse/CALCITE-6175 > Project: Calcite > Issue Type: Improvement > Components: csv-adapter, splunk >Affects Versions: 1.36.0 >Reporter: Tom Lai >Priority: Trivial > Labels: pull-request-available > > Upgrade OpenCSV from version 2.3 to latest version 5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6175) Upgrade OpenCSV to version 5
[ https://issues.apache.org/jira/browse/CALCITE-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Lai updated CALCITE-6175: - Component/s: splunk > Upgrade OpenCSV to version 5 > > > Key: CALCITE-6175 > URL: https://issues.apache.org/jira/browse/CALCITE-6175 > Project: Calcite > Issue Type: Improvement > Components: csv-adapter, splunk >Affects Versions: 1.36.0 >Reporter: Tom Lai >Priority: Trivial > Labels: pull-request-available > > Upgrade OpenCSV from version 2.3 to latest version 5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6175) Upgrade OpenCSV to version 5
[ https://issues.apache.org/jira/browse/CALCITE-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Lai updated CALCITE-6175: - Affects Version/s: 1.36.0 > Upgrade OpenCSV to version 5 > > > Key: CALCITE-6175 > URL: https://issues.apache.org/jira/browse/CALCITE-6175 > Project: Calcite > Issue Type: Improvement > Components: csv-adapter >Affects Versions: 1.36.0 >Reporter: Tom Lai >Priority: Trivial > Labels: pull-request-available > > Upgrade OpenCSV from version 2.3 to latest version 5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-6175) Upgrade OpenCSV to version 5
[ https://issues.apache.org/jira/browse/CALCITE-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-6175: Labels: pull-request-available (was: ) > Upgrade OpenCSV to version 5 > > > Key: CALCITE-6175 > URL: https://issues.apache.org/jira/browse/CALCITE-6175 > Project: Calcite > Issue Type: Improvement > Components: csv-adapter >Reporter: Tom Lai >Priority: Trivial > Labels: pull-request-available > > Upgrade OpenCSV from version 2.3 to latest version 5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-6214) Remove DISTINCT in aggregate function if field is unique
[
https://issues.apache.org/jira/browse/CALCITE-6214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811647#comment-17811647
]
Jiajun Xie commented on CALCITE-6214:
-
I removed `AggregateRemoveDistinctRule` and added `removeRedundantDistinct` to
`RelBuilder`.
Some users maybe not like optimized logical plan by `RelBuilder`.
So the default value is false for `redundantDistinct`.
> Remove DISTINCT in aggregate function if field is unique
>
>
> Key: CALCITE-6214
> URL: https://issues.apache.org/jira/browse/CALCITE-6214
> Project: Calcite
> Issue Type: Improvement
> Components: core
>Reporter: Jiajun Xie
>Assignee: Jiajun Xie
>Priority: Minor
> Labels: pull-request-available
>
> For the sql
> {code:java}
> select count(distinct x) cnt
> from(
>select distinct sal x from emp
> ) t {code}
> The distinct that in count can be removed.
> {code:java}
> LogicalAggregate(group=[{}], CNT=[COUNT($0)])
> LogicalAggregate(group=[{0}])
> LogicalProject(X=[$5])
> LogicalTableScan(table=[[CATALOG, SALES, EMP]]) {code}
> But `CoreRules#AGGREGATE_REMOVE` not support it, so there are two DISTINCT.
> {code:java}
> LogicalAggregate(group=[{}], CNT=[COUNT(DISTINCT $0)])
> LogicalAggregate(group=[{0}])
> LogicalProject(X=[$5])
> LogicalTableScan(table=[[CATALOG, SALES, EMP]]) {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (CALCITE-6218) RelToSqlConverter fails to convert correlated lateral joins
[
https://issues.apache.org/jira/browse/CALCITE-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated CALCITE-6218:
Labels: pull-request-available (was: )
> RelToSqlConverter fails to convert correlated lateral joins
> ---
>
> Key: CALCITE-6218
> URL: https://issues.apache.org/jira/browse/CALCITE-6218
> Project: Calcite
> Issue Type: Bug
> Components: core
>Affects Versions: 1.36.0
>Reporter: Guillaume Massé
>Priority: Major
> Labels: pull-request-available
>
>
> input query:
> {code:sql}
> SELECT
> "a", "x"
> FROM
> "myDb"."myTable",
> unnest("xs") as "x"; {code}
> schema:
> [https://github.com/MasseGuillaume/calcite/blob/0126e6cfa47061886b2012ad2d2c32408455ae88/testkit/src/main/java/org/apache/calcite/test/CalciteAssert.java#L2180-L2211]
> {code:java}
> myTable(
> a: BIGINT,
> // ...
> xs: ARRAY,
> // ...
> )
> {code}
> logical plan:
> {code:java}
> LogicalProject(a=[$0], x=[$6])
> LogicalCorrelate(correlation=[$cor0], joinType=[inner],
> requiredColumns=[{4}])
> LogicalProject(a=[$0], b=[$1.n11.b], c=[$1.n12.c], d=[$2.d], xs=[$3],
> e=[$4])
> LogicalTableScan(table=[[myDb, myTable]])
> Uncollect
> LogicalProject(xs=[$cor0.xs])
> LogicalValues(tuples=[[{ 0 }]])
> {code}
> obtained sql:
>
> {code:sql}
> SELECT
> "$cor0"."a",
> "$cor0"."xs0" AS "x" -- <-- xs0 ?
> FROM
> (
> SELECT "a", "n1"."n11"."b", "n1"."n12"."c", "n2"."d", "xs", "e" FROM
> "myDb"."myTable"
> ) AS "$cor0",
> LATERAL UNNEST (
> SELECT "$cor0"."xs" FROM (VALUES (0)) AS "t" ("ZERO")
> ) AS "t1" ("xs") AS "t10"
> {code}
> I would expect the query to be converted to something close to the original
> query. Here "xs0" does not exists.
>
> [https://github.com/MasseGuillaume/calcite/commit/0126e6cfa47061886b2012ad2d2c32408455ae88]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CALCITE-6218) RelToSqlConverter fails to convert correlated lateral joins
[
https://issues.apache.org/jira/browse/CALCITE-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811644#comment-17811644
]
EveyWu commented on CALCITE-6218:
--
[~MasseGuillaume] I submitted a PR to solve the problem of "xs0" not exists。
I also think there can be more improvements here，correlated lateral join can be
handled directly instead of a lot of rewrites.
> RelToSqlConverter fails to convert correlated lateral joins
> ---
>
> Key: CALCITE-6218
> URL: https://issues.apache.org/jira/browse/CALCITE-6218
> Project: Calcite
> Issue Type: Bug
> Components: core
>Affects Versions: 1.36.0
>Reporter: Guillaume Massé
>Priority: Major
> Labels: pull-request-available
>
>
> input query:
> {code:sql}
> SELECT
> "a", "x"
> FROM
> "myDb"."myTable",
> unnest("xs") as "x"; {code}
> schema:
> [https://github.com/MasseGuillaume/calcite/blob/0126e6cfa47061886b2012ad2d2c32408455ae88/testkit/src/main/java/org/apache/calcite/test/CalciteAssert.java#L2180-L2211]
> {code:java}
> myTable(
> a: BIGINT,
> // ...
> xs: ARRAY,
> // ...
> )
> {code}
> logical plan:
> {code:java}
> LogicalProject(a=[$0], x=[$6])
> LogicalCorrelate(correlation=[$cor0], joinType=[inner],
> requiredColumns=[{4}])
> LogicalProject(a=[$0], b=[$1.n11.b], c=[$1.n12.c], d=[$2.d], xs=[$3],
> e=[$4])
> LogicalTableScan(table=[[myDb, myTable]])
> Uncollect
> LogicalProject(xs=[$cor0.xs])
> LogicalValues(tuples=[[{ 0 }]])
> {code}
> obtained sql:
>
> {code:sql}
> SELECT
> "$cor0"."a",
> "$cor0"."xs0" AS "x" -- <-- xs0 ?
> FROM
> (
> SELECT "a", "n1"."n11"."b", "n1"."n12"."c", "n2"."d", "xs", "e" FROM
> "myDb"."myTable"
> ) AS "$cor0",
> LATERAL UNNEST (
> SELECT "$cor0"."xs" FROM (VALUES (0)) AS "t" ("ZERO")
> ) AS "t1" ("xs") AS "t10"
> {code}
> I would expect the query to be converted to something close to the original
> query. Here "xs0" does not exists.
>
> [https://github.com/MasseGuillaume/calcite/commit/0126e6cfa47061886b2012ad2d2c32408455ae88]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
