[jira] [Comment Edited] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397741#comment-17397741 ] John Bodley edited comment on CALCITE-4727 at 8/12/21, 6:27 PM: [~elserj] sorry I can't provide an encapsulated example. The error above was provided from running Tableau Desktop communicating to a custom local Avatica server. Is the second link I provided (which contains the following statement), {code} @JsonSubTypes.Type(value = RpcMetadataResponse.class, name = "rpcMetadata") {code} I thought that was maybe that was the culprit from the JSON serialization path. was (Author: john.bod...@gmail.com): [~elserj] sorry I can't provide an encapsulated example. The error above was provided from running Tableau Desktop communicating to a custom local Avatica server. Is the second link I provided which refers to the following line {code} @JsonSubTypes.Type(value = RpcMetadataResponse.class, name = "rpcMetadata") {code} and thought that was maybe the culprit from the JSON serialization path. > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397741#comment-17397741 ] John Bodley edited comment on CALCITE-4727 at 8/12/21, 2:43 AM: [~elserj] sorry I can't provide an encapsulated example. The error above was provided from running Tableau Desktop communicating to a custom local Avatica server. Is the second link I provided which refers to the following line {code} @JsonSubTypes.Type(value = RpcMetadataResponse.class, name = "rpcMetadata") {code} and thought that was maybe the culprit from the JSON serialization path. was (Author: john.bod...@gmail.com): [~elserj] sorry I can't provide an encapsulated example. The error above was provided from running Tableau Desktop communicating to a custom local Avatica server. Is the second link I provided which refers to the following line {code} @JsonSubTypes.Type(value = RpcMetadataResponse.class, name = "rpcMetadata") {code} maybe the culprit from the JSON serialization path? > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397741#comment-17397741 ] John Bodley commented on CALCITE-4727: -- [~elserj] sorry I can't provide an encapsulated example. The error above was provided from running Tableau Desktop communicating to a custom local Avatica server. Is the second link I provided which refers to the following line {code} @JsonSubTypes.Type(value = RpcMetadataResponse.class, name = "rpcMetadata") {code} maybe the culprit from the JSON serialization path? > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397651#comment-17397651 ] John Bodley edited comment on CALCITE-4727 at 8/11/21, 10:37 PM: - For context here's the error I get when trying to connect to Tableau when I exclude the `response` property in the {{RpcMetadata}} object, {code:java} An error occurred while communicating with Other Databases (JDBC) Bad Connection: Tableau could not connect to the data source. Error Code: FAB9A2C5 org.apache.calcite.avatica.com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.apache.calcite.avatica.remote.Service$RpcMetadataResponse]: missing type id property 'response' (for POJO property 'rpcMetadata') at [Source: (String)"{ "connectionId": "1d919ce0-c430-42b6-b5d9-8cfeb532fdb0", "rpcMetadata": {}, "firstFrame": { "rows": [ [ "VIEW" ] ], "done": true, "offset": 0 }, "updateCount": -1, "response": "resultSet" } "; line: 14, column: 17] (through reference chain: org.apache.calcite.avatica.remote.Service$ResultSetResponse["rpcMetadata"]) {code} as per [here|https://github.com/apache/calcite-avatica/blob/master/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L174] it does seem like the {{RpcMetadata}} object is being treated as a response. was (Author: john.bod...@gmail.com): For context here's the error I get when trying to connect to Tableau when I exclude the `response` property in the {{RpcMetadata}} object. {code:java} An error occurred while communicating with Other Databases (JDBC) Bad Connection: Tableau could not connect to the data source. Error Code: FAB9A2C5 org.apache.calcite.avatica.com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.apache.calcite.avatica.remote.Service$RpcMetadataResponse]: missing type id property 'response' (for POJO property 'rpcMetadata') at [Source: (String)"{ "connectionId": "1d919ce0-c430-42b6-b5d9-8cfeb532fdb0", "rpcMetadata": {}, "firstFrame": { "rows": [ [ "VIEW" ] ], "done": true, "offset": 0 }, "updateCount": -1, "response": "resultSet" } "; line: 14, column: 17] (through reference chain: org.apache.calcite.avatica.remote.Service$ResultSetResponse["rpcMetadata"]) {code} as per [here|https://github.com/apache/calcite-avatica/blob/master/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L174] it does seem like the {{RpcMetadata}} object is being treated as a response. > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397651#comment-17397651 ] John Bodley edited comment on CALCITE-4727 at 8/11/21, 10:36 PM: - For context here's the error I get when trying to connect to Tableau when I exclude the `response` property in the {{RpcMetadata}} object. {code:java} An error occurred while communicating with Other Databases (JDBC) Bad Connection: Tableau could not connect to the data source. Error Code: FAB9A2C5 org.apache.calcite.avatica.com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.apache.calcite.avatica.remote.Service$RpcMetadataResponse]: missing type id property 'response' (for POJO property 'rpcMetadata') at [Source: (String)"{ "connectionId": "1d919ce0-c430-42b6-b5d9-8cfeb532fdb0", "rpcMetadata": {}, "firstFrame": { "rows": [ [ "VIEW" ] ], "done": true, "offset": 0 }, "updateCount": -1, "response": "resultSet" } "; line: 14, column: 17] (through reference chain: org.apache.calcite.avatica.remote.Service$ResultSetResponse["rpcMetadata"]) {code} as per [here|https://github.com/apache/calcite-avatica/blob/master/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L174] it does seem like the {{RpcMetadata}} object is being treated as a response. was (Author: john.bod...@gmail.com): For context here's the error I get when trying to connect to Tableau when I exclude the `response` property in the {{RpcMetadata}} object. {code:java} An error occurred while communicating with Other Databases (JDBC) Bad Connection: Tableau could not connect to the data source. Error Code: FAB9A2C5 org.apache.calcite.avatica.com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.apache.calcite.avatica.remote.Service$RpcMetadataResponse]: missing type id property 'response' (for POJO property 'rpcMetadata') at [Source: (String)"{ "connectionId": "1d919ce0-c430-42b6-b5d9-8cfeb532fdb0", "rpcMetadata": {}, "firstFrame": { "rows": [ [ "VIEW" ] ], "done": true, "offset": 0 }, "updateCount": -1, "response": "resultSet" } "; line: 14, column: 17] (through reference chain: org.apache.calcite.avatica.remote.Service$ResultSetResponse["rpcMetadata"]) {code} Finally per [here|https://github.com/apache/calcite-avatica/blob/master/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L174] it does seem like the {{RpcMetadata}} object is being treated as a response. > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397651#comment-17397651 ] John Bodley edited comment on CALCITE-4727 at 8/11/21, 10:36 PM: - For context here's the error I get when trying to connect to Tableau when I exclude the `response` property in the {{RpcMetadata}} object. {code:java} An error occurred while communicating with Other Databases (JDBC) Bad Connection: Tableau could not connect to the data source. Error Code: FAB9A2C5 org.apache.calcite.avatica.com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.apache.calcite.avatica.remote.Service$RpcMetadataResponse]: missing type id property 'response' (for POJO property 'rpcMetadata') at [Source: (String)"{ "connectionId": "1d919ce0-c430-42b6-b5d9-8cfeb532fdb0", "rpcMetadata": {}, "firstFrame": { "rows": [ [ "VIEW" ] ], "done": true, "offset": 0 }, "updateCount": -1, "response": "resultSet" } "; line: 14, column: 17] (through reference chain: org.apache.calcite.avatica.remote.Service$ResultSetResponse["rpcMetadata"]) {code} Finally per [here|https://github.com/apache/calcite-avatica/blob/master/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L174] it does seem like the {{RpcMetadata}} object is being treated as a response. was (Author: john.bod...@gmail.com): For context here's the error I get when trying to connect to Tableau when I exclude the `response` property in the {{RpcMetadata}} object. {code:java} An error occurred while communicating with Other Databases (JDBC) Bad Connection: Tableau could not connect to the data source. Error Code: FAB9A2C5 org.apache.calcite.avatica.com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.apache.calcite.avatica.remote.Service$RpcMetadataResponse]: missing type id property 'response' (for POJO property 'rpcMetadata') at [Source: (String)"{ "connectionId": "1d919ce0-c430-42b6-b5d9-8cfeb532fdb0", "rpcMetadata": {}, "firstFrame": { "rows": [ [ "VIEW" ] ], "done": true, "offset": 0 }, "updateCount": -1, "response": "resultSet" } "; line: 14, column: 17] (through reference chain: org.apache.calcite.avatica.remote.Service$ResultSetResponse["rpcMetadata"]) {code} > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397651#comment-17397651 ] John Bodley edited comment on CALCITE-4727 at 8/11/21, 10:35 PM: - For context here's the error I get when trying to connect to Tableau when I exclude the `response` property in the {{RpcMetadata}} object. {code:java} An error occurred while communicating with Other Databases (JDBC) Bad Connection: Tableau could not connect to the data source. Error Code: FAB9A2C5 org.apache.calcite.avatica.com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.apache.calcite.avatica.remote.Service$RpcMetadataResponse]: missing type id property 'response' (for POJO property 'rpcMetadata') at [Source: (String)"{ "connectionId": "1d919ce0-c430-42b6-b5d9-8cfeb532fdb0", "rpcMetadata": {}, "firstFrame": { "rows": [ [ "VIEW" ] ], "done": true, "offset": 0 }, "updateCount": -1, "response": "resultSet" } "; line: 14, column: 17] (through reference chain: org.apache.calcite.avatica.remote.Service$ResultSetResponse["rpcMetadata"]) {code} was (Author: john.bod...@gmail.com): For context here's the error I get when trying to connect to Tableau when I exclude the `response` property in the {{RpcMetadata}} object. {code:java} An error occurred while communicating with Other Databases (JDBC) Bad Connection: Tableau could not connect to the data source. Error Code: FAB9A2C5 org.apache.calcite.avatica.com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.apache.calcite.avatica.remote.Service$RpcMetadataResponse]: missing type id property 'response' (for POJO property 'rpcMetadata') at [Source: (String)"{ "connectionId": "1d919ce0-c430-42b6-b5d9-8cfeb532fdb0", "rpcMetadata": {}, "firstFrame": { "rows": [ [ "VIEW" ] ], "done": true, "offset": 0 }, "updateCount": -1, "response": "resultSet" } "; line: 14, column: 17] (through reference chain: org.apache.calcite.avatica.remote.Service$ResultSetResponse["rpcMetadata"]) {code} > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397651#comment-17397651 ] John Bodley edited comment on CALCITE-4727 at 8/11/21, 9:42 PM: For context here's the error I get when trying to connect to Tableau when I exclude the `response` property in the {{RpcMetadata}} object. {code:java} An error occurred while communicating with Other Databases (JDBC) Bad Connection: Tableau could not connect to the data source. Error Code: FAB9A2C5 org.apache.calcite.avatica.com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.apache.calcite.avatica.remote.Service$RpcMetadataResponse]: missing type id property 'response' (for POJO property 'rpcMetadata') at [Source: (String)"{ "connectionId": "1d919ce0-c430-42b6-b5d9-8cfeb532fdb0", "rpcMetadata": {}, "firstFrame": { "rows": [ [ "VIEW" ] ], "done": true, "offset": 0 }, "updateCount": -1, "response": "resultSet" } "; line: 14, column: 17] (through reference chain: org.apache.calcite.avatica.remote.Service$ResultSetResponse["rpcMetadata"]) {code} was (Author: john.bod...@gmail.com): For context here's the error I get when trying to connect to Tableau when I exclude the `response` property in the {{RpcMetadata}} object. !Screen Shot 2021-08-11 at 2.37.38 PM.png! > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Bodley updated CALCITE-4727: - Attachment: (was: Screen Shot 2021-08-11 at 2.37.38 PM.png) > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397651#comment-17397651 ] John Bodley commented on CALCITE-4727: -- For context here's the error I get when trying to connect to Tableau when I exclude the `response` property in the {{RpcMetadata}} object. !Screen Shot 2021-08-11 at 2.37.38 PM.png! > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > Attachments: Screen Shot 2021-08-11 at 2.37.38 PM.png > > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Bodley updated CALCITE-4727: - Attachment: Screen Shot 2021-08-11 at 2.37.38 PM.png > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > Attachments: Screen Shot 2021-08-11 at 2.37.38 PM.png > > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397644#comment-17397644 ] John Bodley edited comment on CALCITE-4727 at 8/11/21, 9:23 PM: I was testing using {{avatica-1.17.0.jar}} (somewhat akin to [these|https://community.tableau.com/s/question/0D54T0OPNZtSAP/how-to-connect-tableau-with-druid-latest-version-of-tableau-2020] instructions) and Tableau was inoperable without including a `response` field within the RpcMetadata object. Maybe this logic has changed. That said [~elserj] per your comment the code snippet does say {{RpcMetadataResponse}}, i.e., includes the term `response` for the JSON messages, and per [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678] (as mentioned in the issue description) it seems like the RpcMetadata is somewhat of an atypical [miscellaneous|https://calcite.apache.org/avatica/docs/json_reference.html#miscellaneous] type. was (Author: john.bod...@gmail.com): I was testing using {{avatica-1.17.0.jar}} (somewhat akin to [these|https://community.tableau.com/s/question/0D54T0OPNZtSAP/how-to-connect-tableau-with-druid-latest-version-of-tableau-2020] instructions) and Tableau was inoperable without including a `response` field within the RpcMetadata object. Maybe this logic has changed. That said [~elserj] per your comment the code snippet does say {{RpcMetadataResponse}}, i.e., includes the term `response` for the JSON messages, and per [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678] (as mentioned in the issue description) it seems like the RpcMetdata is somewhat of an atypical [miscellaneous|https://calcite.apache.org/avatica/docs/json_reference.html#miscellaneous] type. > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397644#comment-17397644 ] John Bodley edited comment on CALCITE-4727 at 8/11/21, 9:23 PM: I was testing using {{avatica-1.17.0.jar}} (somewhat akin to [these|https://community.tableau.com/s/question/0D54T0OPNZtSAP/how-to-connect-tableau-with-druid-latest-version-of-tableau-2020] instructions) and Tableau was inoperable without including a `response` field within the RpcMetadata object. Maybe this logic has changed. That said [~elserj] per your comment the code snippet does say {{RpcMetadataResponse}}, i.e., includes the term `response` for the JSON messages, and per [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678] (as mentioned in the issue description) it seems like the RpcMetdata is somewhat of an atypical [miscellaneous|https://calcite.apache.org/avatica/docs/json_reference.html#miscellaneous] type. was (Author: john.bod...@gmail.com): I was testing using {{avatica-1.17.0.jar}} (somewhat akin to [these|https://community.tableau.com/s/question/0D54T0OPNZtSAP/how-to-connect-tableau-with-druid-latest-version-of-tableau-2020] instructions) and Tableau was inoperable without including a `response` field within the RpcMetadata object. Maybe this logic has changed. That said [~elserj] per your comment the code snippet does say {{RpcMetadataResponse}}, i.e., includes the term `response` for the JSON messages, and per [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678] (as mentioned in the issue description) it seems like the RpcMetdaata is somewhat of an atypical [miscellaneous|https://calcite.apache.org/avatica/docs/json_reference.html#miscellaneous] type. > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397644#comment-17397644 ] John Bodley edited comment on CALCITE-4727 at 8/11/21, 9:22 PM: I was testing using {{avatica-1.17.0.jar}} (somewhat akin to [these|https://community.tableau.com/s/question/0D54T0OPNZtSAP/how-to-connect-tableau-with-druid-latest-version-of-tableau-2020] instructions) and Tableau was inoperable without including a `response` field within the RpcMetadata object. Maybe this logic has changed. That said [~elserj] per your comment the code snippet does say {{RpcMetadataResponse}}, i.e., includes the term `response` for the JSON messages, and per [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678] (as mentioned in the issue description) it seems like the RpcMetdaata is somewhat of an atypical [miscellaneous|https://calcite.apache.org/avatica/docs/json_reference.html#miscellaneous] type. was (Author: john.bod...@gmail.com): I was testing using {{avatica-1.17.0.jar}} (somewhat akin to [these|https://community.tableau.com/s/question/0D54T0OPNZtSAP/how-to-connect-tableau-with-druid-latest-version-of-tableau-2020] instructions) and Tableau was inoperable without including a `response` field within the RpcMetadata object. Maybe this logic has changed. That said [~elserj] per your comment the code snippet does say {{RpcMetadataResponse}}, i.e., includes the term `response` and per [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678] (as mentioned in the issue description) it seems like the RpcMetdaata is somewhat of an atypical [miscellaneous|https://calcite.apache.org/avatica/docs/json_reference.html#miscellaneous] type. > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397644#comment-17397644 ] John Bodley commented on CALCITE-4727: -- I was testing using {{avatica-1.17.0.jar}} (somewhat akin to [these|https://community.tableau.com/s/question/0D54T0OPNZtSAP/how-to-connect-tableau-with-druid-latest-version-of-tableau-2020] instructions) and Tableau was inoperable without including a `response` field within the RpcMetadata object. Maybe this logic has changed. That said [~elserj] per your comment the code snippet does say {{RpcMetadataResponse}}, i.e., includes the term `response` and per [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678] (as mentioned in the issue description) it seems like the RpcMetdaata is somewhat of an atypical [miscellaneous|https://calcite.apache.org/avatica/docs/json_reference.html#miscellaneous] type. > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (CALCITE-4727) Possible incorrect RpcMetadata JSON reference
[ https://issues.apache.org/jira/browse/CALCITE-4727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Bodley updated CALCITE-4727: - Summary: Possible incorrect RpcMetadata JSON reference (was: Fix RpcMetadata JSON reference ) > Possible incorrect RpcMetadata JSON reference > - > > Key: CALCITE-4727 > URL: https://issues.apache.org/jira/browse/CALCITE-4727 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Priority: Trivial > > Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the > RpMetadata JSON reference is missing the required `response` field. As > discussed in the issue and per > [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], > though this isn't an actual response is does seem to expect a response type > signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CALCITE-4367) Incorrect documentation for Avatica JSON request/response signatures
[ https://issues.apache.org/jira/browse/CALCITE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397562#comment-17397562 ] John Bodley commented on CALCITE-4367: -- Per [~elserj]'s request created [CALCITE-4727|https://issues.apache.org/jira/browse/CALCITE-4727] for tracking the additional correction. > Incorrect documentation for Avatica JSON request/response signatures > > > Key: CALCITE-4367 > URL: https://issues.apache.org/jira/browse/CALCITE-4367 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Assignee: Josh Elser >Priority: Trivial > Fix For: avatica-1.18.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > I noticed a few inconsistencies between what is documented in the [Avatica > JSON Reference|https://calcite.apache.org/avatica/docs/json_reference.html] > and what the Avatica JDBC driver provides, specifically: > # The {{DatabasePropertyRequest}} was missing the {{connection_id}} field in > the example signature. > # `RpcMetadata` is actually a response as opposed to a miscellaneous type per > [here|https://github.com/apache/calcite-avatica/blob/4b7eee5bf430b916c7c07897b6f60d2b6b6dabb7/core/src/main/protobuf/responses.proto#L114-L116] > and thus requires a {{response}} field. Note I'm not certain if this was > intentional, i.e., it being a response, however it it is it seems that it > should be renamed to {{RpcMetadataResponse}} for consistency. > # The supplied {{ConnectionProperties}} contains an undocumented {{dirty}} > field ({{is_dirty}} for protobuf). > # For the {{SchemasRequest}} the {{catalog}} and {{schemaPattern}} are > optional rather than required. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (CALCITE-4727) Fix RpcMetadata JSON reference
John Bodley created CALCITE-4727: Summary: Fix RpcMetadata JSON reference Key: CALCITE-4727 URL: https://issues.apache.org/jira/browse/CALCITE-4727 Project: Calcite Issue Type: Bug Components: avatica Reporter: John Bodley Per [CALCITE-4367|https://issues.apache.org/jira/browse/CALCITE-4367] the RpMetadata JSON reference is missing the required `response` field. As discussed in the issue and per [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2668-L2678], though this isn't an actual response is does seem to expect a response type signature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CALCITE-4367) Incorrect documentation for Avatica JSON request/response signatures
[ https://issues.apache.org/jira/browse/CALCITE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17397465#comment-17397465 ] John Bodley commented on CALCITE-4367: -- [~elserj] and [~francischuang] a follow up regarding the RpcMetadata, per [https://github.com/apache/calcite-avatica/pull/129] and my experience using the Avatica JDBC connector with Tableau, for the JSON objects the [rpcMetadata|https://calcite.apache.org/avatica/docs/json_reference.html#rpcmetadata] does expect a `response` field. This hypothesis is potentially confirmed [here|https://github.com/apache/calcite-avatica/blob/89e0deb510311b85b8c8bacde6d2ff70c309930e/core/src/main/java/org/apache/calcite/avatica/remote/Service.java#L2674]. > Incorrect documentation for Avatica JSON request/response signatures > > > Key: CALCITE-4367 > URL: https://issues.apache.org/jira/browse/CALCITE-4367 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: John Bodley >Assignee: Josh Elser >Priority: Trivial > Fix For: avatica-1.18.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > I noticed a few inconsistencies between what is documented in the [Avatica > JSON Reference|https://calcite.apache.org/avatica/docs/json_reference.html] > and what the Avatica JDBC driver provides, specifically: > # The {{DatabasePropertyRequest}} was missing the {{connection_id}} field in > the example signature. > # `RpcMetadata` is actually a response as opposed to a miscellaneous type per > [here|https://github.com/apache/calcite-avatica/blob/4b7eee5bf430b916c7c07897b6f60d2b6b6dabb7/core/src/main/protobuf/responses.proto#L114-L116] > and thus requires a {{response}} field. Note I'm not certain if this was > intentional, i.e., it being a response, however it it is it seems that it > should be renamed to {{RpcMetadataResponse}} for consistency. > # The supplied {{ConnectionProperties}} contains an undocumented {{dirty}} > field ({{is_dirty}} for protobuf). > # For the {{SchemasRequest}} the {{catalog}} and {{schemaPattern}} are > optional rather than required. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (CALCITE-4367) Incorrect documentation for Avatica JSON request/response signatures
John Bodley created CALCITE-4367: Summary: Incorrect documentation for Avatica JSON request/response signatures Key: CALCITE-4367 URL: https://issues.apache.org/jira/browse/CALCITE-4367 Project: Calcite Issue Type: Bug Components: avatica Reporter: John Bodley I noticed a few inconsistencies between what is documented in the [Avatica JSON Reference|https://calcite.apache.org/avatica/docs/json_reference.html] and what the Avatica JDBC driver provides, specifically: # The {{DatabasePropertyRequest}} was missing the {{connection_id}} field in the example signature. # `RpcMetadata` is actually a response as opposed to a miscellaneous type per [here|https://github.com/apache/calcite-avatica/blob/4b7eee5bf430b916c7c07897b6f60d2b6b6dabb7/core/src/main/protobuf/responses.proto#L114-L116] and thus requires a {{response}} field. Note I'm not certain if this was intentional, i.e., it being a response, however it it is it seems that it should be renamed to {{RpcMetadataResponse}} for consistency. # The supplied {{ConnectionProperties}} contains an undocumented {{dirty}} field ({{is_dirty}} for protobuf). # For the {{SchemasRequest}} the {{catalog}} and {{schemaPattern}} are optional rather than required. -- This message was sent by Atlassian Jira (v8.3.4#803005)