[jira] [Comment Edited] (CALCITE-5567) Failed to apply plugin 'de.thetaphi.forbiddenapis' when running ./gradlew build w/ java19
[
https://issues.apache.org/jira/browse/CALCITE-5567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697991#comment-17697991
]
Kevin Risden edited comment on CALCITE-5567 at 3/8/23 4:18 PM:
---
I'm not sure this is a forbiddensapi issue? Forbiddenapi supports JDK 19 as of
3.4
(https://github.com/policeman-tools/forbidden-apis/wiki/Changes#version-34-released-2022-10-02)
and Calcite 1.33 has Forbiddenapi 3.4 -
https://github.com/apache/calcite/blob/main/gradle.properties#L53
Gradle is only on 7.4.2 I think (see latest commit here
https://github.com/apache/calcite/blob/main/gradlew) - and gradle 7.6 is
required to be able to use JDK 19 -
https://docs.gradle.org/7.6/release-notes.html
was (Author: risdenk):
I'm not sure this is a forbiddensapi issue? Forbiddenapi supports JDK 19 as of
3.4 and 1.33 of calcite has Forbiddenapi 3.4 -
https://github.com/apache/calcite/blob/main/gradle.properties#L53
Gradle is only on 7.4.2 I think (see latest commit here
https://github.com/apache/calcite/blob/main/gradlew) - and gradle 7.6 is
required to be able to use JDK 19 -
https://docs.gradle.org/7.6/release-notes.html
> Failed to apply plugin 'de.thetaphi.forbiddenapis' when running ./gradlew
> build w/ java19
> -
>
> Key: CALCITE-5567
> URL: https://issues.apache.org/jira/browse/CALCITE-5567
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.33.0
> Environment: {{OS: arch linux}}
> {{JDK: java-19-openjdk}}
>Reporter: Matt P
>Priority: Major
> Attachments: build.gradle.kts, output.txt
>
>
> Running {{./gradlew build}} on a fresh {{git clone}} fails with:
> {code:java}
> FAILURE: Build failed with an exception.
> * Where:
> Build file '/home/user/github/apache/calcite/build.gradle.kts' line: 513
> * What went wrong:
> Failed to apply plugin 'de.thetaphi.forbiddenapis'.
> > Could not create plugin of type 'ForbiddenApisPlugin'.
> > Could not initialize class
> de.thetaphi.forbiddenapis.gradle.ForbiddenApisPlugin
> {code}
> The full output (output.txt) and {{build.gradle.kts}} files are attached.
> This is similar to https://issues.apache.org/jira/browse/SOLR-14426 but
> running {{./gradlew clean}} results in the same error.
> I've tried this on version 1.33 plus several older releases with similar
> results.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (CALCITE-5567) Failed to apply plugin 'de.thetaphi.forbiddenapis' when running ./gradlew build w/ java19
[
https://issues.apache.org/jira/browse/CALCITE-5567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697991#comment-17697991
]
Kevin Risden commented on CALCITE-5567:
---
I'm not sure this is a forbiddensapi issue? Forbiddenapi supports JDK 19 as of
3.4 and 1.33 of calcite has Forbiddenapi 3.4 -
https://github.com/apache/calcite/blob/main/gradle.properties#L53
Gradle is only on 7.4.2 I think (see latest commit here
https://github.com/apache/calcite/blob/main/gradlew) - and gradle 7.6 is
required to be able to use JDK 19 -
https://docs.gradle.org/7.6/release-notes.html
> Failed to apply plugin 'de.thetaphi.forbiddenapis' when running ./gradlew
> build w/ java19
> -
>
> Key: CALCITE-5567
> URL: https://issues.apache.org/jira/browse/CALCITE-5567
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.33.0
> Environment: {{OS: arch linux}}
> {{JDK: java-19-openjdk}}
>Reporter: Matt P
>Priority: Major
> Attachments: build.gradle.kts, output.txt
>
>
> Running {{./gradlew build}} on a fresh {{git clone}} fails with:
> {code:java}
> FAILURE: Build failed with an exception.
> * Where:
> Build file '/home/user/github/apache/calcite/build.gradle.kts' line: 513
> * What went wrong:
> Failed to apply plugin 'de.thetaphi.forbiddenapis'.
> > Could not create plugin of type 'ForbiddenApisPlugin'.
> > Could not initialize class
> de.thetaphi.forbiddenapis.gradle.ForbiddenApisPlugin
> {code}
> The full output (output.txt) and {{build.gradle.kts}} files are attached.
> This is similar to https://issues.apache.org/jira/browse/SOLR-14426 but
> running {{./gradlew clean}} results in the same error.
> I've tried this on version 1.33 plus several older releases with similar
> results.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (CALCITE-5298) CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager
[ https://issues.apache.org/jira/browse/CALCITE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved CALCITE-5298. --- Resolution: Fixed Thanks [~julianhyde] and [~zabetak] for the reviews! > CalciteSystemProperty calcite.test.dataset path check fails under Java > Security Manager > --- > > Key: CALCITE-5298 > URL: https://issues.apache.org/jira/browse/CALCITE-5298 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.27.0, 1.28.0, 1.29.0, 1.30.0, 1.31.0, 1.32.0 >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Fix For: 1.33.0 > > Time Spent: 2h > Remaining Estimate: 0h > > SOLR-16433 found that Calcite does not handle the Java security manager > returning permission denied when checking that the calcite.test.dataset path > exists. Solr runs with a security manager that doesn't allow arbitrary > filesystem access. This failure causes Calcite to not load and therefore > unusable. > The code in question is here: > https://github.com/apache/calcite/blame/main/core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java#L189 > A few other places in Calcite already check for SecurityException: > https://github.com/apache/calcite/search?q=SecurityException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-5298) CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager
[ https://issues.apache.org/jira/browse/CALCITE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648669#comment-17648669 ] Kevin Risden commented on CALCITE-5298: --- Very delayed in getting back to this - but add Util method for ignoring the access control exception - https://github.com/apache/calcite/pull/2919 Would appreciate a review [~julianhyde] thanks! > CalciteSystemProperty calcite.test.dataset path check fails under Java > Security Manager > --- > > Key: CALCITE-5298 > URL: https://issues.apache.org/jira/browse/CALCITE-5298 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.27.0, 1.28.0, 1.29.0, 1.30.0, 1.31.0, 1.32.0 >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > > SOLR-16433 found that Calcite does not handle the Java security manager > returning permission denied when checking that the calcite.test.dataset path > exists. Solr runs with a security manager that doesn't allow arbitrary > filesystem access. This failure causes Calcite to not load and therefore > unusable. > The code in question is here: > https://github.com/apache/calcite/blame/main/core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java#L189 > A few other places in Calcite already check for SecurityException: > https://github.com/apache/calcite/search?q=SecurityException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-5298) CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager
[ https://issues.apache.org/jira/browse/CALCITE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615995#comment-17615995 ] Kevin Risden commented on CALCITE-5298: --- Looks like this was introduced in CALCITE-4011 under https://github.com/apache/calcite/commit/0af3fd17a293d37125c7cca58257e5f6cbc1a76c#diff-e2d8310e40328e3187342668cfbd8754af2ebc714ee36580bf84b6d513ab719dR165 inadvertently adding `CalciteSystemProperty.TOPDOWN_OPT` in CalciteConnectionProperty which causes the statics to all be loaded. > CalciteSystemProperty calcite.test.dataset path check fails under Java > Security Manager > --- > > Key: CALCITE-5298 > URL: https://issues.apache.org/jira/browse/CALCITE-5298 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.27.0, 1.28.0, 1.29.0, 1.30.0, 1.31.0, 1.32.0 >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > > SOLR-16433 found that Calcite does not handle the Java security manager > returning permission denied when checking that the calcite.test.dataset path > exists. Solr runs with a security manager that doesn't allow arbitrary > filesystem access. This failure causes Calcite to not load and therefore > unusable. > The code in question is here: > https://github.com/apache/calcite/blame/main/core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java#L189 > A few other places in Calcite already check for SecurityException: > https://github.com/apache/calcite/search?q=SecurityException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-5298) CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager
[ https://issues.apache.org/jira/browse/CALCITE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612338#comment-17612338 ] Kevin Risden commented on CALCITE-5298: --- Yea good point - I'm out for a few weeks due to personal stuff - but will come back to this. > CalciteSystemProperty calcite.test.dataset path check fails under Java > Security Manager > --- > > Key: CALCITE-5298 > URL: https://issues.apache.org/jira/browse/CALCITE-5298 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.27.0, 1.28.0, 1.29.0, 1.30.0, 1.31.0, 1.32.0 >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > > SOLR-16433 found that Calcite does not handle the Java security manager > returning permission denied when checking that the calcite.test.dataset path > exists. Solr runs with a security manager that doesn't allow arbitrary > filesystem access. This failure causes Calcite to not load and therefore > unusable. > The code in question is here: > https://github.com/apache/calcite/blame/main/core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java#L189 > A few other places in Calcite already check for SecurityException: > https://github.com/apache/calcite/search?q=SecurityException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-5298) CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager
[ https://issues.apache.org/jira/browse/CALCITE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609211#comment-17609211 ] Kevin Risden commented on CALCITE-5298: --- PR https://github.com/apache/calcite/pull/2919 > CalciteSystemProperty calcite.test.dataset path check fails under Java > Security Manager > --- > > Key: CALCITE-5298 > URL: https://issues.apache.org/jira/browse/CALCITE-5298 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.27.0, 1.28.0, 1.29.0, 1.30.0, 1.31.0, 1.32.0 >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > > SOLR-16433 found that Calcite does not handle the Java security manager > returning permission denied when checking that the calcite.test.dataset path > exists. Solr runs with a security manager that doesn't allow arbitrary > filesystem access. This failure causes Calcite to not load and therefore > unusable. > The code in question is here: > https://github.com/apache/calcite/blame/main/core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java#L189 > A few other places in Calcite already check for SecurityException: > https://github.com/apache/calcite/search?q=SecurityException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (CALCITE-5298) CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager
[ https://issues.apache.org/jira/browse/CALCITE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned CALCITE-5298: - Assignee: Kevin Risden > CalciteSystemProperty calcite.test.dataset path check fails under Java > Security Manager > --- > > Key: CALCITE-5298 > URL: https://issues.apache.org/jira/browse/CALCITE-5298 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.27.0, 1.28.0, 1.29.0, 1.30.0, 1.31.0, 1.32.0 >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > > SOLR-16433 found that Calcite does not handle the Java security manager > returning permission denied when checking that the calcite.test.dataset path > exists. Solr runs with a security manager that doesn't allow arbitrary > filesystem access. This failure causes Calcite to not load and therefore > unusable. > The code in question is here: > https://github.com/apache/calcite/blame/main/core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java#L189 > A few other places in Calcite already check for SecurityException: > https://github.com/apache/calcite/search?q=SecurityException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (CALCITE-5298) CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager
[ https://issues.apache.org/jira/browse/CALCITE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17609210#comment-17609210 ] Kevin Risden commented on CALCITE-5298: --- Based on CALCITE-4823 - need to be careful about how to go about checking this. > CalciteSystemProperty calcite.test.dataset path check fails under Java > Security Manager > --- > > Key: CALCITE-5298 > URL: https://issues.apache.org/jira/browse/CALCITE-5298 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.27.0, 1.28.0, 1.29.0, 1.30.0, 1.31.0, 1.32.0 >Reporter: Kevin Risden >Priority: Major > > SOLR-16433 found that Calcite does not handle the Java security manager > returning permission denied when checking that the calcite.test.dataset path > exists. Solr runs with a security manager that doesn't allow arbitrary > filesystem access. This failure causes Calcite to not load and therefore > unusable. > The code in question is here: > https://github.com/apache/calcite/blame/main/core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java#L189 > A few other places in Calcite already check for SecurityException: > https://github.com/apache/calcite/search?q=SecurityException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-5298) CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager
[ https://issues.apache.org/jira/browse/CALCITE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated CALCITE-5298: -- Description: SOLR-16433 found that Calcite does not handle the Java security manager returning permission denied when checking that the calcite.test.dataset path exists. Solr runs with a security manager that doesn't allow arbitrary filesystem access. This failure causes Calcite to not load and therefore unusable. The code in question is here: https://github.com/apache/calcite/blame/main/core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java#L189 A few other places in Calcite already check for SecurityException: https://github.com/apache/calcite/search?q=SecurityException was: SOLR-16433 found that Calcite does not handle the Java security manager returning permission denied when checking that the calcite.test.dataset path exists. Solr runs with a security manager that doesn't allow arbitrary filesystem access. This failure causes Calcite to not load and therefore unusable. A few other places in Calcite already check for SecurityException: https://github.com/apache/calcite/search?q=SecurityException > CalciteSystemProperty calcite.test.dataset path check fails under Java > Security Manager > --- > > Key: CALCITE-5298 > URL: https://issues.apache.org/jira/browse/CALCITE-5298 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.27.0, 1.28.0, 1.29.0, 1.30.0, 1.31.0, 1.32.0 >Reporter: Kevin Risden >Priority: Major > > SOLR-16433 found that Calcite does not handle the Java security manager > returning permission denied when checking that the calcite.test.dataset path > exists. Solr runs with a security manager that doesn't allow arbitrary > filesystem access. This failure causes Calcite to not load and therefore > unusable. > The code in question is here: > https://github.com/apache/calcite/blame/main/core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java#L189 > A few other places in Calcite already check for SecurityException: > https://github.com/apache/calcite/search?q=SecurityException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-5298) CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager
[ https://issues.apache.org/jira/browse/CALCITE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated CALCITE-5298: -- Priority: Major (was: Minor) > CalciteSystemProperty calcite.test.dataset path check fails under Java > Security Manager > --- > > Key: CALCITE-5298 > URL: https://issues.apache.org/jira/browse/CALCITE-5298 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.27.0, 1.28.0, 1.29.0, 1.30.0, 1.31.0, 1.32.0 >Reporter: Kevin Risden >Priority: Major > > SOLR-16433 found that Calcite does not handle the Java security manager > returning permission denied when checking that the calcite.test.dataset path > exists. Solr runs with a security manager that doesn't allow arbitrary > filesystem access. This failure causes Calcite to not load and therefore > unusable. > A few other places in Calcite already check for SecurityException: > https://github.com/apache/calcite/search?q=SecurityException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (CALCITE-5298) CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager
[ https://issues.apache.org/jira/browse/CALCITE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated CALCITE-5298: -- Description: SOLR-16433 found that Calcite does not handle the Java security manager returning permission denied when checking that the calcite.test.dataset path exists. Solr runs with a security manager that doesn't allow arbitrary filesystem access. This failure causes Calcite to not load and therefore unusable. A few other places in Calcite already check for SecurityException: https://github.com/apache/calcite/search?q=SecurityException was:SOLR-16433 found that Calcite does not handle the Java security manager returning permission denied when checking that the calcite.test.dataset path exists. Solr runs with a security manager that doesn't allow arbitrary filesystem access. This failure causes Calcite to not load and therefore unusable. > CalciteSystemProperty calcite.test.dataset path check fails under Java > Security Manager > --- > > Key: CALCITE-5298 > URL: https://issues.apache.org/jira/browse/CALCITE-5298 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.27.0, 1.28.0, 1.29.0, 1.30.0, 1.31.0, 1.32.0 >Reporter: Kevin Risden >Priority: Minor > > SOLR-16433 found that Calcite does not handle the Java security manager > returning permission denied when checking that the calcite.test.dataset path > exists. Solr runs with a security manager that doesn't allow arbitrary > filesystem access. This failure causes Calcite to not load and therefore > unusable. > A few other places in Calcite already check for SecurityException: > https://github.com/apache/calcite/search?q=SecurityException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (CALCITE-5298) CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager
Kevin Risden created CALCITE-5298: - Summary: CalciteSystemProperty calcite.test.dataset path check fails under Java Security Manager Key: CALCITE-5298 URL: https://issues.apache.org/jira/browse/CALCITE-5298 Project: Calcite Issue Type: Bug Components: core Affects Versions: 1.32.0, 1.31.0, 1.30.0, 1.29.0, 1.28.0, 1.27.0 Reporter: Kevin Risden SOLR-16433 found that Calcite does not handle the Java security manager returning permission denied when checking that the calcite.test.dataset path exists. Solr runs with a security manager that doesn't allow arbitrary filesystem access. This failure causes Calcite to not load and therefore unusable. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (CALCITE-2254) Test against IBM Java
[ https://issues.apache.org/jira/browse/CALCITE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved CALCITE-2254. --- Resolution: Won't Fix Not planning to look at this and doesn't seem to have come up. JDK has evolved over the past few years as well so IBM Java isn't top of priority list. > Test against IBM Java > - > > Key: CALCITE-2254 > URL: https://issues.apache.org/jira/browse/CALCITE-2254 > Project: Calcite > Issue Type: Improvement >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > IBM Java is open sourced and capable of being tested against with Travis CI > and Docker. We should test against IBM Java as well. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (CALCITE-4814) AvaticaConnection#isValid() doesn't correspond JDBC API
[
https://issues.apache.org/jira/browse/CALCITE-4814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422807#comment-17422807
]
Kevin Risden commented on CALCITE-4814:
---
[~mrymar] - agree there is room for improvement in the isValid method.
Previously without isValid implemented at all - many clients wouldn't even work
at all since they call isValid before doing anything else. Feel free to submit
a PR to improve this.
> AvaticaConnection#isValid() doesn't correspond JDBC API
> ---
>
> Key: CALCITE-4814
> URL: https://issues.apache.org/jira/browse/CALCITE-4814
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Reporter: Rymar Maksym
>Priority: Major
>
> [AvaticaConnection|https://github.com/apache/calcite-avatica/blob/d52c2036224911d93fe3185f521768037e62a437/core/src/main/java/org/apache/calcite/avatica/AvaticaConnection.java#L63]
> implements *Connection* interface of JDBC API, but it's *isValid()* method
> doesn't correspond [java documentation|#isValid(int)].
> Currently, *{{AvaticaConnection}}* only checks attribute *{{'closed'}}* via
> method *{{isClosed()}}* and do nothing more. With current implementation,
> *{{AvaticaConnection#isValid(int timeout)}}* totally correspond to
> *{{AvaticaConnection#isClosed()}}* what is actually incorrect, according to
> [java documentation|#isValid(int)].
> In it's turn, *{{AvaticaConnection#isClosed()}}* will return *{{'true'}}*,
> only when connection will be closed directly by client and it doesn't handle
> case, when server closes connection or server is not accessible due to
> network issues and etc.
>
> *{{AvaticaConnection#isValid}}* should check weather connection is valid. The
> driver may submit a query on the connection or use some other mechanism that
> positively verifies the connection is still valid when this method is called.
> Here is some examples of implementations in [MySql
> JDBC|https://github.com/mysql/mysql-connector-j/blob/18bbd5e68195d0da083cbd5bd0d05d76320df7cd/src/main/user-impl/java/com/mysql/cj/jdbc/ConnectionImpl.java#L2546]
> and [Postgres
> JDBC|https://github.com/pgjdbc/pgjdbc/blob/3a2bbd77969903f8a4ce721d45905c72bd1688d6/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java#L1407].
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (CALCITE-3814) Support JDK 14
[
https://issues.apache.org/jira/browse/CALCITE-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17042141#comment-17042141
]
Kevin Risden commented on CALCITE-3814:
---
FWIW Lucene/Solr ran into something similar with Gradle and early builds of JDK:
http://mail-archives.apache.org/mod_mbox/lucene-dev/202001.mbox/%3C01d5c648%24d7eff570%2487cfe050%24%40thetaphi.de%3E
No real solutions there, but pointed out how Gradle currently isn't friendly to
newer JDKs due to Groovy it looks like.
> Support JDK 14
> --
>
> Key: CALCITE-3814
> URL: https://issues.apache.org/jira/browse/CALCITE-3814
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Priority: Major
>
> JDK 14 will be released on 2020/03/17.
> I tried building Calcite on an early access build and got an error from
> Gradle:
> {noformat}
> $ java -version
> openjdk version "14" 2020-03-17
> OpenJDK Runtime Environment (build 14+36-1461)
> OpenJDK 64-Bit Server VM (build 14+36-1461, mixed mode, sharing)
> $ ./gradlew build
> Starting a Gradle Daemon, 1 busy and 1 incompatible Daemons could not be
> reused, use --status for details
> java.lang.NoClassDefFoundError: Could not initialize class
> org.codehaus.groovy.vmplugin.v7.Java7
> at
> org.codehaus.groovy.vmplugin.VMPluginFactory.(VMPluginFactory.java:43)
> at
> org.codehaus.groovy.reflection.GroovyClassValueFactory.(GroovyClassValueFactory.java:35)
> at
> org.codehaus.groovy.reflection.ClassInfo.(ClassInfo.java:107)
> ...
> $ ./gradlew clean --stacktrace
> FAILURE: Build failed with an exception.
> * What went wrong:
> Could not initialize class org.codehaus.groovy.runtime.InvokerHelper
> * Try:
> Run with --info or --debug option to get more log output. Run with --scan to
> get full insights.
> * Exception is:
> java.lang.NoClassDefFoundError: Could not initialize class
> org.codehaus.groovy.runtime.InvokerHelper
> at
> org.gradle.internal.extensibility.DefaultExtraPropertiesExtension.(DefaultExtraPropertiesExtension.java:29)
> at
> org.gradle.internal.extensibility.DefaultConvention.(DefaultConvention.java:49)
> at
> org.gradle.internal.extensibility.ExtensibleDynamicObject.(ExtensibleDynamicObject.java:60)
> ...
> {noformat}
> Problem appears to be https://github.com/gradle/gradle/issues/10248, which is
> related to (caused by) GROOVY-9211, and alrso related to NETBEANS-3876.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (CALCITE-3258) Upgrade jackson-databind from 2.9.9 to 2.9.9.3, and kafka-clients from 2.0.0 to 2.1.1
[ https://issues.apache.org/jira/browse/CALCITE-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated CALCITE-3258: -- Description: Upgrade jackson-databind from 2.9.9 to 2.9.9.3. (was: Upgrade jackson-databind from 2.9.9 to 2.9.9.2.) > Upgrade jackson-databind from 2.9.9 to 2.9.9.3, and kafka-clients from 2.0.0 > to 2.1.1 > - > > Key: CALCITE-3258 > URL: https://issues.apache.org/jira/browse/CALCITE-3258 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Priority: Major > Fix For: 1.21.0 > > > Upgrade jackson-databind from 2.9.9 to 2.9.9.3. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (CALCITE-3236) Handle issues found in static code analysis
[ https://issues.apache.org/jira/browse/CALCITE-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909840#comment-16909840 ] Kevin Risden commented on CALCITE-3236: --- [~danny0405] - there is some performance slow down during compilation/build using spotbugs (same as with forbiddenapis and other static build checks), but not for running of Calcite. It would catch hard to find issues like these which a little build slowdown is worth it in my opinion. > Handle issues found in static code analysis > > > Key: CALCITE-3236 > URL: https://issues.apache.org/jira/browse/CALCITE-3236 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.20.0 >Reporter: Feng Zhu >Assignee: Feng Zhu >Priority: Major > Labels: pull-request-available > Fix For: 1.21.0 > > Attachments: findbugs.png > > Time Spent: 40m > Remaining Estimate: 0h > > Recently, we are conducting static code analysis to make our project robust. > In Calcite, many potential risks can also be found with the tool FindBugs, as > shown in the figure below. > !findbugs.png! > However, it is difficult to trigger most of them. Current now, we fix two > obvious issues. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (CALCITE-3141) Slow tests are not run in continuous integration
[ https://issues.apache.org/jira/browse/CALCITE-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909839#comment-16909839 ] Kevin Risden commented on CALCITE-3141: --- Depending how slow these tests are, have to be careful with timeouts in shared test executors like Travis. I think there is a 50 min limit to Travis. We also want to be conscious of running slow tests on too many different JVM configs (JDK 9, 10, 11, etc) to avoid using a ton of shared resources. I'm definitely in favor of unifying the selection of slow tests to one option. Just want to make sure we don't make our test runs take forever by default. I do think running the "slow" tests periodically is a good idea. > Slow tests are not run in continuous integration > > > Key: CALCITE-3141 > URL: https://issues.apache.org/jira/browse/CALCITE-3141 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.19.0, 1.20.0 >Reporter: Stamatis Zampetakis >Assignee: Stamatis Zampetakis >Priority: Major > Fix For: 1.21.0 > > > Trying to execute slow tests locally always ends up with failures and these > failures are not reflected in continuous integration (Jenkins, AppVeyor, > Travis). > > From the CI configuration below (extract from the logs) this appears normal > for Jenkins and AppVeyor but not for Travis. > > *Jenkins:* > /home/jenkins/tools/maven/apache-maven-3.3.3/bin/mvn -f ws/pom.xml > "-Dmaven.repo.local=/home/jenkins/jenkins-slave/workspace/Calcite-Master/jdk/JDK > 1.8 (latest)/label_exp/ubuntu&&!cloud-slave&&!H27/.repository" clean install > javadoc:javadoc -DskipITs -B > > *Travis:* > $ if [ $SLOW_TESTS = "Y" ]; then export > TESTS="-Dgroups=org.apache.calcite.test.SlowTests --projects :calcite-core"; > else export TESTS=-DskipSlowTests; fi > The command "if [ $SLOW_TESTS = "Y" ]; then export > TESTS="-Dgroups=org.apache.calcite.test.SlowTests --projects :calcite-core"; > else export TESTS=-DskipSlowTests; fi" exited with 0. > > *AppVeyor:* > mvn -Dcheckstyle.skip -Dsurefire.useFile=false -Dsurefire.threadCount=1 > -Dsurefire.perCoreThreadCount=false > -Djavax.net.ssl.trustStorePassword=changeit test -Djna.nosys=true -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (CALCITE-3236) Handle issues found in static code analysis
[ https://issues.apache.org/jira/browse/CALCITE-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903036#comment-16903036 ] Kevin Risden commented on CALCITE-3236: --- [~donnyzone] - Calcite Avatica already integrates with SpotBugs (the successor to FindBugs) - CALCITE-1006. It would make sense to hook up the Spotbugs plugin to Calcite. That way we would avoid new issues moving forward. > Handle issues found in static code analysis > > > Key: CALCITE-3236 > URL: https://issues.apache.org/jira/browse/CALCITE-3236 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.20.0 >Reporter: Feng Zhu >Assignee: Feng Zhu >Priority: Major > Labels: pull-request-available > Attachments: findbugs.png > > Time Spent: 0.5h > Remaining Estimate: 0h > > Recently, we are conducting static code analysis to make our project robust. > In Calcite, many potential risks can also be found with the tool FindBugs, as > shown in the figure below. > !findbugs.png! > However, it is difficult to trigger most of them. Current now, we fix two > obvious issues. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (CALCITE-2910) Improve testing of RexSqlStandardConvertletTable
[ https://issues.apache.org/jira/browse/CALCITE-2910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852235#comment-16852235 ] Kevin Risden commented on CALCITE-2910: --- [~michaelmior] - I guess so. I only created it so I could close CALCITE-2767 for 1.19.0. I haven't looked into this testing. I don't have any plans currently to look into it either. > Improve testing of RexSqlStandardConvertletTable > > > Key: CALCITE-2910 > URL: https://issues.apache.org/jira/browse/CALCITE-2910 > Project: Calcite > Issue Type: Test >Reporter: Kevin Risden >Priority: Major > Fix For: 1.20.0 > > > CALCITE-2767 found that there is a lack of tests around > RexSqlStandardConvertletTable -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2725) Link to SHA512 digest and remove link to Github commit per ASF policy
[ https://issues.apache.org/jira/browse/CALCITE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852234#comment-16852234 ] Kevin Risden commented on CALCITE-2725: --- Yea agreed with [~julianhyde] - Nothing changed from March 2019 since gitbox still blocks direct links to commits and refers to github. > Link to SHA512 digest and remove link to Github commit per ASF policy > - > > Key: CALCITE-2725 > URL: https://issues.apache.org/jira/browse/CALCITE-2725 > Project: Calcite > Issue Type: Bug > Components: site >Reporter: Julian Hyde >Priority: Major > Labels: pull-request-available > Fix For: 1.20.0 > > > Link to SHA512 digest and remove link to Github commit per ASF policy. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-3090) Update repository URL
[
https://issues.apache.org/jira/browse/CALCITE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847751#comment-16847751
]
Kevin Risden commented on CALCITE-3090:
---
Did some more digging. Apache ASF POM [1] pulls from the Maven Super POM [2]
This super pom from 3.5.4 uses:
{code:java}
central
Central Repository
https://repo.maven.apache.org/maven2
default
false
central
Central Repository
https://repo.maven.apache.org/maven2
default
false
never
{code}
[1] [https://github.com/apache/maven-apache-parent/blob/apache-21/pom.xml]
[2]
[https://maven.apache.org/guides/introduction/introduction-to-the-pom.html#Super_POM]
> Update repository URL
> -
>
> Key: CALCITE-3090
> URL: https://issues.apache.org/jira/browse/CALCITE-3090
> Project: Calcite
> Issue Type: Task
> Components: avatica, build
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.20.0, avatica-1.16.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Use https for maven central.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-3090) Update repository URL
[
https://issues.apache.org/jira/browse/CALCITE-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847731#comment-16847731
]
Kevin Risden commented on CALCITE-3090:
---
Agreed +1. Commented on the PR but I'll throw it here too:
Side thought: Do we even need the {{}} section at all? I don't
think other projects have it. I guess Maven figures it out somehow? (I checked
the ASF parent POM and it doesn't list central...)
> Update repository URL
> -
>
> Key: CALCITE-3090
> URL: https://issues.apache.org/jira/browse/CALCITE-3090
> Project: Calcite
> Issue Type: Task
> Components: avatica, build
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.20.0, avatica-1.16.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Use https for maven central.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2952) Certify Calcite on JDK 12
[ https://issues.apache.org/jira/browse/CALCITE-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844025#comment-16844025 ] Kevin Risden commented on CALCITE-2952: --- I don't know if the howto docs were updated with JDK 12. I know that we are testing with JDK 12 on Travis so thats a bonus. > Certify Calcite on JDK 12 > - > > Key: CALCITE-2952 > URL: https://issues.apache.org/jira/browse/CALCITE-2952 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > Fix For: 1.20.0 > > > Certify Calcite on JDK 12. JDK 12 was released on 2019/03/12. > I and - I believe - several other people regularly build Calcite on both JDK > 12 and OpenJDK 12, so we should declare that we support it. Tasks: > * Enable Travis on JDK 12 and/or OpenJDK 12 > * Add a paragraph to HISTORY.md for 1.20. > * Add JDK 12 to the paragraph in HISTORY.md for release 1.19. I built and > tested on JDK 12 and everything was FINE. > * Add JDK 12 to site/_docs/howto.md. > * Wherever howto.md says to use JDK 11 for a particular task, switch to JDK > 12. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-3075) Evaluate Travis CI for Windows build
[ https://issues.apache.org/jira/browse/CALCITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842215#comment-16842215 ] Kevin Risden commented on CALCITE-3075: --- I don't remember any details about Windows CI sadly :( Sorry. > Evaluate Travis CI for Windows build > > > Key: CALCITE-3075 > URL: https://issues.apache.org/jira/browse/CALCITE-3075 > Project: Calcite > Issue Type: Improvement >Reporter: Hongze Zhang >Priority: Major > > Travis.org supports running CI on Windows now: > https://blog.travis-ci.com/2018-10-11-windows-early-release, it is probably > worth to investigate if running Windows CI using Travis would benefit us more > than AppVevor can do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-3075) Evaluate Travis CI for Windows build
[ https://issues.apache.org/jira/browse/CALCITE-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841479#comment-16841479 ] Kevin Risden commented on CALCITE-3075: --- I thought there was a thread about using Travis CI on Windows at one point. I couldn't find it with some quick searches. Not going to stop forward progress if someone wants to try to move forward with testing. I think it should be possible to make whatever changes to .travis.yml and open a PR to see if the changes work. > Evaluate Travis CI for Windows build > > > Key: CALCITE-3075 > URL: https://issues.apache.org/jira/browse/CALCITE-3075 > Project: Calcite > Issue Type: Improvement >Reporter: Hongze Zhang >Priority: Major > > Travis.org supports running CI on Windows now: > https://blog.travis-ci.com/2018-10-11-windows-early-release, it is probably > worth to investigate if running Windows CI using Travis would benefit us more > than AppVevor can do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2983) Add Avatica compatibility page for TLS and IBM Java
[ https://issues.apache.org/jira/browse/CALCITE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823102#comment-16823102 ] Kevin Risden commented on CALCITE-2983: --- I wouldn't hold the release up for it. It should only be a site update. I don't think I'll be able to make time in the next few days for this. > Add Avatica compatibility page for TLS and IBM Java > --- > > Key: CALCITE-2983 > URL: https://issues.apache.org/jira/browse/CALCITE-2983 > Project: Calcite > Issue Type: Task > Components: avatica, site >Reporter: Kevin Risden >Priority: Major > Fix For: avatica-1.14.0 > > > With the Jetty upgrade in CALCITE-2972, there are some compatibility issues > between TLS support and IBM Java. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CALCITE-2983) Add Avatica compatibility page for TLS and IBM Java
[ https://issues.apache.org/jira/browse/CALCITE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated CALCITE-2983: -- Component/s: site > Add Avatica compatibility page for TLS and IBM Java > --- > > Key: CALCITE-2983 > URL: https://issues.apache.org/jira/browse/CALCITE-2983 > Project: Calcite > Issue Type: Task > Components: avatica, site >Reporter: Kevin Risden >Priority: Major > Fix For: avatica-1.14.0 > > > With the Jetty upgrade in CALCITE-2972, there are some compatibility issues > between TLS support and IBM Java. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CALCITE-2983) Add Avatica compatibility page for TLS and IBM Java
[ https://issues.apache.org/jira/browse/CALCITE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated CALCITE-2983: -- Fix Version/s: avatica-1.14.0 > Add Avatica compatibility page for TLS and IBM Java > --- > > Key: CALCITE-2983 > URL: https://issues.apache.org/jira/browse/CALCITE-2983 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Kevin Risden >Priority: Major > Fix For: avatica-1.14.0 > > > With the Jetty upgrade in CALCITE-2972, there are some compatibility issues > between TLS support and IBM Java. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2983) Add Avatica compatibility page for TLS and IBM Java
[ https://issues.apache.org/jira/browse/CALCITE-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812434#comment-16812434 ] Kevin Risden commented on CALCITE-2983: --- cc [~elserj] > Add Avatica compatibility page for TLS and IBM Java > --- > > Key: CALCITE-2983 > URL: https://issues.apache.org/jira/browse/CALCITE-2983 > Project: Calcite > Issue Type: Task > Components: avatica >Reporter: Kevin Risden >Priority: Major > Fix For: avatica-1.14.0 > > > With the Jetty upgrade in CALCITE-2972, there are some compatibility issues > between TLS support and IBM Java. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CALCITE-2972) Upgrade jetty to 9.4.15.v20190215
[ https://issues.apache.org/jira/browse/CALCITE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved CALCITE-2972. --- Resolution: Fixed > Upgrade jetty to 9.4.15.v20190215 > - > > Key: CALCITE-2972 > URL: https://issues.apache.org/jira/browse/CALCITE-2972 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Avatica should be upgraded to the latest Jetty 9.4.15.v20190215 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CALCITE-2983) Add Avatica compatibility page for TLS and IBM Java
Kevin Risden created CALCITE-2983: - Summary: Add Avatica compatibility page for TLS and IBM Java Key: CALCITE-2983 URL: https://issues.apache.org/jira/browse/CALCITE-2983 Project: Calcite Issue Type: Task Components: avatica Reporter: Kevin Risden With the Jetty upgrade in CALCITE-2972, there are some compatibility issues between TLS support and IBM Java. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2972) Upgrade jetty to 9.4.15.v20190215
[ https://issues.apache.org/jira/browse/CALCITE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812433#comment-16812433 ] Kevin Risden commented on CALCITE-2972: --- Created CALCITE-2983 > Upgrade jetty to 9.4.15.v20190215 > - > > Key: CALCITE-2972 > URL: https://issues.apache.org/jira/browse/CALCITE-2972 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Avatica should be upgraded to the latest Jetty 9.4.15.v20190215 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2972) Upgrade jetty to 9.4.15.v20190215
[ https://issues.apache.org/jira/browse/CALCITE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16811222#comment-16811222 ] Kevin Risden commented on CALCITE-2972: --- merged in commit - 6da2296ff14cf5049cab58c3361440be37a43c63 [~elserj] - We should make change to the docs/website with a compatibility change. Do you want to do that as part of this change or separate JIRA? > Upgrade jetty to 9.4.15.v20190215 > - > > Key: CALCITE-2972 > URL: https://issues.apache.org/jira/browse/CALCITE-2972 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Avatica should be upgraded to the latest Jetty 9.4.15.v20190215 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2972) Upgrade jetty to 9.4.15.v20190215
[ https://issues.apache.org/jira/browse/CALCITE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809820#comment-16809820 ] Kevin Risden commented on CALCITE-2972: --- I thought about this more last night. I think this change depends on CALCITE-1480 to support IBM Java. Without CALCITE-1480, IBM Java won't be able to run Avatica with TLS since the ciphers will never match. Jetty only deals with the standard cipher names which IBM Java doesn't follow. So here are the options: * implement CALCITE-1480 (and fix the tests to have a cipher suite in common) * Skip the ssldrivertest on IBM Java - IBM Java won't work with Avatica TLS > Upgrade jetty to 9.4.15.v20190215 > - > > Key: CALCITE-2972 > URL: https://issues.apache.org/jira/browse/CALCITE-2972 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Avatica should be upgraded to the latest Jetty 9.4.15.v20190215 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (CALCITE-2972) Upgrade jetty to 9.4.15.v20190215
[ https://issues.apache.org/jira/browse/CALCITE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809307#comment-16809307 ] Kevin Risden edited comment on CALCITE-2972 at 4/3/19 10:00 PM: For those that are playing along at home. The "straightforward" just suppress warnings approach is broken on IBM Java. See comments here on the PR: https://github.com/apache/calcite-avatica/pull/93 was (Author: risdenk): For those that are playing along at home. Both the "straightforward" just suppress warnings approach is broken on IBM Java. See comments here on the PR: https://github.com/apache/calcite-avatica/pull/93 > Upgrade jetty to 9.4.15.v20190215 > - > > Key: CALCITE-2972 > URL: https://issues.apache.org/jira/browse/CALCITE-2972 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 3h > Remaining Estimate: 0h > > Avatica should be upgraded to the latest Jetty 9.4.15.v20190215 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2972) Upgrade jetty to 9.4.15.v20190215
[ https://issues.apache.org/jira/browse/CALCITE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809307#comment-16809307 ] Kevin Risden commented on CALCITE-2972: --- For those that are playing along at home. Both the "straightforward" just suppress warnings approach is broken on IBM Java. See comments here on the PR: https://github.com/apache/calcite-avatica/pull/93 > Upgrade jetty to 9.4.15.v20190215 > - > > Key: CALCITE-2972 > URL: https://issues.apache.org/jira/browse/CALCITE-2972 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 3h > Remaining Estimate: 0h > > Avatica should be upgraded to the latest Jetty 9.4.15.v20190215 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2972) Upgrade jetty to 9.4.15.v20190215
[ https://issues.apache.org/jira/browse/CALCITE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808145#comment-16808145 ] Kevin Risden commented on CALCITE-2972: --- Well removing the deprecations is kicking my butt. Put a bunch of notes on the first PR. I created a second PR that upgrades but just suppresses the deprecations - https://github.com/apache/calcite-avatica/pull/93 > Upgrade jetty to 9.4.15.v20190215 > - > > Key: CALCITE-2972 > URL: https://issues.apache.org/jira/browse/CALCITE-2972 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Avatica should be upgraded to the latest Jetty 9.4.15.v20190215 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2972) Upgrade jetty to 9.4.15.v20190215
[ https://issues.apache.org/jira/browse/CALCITE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807107#comment-16807107 ] Kevin Risden commented on CALCITE-2972: --- Well I guess I should have added this detail: SpnegoLoginService and SpnegoAuthenticator are what is deprecated. So it is the base class that we need to worry about. Its not just a simple deprecation. The way Jetty handles this changed significantly it looks like. I looked at this pretty closely in CALCITE-2789, but apparently didn't put any notes in the tickets :( Side note - we could probably add suppressions to this and move on but eventually have to rip off the bandaid. > Upgrade jetty to 9.4.15.v20190215 > - > > Key: CALCITE-2972 > URL: https://issues.apache.org/jira/browse/CALCITE-2972 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Avatica should be upgraded to the latest Jetty 9.4.15.v20190215 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2972) Upgrade jetty to 9.4.15.v20190215
[ https://issues.apache.org/jira/browse/CALCITE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807085#comment-16807085 ] Kevin Risden commented on CALCITE-2972: --- [~elserj] - AvaticaSpnegoAuthenticator and PropertyBasedSpnegoLoginService are the two deprecations I am worried about. Specifically the comment in PropertyBasedSpnegoLoginService - "Known to work with Jetty-9.2.x, any other version would require testing/inspection to ensure the logic is still sound." I know there is a Jetty bug that was resolved recently which might make this custom logic unnecessary. https://github.com/eclipse/jetty.project/issues/1708 I don't have a testing framework available to ensure that this doesn't break again. > Upgrade jetty to 9.4.15.v20190215 > - > > Key: CALCITE-2972 > URL: https://issues.apache.org/jira/browse/CALCITE-2972 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: avatica-1.14.0 > > > Avatica should be upgraded to the latest Jetty 9.4.15.v20190215 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2972) Upgrade jetty to 9.4.15.v20190215
[
https://issues.apache.org/jira/browse/CALCITE-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807076#comment-16807076
]
Kevin Risden commented on CALCITE-2972:
---
avatica-server has some deprecation warnings that need to be fixed.
{code:java}
[WARNING] COMPILATION WARNING :
[INFO] -
[WARNING]
/Users/krisden/repos/apache/calcite-avatica/server/src/main/java/org/apache/calcite/avatica/server/PropertyBasedSpnegoLoginService.java:[19,34]
org.eclipse.jetty.security.SpnegoLoginService in org.eclipse.jetty.security
has been deprecated
[WARNING]
/Users/krisden/repos/apache/calcite-avatica/server/src/main/java/org/apache/calcite/avatica/server/AvaticaSpnegoAuthenticator.java:[22,49]
org.eclipse.jetty.security.authentication.SpnegoAuthenticator in
org.eclipse.jetty.security.authentication has been deprecated
[WARNING]
/Users/krisden/repos/apache/calcite-avatica/server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java:[263,14]
setSoLingerTime(int) in org.eclipse.jetty.server.ServerConnector has been
deprecated
[WARNING]
/Users/krisden/repos/apache/calcite-avatica/server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java:[429,14]
setSoLingerTime(int) in org.eclipse.jetty.server.ServerConnector has been
deprecated
[WARNING]
/Users/krisden/repos/apache/calcite-avatica/server/src/main/java/org/apache/calcite/avatica/server/PropertyBasedSpnegoLoginService.java:[43,54]
org.eclipse.jetty.security.SpnegoLoginService in org.eclipse.jetty.security
has been deprecated
[WARNING]
/Users/krisden/repos/apache/calcite-avatica/server/src/main/java/org/apache/calcite/avatica/server/PropertyBasedSpnegoLoginService.java:[59,35]
org.eclipse.jetty.security.SpnegoLoginService in org.eclipse.jetty.security
has been deprecated
[WARNING]
/Users/krisden/repos/apache/calcite-avatica/server/src/main/java/org/apache/calcite/avatica/server/AvaticaSpnegoAuthenticator.java:[38,49]
org.eclipse.jetty.security.authentication.SpnegoAuthenticator in
org.eclipse.jetty.security.authentication has been deprecated
{code}
> Upgrade jetty to 9.4.15.v20190215
> -
>
> Key: CALCITE-2972
> URL: https://issues.apache.org/jira/browse/CALCITE-2972
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Major
> Fix For: avatica-1.14.0
>
>
> Avatica should be upgraded to the latest Jetty 9.4.15.v20190215
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (CALCITE-2972) Upgrade jetty to 9.4.15.v20190215
Kevin Risden created CALCITE-2972: - Summary: Upgrade jetty to 9.4.15.v20190215 Key: CALCITE-2972 URL: https://issues.apache.org/jira/browse/CALCITE-2972 Project: Calcite Issue Type: Improvement Components: avatica Reporter: Kevin Risden Assignee: Kevin Risden Fix For: avatica-1.14.0 Avatica should be upgraded to the latest Jetty 9.4.15.v20190215 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CALCITE-2961) Enable Travis to test against JDK 13
[ https://issues.apache.org/jira/browse/CALCITE-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved CALCITE-2961. --- Resolution: Fixed > Enable Travis to test against JDK 13 > > > Key: CALCITE-2961 > URL: https://issues.apache.org/jira/browse/CALCITE-2961 > Project: Calcite > Issue Type: Improvement > Components: build >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Minor > Labels: pull-request-available > Fix For: avatica-1.14.0, 1.20.0 > > Time Spent: 3.5h > Remaining Estimate: 0h > > The docker hub Maven image recently added support for JDK 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2961) Enable Travis to test against JDK 13
[ https://issues.apache.org/jira/browse/CALCITE-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805475#comment-16805475 ] Kevin Risden commented on CALCITE-2961: --- Fixed for Calcite in commit 5cdf8562e1aaf97d5ba16ccafc3e16a96966561d > Enable Travis to test against JDK 13 > > > Key: CALCITE-2961 > URL: https://issues.apache.org/jira/browse/CALCITE-2961 > Project: Calcite > Issue Type: Improvement > Components: build >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Minor > Labels: pull-request-available > Fix For: avatica-1.14.0, 1.20.0 > > Time Spent: 3.5h > Remaining Estimate: 0h > > The docker hub Maven image recently added support for JDK 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CALCITE-2961) Enable Travis to test against JDK 13
Kevin Risden created CALCITE-2961: - Summary: Enable Travis to test against JDK 13 Key: CALCITE-2961 URL: https://issues.apache.org/jira/browse/CALCITE-2961 Project: Calcite Issue Type: Improvement Components: build Reporter: Kevin Risden Assignee: Kevin Risden Fix For: avatica-1.14.0, 1.20.0 The docker hub Maven image recently added support for JDK 13. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CALCITE-2269) Enable Error Prone checking
[ https://issues.apache.org/jira/browse/CALCITE-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved CALCITE-2269. --- Resolution: Fixed > Enable Error Prone checking > --- > > Key: CALCITE-2269 > URL: https://issues.apache.org/jira/browse/CALCITE-2269 > Project: Calcite > Issue Type: Improvement > Components: build >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 50m > Remaining Estimate: 0h > > [http://errorprone.info/] provides the ability to do static checks like > Spotbugs (CALCITE-1006). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2269) Enable Error Prone checking
[ https://issues.apache.org/jira/browse/CALCITE-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803928#comment-16803928 ] Kevin Risden commented on CALCITE-2269: --- Merged in commit 1b68d1fae721f45405e580582abb8fede9a6c028 > Enable Error Prone checking > --- > > Key: CALCITE-2269 > URL: https://issues.apache.org/jira/browse/CALCITE-2269 > Project: Calcite > Issue Type: Improvement > Components: build >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 50m > Remaining Estimate: 0h > > [http://errorprone.info/] provides the ability to do static checks like > Spotbugs (CALCITE-1006). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2269) Enable Error Prone checking
[ https://issues.apache.org/jira/browse/CALCITE-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803348#comment-16803348 ] Kevin Risden commented on CALCITE-2269: --- Updated title to "Error Prone" based on usage on the website. I updated the PR to only have an opt in profile and enabled running on JDK 11. JDK9+ support is included. JDK 8 support isn't easy to configure due to compiler requirements from Error Prone documentation. > Enable Error Prone checking > --- > > Key: CALCITE-2269 > URL: https://issues.apache.org/jira/browse/CALCITE-2269 > Project: Calcite > Issue Type: Improvement > Components: build >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > [http://errorprone.info/] provides the ability to do static checks like > Spotbugs (CALCITE-1006). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CALCITE-2269) Enable Error Prone checking
[ https://issues.apache.org/jira/browse/CALCITE-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated CALCITE-2269: -- Fix Version/s: avatica-1.14.0 > Enable Error Prone checking > --- > > Key: CALCITE-2269 > URL: https://issues.apache.org/jira/browse/CALCITE-2269 > Project: Calcite > Issue Type: Improvement > Components: build >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > [http://errorprone.info/] provides the ability to do static checks like > Spotbugs (CALCITE-1006). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CALCITE-2269) Enable Error Prone checking
[ https://issues.apache.org/jira/browse/CALCITE-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated CALCITE-2269: -- Summary: Enable Error Prone checking (was: Enable errorprone checking) > Enable Error Prone checking > --- > > Key: CALCITE-2269 > URL: https://issues.apache.org/jira/browse/CALCITE-2269 > Project: Calcite > Issue Type: Improvement > Components: build >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > [http://errorprone.info/] provides the ability to do static checks like > Spotbugs (CALCITE-1006). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2952) Certify Calcite on JDK 12
[ https://issues.apache.org/jira/browse/CALCITE-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801642#comment-16801642 ] Kevin Risden commented on CALCITE-2952: --- Took care of "Add JDK 12 to the paragraph in HISTORY.md for release 1.19." > Certify Calcite on JDK 12 > - > > Key: CALCITE-2952 > URL: https://issues.apache.org/jira/browse/CALCITE-2952 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > Fix For: 1.20.0 > > > Certify Calcite on JDK 12. JDK 12 was released on 2019/03/12. > I and - I believe - several other people regularly build Calcite on both JDK > 12 and OpenJDK 12, so we should declare that we support it. Tasks: > * Enable Travis on JDK 12 and/or OpenJDK 12 > * Add a paragraph to HISTORY.md for 1.20. > * Add JDK 12 to the paragraph in HISTORY.md for release 1.19. I built and > tested on JDK 12 and everything was FINE. > * Add JDK 12 to site/_docs/howto.md. > * Wherever howto.md says to use JDK 11 for a particular task, switch to JDK > 12. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2952) Certify Calcite on JDK 12
[ https://issues.apache.org/jira/browse/CALCITE-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801182#comment-16801182 ] Kevin Risden commented on CALCITE-2952: --- CALCITE-2655 enabled JDK 12 on Travis CI already. > Certify Calcite on JDK 12 > - > > Key: CALCITE-2952 > URL: https://issues.apache.org/jira/browse/CALCITE-2952 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde >Priority: Major > Fix For: 1.20.0 > > > Certify Calcite on JDK 12. JDK 12 was released on 2019/03/12. > I and - I believe - several other people regularly build Calcite on both JDK > 12 and OpenJDK 12, so we should declare that we support it. Tasks: > * Enable Travis on JDK 12 and/or OpenJDK 12 > * Add a paragraph to HISTORY.md for 1.20. > * Add JDK 12 to the paragraph in HISTORY.md for release 1.19. I built and > tested on JDK 12 and everything was FINE. > * Add JDK 12 to site/_docs/howto.md. > * Wherever howto.md says to use JDK 11 for a particular task, switch to JDK > 12. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (CALCITE-2911) Release Calcite 1.19.0
[ https://issues.apache.org/jira/browse/CALCITE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden closed CALCITE-2911. - > Release Calcite 1.19.0 > -- > > Key: CALCITE-2911 > URL: https://issues.apache.org/jira/browse/CALCITE-2911 > Project: Calcite > Issue Type: Task >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 1.19.0 > > > Release Calcite 1.19.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CALCITE-2911) Release Calcite 1.19.0
[ https://issues.apache.org/jira/browse/CALCITE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved CALCITE-2911. --- Resolution: Fixed Resolved in commit 4143176acdb2860b3a80eb18e4cb1557f5969d13 > Release Calcite 1.19.0 > -- > > Key: CALCITE-2911 > URL: https://issues.apache.org/jira/browse/CALCITE-2911 > Project: Calcite > Issue Type: Task >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 1.19.0 > > > Release Calcite 1.19.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (CALCITE-2790) AggregateJoinTransposeRule incorrectly pushes down distinct count into join
[ https://issues.apache.org/jira/browse/CALCITE-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden closed CALCITE-2790. - > AggregateJoinTransposeRule incorrectly pushes down distinct count into join > --- > > Key: CALCITE-2790 > URL: https://issues.apache.org/jira/browse/CALCITE-2790 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.18.0 >Reporter: Andrew Tsvelodub >Assignee: Julian Hyde >Priority: Major > Fix For: 1.19.0 > > > AggregateJoinTransposeRule.EXTENDED can push down aggregate functions into > the join. > For Distinct Count (and other distinct aggregate functions) this should not > be performed the same way as for simple count, since distinct count is not a > decomposable function. [1] > While this can be done in theory, by adding the distinct column to the list > of groups in below aggregate[2], I want to fix the buggy behavior first, > before trying to improve the existing rule. > [1] Dynamic Programming: The Next Step, M. Eich, G. Moerkotte > ([https://ub-madoc.bib.uni-mannheim.de/37228/1/main.pdf]) > [2] Including Group-By in Query Optimization, S. Chaudhuri, K. Shim > ([https://pdfs.semanticscholar.org/3079/5447cec18753254edbbd7839f0afa58b2a39.pdf]) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2911) Release Calcite 1.19.0
[ https://issues.apache.org/jira/browse/CALCITE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797256#comment-16797256 ] Kevin Risden commented on CALCITE-2911: --- Blockers have been resolved after RC1. Starting RC2 > Release Calcite 1.19.0 > -- > > Key: CALCITE-2911 > URL: https://issues.apache.org/jira/browse/CALCITE-2911 > Project: Calcite > Issue Type: Task >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 1.19.0 > > > Release Calcite 1.19.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CALCITE-2929) Simplification of IS NULL checks are incorrectly assuming that CAST-s are possible
[
https://issues.apache.org/jira/browse/CALCITE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden resolved CALCITE-2929.
---
Resolution: Fixed
merged in commit a648f9c12309cc253628930b0cab98591caa66ab
> Simplification of IS NULL checks are incorrectly assuming that CAST-s are
> possible
> --
>
> Key: CALCITE-2929
> URL: https://issues.apache.org/jira/browse/CALCITE-2929
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Example:
> {code}
> with ax(s) as (values ('xxx'),(cast(null as character varying)))
> select cast(s as int) IS NULL from ax;
> {code}
> returns a result set; which evaluates
> however 'xxx' is not a valid integer; so an error should be recieved instead
> Another class of almost the same issue:
> {code}
> select cast('xxx' as int) IS NULL;
> {code}
> is also problematic; in that case the not nullability is deduced from the
> fact that the literal's type is not nullable
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2930) FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException
[
https://issues.apache.org/jira/browse/CALCITE-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2930:
--
Fix Version/s: (was: 1.19.0)
1.20.0
> FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws
> IllegalStateException
>
>
> Key: CALCITE-2930
> URL: https://issues.apache.org/jira/browse/CALCITE-2930
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.18.0, 1.19.0
>Reporter: Ruben Quesada Lopez
>Assignee: Ruben Quesada Lopez
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.20.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> FilterCorrelateRule#onMatch method executes the following:
> {code:java}
> public void onMatch(RelOptRuleCall call) {
> final Filter filter = call.rel(0);
> final Correlate corr = call.rel(1);
> ...
> RelOptUtil.classifyFilters(
> corr,
> aboveFilters,
> JoinRelType.INNER,
> false,
> !corr.getJoinType().toJoinType().generatesNullsOnLeft(), // *** HERE!
> !corr.getJoinType().toJoinType().generatesNullsOnRight(), // *** HERE!
> aboveFilters,
> leftFilters,
> rightFilters);
> ...
> {code}
> If the Correlate object has SemiJoinType SEMI (or ANTI), the
> {{corr.getJoinType().toJoinType()}} will throw a IllegalStateException:
> {code}
> Caused by: java.lang.IllegalStateException: Unable to convert SEMI to
> JoinRelType
> at org.apache.calcite.sql.SemiJoinType.toJoinType(SemiJoinType.java:83)
> at
> org.apache.calcite.rel.rules.FilterCorrelateRule.onMatch(FilterCorrelateRule.java:89)
> at
> org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:205)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2928) Make UDF lookup default to case insensitive
[
https://issues.apache.org/jira/browse/CALCITE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797176#comment-16797176
]
Kevin Risden commented on CALCITE-2928:
---
Updated fix version to 1.20.0 since this was created after 1.19.0 RC were
started.
> Make UDF lookup default to case insensitive
> ---
>
> Key: CALCITE-2928
> URL: https://issues.apache.org/jira/browse/CALCITE-2928
> Project: Calcite
> Issue Type: Improvement
> Components: core
>Affects Versions: 1.19.0
>Reporter: Danny Chan
>Assignee: Danny Chan
>Priority: Major
> Fix For: 1.20.0
>
>
> Now for Calcite, we make default parser config unquotedCasing to
> Lex.ORACLE.unquotedCasing(to uppercase)[1], and caseSensitive to
> Lex.ORACLE.caseSensitive(case sensitive true).
> So if we have a UDAF named my_func and query with sql like:
> {code:java}
> select f0, my_func(f1) from table1 group by f0;
> {code}
> We would got a unparsed sql:
> {code:java}
> SELECT F0, MY_FUNC(F1) FROM TABLE1 GROUP BY F0;
> {code}
> For CalciteCatalogReader we hard code the function look up to case sensitive
> true[2],
> For ListSqlOperatorTable we make the operator name lookup case sensitive
> true[3].
> For ReflectiveSqlOperatorTable, we make built-in operators
> case-insensitively[4].
> For most of the cases, we use ListSqlOperatorTable to register our UDFs[5]
> chained with SqlStdOperatorTable(which composite a ChainedSqlOperatorTable),
> which finally passed to CalciteCatalogReader for validation.
> So there are some questions i have:
> 1. Why we make built-in operators look up case-insensitively while
> ListSqlOperatorTable(for UDFs) case-sensitively, with default unquotedCasing
> of TO_UPPERCASE.
> 2. What is the usage of CalciteCatalogReader#lookupOperatorOverloads i only
> saw it used in a unit test LookupOperatorOverloadsTest.
> It seems that make UDF look up case-sensitively does not make any sense,
> users will never distinguish their function with just word cases. And i
> checked also MYSQL, ORACLE, POSTGRES, their UDFs are all registered
> case-insensitively.
> [1]
> https://github.com/apache/calcite/blob/ffca956be03a99cd11e440d652b09674aaa727e6/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java#L231
> [2]
> https://github.com/apache/calcite/blob/ffca956be03a99cd11e440d652b09674aaa727e6/core/src/main/java/org/apache/calcite/prepare/CalciteCatalogReader.java#L166
> [3]
> https://github.com/apache/calcite/blob/ffca956be03a99cd11e440d652b09674aaa727e6/core/src/main/java/org/apache/calcite/sql/util/ListSqlOperatorTable.java#L63
> [4]
> https://github.com/apache/calcite/blob/ffca956be03a99cd11e440d652b09674aaa727e6/core/src/main/java/org/apache/calcite/sql/util/ReflectiveSqlOperatorTable.java#L103
> [5]
> https://github.com/apache/calcite/blob/ffca956be03a99cd11e440d652b09674aaa727e6/core/src/test/java/org/apache/calcite/test/MockSqlOperatorTable.java#L46
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2930) FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException
[
https://issues.apache.org/jira/browse/CALCITE-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797179#comment-16797179
]
Kevin Risden commented on CALCITE-2930:
---
Updated fix version to 1.20.0 since this was created after 1.19.0 RC were
started and reviews are still ongoing.
> FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws
> IllegalStateException
>
>
> Key: CALCITE-2930
> URL: https://issues.apache.org/jira/browse/CALCITE-2930
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.18.0, 1.19.0
>Reporter: Ruben Quesada Lopez
>Assignee: Ruben Quesada Lopez
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.20.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> FilterCorrelateRule#onMatch method executes the following:
> {code:java}
> public void onMatch(RelOptRuleCall call) {
> final Filter filter = call.rel(0);
> final Correlate corr = call.rel(1);
> ...
> RelOptUtil.classifyFilters(
> corr,
> aboveFilters,
> JoinRelType.INNER,
> false,
> !corr.getJoinType().toJoinType().generatesNullsOnLeft(), // *** HERE!
> !corr.getJoinType().toJoinType().generatesNullsOnRight(), // *** HERE!
> aboveFilters,
> leftFilters,
> rightFilters);
> ...
> {code}
> If the Correlate object has SemiJoinType SEMI (or ANTI), the
> {{corr.getJoinType().toJoinType()}} will throw a IllegalStateException:
> {code}
> Caused by: java.lang.IllegalStateException: Unable to convert SEMI to
> JoinRelType
> at org.apache.calcite.sql.SemiJoinType.toJoinType(SemiJoinType.java:83)
> at
> org.apache.calcite.rel.rules.FilterCorrelateRule.onMatch(FilterCorrelateRule.java:89)
> at
> org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:205)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2930) FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException
[
https://issues.apache.org/jira/browse/CALCITE-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2930:
--
Affects Version/s: 1.19.0
> FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws
> IllegalStateException
>
>
> Key: CALCITE-2930
> URL: https://issues.apache.org/jira/browse/CALCITE-2930
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.18.0, 1.19.0
>Reporter: Ruben Quesada Lopez
>Assignee: Ruben Quesada Lopez
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> FilterCorrelateRule#onMatch method executes the following:
> {code:java}
> public void onMatch(RelOptRuleCall call) {
> final Filter filter = call.rel(0);
> final Correlate corr = call.rel(1);
> ...
> RelOptUtil.classifyFilters(
> corr,
> aboveFilters,
> JoinRelType.INNER,
> false,
> !corr.getJoinType().toJoinType().generatesNullsOnLeft(), // *** HERE!
> !corr.getJoinType().toJoinType().generatesNullsOnRight(), // *** HERE!
> aboveFilters,
> leftFilters,
> rightFilters);
> ...
> {code}
> If the Correlate object has SemiJoinType SEMI (or ANTI), the
> {{corr.getJoinType().toJoinType()}} will throw a IllegalStateException:
> {code}
> Caused by: java.lang.IllegalStateException: Unable to convert SEMI to
> JoinRelType
> at org.apache.calcite.sql.SemiJoinType.toJoinType(SemiJoinType.java:83)
> at
> org.apache.calcite.rel.rules.FilterCorrelateRule.onMatch(FilterCorrelateRule.java:89)
> at
> org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:205)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2928) Make UDF lookup default to case insensitive
[
https://issues.apache.org/jira/browse/CALCITE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2928:
--
Fix Version/s: (was: 1.19.0)
1.20.0
> Make UDF lookup default to case insensitive
> ---
>
> Key: CALCITE-2928
> URL: https://issues.apache.org/jira/browse/CALCITE-2928
> Project: Calcite
> Issue Type: Improvement
> Components: core
>Affects Versions: 1.19.0
>Reporter: Danny Chan
>Assignee: Danny Chan
>Priority: Major
> Fix For: 1.20.0
>
>
> Now for Calcite, we make default parser config unquotedCasing to
> Lex.ORACLE.unquotedCasing(to uppercase)[1], and caseSensitive to
> Lex.ORACLE.caseSensitive(case sensitive true).
> So if we have a UDAF named my_func and query with sql like:
> {code:java}
> select f0, my_func(f1) from table1 group by f0;
> {code}
> We would got a unparsed sql:
> {code:java}
> SELECT F0, MY_FUNC(F1) FROM TABLE1 GROUP BY F0;
> {code}
> For CalciteCatalogReader we hard code the function look up to case sensitive
> true[2],
> For ListSqlOperatorTable we make the operator name lookup case sensitive
> true[3].
> For ReflectiveSqlOperatorTable, we make built-in operators
> case-insensitively[4].
> For most of the cases, we use ListSqlOperatorTable to register our UDFs[5]
> chained with SqlStdOperatorTable(which composite a ChainedSqlOperatorTable),
> which finally passed to CalciteCatalogReader for validation.
> So there are some questions i have:
> 1. Why we make built-in operators look up case-insensitively while
> ListSqlOperatorTable(for UDFs) case-sensitively, with default unquotedCasing
> of TO_UPPERCASE.
> 2. What is the usage of CalciteCatalogReader#lookupOperatorOverloads i only
> saw it used in a unit test LookupOperatorOverloadsTest.
> It seems that make UDF look up case-sensitively does not make any sense,
> users will never distinguish their function with just word cases. And i
> checked also MYSQL, ORACLE, POSTGRES, their UDFs are all registered
> case-insensitively.
> [1]
> https://github.com/apache/calcite/blob/ffca956be03a99cd11e440d652b09674aaa727e6/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java#L231
> [2]
> https://github.com/apache/calcite/blob/ffca956be03a99cd11e440d652b09674aaa727e6/core/src/main/java/org/apache/calcite/prepare/CalciteCatalogReader.java#L166
> [3]
> https://github.com/apache/calcite/blob/ffca956be03a99cd11e440d652b09674aaa727e6/core/src/main/java/org/apache/calcite/sql/util/ListSqlOperatorTable.java#L63
> [4]
> https://github.com/apache/calcite/blob/ffca956be03a99cd11e440d652b09674aaa727e6/core/src/main/java/org/apache/calcite/sql/util/ReflectiveSqlOperatorTable.java#L103
> [5]
> https://github.com/apache/calcite/blob/ffca956be03a99cd11e440d652b09674aaa727e6/core/src/test/java/org/apache/calcite/test/MockSqlOperatorTable.java#L46
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2930) FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws IllegalStateException
[
https://issues.apache.org/jira/browse/CALCITE-2930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796217#comment-16796217
]
Kevin Risden commented on CALCITE-2930:
---
[~rubenql] - we have been closing down 1.19.0 for the last few weeks. There
have been 2 RCs so far.
Why do you think this should go into 1.19.0 now?
Do you have a link to the JIRA that caused this?
> FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws
> IllegalStateException
>
>
> Key: CALCITE-2930
> URL: https://issues.apache.org/jira/browse/CALCITE-2930
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Ruben Quesada Lopez
>Assignee: Ruben Quesada Lopez
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> FilterCorrelateRule#onMatch method executes the following:
> {code:java}
> public void onMatch(RelOptRuleCall call) {
> final Filter filter = call.rel(0);
> final Correlate corr = call.rel(1);
> ...
> RelOptUtil.classifyFilters(
> corr,
> aboveFilters,
> JoinRelType.INNER,
> false,
> !corr.getJoinType().toJoinType().generatesNullsOnLeft(), // *** HERE!
> !corr.getJoinType().toJoinType().generatesNullsOnRight(), // *** HERE!
> aboveFilters,
> leftFilters,
> rightFilters);
> ...
> {code}
> If the Correlate object has SemiJoinType SEMI (or ANTI), the
> {{corr.getJoinType().toJoinType()}} will throw a IllegalStateException:
> {code}
> Caused by: java.lang.IllegalStateException: Unable to convert SEMI to
> JoinRelType
> at org.apache.calcite.sql.SemiJoinType.toJoinType(SemiJoinType.java:83)
> at
> org.apache.calcite.rel.rules.FilterCorrelateRule.onMatch(FilterCorrelateRule.java:89)
> at
> org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:205)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (CALCITE-2932) DruidAdapterIT regression after 1.17 release
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden resolved CALCITE-2932.
---
Resolution: Fixed
> DruidAdapterIT regression after 1.17 release
>
>
> Key: CALCITE-2932
> URL: https://issues.apache.org/jira/browse/CALCITE-2932
> Project: Calcite
> Issue Type: Bug
> Components: druid
>Affects Versions: 1.18.0
>Reporter: Kevin Risden
>Assignee: Hongze Zhang
>Priority: Major
> Labels: pull-request-available, regression
> Fix For: 1.19.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Output below from running:
> {code:java}
> mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
> -Dit.test=DruidAdapterIT
> ...
> [ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
> {code}
> {code:java}
> [INFO] Running org.apache.calcite.test.DruidAdapterIT
> [ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
> 96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
> [ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 3.725 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
> BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
> DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{29}], aggs=[[COUNT()]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
> [ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 30.195 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
> DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
> but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4],
> WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
> [ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
> 4.556 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
> BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{1}], aggs=[[]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC],
> fetch=[5])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
> [ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 23.506 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
> [ERROR]
>
[jira] [Commented] (CALCITE-2932) DruidAdapterIT regression after 1.17 release
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796058#comment-16796058
]
Kevin Risden commented on CALCITE-2932:
---
Thanks [~zhztheplayer]!
> DruidAdapterIT regression after 1.17 release
>
>
> Key: CALCITE-2932
> URL: https://issues.apache.org/jira/browse/CALCITE-2932
> Project: Calcite
> Issue Type: Bug
> Components: druid
>Affects Versions: 1.18.0
>Reporter: Kevin Risden
>Assignee: Hongze Zhang
>Priority: Major
> Labels: pull-request-available, regression
> Fix For: 1.19.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Output below from running:
> {code:java}
> mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
> -Dit.test=DruidAdapterIT
> ...
> [ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
> {code}
> {code:java}
> [INFO] Running org.apache.calcite.test.DruidAdapterIT
> [ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
> 96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
> [ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 3.725 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
> BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
> DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{29}], aggs=[[COUNT()]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
> [ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 30.195 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
> DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
> but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4],
> WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
> [ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
> 4.556 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
> BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{1}], aggs=[[]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC],
> fetch=[5])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
> [ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 23.506 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
> at
>
[jira] [Updated] (CALCITE-2932) DruidAdapterIT regression after 1.17 release
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2932:
--
Priority: Major (was: Blocker)
> DruidAdapterIT regression after 1.17 release
>
>
> Key: CALCITE-2932
> URL: https://issues.apache.org/jira/browse/CALCITE-2932
> Project: Calcite
> Issue Type: Bug
> Components: druid
>Affects Versions: 1.18.0
>Reporter: Kevin Risden
>Assignee: Hongze Zhang
>Priority: Major
> Labels: pull-request-available, regression
> Fix For: 1.19.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Output below from running:
> {code:java}
> mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
> -Dit.test=DruidAdapterIT
> ...
> [ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
> {code}
> {code:java}
> [INFO] Running org.apache.calcite.test.DruidAdapterIT
> [ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
> 96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
> [ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 3.725 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
> BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
> DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{29}], aggs=[[COUNT()]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
> [ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 30.195 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
> DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
> but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4],
> WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
> [ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
> 4.556 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
> BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{1}], aggs=[[]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC],
> fetch=[5])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
> [ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 23.506 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
> [ERROR]
>
[jira] [Commented] (CALCITE-2933) In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as varchar)" returns as epoch millisecond
[
https://issues.apache.org/jira/browse/CALCITE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796055#comment-16796055
]
Kevin Risden commented on CALCITE-2933:
---
[~zhztheplayer] and [~danny0405] - correct me if I'm wrong but is this issue
only in the druid adapter or is this a more general regression in Calcite?
> In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as
> varchar)" returns as epoch millisecond
> --
>
> Key: CALCITE-2933
> URL: https://issues.apache.org/jira/browse/CALCITE-2933
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Hongze Zhang
>Assignee: Danny Chan
>Priority: Major
>
> SQL 1:
> {code}
> select cast("timestamp" as timestamp) as t from "foodmart" order by t limit 1
> {code}
> Result:
> {code}
> T=1997-01-01 00:00:00
> {code}
> SQL 2:
> {code}
> select cast(cast("timestamp" as timestamp) as varchar) as t from "foodmart"
> order by t limit 1
> {code}
> Result:
> {code}
> T=85207680
> {code}
> The second query should returns with the same format as the first one.
> See test case:
> https://github.com/apache/calcite/blob/master/druid/src/test/java/org/apache/calcite/test/DruidAdapterIT2.java#L3937-L3946
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2911) Release Calcite 1.19.0
[ https://issues.apache.org/jira/browse/CALCITE-2911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796035#comment-16796035 ] Kevin Risden commented on CALCITE-2911: --- RC 0 was cancelled by CALCITE-2925 RC 1 was cancelled by CALCITE-2929 and CALCITE-2932 > Release Calcite 1.19.0 > -- > > Key: CALCITE-2911 > URL: https://issues.apache.org/jira/browse/CALCITE-2911 > Project: Calcite > Issue Type: Task >Reporter: Kevin Risden >Assignee: Kevin Risden >Priority: Major > Fix For: 1.19.0 > > > Release Calcite 1.19.0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CALCITE-2931) Mongo Adapter - Compare Bson (not string) query representation in tests
[
https://issues.apache.org/jira/browse/CALCITE-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden resolved CALCITE-2931.
---
Resolution: Fixed
Thanks [~sereda]!
> Mongo Adapter - Compare Bson (not string) query representation in tests
> ---
>
> Key: CALCITE-2931
> URL: https://issues.apache.org/jira/browse/CALCITE-2931
> Project: Calcite
> Issue Type: Test
> Components: mongodb
>Reporter: Andrei Sereda
>Assignee: Andrei Sereda
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Some tests currently fail because of wrong order of keys in Bson.
> {code:json}
> // Expected
> {$project: {POP: '$pop', STATE: '$state'}}
> // Actual
> {$project: {STATE: '$state', POP: '$pop'}}
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2931) Mongo Adapter - Compare Bson (not string) query representation in tests
[
https://issues.apache.org/jira/browse/CALCITE-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796022#comment-16796022
]
Kevin Risden commented on CALCITE-2931:
---
Resolved in 600da53545eb9b116aae7692ba287a7acd23d987
> Mongo Adapter - Compare Bson (not string) query representation in tests
> ---
>
> Key: CALCITE-2931
> URL: https://issues.apache.org/jira/browse/CALCITE-2931
> Project: Calcite
> Issue Type: Test
> Components: mongodb
>Reporter: Andrei Sereda
>Assignee: Andrei Sereda
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Some tests currently fail because of wrong order of keys in Bson.
> {code:json}
> // Expected
> {$project: {POP: '$pop', STATE: '$state'}}
> // Actual
> {$project: {STATE: '$state', POP: '$pop'}}
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2931) Mongo Adapter - Compare Bson (not string) query representation in tests
[
https://issues.apache.org/jira/browse/CALCITE-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2931:
--
Summary: Mongo Adapter - Compare Bson (not string) query representation in
tests (was: Mongo Adapter. Compare Bson (not string) query representation in
tests)
> Mongo Adapter - Compare Bson (not string) query representation in tests
> ---
>
> Key: CALCITE-2931
> URL: https://issues.apache.org/jira/browse/CALCITE-2931
> Project: Calcite
> Issue Type: Test
> Components: mongodb
>Reporter: Andrei Sereda
>Assignee: Andrei Sereda
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Some tests currently fail because of wrong order of keys in Bson.
> {code:json}
> // Expected
> {$project: {POP: '$pop', STATE: '$state'}}
> // Actual
> {$project: {STATE: '$state', POP: '$pop'}}
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2932) DruidAdapterIT regression after 1.17 release
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795985#comment-16795985
]
Kevin Risden commented on CALCITE-2932:
---
[~zhztheplayer] - FYI you can run just the Druid integration tests with "mvn
clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
-Dit.test=DruidAdapterIT"
I'll checkout the PR shortly to see if it solves the issues we were seeing.
> DruidAdapterIT regression after 1.17 release
>
>
> Key: CALCITE-2932
> URL: https://issues.apache.org/jira/browse/CALCITE-2932
> Project: Calcite
> Issue Type: Bug
> Components: druid
>Affects Versions: 1.18.0
>Reporter: Kevin Risden
>Assignee: Hongze Zhang
>Priority: Blocker
> Labels: pull-request-available, regression
> Fix For: 1.19.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Output below from running:
> {code:java}
> mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
> -Dit.test=DruidAdapterIT
> ...
> [ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
> {code}
> {code:java}
> [INFO] Running org.apache.calcite.test.DruidAdapterIT
> [ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
> 96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
> [ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 3.725 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
> BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
> DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{29}], aggs=[[COUNT()]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
> [ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 30.195 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
> DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
> but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4],
> WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
> [ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
> 4.556 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
> BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{1}], aggs=[[]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC],
> fetch=[5])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
> [ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 23.506 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]],
[jira] [Commented] (CALCITE-2934) Simplification of a filter =($0, false) to NOT($0) ($0 is boolean)
[ https://issues.apache.org/jira/browse/CALCITE-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795972#comment-16795972 ] Kevin Risden commented on CALCITE-2934: --- [~zabetak] - Please correct as you see fit. I copied/pasted your description from the 1.19 RC vote thread. > Simplification of a filter =($0, false) to NOT($0) ($0 is boolean) > -- > > Key: CALCITE-2934 > URL: https://issues.apache.org/jira/browse/CALCITE-2934 > Project: Calcite > Issue Type: Bug >Reporter: Stamatis Zampetakis >Priority: Major > Fix For: 1.20.0 > > > The errors occur due to the simplification of a filter =($0, false) to > NOT($0) ($0 is boolean). The transformation is valid so in principle the > tests should not fail. However it makes me wonder if adding negation is > really a simplification. If I want to push this expression into an index > (e.g., B+Tree) I would have to rewrite it again to something equivalent to > =($0, false) since many types of indexes do not support negative conditions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CALCITE-2934) Simplification of a filter =($0, false) to NOT($0) ($0 is boolean)
Kevin Risden created CALCITE-2934: - Summary: Simplification of a filter =($0, false) to NOT($0) ($0 is boolean) Key: CALCITE-2934 URL: https://issues.apache.org/jira/browse/CALCITE-2934 Project: Calcite Issue Type: Bug Reporter: Stamatis Zampetakis Fix For: 1.20.0 The errors occur due to the simplification of a filter =($0, false) to NOT($0) ($0 is boolean). The transformation is valid so in principle the tests should not fail. However it makes me wonder if adding negation is really a simplification. If I want to push this expression into an index (e.g., B+Tree) I would have to rewrite it again to something equivalent to =($0, false) since many types of indexes do not support negative conditions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (CALCITE-2931) Mongo Adapter. Compare Bson (not string) query representation in tests
[
https://issues.apache.org/jira/browse/CALCITE-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795442#comment-16795442
]
Kevin Risden edited comment on CALCITE-2931 at 3/19/19 10:35 AM:
-
Marking for release 1.20.0 since it looks to be just an ordering issue and not
a blocker for 1.19.0.
was (Author: risdenk):
Marking for release 1.12.0 since it looks to be just an ordering issue and not
a blocker for 1.19.0.
> Mongo Adapter. Compare Bson (not string) query representation in tests
> --
>
> Key: CALCITE-2931
> URL: https://issues.apache.org/jira/browse/CALCITE-2931
> Project: Calcite
> Issue Type: Bug
> Components: mongodb
>Reporter: Andrei Sereda
>Assignee: Andrei Sereda
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Some tests currently fail because of wrong order of keys in Bson.
> {code:json}
> // Expected
> {$project: {POP: '$pop', STATE: '$state'}}
> // Actual
> {$project: {STATE: '$state', POP: '$pop'}}
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2931) Mongo Adapter. Compare Bson (not string) query representation in tests
[
https://issues.apache.org/jira/browse/CALCITE-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795958#comment-16795958
]
Kevin Risden commented on CALCITE-2931:
---
Pulling this back into 1.19.0 since there are other fixes needed so might as
well include.
> Mongo Adapter. Compare Bson (not string) query representation in tests
> --
>
> Key: CALCITE-2931
> URL: https://issues.apache.org/jira/browse/CALCITE-2931
> Project: Calcite
> Issue Type: Bug
> Components: mongodb
>Reporter: Andrei Sereda
>Assignee: Andrei Sereda
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Some tests currently fail because of wrong order of keys in Bson.
> {code:json}
> // Expected
> {$project: {POP: '$pop', STATE: '$state'}}
> // Actual
> {$project: {STATE: '$state', POP: '$pop'}}
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2929) Simplification of IS NULL checks are incorrectly assuming that CAST-s are possible
[
https://issues.apache.org/jira/browse/CALCITE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2929:
--
Affects Version/s: 1.18.0
> Simplification of IS NULL checks are incorrectly assuming that CAST-s are
> possible
> --
>
> Key: CALCITE-2929
> URL: https://issues.apache.org/jira/browse/CALCITE-2929
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.18.0
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.19.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Example:
> {code}
> with ax(s) as (values ('xxx'),(cast(null as character varying)))
> select cast(s as int) IS NULL from ax;
> {code}
> returns a result set; which evaluates
> however 'xxx' is not a valid integer; so an error should be recieved instead
> Another class of almost the same issue:
> {code}
> select cast('xxx' as int) IS NULL;
> {code}
> is also problematic; in that case the not nullability is deduced from the
> fact that the literal's type is not nullable
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2932) DruidAdapterIT regression after 1.17 release
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2932:
--
Affects Version/s: (was: 1.19.0)
> DruidAdapterIT regression after 1.17 release
>
>
> Key: CALCITE-2932
> URL: https://issues.apache.org/jira/browse/CALCITE-2932
> Project: Calcite
> Issue Type: Test
> Components: druid
>Affects Versions: 1.18.0
>Reporter: Kevin Risden
>Assignee: Hongze Zhang
>Priority: Blocker
> Labels: pull-request-available, regression
> Fix For: 1.19.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Output below from running:
> {code:java}
> mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
> -Dit.test=DruidAdapterIT
> ...
> [ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
> {code}
> {code:java}
> [INFO] Running org.apache.calcite.test.DruidAdapterIT
> [ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
> 96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
> [ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 3.725 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
> BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
> DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{29}], aggs=[[COUNT()]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
> [ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 30.195 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
> DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
> but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4],
> WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
> [ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
> 4.556 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
> BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{1}], aggs=[[]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC],
> fetch=[5])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
> [ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 23.506 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
> [ERROR]
>
[jira] [Updated] (CALCITE-2932) DruidAdapterIT regression after 1.17 release
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2932:
--
Fix Version/s: 1.19.0
> DruidAdapterIT regression after 1.17 release
>
>
> Key: CALCITE-2932
> URL: https://issues.apache.org/jira/browse/CALCITE-2932
> Project: Calcite
> Issue Type: Test
> Components: druid
>Affects Versions: 1.18.0, 1.19.0
>Reporter: Kevin Risden
>Assignee: Hongze Zhang
>Priority: Blocker
> Labels: pull-request-available, regression
> Fix For: 1.19.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Output below from running:
> {code:java}
> mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
> -Dit.test=DruidAdapterIT
> ...
> [ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
> {code}
> {code:java}
> [INFO] Running org.apache.calcite.test.DruidAdapterIT
> [ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
> 96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
> [ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 3.725 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
> BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
> DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{29}], aggs=[[COUNT()]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
> [ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 30.195 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
> DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
> but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4],
> WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
> [ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
> 4.556 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
> BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{1}], aggs=[[]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC],
> fetch=[5])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
> [ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 23.506 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
> [ERROR]
>
[jira] [Updated] (CALCITE-2932) DruidAdapterIT regression after 1.17 release
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2932:
--
Summary: DruidAdapterIT regression after 1.17 release (was: DruidAdapterIT
regression after 1.18 release)
> DruidAdapterIT regression after 1.17 release
>
>
> Key: CALCITE-2932
> URL: https://issues.apache.org/jira/browse/CALCITE-2932
> Project: Calcite
> Issue Type: Test
> Components: druid
>Affects Versions: 1.18.0, 1.19.0
>Reporter: Kevin Risden
>Assignee: Hongze Zhang
>Priority: Blocker
> Labels: pull-request-available, regression
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Output below from running:
> {code:java}
> mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
> -Dit.test=DruidAdapterIT
> ...
> [ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
> {code}
> {code:java}
> [INFO] Running org.apache.calcite.test.DruidAdapterIT
> [ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
> 96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
> [ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 3.725 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
> BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
> DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{29}], aggs=[[COUNT()]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
> [ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 30.195 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
> DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
> but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4],
> WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
> [ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
> 4.556 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
> BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{1}], aggs=[[]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC],
> fetch=[5])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
> [ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 23.506 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
> at
>
[jira] [Commented] (CALCITE-2932) DruidAdapterIT test failures
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795450#comment-16795450
]
Kevin Risden commented on CALCITE-2932:
---
One of the failures is from CALCITE-2469
90f49be639b9a569e3dc4d8369c08e2db64ea301. This doesn't account for all the
failures.
> DruidAdapterIT test failures
>
>
> Key: CALCITE-2932
> URL: https://issues.apache.org/jira/browse/CALCITE-2932
> Project: Calcite
> Issue Type: Test
>Affects Versions: 1.18.0, 1.19.0
>Reporter: Kevin Risden
>Priority: Major
>
> Output below from running:
> {code:java}
> mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
> -Dit.test=DruidAdapterIT
> ...
> [ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
> {code}
> {code:java}
> [INFO] Running org.apache.calcite.test.DruidAdapterIT
> [ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
> 96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
> [ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 3.725 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
> BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
> DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{29}], aggs=[[COUNT()]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
> [ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 30.195 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
> DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
> but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4],
> WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
> [ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
> 4.556 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
> BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{1}], aggs=[[]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC],
> fetch=[5])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
> [ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 23.506 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
> [ERROR]
> testExpressionsFilterWithCastTimeToDateToChar(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 0.336 s
[jira] [Commented] (CALCITE-2932) DruidAdapterIT test failures
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795438#comment-16795438
]
Kevin Risden commented on CALCITE-2932:
---
So this broke somewhere between the 1.17 to 1.18 releases (and doesn't seem to
have gotten any worse in the 1.19 release).
> DruidAdapterIT test failures
>
>
> Key: CALCITE-2932
> URL: https://issues.apache.org/jira/browse/CALCITE-2932
> Project: Calcite
> Issue Type: Test
>Reporter: Kevin Risden
>Priority: Major
>
> Output below from running:
> {code:java}
> mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
> -Dit.test=DruidAdapterIT
> ...
> [ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
> {code}
> {code:java}
> [INFO] Running org.apache.calcite.test.DruidAdapterIT
> [ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
> 96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
> [ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 3.725 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
> BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
> DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{29}], aggs=[[COUNT()]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
> [ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 30.195 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
> DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
> but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4],
> WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
> [ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
> 4.556 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
> BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{1}], aggs=[[]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC],
> fetch=[5])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
> [ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 23.506 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
> [ERROR]
> testExpressionsFilterWithCastTimeToDateToChar(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 0.336 s <<< FAILURE!
> java.lang.AssertionError:
>
[jira] [Commented] (CALCITE-2931) Mongo Adapter. Compare Bson (not string) query representation in tests
[
https://issues.apache.org/jira/browse/CALCITE-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795442#comment-16795442
]
Kevin Risden commented on CALCITE-2931:
---
Marking for release 1.12.0 since it looks to be just an ordering issue and not
a blocker for 1.19.0.
> Mongo Adapter. Compare Bson (not string) query representation in tests
> --
>
> Key: CALCITE-2931
> URL: https://issues.apache.org/jira/browse/CALCITE-2931
> Project: Calcite
> Issue Type: Bug
> Components: mongodb
>Reporter: Andrei Sereda
>Assignee: Andrei Sereda
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.20.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Some tests currently fail because of wrong order of keys in Bson.
> {code:json}
> // Expected
> {$project: {POP: '$pop', STATE: '$state'}}
> // Actual
> {$project: {STATE: '$state', POP: '$pop'}}
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CALCITE-2931) Mongo Adapter. Compare Bson (not string) query representation in tests
[
https://issues.apache.org/jira/browse/CALCITE-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2931:
--
Fix Version/s: 1.20.0
> Mongo Adapter. Compare Bson (not string) query representation in tests
> --
>
> Key: CALCITE-2931
> URL: https://issues.apache.org/jira/browse/CALCITE-2931
> Project: Calcite
> Issue Type: Bug
> Components: mongodb
>Reporter: Andrei Sereda
>Assignee: Andrei Sereda
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.20.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Some tests currently fail because of wrong order of keys in Bson.
> {code:json}
> // Expected
> {$project: {POP: '$pop', STATE: '$state'}}
> // Actual
> {$project: {STATE: '$state', POP: '$pop'}}
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-2932) DruidAdapterIT test failures
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795440#comment-16795440
]
Kevin Risden commented on CALCITE-2932:
---
Running git bisect between the 1.17.0 and 1.18.0 release tags to see where this
started failing. Will post results when it is finished.
> DruidAdapterIT test failures
>
>
> Key: CALCITE-2932
> URL: https://issues.apache.org/jira/browse/CALCITE-2932
> Project: Calcite
> Issue Type: Test
>Affects Versions: 1.18.0, 1.19.0
>Reporter: Kevin Risden
>Priority: Major
>
> Output below from running:
> {code:java}
> mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
> -Dit.test=DruidAdapterIT
> ...
> [ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
> {code}
> {code:java}
> [INFO] Running org.apache.calcite.test.DruidAdapterIT
> [ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
> 96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
> [ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 3.725 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
> BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
> DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{29}], aggs=[[COUNT()]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
> [ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 30.195 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
> DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
> but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4],
> WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
> [ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
> 4.556 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
> BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{1}], aggs=[[]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC],
> fetch=[5])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
> [ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 23.506 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
> [ERROR]
> testExpressionsFilterWithCastTimeToDateToChar(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed:
[jira] [Updated] (CALCITE-2932) DruidAdapterIT test failures
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2932:
--
Description:
Output below from running:
{code:java}
./mvnw verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
-Dit.test=DruidAdapterIT
...
[ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
{code}
{code:java}
[INFO] Running org.apache.calcite.test.DruidAdapterIT
[ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
[ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 3.725 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], groups=[{29}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
[ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT) Time
elapsed: 30.195 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
DruidQuery(table=[[wiki, wikiticker]],
intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0), EXTRACT(FLAG(DAY),
$0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0), $1]], groups=[{0, 1,
2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4], WEEK=[$0],
DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
DruidQuery(table=[[wiki, wikiticker]],
intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0), EXTRACT(FLAG(DAY),
$0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0), $1]], groups=[{0, 1,
2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
[ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
4.556 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
groups=[{1}], aggs=[[]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC], fetch=[5])\n\n"
at org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
[ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 23.506 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
[ERROR]
testExpressionsFilterWithCastTimeToDateToChar(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 0.336 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[=(CAST(CAST($0):DATE NOT NULL):VARCHAR CHARACTER SET \"ISO-8859-1\"
COLLATE \"ISO-8859-1$en_US$primary\" NOT NULL, '1997-01-01')], groups=[{}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[=(CAST(CAST($0):DATE NOT NULL):VARCHAR NOT NULL, '1997-01-01')],
groups=[{}], aggs=[[COUNT()]])\n\n"
at
[jira] [Updated] (CALCITE-2932) DruidAdapterIT test failures
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2932:
--
Affects Version/s: 1.19.0
1.18.0
> DruidAdapterIT test failures
>
>
> Key: CALCITE-2932
> URL: https://issues.apache.org/jira/browse/CALCITE-2932
> Project: Calcite
> Issue Type: Test
>Affects Versions: 1.18.0, 1.19.0
>Reporter: Kevin Risden
>Priority: Major
>
> Output below from running:
> {code:java}
> mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
> -Dit.test=DruidAdapterIT
> ...
> [ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
> {code}
> {code:java}
> [INFO] Running org.apache.calcite.test.DruidAdapterIT
> [ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
> 96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
> [ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 3.725 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
> BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
> DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{29}], aggs=[[COUNT()]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
> [ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 30.195 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
> DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
> but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4],
> WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
> [ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
> 4.556 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
> BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{1}], aggs=[[]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC],
> fetch=[5])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
> [ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 23.506 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
> SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
> CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
> [ERROR]
> testExpressionsFilterWithCastTimeToDateToChar(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 0.336 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
>
[jira] [Commented] (CALCITE-2932) DruidAdapterIT test failures
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795437#comment-16795437
]
Kevin Risden commented on CALCITE-2932:
---
Went back to branch 1.17 and ran the same test:
{code:java}
mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
-Dit.test=DruidAdapterIT
...
[INFO] Calcite SUCCESS [ 5.779 s]
[INFO] Calcite Linq4j . SUCCESS [ 14.458 s]
[INFO] Calcite Core ... SUCCESS [ 41.182 s]
[INFO] Calcite Babel .. SUCCESS [ 3.856 s]
[INFO] Calcite Cassandra .. SUCCESS [ 3.158 s]
[INFO] Calcite Druid .. SUCCESS [01:09 min]
[INFO] Calcite Elasticsearch .. SUCCESS [ 3.694 s]
[INFO] Calcite Examples ... SUCCESS [ 0.298 s]
[INFO] Calcite Example CSV SUCCESS [ 2.226 s]
[INFO] Calcite Example Function ... SUCCESS [ 1.838 s]
[INFO] Calcite File ... SUCCESS [ 2.512 s]
[INFO] Calcite Geode .. SUCCESS [ 2.578 s]
[INFO] Calcite MongoDB SUCCESS [ 2.246 s]
[INFO] Calcite Pig SUCCESS [ 3.052 s]
[INFO] Calcite Piglet . SUCCESS [ 2.372 s]
[INFO] Calcite Plus ... SUCCESS [ 2.494 s]
[INFO] Calcite Server . SUCCESS [ 3.359 s]
[INFO] Calcite Spark .. SUCCESS [ 2.819 s]
[INFO] Calcite Splunk . SUCCESS [ 1.917 s]
[INFO] Calcite Ubenchmark . SUCCESS [ 4.646 s]
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 02:54 min
[INFO] Finished at: 2019-03-18T18:12:22-04:00
[INFO]
{code}
> DruidAdapterIT test failures
>
>
> Key: CALCITE-2932
> URL: https://issues.apache.org/jira/browse/CALCITE-2932
> Project: Calcite
> Issue Type: Test
>Reporter: Kevin Risden
>Priority: Major
>
> Output below from running:
> {code:java}
> mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
> -Dit.test=DruidAdapterIT
> ...
> [ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
> {code}
> {code:java}
> [INFO] Running org.apache.calcite.test.DruidAdapterIT
> [ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
> 96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
> [ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 3.725 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
> BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
> DruidQuery(table=[[foodmart, foodmart]],
> intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> groups=[{29}], aggs=[[COUNT()]])"
> but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart,
> foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
> projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
> at
> org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
> [ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT)
> Time elapsed: 30.195 s <<< FAILURE!
> java.lang.AssertionError:
> Expected: a string containing "PLAN=EnumerableInterpreter\n
> BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
> DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
> but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4],
> WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
> DruidQuery(table=[[wiki, wikiticker]],
> intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
> projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0),
> EXTRACT(FLAG(DAY), $0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0),
> $1]], groups=[{0, 1, 2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
> at
>
[jira] [Updated] (CALCITE-2932) DruidAdapterIT test failures
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2932:
--
Description:
Output below from running:
{code:java}
./mvnw clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
-Dit.test=DruidAdapterIT
...
[ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
{code}
{code:java}
[INFO] Running org.apache.calcite.test.DruidAdapterIT
[ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
[ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 3.725 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], groups=[{29}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
[ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT) Time
elapsed: 30.195 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
DruidQuery(table=[[wiki, wikiticker]],
intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0), EXTRACT(FLAG(DAY),
$0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0), $1]], groups=[{0, 1,
2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4], WEEK=[$0],
DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
DruidQuery(table=[[wiki, wikiticker]],
intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0), EXTRACT(FLAG(DAY),
$0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0), $1]], groups=[{0, 1,
2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
[ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
4.556 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
groups=[{1}], aggs=[[]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC], fetch=[5])\n\n"
at org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
[ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 23.506 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
[ERROR]
testExpressionsFilterWithCastTimeToDateToChar(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 0.336 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[=(CAST(CAST($0):DATE NOT NULL):VARCHAR CHARACTER SET \"ISO-8859-1\"
COLLATE \"ISO-8859-1$en_US$primary\" NOT NULL, '1997-01-01')], groups=[{}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[=(CAST(CAST($0):DATE NOT NULL):VARCHAR NOT NULL, '1997-01-01')],
groups=[{}],
[jira] [Comment Edited] (CALCITE-2932) DruidAdapterIT test failures
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795429#comment-16795429
]
Kevin Risden edited comment on CALCITE-2932 at 3/18/19 10:08 PM:
-
Went back to branch-1.18 and ran the same test:
{code:java}
./mvnw clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
-Dit.test=DruidAdapterIT
...
[ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0{code}
{code:java}
[INFO] Running org.apache.calcite.test.DruidAdapterIT
2019-03-18 18:05:31,591 [pool-1-thread-3] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Rolled up column
'user_id' is not allowed in COUNT
2019-03-18 18:05:31,596 [pool-1-thread-3] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 23 to
line 1, column 31: Rolled up column 'user_id' is not allowed in COUNT
2019-03-18 18:05:46,558 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Rolled up column
'user_id' is not allowed in COUNT
2019-03-18 18:05:46,558 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 14 to
line 1, column 22: Rolled up column 'user_id' is not allowed in COUNT
2019-03-18 18:05:46,562 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Cannot apply 'SUM' to
arguments of type 'SUM()'. Supported form(s): 'SUM()'
2019-03-18 18:05:46,562 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 8 to
line 1, column 21: Cannot apply 'SUM' to arguments of type 'SUM()'.
Supported form(s): 'SUM()'
2019-03-18 18:05:46,565 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Cannot apply 'AVG' to
arguments of type 'AVG()'. Supported form(s): 'AVG()'
2019-03-18 18:05:46,566 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 8 to
line 1, column 21: Cannot apply 'AVG' to arguments of type 'AVG()'.
Supported form(s): 'AVG()'
2019-03-18 18:05:46,569 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Rolled up column
'user_id' is not allowed in MAX
2019-03-18 18:05:46,569 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 12 to
line 1, column 20: Rolled up column 'user_id' is not allowed in MAX
2019-03-18 18:05:46,572 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Rolled up column
'user_id' is not allowed in MIN
2019-03-18 18:05:46,573 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 12 to
line 1, column 20: Rolled up column 'user_id' is not allowed in MIN
[ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0, Time elapsed:
66.56 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
[ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 3.808 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], groups=[{29}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3481)
[ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
4.966 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
groups=[{1}], aggs=[[]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC], fetch=[5])\n\n"
at org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1950)
[ERROR] testBooleanFilterExpressions(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 0.099 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], filter=[IS
TRUE(CAST(<>($1, '1')):BOOLEAN)], groups=[{}], aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], filter=[IS
[jira] [Comment Edited] (CALCITE-2932) DruidAdapterIT test failures
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795429#comment-16795429
]
Kevin Risden edited comment on CALCITE-2932 at 3/18/19 10:09 PM:
-
Went back to branch-1.18 and ran the same test:
{code:java}
mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
-Dit.test=DruidAdapterIT
...
[ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0{code}
{code:java}
[INFO] Running org.apache.calcite.test.DruidAdapterIT
2019-03-18 18:05:31,591 [pool-1-thread-3] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Rolled up column
'user_id' is not allowed in COUNT
2019-03-18 18:05:31,596 [pool-1-thread-3] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 23 to
line 1, column 31: Rolled up column 'user_id' is not allowed in COUNT
2019-03-18 18:05:46,558 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Rolled up column
'user_id' is not allowed in COUNT
2019-03-18 18:05:46,558 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 14 to
line 1, column 22: Rolled up column 'user_id' is not allowed in COUNT
2019-03-18 18:05:46,562 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Cannot apply 'SUM' to
arguments of type 'SUM()'. Supported form(s): 'SUM()'
2019-03-18 18:05:46,562 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 8 to
line 1, column 21: Cannot apply 'SUM' to arguments of type 'SUM()'.
Supported form(s): 'SUM()'
2019-03-18 18:05:46,565 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Cannot apply 'AVG' to
arguments of type 'AVG()'. Supported form(s): 'AVG()'
2019-03-18 18:05:46,566 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 8 to
line 1, column 21: Cannot apply 'AVG' to arguments of type 'AVG()'.
Supported form(s): 'AVG()'
2019-03-18 18:05:46,569 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Rolled up column
'user_id' is not allowed in MAX
2019-03-18 18:05:46,569 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 12 to
line 1, column 20: Rolled up column 'user_id' is not allowed in MAX
2019-03-18 18:05:46,572 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Rolled up column
'user_id' is not allowed in MIN
2019-03-18 18:05:46,573 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 12 to
line 1, column 20: Rolled up column 'user_id' is not allowed in MIN
[ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0, Time elapsed:
66.56 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
[ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 3.808 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], groups=[{29}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3481)
[ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
4.966 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
groups=[{1}], aggs=[[]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC], fetch=[5])\n\n"
at org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1950)
[ERROR] testBooleanFilterExpressions(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 0.099 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], filter=[IS
TRUE(CAST(<>($1, '1')):BOOLEAN)], groups=[{}], aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], filter=[IS
[jira] [Updated] (CALCITE-2932) DruidAdapterIT test failures
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2932:
--
Description:
Output below from running:
{code:java}
mvn clean verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
-Dit.test=DruidAdapterIT
...
[ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0
{code}
{code:java}
[INFO] Running org.apache.calcite.test.DruidAdapterIT
[ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
[ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 3.725 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], groups=[{29}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
[ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT) Time
elapsed: 30.195 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
DruidQuery(table=[[wiki, wikiticker]],
intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0), EXTRACT(FLAG(DAY),
$0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0), $1]], groups=[{0, 1,
2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4], WEEK=[$0],
DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
DruidQuery(table=[[wiki, wikiticker]],
intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0), EXTRACT(FLAG(DAY),
$0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0), $1]], groups=[{0, 1,
2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
[ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
4.556 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
groups=[{1}], aggs=[[]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC], fetch=[5])\n\n"
at org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
[ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 23.506 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
[ERROR]
testExpressionsFilterWithCastTimeToDateToChar(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 0.336 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[=(CAST(CAST($0):DATE NOT NULL):VARCHAR CHARACTER SET \"ISO-8859-1\"
COLLATE \"ISO-8859-1$en_US$primary\" NOT NULL, '1997-01-01')], groups=[{}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[=(CAST(CAST($0):DATE NOT NULL):VARCHAR NOT NULL, '1997-01-01')],
groups=[{}], aggs=[[COUNT()]])\n\n"
[jira] [Commented] (CALCITE-2932) DruidAdapterIT test failures
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795429#comment-16795429
]
Kevin Risden commented on CALCITE-2932:
---
Went back to branch-1.18 and ran the same test "./mvnw clean verify -Pit
-DfailIfNoTests=false -Dtest=DoesNotExist -Dit.test=DruidAdapterIT":
{code:java}
[ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0{code}
{code:java}
[INFO] Running org.apache.calcite.test.DruidAdapterIT
2019-03-18 18:05:31,591 [pool-1-thread-3] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Rolled up column
'user_id' is not allowed in COUNT
2019-03-18 18:05:31,596 [pool-1-thread-3] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 23 to
line 1, column 31: Rolled up column 'user_id' is not allowed in COUNT
2019-03-18 18:05:46,558 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Rolled up column
'user_id' is not allowed in COUNT
2019-03-18 18:05:46,558 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 14 to
line 1, column 22: Rolled up column 'user_id' is not allowed in COUNT
2019-03-18 18:05:46,562 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Cannot apply 'SUM' to
arguments of type 'SUM()'. Supported form(s): 'SUM()'
2019-03-18 18:05:46,562 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 8 to
line 1, column 21: Cannot apply 'SUM' to arguments of type 'SUM()'.
Supported form(s): 'SUM()'
2019-03-18 18:05:46,565 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Cannot apply 'AVG' to
arguments of type 'AVG()'. Supported form(s): 'AVG()'
2019-03-18 18:05:46,566 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 8 to
line 1, column 21: Cannot apply 'AVG' to arguments of type 'AVG()'.
Supported form(s): 'AVG()'
2019-03-18 18:05:46,569 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Rolled up column
'user_id' is not allowed in MAX
2019-03-18 18:05:46,569 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 12 to
line 1, column 20: Rolled up column 'user_id' is not allowed in MAX
2019-03-18 18:05:46,572 [pool-1-thread-22] ERROR -
org.apache.calcite.sql.validate.SqlValidatorException: Rolled up column
'user_id' is not allowed in MIN
2019-03-18 18:05:46,573 [pool-1-thread-22] ERROR -
org.apache.calcite.runtime.CalciteContextException: From line 1, column 12 to
line 1, column 20: Rolled up column 'user_id' is not allowed in MIN
[ERROR] Tests run: 234, Failures: 10, Errors: 6, Skipped: 0, Time elapsed:
66.56 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
[ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 3.808 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], groups=[{29}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3481)
[ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
4.966 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
groups=[{1}], aggs=[[]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC], fetch=[5])\n\n"
at org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1950)
[ERROR] testBooleanFilterExpressions(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 0.099 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], filter=[IS
TRUE(CAST(<>($1, '1')):BOOLEAN)], groups=[{}], aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], filter=[IS
TRUE(<>($1, '1'))], groups=[{}],
[jira] [Updated] (CALCITE-2932) DruidAdapterIT test failures
[
https://issues.apache.org/jira/browse/CALCITE-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated CALCITE-2932:
--
Description:
Output below from running:
{code:java}
./mvnw verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
-Dit.test=DruidAdapterIT
{code}
{code:java}
[INFO] Running org.apache.calcite.test.DruidAdapterIT
[ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
[ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 3.725 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], groups=[{29}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
[ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT) Time
elapsed: 30.195 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
DruidQuery(table=[[wiki, wikiticker]],
intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0), EXTRACT(FLAG(DAY),
$0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0), $1]], groups=[{0, 1,
2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4], WEEK=[$0],
DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
DruidQuery(table=[[wiki, wikiticker]],
intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0), EXTRACT(FLAG(DAY),
$0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0), $1]], groups=[{0, 1,
2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
[ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
4.556 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
groups=[{1}], aggs=[[]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC], fetch=[5])\n\n"
at org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
[ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 23.506 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
[ERROR]
testExpressionsFilterWithCastTimeToDateToChar(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 0.336 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[=(CAST(CAST($0):DATE NOT NULL):VARCHAR CHARACTER SET \"ISO-8859-1\"
COLLATE \"ISO-8859-1$en_US$primary\" NOT NULL, '1997-01-01')], groups=[{}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[=(CAST(CAST($0):DATE NOT NULL):VARCHAR NOT NULL, '1997-01-01')],
groups=[{}], aggs=[[COUNT()]])\n\n"
at
[jira] [Created] (CALCITE-2932) DruidAdapterIT test failures
Kevin Risden created CALCITE-2932:
-
Summary: DruidAdapterIT test failures
Key: CALCITE-2932
URL: https://issues.apache.org/jira/browse/CALCITE-2932
Project: Calcite
Issue Type: Test
Reporter: Kevin Risden
Output below from running:
{code:java}
./mvnw verify -Pit -DfailIfNoTests=false -Dtest=DoesNotExist
-Dit.test=DruidAdapterIT
{code}
{code:java}
[INFO] Running org.apache.calcite.test.DruidAdapterIT
[ERROR] Tests run: 234, Failures: 16, Errors: 6, Skipped: 0, Time elapsed:
96.879 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT
[ERROR] testComplexExpressionsIsNull(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 3.725 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableAggregate(group=[{}], EXPR$0=[$SUM0($1)])\n
BindableFilter(condition=[IS NULL(+(null, CAST($0):INTEGER))])\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]], groups=[{29}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[0]], groups=[{}], aggs=[[COUNT()]])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testComplexExpressionsIsNull(DruidAdapterIT.java:3475)
[ERROR] testQueryWithExtractsTimes(org.apache.calcite.test.DruidAdapterIT) Time
elapsed: 30.195 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableProject(QUARTER=[$4], WEEK=[$0], DAYOFWEEK=[$1], DAYOFMONTH=[$2],
DAYOFYEAR=[$3], SUM_ADDED=[$5])\n BindableSort(fetch=[1])\n
DruidQuery(table=[[wiki, wikiticker]],
intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0), EXTRACT(FLAG(DAY),
$0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0), $1]], groups=[{0, 1,
2, 3, 4}], aggs=[[SUM($5)]], sort0=[5], dir0=[ASC])"
but: was "PLAN=EnumerableInterpreter\n BindableProject(QUARTER=[$4], WEEK=[$0],
DAYOFWEEK=[$1], DAYOFMONTH=[$2], DAYOFYEAR=[$3], SUM_ADDED=[$5])\n
DruidQuery(table=[[wiki, wikiticker]],
intervals=[[1900-01-01T00:00:00.000Z/3000-01-01T00:00:00.000Z]],
projects=[[EXTRACT(FLAG(WEEK), $0), EXTRACT(FLAG(DOW), $0), EXTRACT(FLAG(DAY),
$0), EXTRACT(FLAG(DOY), $0), EXTRACT(FLAG(QUARTER), $0), $1]], groups=[{0, 1,
2, 3, 4}], aggs=[[SUM($5)]], fetch=[1])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testQueryWithExtractsTimes(DruidAdapterIT.java:4344)
[ERROR] testPushCast(org.apache.calcite.test.DruidAdapterIT) Time elapsed:
4.556 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
BindableSort(sort0=[$0], dir0=[ASC], fetch=[5])\n
BindableFilter(condition=[=($0, null)])\n DruidQuery(table=[[foodmart,
foodmart]], intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
groups=[{1}], aggs=[[]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[false], groups=[{1}], aggs=[[]], sort0=[0], dir0=[ASC], fetch=[5])\n\n"
at org.apache.calcite.test.DruidAdapterIT.testPushCast(DruidAdapterIT.java:1944)
[ERROR] testPartiallyPostAggregation(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 23.506 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0,
CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
projects=[[$63, $89, $90, $91]], groups=[{0}], aggs=[[SUM($2), SUM($3),
SUM($1)]], post_projects=[[$0, /($1, $2), CASE(=($3, 0), 1.0:DECIMAL(19, 0),
CAST($3):DECIMAL(19, 0))]], sort0=[1], dir0=[DESC])\n\n"
at
org.apache.calcite.test.DruidAdapterIT.testPartiallyPostAggregation(DruidAdapterIT.java:2203)
[ERROR]
testExpressionsFilterWithCastTimeToDateToChar(org.apache.calcite.test.DruidAdapterIT)
Time elapsed: 0.336 s <<< FAILURE!
java.lang.AssertionError:
Expected: a string containing "PLAN=EnumerableInterpreter\n
DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[=(CAST(CAST($0):DATE NOT NULL):VARCHAR CHARACTER SET \"ISO-8859-1\"
COLLATE \"ISO-8859-1$en_US$primary\" NOT NULL, '1997-01-01')], groups=[{}],
aggs=[[COUNT()]])"
but: was "PLAN=EnumerableInterpreter\n DruidQuery(table=[[foodmart, foodmart]],
intervals=[[1900-01-09T00:00:00.000Z/2992-01-10T00:00:00.000Z]],
filter=[=(CAST(CAST($0):DATE NOT NULL):VARCHAR NOT NULL,
[jira] [Commented] (CALCITE-2924) build calcite error
[ https://issues.apache.org/jira/browse/CALCITE-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16795011#comment-16795011 ] Kevin Risden commented on CALCITE-2924: --- Maven has released versions of calcite builds - https://repo1.maven.org/maven2/org/apache/calcite/. For the most part you shouldn't need to build an older release of Calcite. This seems like a question for the mailing list though instead of Jira since its not a code problem so far. > build calcite error > --- > > Key: CALCITE-2924 > URL: https://issues.apache.org/jira/browse/CALCITE-2924 > Project: Calcite > Issue Type: Bug >Reporter: hui >Priority: Major > Labels: build > Attachments: error.txt > > > I want to build calcite-1.16.0 on my computer, but failed. > java and maven > Apache Maven 3.6.0 > Maven home: /usr/local/apache-maven-3.6.0 > Java version: 1.8.0_201, vendor: Oracle Corporation, runtime: > /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.201.b09-2.el7_6.x86_64/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "3.10.0-957.1.3.el7.x86_64", arch: "amd64", > family: "unix" > > the detailed information of the error is in the file. > Thank you -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CALCITE-2922) Update link to Apache Jenkins Calcite-Avatica job
[ https://issues.apache.org/jira/browse/CALCITE-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned CALCITE-2922: - Assignee: aloyszhang > Update link to Apache Jenkins Calcite-Avatica job > - > > Key: CALCITE-2922 > URL: https://issues.apache.org/jira/browse/CALCITE-2922 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: aloyszhang >Assignee: aloyszhang >Priority: Minor > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > h2. "Continuous Integration Testing" hyperlink description in > site/develop/avatica.md has failed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CALCITE-2922) Update link to Apache Jenkins Calcite-Avatica job
[ https://issues.apache.org/jira/browse/CALCITE-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned CALCITE-2922: - Assignee: Kevin Risden (was: aloyszhang) > Update link to Apache Jenkins Calcite-Avatica job > - > > Key: CALCITE-2922 > URL: https://issues.apache.org/jira/browse/CALCITE-2922 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: aloyszhang >Assignee: Kevin Risden >Priority: Minor > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > h2. "Continuous Integration Testing" hyperlink description in > site/develop/avatica.md has failed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2922) Update link to Apache Jenkins Calcite-Avatica job
[ https://issues.apache.org/jira/browse/CALCITE-2922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16793683#comment-16793683 ] Kevin Risden commented on CALCITE-2922: --- [~aloyszhang] - Thanks for the PR. Added you as a contributor to JIRA and assigned this ticket to you. > Update link to Apache Jenkins Calcite-Avatica job > - > > Key: CALCITE-2922 > URL: https://issues.apache.org/jira/browse/CALCITE-2922 > Project: Calcite > Issue Type: Bug > Components: avatica >Reporter: aloyszhang >Assignee: aloyszhang >Priority: Minor > Labels: pull-request-available > Fix For: avatica-1.14.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > h2. "Continuous Integration Testing" hyperlink description in > site/develop/avatica.md has failed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
