[jira] [Comment Edited] (CALCITE-2754) LISTAGG support
[ https://issues.apache.org/jira/browse/CALCITE-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807421#comment-16807421 ] Chunwei Lei edited comment on CALCITE-2754 at 4/2/19 6:08 AM: -- I opened [PR#1142|https://github.com/apache/calcite/pull/1142] addressing all comments. Please feel free to close it if you still work on it. was (Author: chunwei lei): I opened [PR#1142|https://github.com/apache/calcite/pull/1142] addressing all comments. Please feel free to close it if you still work on it. > LISTAGG support > --- > > Key: CALCITE-2754 > URL: https://issues.apache.org/jira/browse/CALCITE-2754 > Project: Calcite > Issue Type: New Feature > Components: core >Affects Versions: 1.18.0 >Reporter: Sergey Nuyanzin >Assignee: Sergey Nuyanzin >Priority: Major > Labels: pull-request-available > Fix For: 1.20.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Inspired by CALCITE-2224. > There is an implementation of LISTAGG mentioned in description of CALCITE-2224 > Unfortunately there is no info about LISTAGG in public available SQL:2016 > draft at [1] while there is some description about LISTAGG as feature T625 > e.g.at [2] > [1] http://jtc1sc32.org/doc/N2551-2600/32N2572T-text_for_ballot-DIS_9075-2.pdf > [2] https://modern-sql.com/feature/listagg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (CALCITE-2754) LISTAGG support
[ https://issues.apache.org/jira/browse/CALCITE-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807421#comment-16807421 ] Chunwei Lei edited comment on CALCITE-2754 at 4/2/19 6:07 AM: -- I opened [PR#1142|https://github.com/apache/calcite/pull/1142] addressing all comments. Please feel free to close it if you still work on it. was (Author: chunwei lei): I opened [PR#1142|[https://github.com/apache/calcite/pull/1142]] addressing all comments. Please feel free to close it if you still work on it. > LISTAGG support > --- > > Key: CALCITE-2754 > URL: https://issues.apache.org/jira/browse/CALCITE-2754 > Project: Calcite > Issue Type: New Feature > Components: core >Affects Versions: 1.18.0 >Reporter: Sergey Nuyanzin >Assignee: Sergey Nuyanzin >Priority: Major > Labels: pull-request-available > Fix For: 1.20.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Inspired by CALCITE-2224. > There is an implementation of LISTAGG mentioned in description of CALCITE-2224 > Unfortunately there is no info about LISTAGG in public available SQL:2016 > draft at [1] while there is some description about LISTAGG as feature T625 > e.g.at [2] > [1] http://jtc1sc32.org/doc/N2551-2600/32N2572T-text_for_ballot-DIS_9075-2.pdf > [2] https://modern-sql.com/feature/listagg -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (CALCITE-2754) LISTAGG support
[
https://issues.apache.org/jira/browse/CALCITE-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729803#comment-16729803
]
Julian Hyde edited comment on CALCITE-2754 at 12/27/18 7:27 PM:
SQL:2016 will never be "publicly available". They always charge money for the
final spec. Nevertheless, it's safe to assume that Oracle's implementation is
close enough.
Review comments:
* In the doc, change "Return a string of concatenated values that are
delimited by a configurable separator" to "Returns values concatenated into a
string, delimited by *separator* (default ',')"
* Add a test for LISTAGG applied to non-string values. (Is this supposed to
succeed or fail?)
* Add a test for LISTAGG applied to expressions. (If the previous test fails,
people will at least need {{LISTAGG(CAST(...))}} to work.)
* I don't think that LISTAGG needs to be a keyword.
was (Author: julianhyde):
SQL:2016 will never be "publicly available". They always charge money for the
final spec. Nevertheless, it's safe to assume that Oracle's implementation is
close enough.
Review comments:
* In the doc, change "Return a string of concatenated values that are delimited
by a configurable separator" to "Returns values concatenated into a string,
delimited by *separator* (default ',')
* Add a test for LISTAGG applied to non-string values. (Is this supposed to
succeed or fail?)
* Add a test for LISTAGG applied to expressions. (If the previous test fails,
people will at least need {{LISTAGG(CAST(...))}} to work.)
* I don't think that LISTAGG needs to be a keyword.
> LISTAGG support
> ---
>
> Key: CALCITE-2754
> URL: https://issues.apache.org/jira/browse/CALCITE-2754
> Project: Calcite
> Issue Type: New Feature
> Components: core
>Affects Versions: 1.18.0
>Reporter: Sergey Nuyanzin
>Assignee: Sergey Nuyanzin
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.19.0
>
>
> Inspired by CALCITE-2224.
> There is an implementation of LISTAGG mentioned in description of CALCITE-2224
> Unfortunately there is no info about LISTAGG in public available SQL:2016
> draft at [1] while there is some description about LISTAGG as feature T625
> e.g.at [2]
> [1] http://jtc1sc32.org/doc/N2551-2600/32N2572T-text_for_ballot-DIS_9075-2.pdf
> [2] https://modern-sql.com/feature/listagg
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
