[jira] [Comment Edited] (CALCITE-2829) Use consistent types when processing ranges
[ https://issues.apache.org/jira/browse/CALCITE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858261#comment-16858261 ] Danny Chan edited comment on CALCITE-2829 at 6/7/19 2:40 AM: - Sure, the more test cases the better, i would link this issue with CALCITE-2302, thanks for your test cases. was (Author: danny0405): Sure, the more test cases the better, i would link this issue with CALCITE-2302 > Use consistent types when processing ranges > --- > > Key: CALCITE-2829 > URL: https://issues.apache.org/jira/browse/CALCITE-2829 > Project: Calcite > Issue Type: Bug >Reporter: Siddharth Teotia >Assignee: Juhwan Kim >Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Range expressions like = 'literal' AND < 'literal' trigger > ClassCastException as literal are implicitly casted differently between =/<> > operators and other comparison operators. Apply the same casting rules for > comparison to =/<> calls when processing ranges, so that all the terms have > the same type for literals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (CALCITE-2829) Use consistent types when processing ranges
[ https://issues.apache.org/jira/browse/CALCITE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848558#comment-16848558 ] Julian Hyde edited comment on CALCITE-2829 at 5/27/19 3:33 AM: --- Kind of related with CALCITE-2302, maybe we should keep the implicit type coercion rules consistent and got a centralized maintenance instead of making the rules everywhere. was (Author: danny0405): Kind of related with CALCIE-2302, maybe we should keep the implicit type coercion rules consistent and got a centralized maintenance instead of making the rules everywhere. > Use consistent types when processing ranges > --- > > Key: CALCITE-2829 > URL: https://issues.apache.org/jira/browse/CALCITE-2829 > Project: Calcite > Issue Type: Bug >Reporter: Siddharth Teotia >Assignee: Juhwan Kim >Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Range expressions like = 'literal' AND < 'literal' trigger > ClassCastException as literal are implicitly casted differently between =/<> > operators and other comparison operators. Apply the same casting rules for > comparison to =/<> calls when processing ranges, so that all the terms have > the same type for literals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (CALCITE-2829) Use consistent types when processing ranges
[ https://issues.apache.org/jira/browse/CALCITE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846090#comment-16846090 ] Juhwan Kim edited comment on CALCITE-2829 at 5/22/19 5:44 PM: -- Thanks [~julianhyde]. I accidentally closed the previous PR while resolving merge conflict. Opened a new PR ([https://github.com/apache/calcite/pull/1227)] and updated commit message. was (Author: juhwan): Thanks for the suggestion. I accidentally closed the previous PR while resolving merge conflict. Opened a new PR ([https://github.com/apache/calcite/pull/1227)] and updated commit message. > Use consistent types when processing ranges > --- > > Key: CALCITE-2829 > URL: https://issues.apache.org/jira/browse/CALCITE-2829 > Project: Calcite > Issue Type: Bug >Reporter: Siddharth Teotia >Assignee: Juhwan Kim >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Range expressions like = 'literal' AND < 'literal' trigger > ClassCastException as literal are implicitly casted differently between =/<> > operators and other comparison operators. Apply the same casting rules for > comparison to =/<> calls when processing ranges, so that all the terms have > the same type for literals. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
