[jira] [Comment Edited] (CALCITE-2999) Can't get the right column value in LogicalSort

2019-04-15 Thread yuqi (JIRA) 


[ 
https://issues.apache.org/jira/browse/CALCITE-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817844#comment-16817844
 ] 

yuqi edited comment on CALCITE-2999 at 4/15/19 10:23 AM:
-

[~zhztheplayer] amzaing, RelRoot output Type is correct and the output value of 
LogicalSort is wrong, indeed, the the value of root.rel is LogicalSort, see 
picture below.
 !picture4.png! 

I have not execute it on my data as i just want to analyze the structure of 
logicalSort and make codegen according to the result from analysis, but run 
into this problem.

On this issue, do you have any suggestions, if i want to get the output type of 
logicalsort and the corresponding mapping relation to the input? thanks a lot 


was (Author: yuqi):
[~zhztheplayer] amzaing, RelRoot output Type is correct and the output value of 
LogicalSort is wrong, indeed, the the value of root.rel is LogicalSort, see 
picture below.
 !picture4.png! 

I have not execute it on my data as i just want to analyze the structure of 
logicalSort and make codegen according to the result from analysis, but run 
into this problem.

On this issue, do you have any suggestions ? thanks a lot

> Can't get the right column value in LogicalSort
> ---
>
> Key: CALCITE-2999
> URL: https://issues.apache.org/jira/browse/CALCITE-2999
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.19.0
>Reporter: yuqi
>Assignee: Danny Chan
>Priority: Critical
> Attachments: picture2.png, picture4.png, problem.png, problem.png
>
>
> Let's consider the sql:
> {code:sql}
> // Some comments here
> select 'hello', tag from b where text = '2' or text = '1' order by cast(text 
> as int) + 1 asc , tag desc limit 1"
> {code}
> And the Plan can be seen in the picture below
> We can't get the right column value of LogicalSort if sort condition is not 
> the select column list
> Can anyone help to explain this problem if i'm wrong



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (CALCITE-2999) Can't get the right column value in LogicalSort

2019-04-15 Thread yuqi (JIRA) 


[ 
https://issues.apache.org/jira/browse/CALCITE-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817677#comment-16817677
 ] 

yuqi edited comment on CALCITE-2999 at 4/15/19 9:18 AM:


[~danny0405] I do agree with you on this point, there seems a bug on the output 
column where sorting key is not in the project list, for now, we should try to 
confirm whether this is really a bug and then try to fix it


was (Author: yuqi):
[~zhztheplayer], I do agree with you on this point, there seems a bug on the 
output column where sorting key is not in the project list, for now, we should 
try to confirm whether this is really a bug and then try to fix it

> Can't get the right column value in LogicalSort
> ---
>
> Key: CALCITE-2999
> URL: https://issues.apache.org/jira/browse/CALCITE-2999
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.19.0
>Reporter: yuqi
>Assignee: Danny Chan
>Priority: Critical
> Attachments: picture2.png, problem.png, problem.png
>
>
> Let's consider the sql:
> {code:sql}
> // Some comments here
> select 'hello', tag from b where text = '2' or text = '1' order by cast(text 
> as int) + 1 asc , tag desc limit 1"
> {code}
> And the Plan can be seen in the picture below
> We can't get the right column value of LogicalSort if sort condition is not 
> the select column list
> Can anyone help to explain this problem if i'm wrong



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)