[jira] [Commented] (CALCITE-1224) Provide non-shaded and shaded variants of Avatica artifacts
[ https://issues.apache.org/jira/browse/CALCITE-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524927#comment-15524927 ] Josh Elser commented on CALCITE-1224: - Just put together a quick PR which will provide both shaded and unshaded Avatica "client" artifacts. Outlined a few thigns that still need to be verified before the change can be merged in, but hopefully I can knock those out easy-peasy tmrw. > Provide non-shaded and shaded variants of Avatica artifacts > --- > > Key: CALCITE-1224 > URL: https://issues.apache.org/jira/browse/CALCITE-1224 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: avatica-1.9.0 > > > Kevin Risden started a discussion about problems he using Avatica in certain > environments because of the shaded classes. > https://mail-archives.apache.org/mod_mbox/calcite-dev/201605.mbox/%3CCAJU9nmgcPU9XnFh7RtR%3D4eDZ1Qg25qO0j6xudd_%3Ds89VZ3P1Ag%40mail.gmail.com%3E > After talking it out, we can to the conclusion that providing three things > for Avatica clients should be sufficient for users: > # Provide an avatica client artifact with all dependencies shaded (relocated, > when possible) > # Provide an avatica client artifact with no dependencies shaded > # Provide an example project (e.g. documentatino) users can modify to > construct their own Avatica client artifact with just the dependencies they > desire. > We can't reasonably enumerate all permutations of what might be desired by > users WRT dependency versions, but we can provide them the tools to create > the artifacts they need for their unique environment/deployment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1224) Provide non-shaded and shaded variants of Avatica artifacts
[ https://issues.apache.org/jira/browse/CALCITE-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267058#comment-15267058 ] Kevin Risden commented on CALCITE-1224: --- > That said, we could certainly change this mindset to start letting you re-use > just the Jetty Handler. I would agree that the HttpServer as the entry point is the right place. I have no absolutely need to reuse the Jetty handler itself just seemed to make sense at first. I like the idea of the standalone server honestly. It makes things a lot nicer in terms of integration related to dependencies I think. Let me put some more thought into this and get back to you. > Provide non-shaded and shaded variants of Avatica artifacts > --- > > Key: CALCITE-1224 > URL: https://issues.apache.org/jira/browse/CALCITE-1224 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > Kevin Risden started a discussion about problems he using Avatica in certain > environments because of the shaded classes. > https://mail-archives.apache.org/mod_mbox/calcite-dev/201605.mbox/%3CCAJU9nmgcPU9XnFh7RtR%3D4eDZ1Qg25qO0j6xudd_%3Ds89VZ3P1Ag%40mail.gmail.com%3E > After talking it out, we can to the conclusion that providing three things > for Avatica clients should be sufficient for users: > # Provide an avatica client artifact with all dependencies shaded (relocated, > when possible) > # Provide an avatica client artifact with no dependencies shaded > # Provide an example project (e.g. documentatino) users can modify to > construct their own Avatica client artifact with just the dependencies they > desire. > We can't reasonably enumerate all permutations of what might be desired by > users WRT dependency versions, but we can provide them the tools to create > the artifacts they need for their unique environment/deployment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1224) Provide non-shaded and shaded variants of Avatica artifacts
[ https://issues.apache.org/jira/browse/CALCITE-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267052#comment-15267052 ] Josh Elser commented on CALCITE-1224: - bq. My thinking was that I could embed the Avatica server into Solr. Solr already has Jetty so could basically make it another handler. However, I could switch the solution and instead just have Avatica server standalone and point it to Solr. This would avoid the need to change any of the Avatica dependencies. In general, we don't have a firm definition of what we expect you can use as a consumer of Avatica. That's the biggest issue we have here. I will say that changes I make to Avatica-server are centered around the HttpServer as the entry point, not the Jetty handler itself. Ideally, we wouldn't want you to have to know that Jetty is even being used under the covers. That said, we could certainly change this mindset to start letting you re-use just the Jetty Handler. I don't think there's anything wrong with embedding the server in a variety of scenarios (e.g. an app-server), we've just been pursuing the standalone server scenario. If you'd like to help us drive this, that would be awesome. > Provide non-shaded and shaded variants of Avatica artifacts > --- > > Key: CALCITE-1224 > URL: https://issues.apache.org/jira/browse/CALCITE-1224 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > Kevin Risden started a discussion about problems he using Avatica in certain > environments because of the shaded classes. > https://mail-archives.apache.org/mod_mbox/calcite-dev/201605.mbox/%3CCAJU9nmgcPU9XnFh7RtR%3D4eDZ1Qg25qO0j6xudd_%3Ds89VZ3P1Ag%40mail.gmail.com%3E > After talking it out, we can to the conclusion that providing three things > for Avatica clients should be sufficient for users: > # Provide an avatica client artifact with all dependencies shaded (relocated, > when possible) > # Provide an avatica client artifact with no dependencies shaded > # Provide an example project (e.g. documentatino) users can modify to > construct their own Avatica client artifact with just the dependencies they > desire. > We can't reasonably enumerate all permutations of what might be desired by > users WRT dependency versions, but we can provide them the tools to create > the artifacts they need for their unique environment/deployment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1224) Provide non-shaded and shaded variants of Avatica artifacts
[ https://issues.apache.org/jira/browse/CALCITE-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267042#comment-15267042 ] Kevin Risden commented on CALCITE-1224: --- [~elserj] - So I put some more thought into this and maybe I'm trying to use Avatica "wrong". My thinking was that I could embed the Avatica server into Solr. Solr already has Jetty so could basically make it another handler. However, I could switch the solution and instead just have Avatica server standalone and point it to Solr. This would avoid the need to change any of the Avatica dependencies. Is the idea that Avatica be standalone and just add to it the adapters? That would make sense why avatica and avatica-server dependencies are included and shaded. If I am understanding Avatica wrong that is OK just want to try to understand the right way. > Provide non-shaded and shaded variants of Avatica artifacts > --- > > Key: CALCITE-1224 > URL: https://issues.apache.org/jira/browse/CALCITE-1224 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > Kevin Risden started a discussion about problems he using Avatica in certain > environments because of the shaded classes. > https://mail-archives.apache.org/mod_mbox/calcite-dev/201605.mbox/%3CCAJU9nmgcPU9XnFh7RtR%3D4eDZ1Qg25qO0j6xudd_%3Ds89VZ3P1Ag%40mail.gmail.com%3E > After talking it out, we can to the conclusion that providing three things > for Avatica clients should be sufficient for users: > # Provide an avatica client artifact with all dependencies shaded (relocated, > when possible) > # Provide an avatica client artifact with no dependencies shaded > # Provide an example project (e.g. documentatino) users can modify to > construct their own Avatica client artifact with just the dependencies they > desire. > We can't reasonably enumerate all permutations of what might be desired by > users WRT dependency versions, but we can provide them the tools to create > the artifacts they need for their unique environment/deployment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
