[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808418#comment-16808418 ] Chunwei Lei commented on CALCITE-1515: -- Oops, sorry for that. > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.19.0 >Reporter: Anton Mushin >Assignee: Chunwei Lei >Priority: Minor > Labels: pull-request-available > Fix For: 1.20.0 > > Time Spent: 4h 40m > Remaining Estimate: 0h > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804513#comment-16804513 ] Chunwei Lei commented on CALCITE-1515: -- [~julianhyde] +1, thank you for your review and fix-up. > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Anton Mushin >Assignee: Chunwei Lei >Priority: Minor > Labels: pull-request-available > Time Spent: 4.5h > Remaining Estimate: 0h > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804165#comment-16804165 ] Julian Hyde commented on CALCITE-1515: -- [~Chunwei Lei], I did some fix-up (removing the redundant 'inputCount' argument to CURSOR, and allowing a table function to be called with zero inputs). Please take a look at https://github.com/julianhyde/calcite/commit/bd116f45fb9438293a55260717500391bf977197; if you +1 I will squash and commit. > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Anton Mushin >Assignee: Chunwei Lei >Priority: Minor > Labels: pull-request-available > Time Spent: 4.5h > Remaining Estimate: 0h > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803500#comment-16803500 ] Julian Hyde commented on CALCITE-1515: -- Reviewing now. > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Anton Mushin >Assignee: Chunwei Lei >Priority: Minor > Labels: pull-request-available > Time Spent: 4h 20m > Remaining Estimate: 0h > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797776#comment-16797776 ] Chunwei Lei commented on CALCITE-1515: -- [~julianhyde] Since you reviewed the PR and left some comments, would you please have a look on the updated PR? Appreciate it much. > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Anton Mushin >Priority: Minor > Labels: pull-request-available > Time Spent: 3.5h > Remaining Estimate: 0h > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[
https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789516#comment-16789516
]
Chunwei Lei commented on CALCITE-1515:
--
Hi [~julianhyde] [~anmu]
I opened a pull request: https://github.com/apache/calcite/pull/1102.
Though I think the signature is convenient, I am not sure whether it is proper
which is as follows:
{code:java}
RelBuilder functionScan(
SqlOperator operator,
Iterable operands);
RexNode cursor(int ordinal);
{code}
Any comment will be appreciated.
> Support TableFunctionScan in RelBuilder
> ---
>
> Key: CALCITE-1515
> URL: https://issues.apache.org/jira/browse/CALCITE-1515
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.10.0
>Reporter: Anton Mushin
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or
> more RelNode inputs, and 0 or more other arguments.
> RelBuilder does not support TableFunctionScan yet.
> add In RelBuilder TableFunctionScanFactory which will create
> LogicalTableFunctionScan like as for LogicalTableScan and factory for others
> RelNodes [
> [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125]
> ]
> also adding a functionScan method, analogous to the scan method but for table
> functions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786749#comment-16786749 ] Chunwei Lei commented on CALCITE-1515: -- Ok. I would like to take it. Thanks. > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Anton Mushin >Priority: Minor > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786729#comment-16786729 ] Anton Mushin commented on CALCITE-1515: --- Hi, [~Chunwei Lei] Unfortunately, I'm not able to finish it, feel free to get it. > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Anton Mushin >Priority: Minor > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786722#comment-16786722 ] Chunwei Lei commented on CALCITE-1515: -- Hi,[~anmu] It seems that there are a lot of discuss. Do you plan to finish it? If not, I would like to take it. > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Anton Mushin >Priority: Minor > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[
https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886589#comment-15886589
]
Julian Hyde commented on CALCITE-1515:
--
Sorry, I misread {{RexNode}} as {{RelNode}}.
A table function is a {{RexCall}}, so its arguments are all {{RexNode}}s, even
those that represent relational expressions. So, you convert a {{RelNode}} as a
{{RexNode}} in order to pass it into the function. The convention is to use a
{{RexInputRef}} whose ordinal is the number of {{CURSOR}} arguments to the
current function seen so far, and whose type is the row type of the relational
expression. To see how it works, put a breakpoint in
{{SqlToRelConverterTest.convertCursor}} and run
{{SqlToRelConverterTest#testCollectionTableWithCursorParam}}.
> Support TableFunctionScan in RelBuilder
> ---
>
> Key: CALCITE-1515
> URL: https://issues.apache.org/jira/browse/CALCITE-1515
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.10.0
>Reporter: Anton Mushin
>Assignee: Julian Hyde
>Priority: Minor
>
> Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or
> more RelNode inputs, and 0 or more other arguments.
> RelBuilder does not support TableFunctionScan yet.
> add In RelBuilder TableFunctionScanFactory which will create
> LogicalTableFunctionScan like as for LogicalTableScan and factory for others
> RelNodes [
> [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125]
> ]
> also adding a functionScan method, analogous to the scan method but for table
> functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885351#comment-15885351 ] Anton Mushin commented on CALCITE-1515: --- bq.Regarding 2: use ImmutableList.copyOf(inputs). but how do it cast RexNode to RelNode type of list? > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Anton Mushin >Assignee: Julian Hyde >Priority: Minor > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[
https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879107#comment-15879107
]
Julian Hyde commented on CALCITE-1515:
--
Regarding 1. Note that {{RelBuilder.scan}} calls {{RelOptTable
RelOptSchema.getTableForMember(List names)}}. We'd need something
analogous for table-functions.
Also, {{RelBuilder}} has a field {{private final RelFactories.TableScanFactory
scanFactory}} and it will need an analogous field {{private final
RelFactories.TableFunctionScanFactory tableFunctionScanFactory}}. {{interface
TableFunctionScanFactory}} does not exist yet.
> Support TableFunctionScan in RelBuilder
> ---
>
> Key: CALCITE-1515
> URL: https://issues.apache.org/jira/browse/CALCITE-1515
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.10.0
>Reporter: Anton Mushin
>Assignee: Julian Hyde
>Priority: Minor
>
> Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or
> more RelNode inputs, and 0 or more other arguments.
> RelBuilder does not support TableFunctionScan yet.
> add In RelBuilder TableFunctionScanFactory which will create
> LogicalTableFunctionScan like as for LogicalTableScan and factory for others
> RelNodes [
> [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125]
> ]
> also adding a functionScan method, analogous to the scan method but for table
> functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[
https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879056#comment-15879056
]
Julian Hyde commented on CALCITE-1515:
--
Regarding 2: use {{ImmutableList.copyOf(inputs)}}.
> Support TableFunctionScan in RelBuilder
> ---
>
> Key: CALCITE-1515
> URL: https://issues.apache.org/jira/browse/CALCITE-1515
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.10.0
>Reporter: Anton Mushin
>Assignee: Julian Hyde
>Priority: Minor
>
> Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or
> more RelNode inputs, and 0 or more other arguments.
> RelBuilder does not support TableFunctionScan yet.
> add In RelBuilder TableFunctionScanFactory which will create
> LogicalTableFunctionScan like as for LogicalTableScan and factory for others
> RelNodes [
> [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125]
> ]
> also adding a functionScan method, analogous to the scan method but for table
> functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[
https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877684#comment-15877684
]
Anton Mushin commented on CALCITE-1515:
---
Hi,[~julianhyde]
I am working on the issue.
And I have some problem.
1. If in schema has table function then the function store in
{{CalciteSchema}}, but in {{RelBuilder}} have not {{CalciteSchema}} object. Is
correct if I will create {{CalciteSchema}} object in {{RelBuilder}} like as
{code}
CalciteSchema schema =
config.getDefaultSchema() != null
? CalciteSchema.from(config.getDefaultSchema())
: null;
{code}
?
2. I need {{List inputs}} for initialize
{{LogicalTableFunctionScan}}. How could I convert {{Iterable
operands}} to {{List inputs}} in {{RelBuilder}}? Or I don't correctly
understand
> Support TableFunctionScan in RelBuilder
> ---
>
> Key: CALCITE-1515
> URL: https://issues.apache.org/jira/browse/CALCITE-1515
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.10.0
>Reporter: Anton Mushin
>Assignee: Julian Hyde
>Priority: Minor
>
> Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or
> more RelNode inputs, and 0 or more other arguments.
> RelBuilder does not support TableFunctionScan yet.
> add In RelBuilder TableFunctionScanFactory which will create
> LogicalTableFunctionScan like as for LogicalTableScan and factory for others
> RelNodes [
> [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125]
> ]
> also adding a functionScan method, analogous to the scan method but for table
> functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876390#comment-15876390 ] Julian Hyde commented on CALCITE-1515: -- [~anmu], Any progress on this? > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Anton Mushin >Assignee: Julian Hyde >Priority: Minor > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795649#comment-15795649 ] Julian Hyde commented on CALCITE-1515: -- [~anmu], You don't need a RelOptTable to create a TableFunctionScan. You need a RexCall. As long as it's a call to a table function you should be set. > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Anton Mushin >Assignee: Julian Hyde >Priority: Minor > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[
https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731830#comment-15731830
]
Anton Mushin commented on CALCITE-1515:
---
I have question about
{code}
.functionScan(Arrays.asList("mySchema"."myFunction")
{code}
Can I get RelOptTable for "myFunction" if I will call
{{relOptSchema.getTableForMember("myFunction")}} in {{RelBuilder}}?
If I can then schema name is redundant in this call, isn't it?
Correct me please if i mistake.
> Support TableFunctionScan in RelBuilder
> ---
>
> Key: CALCITE-1515
> URL: https://issues.apache.org/jira/browse/CALCITE-1515
> Project: Calcite
> Issue Type: Bug
>Affects Versions: 1.10.0
>Reporter: Anton Mushin
>Assignee: Julian Hyde
>Priority: Minor
>
> Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or
> more RelNode inputs, and 0 or more other arguments.
> RelBuilder does not support TableFunctionScan yet.
> add In RelBuilder TableFunctionScanFactory which will create
> LogicalTableFunctionScan like as for LogicalTableScan and factory for others
> RelNodes [
> [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125]
> ]
> also adding a functionScan method, analogous to the scan method but for table
> functions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731647#comment-15731647 ] Anton Mushin commented on CALCITE-1515: --- Hi [~julianhyde], Could assign issue to me please? How do sql should translate to RelBulder code? I don't understand it yet. > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Anton Mushin >Assignee: Julian Hyde >Priority: Minor > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1515) Support TableFunctionScan in RelBuilder
[ https://issues.apache.org/jira/browse/CALCITE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15714315#comment-15714315 ] Anton Mushin commented on CALCITE-1515: --- Hi [~julianhyde], Do you do this issue? Can I try resolve this? > Support TableFunctionScan in RelBuilder > --- > > Key: CALCITE-1515 > URL: https://issues.apache.org/jira/browse/CALCITE-1515 > Project: Calcite > Issue Type: Bug >Affects Versions: 1.10.0 >Reporter: Anton Mushin >Assignee: Julian Hyde >Priority: Minor > > Calcite has a TableFunctionScan, which is a RelNode, takes a function, 0 or > more RelNode inputs, and 0 or more other arguments. > RelBuilder does not support TableFunctionScan yet. > add In RelBuilder TableFunctionScanFactory which will create > LogicalTableFunctionScan like as for LogicalTableScan and factory for others > RelNodes [ > [example|https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/tools/RelBuilder.java#L125] > ] > also adding a functionScan method, analogous to the scan method but for table > functions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
