[jira] [Commented] (CALCITE-2083) Update Avatica documentation

2018-01-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CALCITE-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347739#comment-16347739
 ] 

ASF GitHub Bot commented on CALCITE-2083:
-

Github user asfgit closed the pull request at:

https://github.com/apache/calcite-avatica/pull/20


> Update Avatica documentation
> 
>
> Key: CALCITE-2083
> URL: https://issues.apache.org/jira/browse/CALCITE-2083
> Project: Calcite
>  Issue Type: Bug
>Reporter: Michael Mior
>Assignee: Michael Mior
>Priority: Major
>
> The documentation doesn't explain how Avatica is a (semi-)separate project 
> and lists the old location of the Go driver.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CALCITE-2083) Update Avatica documentation

2018-01-31 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CALCITE-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347028#comment-16347028
 ] 

ASF GitHub Bot commented on CALCITE-2083:
-

Github user joshelser commented on the issue:

https://github.com/apache/calcite-avatica/pull/20
  
+1


> Update Avatica documentation
> 
>
> Key: CALCITE-2083
> URL: https://issues.apache.org/jira/browse/CALCITE-2083
> Project: Calcite
>  Issue Type: Bug
>Reporter: Michael Mior
>Assignee: Michael Mior
>Priority: Major
>
> The documentation doesn't explain how Avatica is a (semi-)separate project 
> and lists the old location of the Go driver.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CALCITE-2083) Update Avatica documentation

2017-12-09 Thread Michael Mior (JIRA)

[ 
https://issues.apache.org/jira/browse/CALCITE-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284714#comment-16284714
 ] 

Michael Mior commented on CALCITE-2083:
---

[~francischuang] Thanks for the extra info. Since these changes are fairly 
minor anyway, I think they might as well wait until the release.

> Update Avatica documentation
> 
>
> Key: CALCITE-2083
> URL: https://issues.apache.org/jira/browse/CALCITE-2083
> Project: Calcite
>  Issue Type: Bug
>Reporter: Michael Mior
>Assignee: Michael Mior
>
> The documentation doesn't explain how Avatica is a (semi-)separate project 
> and lists the old location of the Go driver.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CALCITE-2083) Update Avatica documentation

2017-12-09 Thread Francis Chuang (JIRA)

[ 
https://issues.apache.org/jira/browse/CALCITE-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284709#comment-16284709
 ] 

Francis Chuang commented on CALCITE-2083:
-

[~julianhyde] The quality in the original repo is not higher. I am 
cherry-picking changes from the original repo into the avatica-go repo. The 
tests against Apache Phoenix passes in both repo, but as discussed in the JIRA 
for releasing avatica-go, the consensus is that the tests against Avatica 
HSQLDB should pass as the project is part of avatica. Unfortunately, due to 
some issues with Avatica HSQLDB, the tests against it do not pass.

If the PMC is happy with making a release where the tests only passing against 
Phoenix, I am happy to move forward with it. However, in that case I'd still 
like to have travis set up for the repo.

Let's continue the discussion for that in CALCITE-1938 as I don't want to 
derail this JIRA.

> Update Avatica documentation
> 
>
> Key: CALCITE-2083
> URL: https://issues.apache.org/jira/browse/CALCITE-2083
> Project: Calcite
>  Issue Type: Bug
>Reporter: Michael Mior
>Assignee: Michael Mior
>
> The documentation doesn't explain how Avatica is a (semi-)separate project 
> and lists the old location of the Go driver.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CALCITE-2083) Update Avatica documentation

2017-12-09 Thread Julian Hyde (JIRA)

[ 
https://issues.apache.org/jira/browse/CALCITE-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284685#comment-16284685
 ] 

Julian Hyde commented on CALCITE-2083:
--

A release “blesses” the source code, because the pmc members scrutinize then 
vote upon it, and then the pmc releases on behalf of the asf. Whether the code 
passes ci, or even compiles, is secondary - the release is a legal transaction.

So, let’s get a release out.

People are welcome to run from later versions, if they wish, but let’s give 
them the option of using a release with sound ip. 

[~francischuang], is the quality really higher in the original repo? Or is it 
just that we can’t prove the quality of the Apache repo because of ci issues?

> Update Avatica documentation
> 
>
> Key: CALCITE-2083
> URL: https://issues.apache.org/jira/browse/CALCITE-2083
> Project: Calcite
>  Issue Type: Bug
>Reporter: Michael Mior
>Assignee: Michael Mior
>
> The documentation doesn't explain how Avatica is a (semi-)separate project 
> and lists the old location of the Go driver.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CALCITE-2083) Update Avatica documentation

2017-12-08 Thread Francis Chuang (JIRA)

[ 
https://issues.apache.org/jira/browse/CALCITE-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284604#comment-16284604
 ] 

Francis Chuang commented on CALCITE-2083:
-

I think it would be better if we point the Go driver back to the original repo, 
because:
- There is currently no release yet.
- With the Avatica Go Driver, one would expect its integration test suite to 
pass when executed against Avatica backed using HSQLDB, but there are still 
currently a few open issues with Avatica preventing this, so the tests 
currently fail.
- There is currently no CI for avatica-go and I would not recommend using it at 
the moment.
- The tests currently pass when executed against Apache Phoenix, but since the 
driver is part of Calcite and Avatica, I'd like to make sure the tests pass 
against Avatica/HSQLDB.

> Update Avatica documentation
> 
>
> Key: CALCITE-2083
> URL: https://issues.apache.org/jira/browse/CALCITE-2083
> Project: Calcite
>  Issue Type: Bug
>Reporter: Michael Mior
>Assignee: Michael Mior
>
> The documentation doesn't explain how Avatica is a (semi-)separate project 
> and lists the old location of the Go driver.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CALCITE-2083) Update Avatica documentation

2017-12-08 Thread Michael Mior (JIRA)

[ 
https://issues.apache.org/jira/browse/CALCITE-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284555#comment-16284555
 ] 

Michael Mior commented on CALCITE-2083:
---

Why not? My understanding is that this is where active development is taking 
place even if there hasn't been a release yet. Besides, with Go it's fairly 
common to just use the latest GitHub commit to reference a dependency and a 
release isn't as necessary.

> Update Avatica documentation
> 
>
> Key: CALCITE-2083
> URL: https://issues.apache.org/jira/browse/CALCITE-2083
> Project: Calcite
>  Issue Type: Bug
>Reporter: Michael Mior
>Assignee: Michael Mior
>
> The documentation doesn't explain how Avatica is a (semi-)separate project 
> and lists the old location of the Go driver.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CALCITE-2083) Update Avatica documentation

2017-12-08 Thread Julian Hyde (JIRA)

[ 
https://issues.apache.org/jira/browse/CALCITE-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284549#comment-16284549
 ] 

Julian Hyde commented on CALCITE-2083:
--

We shouldn’t really reference Apache Avatica go until there has been a release. 

> Update Avatica documentation
> 
>
> Key: CALCITE-2083
> URL: https://issues.apache.org/jira/browse/CALCITE-2083
> Project: Calcite
>  Issue Type: Bug
>Reporter: Michael Mior
>Assignee: Michael Mior
>
> The documentation doesn't explain how Avatica is a (semi-)separate project 
> and lists the old location of the Go driver.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CALCITE-2083) Update Avatica documentation

2017-12-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CALCITE-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284547#comment-16284547
 ] 

ASF GitHub Bot commented on CALCITE-2083:
-

GitHub user michaelmior opened a pull request:

https://github.com/apache/calcite-avatica/pull/20

[CALCITE-2083] Update documentation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelmior/calcite-avatica 
2083-avatica-documentation

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/calcite-avatica/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit 798c5bce8f5a5e33ffd5f8dfe1259fba0a09bd44
Author: Michael Mior 
Date:   2017-12-09T02:38:39Z

[CALCITE-2083] Update documentation




> Update Avatica documentation
> 
>
> Key: CALCITE-2083
> URL: https://issues.apache.org/jira/browse/CALCITE-2083
> Project: Calcite
>  Issue Type: Bug
>Reporter: Michael Mior
>Assignee: Michael Mior
>
> The documentation doesn't explain how Avatica is a (semi-)separate project 
> and lists the old location of the Go driver.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CALCITE-2083) Update Avatica documentation

2017-12-08 Thread Michael Mior (JIRA)

[ 
https://issues.apache.org/jira/browse/CALCITE-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284548#comment-16284548
 ] 

Michael Mior commented on CALCITE-2083:
---

Pull request https://github.com/apache/calcite-avatica/pull/20

> Update Avatica documentation
> 
>
> Key: CALCITE-2083
> URL: https://issues.apache.org/jira/browse/CALCITE-2083
> Project: Calcite
>  Issue Type: Bug
>Reporter: Michael Mior
>Assignee: Michael Mior
>
> The documentation doesn't explain how Avatica is a (semi-)separate project 
> and lists the old location of the Go driver.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)