[jira] [Commented] (CALCITE-2161) Add "types" collection to the schema element in the JSON model

2018-02-05 Thread Julian Hyde (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353259#comment-16353259
 ] 

Julian Hyde commented on CALCITE-2161:
--

I reviewed [PR 623 commit 
4321f40|https://github.com/apache/calcite/pull/623/commits/4321f40fd8c958bbfcc852da7657ce7e5b6c46fe];
 it looks good, but you should add test(s) to ModelTest. There may be further 
changes needed for CALCITE-2045, so I propose to commit both at the same time 
(as separate commits).

> Add "types" collection to the schema element in the JSON model
> --
>
> Key: CALCITE-2161
> URL: https://issues.apache.org/jira/browse/CALCITE-2161
> Project: Calcite
>  Issue Type: Task
>  Components: core
>Affects Versions: 1.16.0
>Reporter: Shuyi Chen
>Assignee: Shuyi Chen
>Priority: Major
>
> As discussed in CALCITE-2045, we need to add "types" collection in the schema 
> element in the JSON model.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CALCITE-2161) Add "types" collection to the schema element in the JSON model

2018-02-05 Thread Shuyi Chen (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353201#comment-16353201
 ] 

Shuyi Chen commented on CALCITE-2161:
-

Hi [~julianhyde], added a PR. jdk8 test passes, but jdk9 test still fails with 
similar output. Could you please take a look at your convenience? Thanks.

> Add "types" collection to the schema element in the JSON model
> --
>
> Key: CALCITE-2161
> URL: https://issues.apache.org/jira/browse/CALCITE-2161
> Project: Calcite
>  Issue Type: Task
>  Components: core
>Affects Versions: 1.16.0
>Reporter: Shuyi Chen
>Assignee: Shuyi Chen
>Priority: Major
>
> As discussed in CALCITE-2045, we need to add "types" collection in the schema 
> element in the JSON model.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CALCITE-2161) Add "types" collection to the schema element in the JSON model

2018-01-30 Thread Julian Hyde (JIRA) 

[ 
https://issues.apache.org/jira/browse/CALCITE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346265#comment-16346265
 ] 

Julian Hyde commented on CALCITE-2161:
--

Can you change {{getType}} to return {{RelProtoDataType}}? A type belongs to a 
type-factory, and schemas live longer than type-factories, therefore they 
cannot contain types. Also, you'll need a method in {{AbstractSchema}} that is 
analogous to {{getTableMap()}}.

> Add "types" collection to the schema element in the JSON model
> --
>
> Key: CALCITE-2161
> URL: https://issues.apache.org/jira/browse/CALCITE-2161
> Project: Calcite
>  Issue Type: Task
>  Components: core
>Affects Versions: 1.16.0
>Reporter: Shuyi Chen
>Assignee: Julian Hyde
>Priority: Major
>
> As discussed in CALCITE-2045, we need to add "types" collection in the schema 
> element in the JSON model.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)