[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17249256#comment-17249256 ] Julian Hyde commented on CALCITE-2266: -- Do we support empty arrays; i.e. should the following be valid? Some work, some don't. * JSON_ARRAY() * JSON_ARRAY(ABSENT ON NULL) * JSON_ARRAY(NULL ON NULL) * JSON_OBJECT() * JSON_OBJECT(ABSENT ON NULL) > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Sub-task > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684653#comment-16684653 ] Hongze Zhang commented on CALCITE-2266: --- [~risdenk] Thank you for fixing up Travis CI, the new error seems to be caused by my code, I am sorry for that. And Thank you [~julianhyde] for taking this. I guess in my code there is some explicit importing of the *org.jetbrains* which is not good for *mvn install*. If any other help from me is needed please let me know. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684239#comment-16684239 ] Michael Mior commented on CALCITE-2266: --- Thanks for cleaning up after me. Unfortunately I don't think this is the first time. Much appreciated :) > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684220#comment-16684220 ] Julian Hyde commented on CALCITE-2266: -- I'll take this. There are some code formatting issues too. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684135#comment-16684135 ] Kevin Risden commented on CALCITE-2266: --- Looks like there might be another failure related to this about dependencies. I fixed up Travis as part of CACLITE-2655 and the next master commit was this one with the below failure. {code:java} [INFO] --- maven-dependency-plugin:3.1.1:analyze-only (analyze) @ calcite-core --- [WARNING] Used undeclared dependencies found: [WARNING] org.jetbrains:annotations:jar:13.0:test {code} [https://travis-ci.org/apache/calcite/builds/452962329] New PRs are also failing with the same error. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682699#comment-16682699 ] Michael Mior commented on CALCITE-2266: --- Thanks [~zhztheplayer]! I committed your fix. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682530#comment-16682530 ] Hongze Zhang commented on CALCITE-2266: --- [~julianhyde] Thanks for the catch Julian! I have made a quick fix at https://github.com/zhztheplayer/calcite/commit/c8145888ab91ee4c8cfabb0f8137943f5de67154, if a new JIRA issue is necessary, please let me know. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682496#comment-16682496 ] Julian Hyde commented on CALCITE-2266: -- There are a few deprecation warnings, like this: {noformat}[WARNING] /home/jhyde/regress/calcite/core/src/main/java/org/apache/calcite/sql/fun/SqlJsonArrayAggAggFunction.java:[38,5] SqlAggFunction(java.lang.String,org.apache.calcite.sql.SqlIdentifier,org.apache.calcite.sql.SqlKind,org.apache.calcite.sql.type.SqlReturnTypeInference,org.apache.calcite.sql.type.SqlOperandTypeInference,org.apache.calcite.sql.type.SqlOperandTypeChecker,org.apache.calcite.sql.SqlFunctionCategory,boolean,boolean) in org.apache.calcite.sql.SqlAggFunction has been deprecated{noformat}. Probably due to the merge with CALCITE-2224. Can someone fix please? > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681684#comment-16681684 ] Michael Mior commented on CALCITE-2266: --- Fixed in [8e557d26c|[https://github.com/apache/calcite/commit/8e557d26cffceaf7d7f98d8f8bafd9fbe3bc2447].] Thanks [~zhztheplayer]! > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678470#comment-16678470 ] Kevin Risden commented on CALCITE-2266: --- I am looking into the Travis issues as part of CALCITE-2655. A lot of the recent failures are due to a Debian openjdk bug. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911925 > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677545#comment-16677545 ] Hongze Zhang commented on CALCITE-2266: --- Hi [~julianhyde], {quote}Do you still need to up the stack size, following my changes in CALCITE-2405? I found that breaking up NonReservedKeyWord() into smaller methods - none of which breaks the de facto maximum nesting depth of ~300 - solved the problem. {quote} Thank you for mentioning this, I have revert the stack size changes, yet I did not make a test about if the StackOverflowError still exists after CALCITE-2405 solved (Calcite's Travis seems to be unavailable now), but I believe it was fixed. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677064#comment-16677064 ] Julian Hyde commented on CALCITE-2266: -- Do you still need to up the stack size, following my changes in CALCITE-2405? I found that breaking up {{NonReservedKeyWord()}} into smaller methods - none of which breaks the de facto maximum nesting depth of ~300 - solved the problem. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676389#comment-16676389 ] Hongze Zhang commented on CALCITE-2266: --- Hi [~vlsi], PR has been updated based on your suggestion, please check [https://github.com/apache/calcite/pull/785/commits/2c3376dfd21a77664cafa427427896634ceef464] at your convenience. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675271#comment-16675271 ] Vladimir Sitnikov commented on CALCITE-2266: The feature looks great, and it definitely took tremendous resources to build, however I wonder if tests could print human-readable (and undstandable) messages in case of failures. For instance, I've taken a sample from {code:java} @Test public void testJsonApiCommonSyntax() { assertJsonApiCommonSyntaxPathReturned( SqlFunctions. jsonApiCommonSyntax(ImmutableMap.of("foo", "bar"), "strict $.foor"), // <-- Note "r" here is("bar")); } {code} The exception is as follows: {noformat} Expected: a instance of PathContext, and the property [pathReturned] is "bar" but: was Expected :a instance of PathContext, and the property [pathReturned] is "bar" Actual : at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:956) at org.junit.Assert.assertThat(Assert.java:923) at org.apache.calcite.test.SqlFunctionsTest.assertObjectProperty(SqlFunctionsTest.java:848) at org.apache.calcite.test.SqlFunctionsTest.assertJsonApiCommonSyntaxPathReturned(SqlFunctionsTest.java:871) at org.apache.calcite.test.SqlFunctionsTest.testJsonApiCommonSyntax(SqlFunctionsTest.java:900) {noformat} Frankly speaking, the exception is very moot. Here's how the same test could be corrected to produce much cleaner exceptions: {code:java} @Test public void testJsonApiCommonSyntax() { assertJsonApiCommonSyntaxPathReturned2( ImmutableMap.of("foo", "bar"), "strict $.foor", is("bar")); } private void assertJsonApiCommonSyntaxPathReturned2(Map context, String jsonPath, Matcher matcher) { SqlFunctions.PathContext pathContext = SqlFunctions.jsonApiCommonSyntax(context, jsonPath); assertThat("jsonApiCommonSyntax(" + context + ", " + jsonPath + ")", pathContext.pathReturned, matcher); } {code} Now it produces {noformat} java.lang.AssertionError: jsonApiCommonSyntax({foo=bar}, strict $.foor) Expected: is "bar" but: was null Expected :is "bar" Actual :null at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:956) at org.apache.calcite.test.SqlFunctionsTest.assertJsonApiCommonSyntaxPathReturned2(SqlFunctionsTest.java:876) at org.apache.calcite.test.SqlFunctionsTest.testJsonApiCommonSyntax(SqlFunctionsTest.java:906) {noformat} [~zhztheplayer], would you please update test code accordingly? PS. I think it is worth putting the newly added tests to its own file instead of abusing the existing {{SqlFunctionsTest}} > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675203#comment-16675203 ] Michael Mior commented on CALCITE-2266: --- I'm happy as-is. I'll let [~vlsi] respond before merging. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16674553#comment-16674553 ] Julian Hyde commented on CALCITE-2266: -- It seems that [~vlsi] and [~michaelmior] have reviewed, and [~zhztheplayer] has revised. Is this good to go? We should get this into 1.18 if it's good enough (even if not perfect), since this is a significant and useful contribution. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > Fix For: 1.18.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672821#comment-16672821 ] Hongze Zhang commented on CALCITE-2266: --- Hi [~michaelmior], [~julianhyde], [~vlsi], Thank you very much for your review. Recently I have made some more changes to the PR, including solution of StackOverFlowError during Travis CI, more test cases, and solving the confilicts with the latest code master. Could anyone please help continue the reviewing of the PR? And If there is any plan about merging the PR, or anything I can help to push this forward, please be free to let me know. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575697#comment-16575697 ] Hongze Zhang commented on CALCITE-2266: --- [~michaelmior] Thanks, I have submitted a PR at [https://github.com/apache/calcite/pull/785]. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574941#comment-16574941 ] Michael Mior commented on CALCITE-2266: --- If you could put together a pull request on GitHub whenever you're ready, that would be great! > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574722#comment-16574722 ] Hongze Zhang commented on CALCITE-2266: --- The basic implementation code of this is ready now. JSON functions part of SQL:2016 can be found at [http://standards.iso.org/ittf/PubliclyAvailableStandards/c065143_ISO_IEC_TR_19075-5_2016.zip|http://standards.iso.org/ittf/PubliclyAvailableStandards/c065143_ISO_IEC_TR_19075-5_2016.zip] h4. Implemented Function List JSON_EXISTS JSON_VALUE JSON_QUERY JSON_OBJECT JSON_OBJECTAGG JSON_ARRAY JSON_ARRAYAGG IS JSON predicate h4. New Reserved Keyword List JSON_EXISTS JSON_VALUE JSON_QUERY JSON_OBJECT JSON_OBJECTAGG JSON_ARRAY JSON_ARRAYAGG h4. Not Implemented Yet (might implemet in future versions) 1. JSON_TABLE function 2. Encoding of JSON representation (ISO_IEC_TR_19075-5_2016 - 5.2.1: JSON value expression) 3. (ISO_IEC_TR_19075-5_2016 - 5.2.4: JSON output clause) 4. in JSON_QUERY function (ISO_IEC_TR_19075-5_2016 - 5.3.3: JSON_QUERY) 5. in JSON_OBJECT / JSON_OBJECTAGG / IS JSON predicate (ISO_IEC_TR_19075-5_2016 - 5.4.1: JSON_OBJECT / 5.4.2: JSON_OBJECTAGG / 5.4.5: IS JSON predicate) 6. in JSON_ARRAY function (ISO_IEC_TR_19075-5_2016 - 5.4.3: JSON_ARRAY) 7. in JSON_ARRAYAGG function (ISO_IEC_TR_19075-5_2016 - 5.4.4: JSON_ARRAYAGG) > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565255#comment-16565255 ] Michael Mior commented on CALCITE-2266: --- [~zhztheplayer] I'm not currently working this, so that would be great if you're willing to take it on! > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565239#comment-16565239 ] Hongze Zhang commented on CALCITE-2266: --- Hi [~michaelmior], [~suez1224], I have experience in some Calcite-based tools such as Drill and Druid, and I am currently interested in Json processing abilities of Calcite. If no other people is working on this, I would like to implement this following the ISO/IEC 9075:2016 standard_._ > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495119#comment-16495119 ] Michael Mior commented on CALCITE-2266: --- AFAIK, this is not currently being worked on. I've unassigned to myself to make that clear. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Assignee: Michael Mior >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2266) Implement SQL 2016 JSON functions
[ https://issues.apache.org/jira/browse/CALCITE-2266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494764#comment-16494764 ] Shuyi Chen commented on CALCITE-2266: - Hi [~michaelmior], when do you think this will be ready? The Flink community is also interested in integrating the SQL 2016 JSON functions. > Implement SQL 2016 JSON functions > - > > Key: CALCITE-2266 > URL: https://issues.apache.org/jira/browse/CALCITE-2266 > Project: Calcite > Issue Type: Improvement > Components: core >Reporter: Michael Mior >Assignee: Michael Mior >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)