[jira] [Commented] (CALCITE-2353) Allow user to override SqlSetOption in alterStatementParserMethods
[ https://issues.apache.org/jira/browse/CALCITE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505563#comment-16505563 ] Shuyi Chen commented on CALCITE-2353: - Fixed in [aaf4471|https://github.com/apache/calcite/commit/aaf44711ae2b01ab97be93dafd86dd97b75e5101]. > Allow user to override SqlSetOption in alterStatementParserMethods > -- > > Key: CALCITE-2353 > URL: https://issues.apache.org/jira/browse/CALCITE-2353 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: Andrew Pilloud >Assignee: Shuyi Chen >Priority: Major > Fix For: 1.17.0 > > > If alterStatementParserMethods are added before SqlSetOption then the user > can replace SqlSetOption. This change matches how statementParserMethods are > added at the top level. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2353) Allow user to override SqlSetOption in alterStatementParserMethods
[ https://issues.apache.org/jira/browse/CALCITE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505558#comment-16505558 ] Julian Hyde commented on CALCITE-2353: -- [~suez1224], Looks good. Thanks for taking this on. > Allow user to override SqlSetOption in alterStatementParserMethods > -- > > Key: CALCITE-2353 > URL: https://issues.apache.org/jira/browse/CALCITE-2353 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: Andrew Pilloud >Assignee: Shuyi Chen >Priority: Major > Fix For: 1.17.0 > > > If alterStatementParserMethods are added before SqlSetOption then the user > can replace SqlSetOption. This change matches how statementParserMethods are > added at the top level. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2353) Allow user to override SqlSetOption in alterStatementParserMethods
[ https://issues.apache.org/jira/browse/CALCITE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504306#comment-16504306 ] Shuyi Chen commented on CALCITE-2353: - Hi [~julianhyde], assigning this ticket to me for review. Let me know if you have any comment otherwise. > Allow user to override SqlSetOption in alterStatementParserMethods > -- > > Key: CALCITE-2353 > URL: https://issues.apache.org/jira/browse/CALCITE-2353 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: Andrew Pilloud >Assignee: Shuyi Chen >Priority: Major > > If alterStatementParserMethods are added before SqlSetOption then the user > can replace SqlSetOption. This change matches how statementParserMethods are > added at the top level. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2353) Allow user to override SqlSetOption in alterStatementParserMethods
[ https://issues.apache.org/jira/browse/CALCITE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502770#comment-16502770 ] Andrew Pilloud commented on CALCITE-2353: - That is what I intended. I opened a PR that does this; https://github.com/apache/calcite/pull/722 > Allow user to override SqlSetOption in alterStatementParserMethods > -- > > Key: CALCITE-2353 > URL: https://issues.apache.org/jira/browse/CALCITE-2353 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: Andrew Pilloud >Assignee: Julian Hyde >Priority: Major > > If alterStatementParserMethods are added before SqlSetOption then the user > can replace SqlSetOption. This change matches how statementParserMethods are > added at the top level. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CALCITE-2353) Allow user to override SqlSetOption in alterStatementParserMethods
[ https://issues.apache.org/jira/browse/CALCITE-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502690#comment-16502690 ] Shuyi Chen commented on CALCITE-2353: - By swapping the order, the parser will match the user DDL rule first, so you can implement your own SET operation, is that what you intend to do? I am not an expert in the parser logic, but it sounds fine to me. > Allow user to override SqlSetOption in alterStatementParserMethods > -- > > Key: CALCITE-2353 > URL: https://issues.apache.org/jira/browse/CALCITE-2353 > Project: Calcite > Issue Type: Bug > Components: core >Reporter: Andrew Pilloud >Assignee: Julian Hyde >Priority: Major > > If alterStatementParserMethods are added before SqlSetOption then the user > can replace SqlSetOption. This change matches how statementParserMethods are > added at the top level. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
