[jira] [Commented] (CALCITE-3599) Initial the digest of RexRangeRef to avoid null string

2019-12-13 Thread Chunwei Lei (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995570#comment-16995570
 ] 

Chunwei Lei commented on CALCITE-3599:
--

Good idea. PR was updated.

> Initial the digest of RexRangeRef to avoid null string
> --
>
> Key: CALCITE-3599
> URL: https://issues.apache.org/jira/browse/CALCITE-3599
> Project: Calcite
>  Issue Type: Improvement
>  Components: core
>Reporter: Chunwei Lei
>Assignee: Chunwei Lei
>Priority: Minor
>  Labels: pull-request-available
> Attachments: image-2019-12-12-23-49-18-977.png
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, the digest of {{RexRangeRef}} is always {{null}} which is 
> confusing when we try to debug the code. I suggest changing it to a more 
> meaningful string such as {{offset(0)}}.
> !image-2019-12-12-23-49-18-977.png|width=529,height=234!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CALCITE-3599) Initial the digest of RexRangeRef to avoid null string

2019-12-12 Thread Julian Hyde (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994956#comment-16994956
 ] 

Julian Hyde commented on CALCITE-3599:
--

RexRangeRef is ephemeral. Digest exists so that you can compare two nodes, and 
we never need to do that. Instead of setting digest, how about overriding 
{{toString()}}? Then the cost only gets paid if you print the string in the 
debugger.

> Initial the digest of RexRangeRef to avoid null string
> --
>
> Key: CALCITE-3599
> URL: https://issues.apache.org/jira/browse/CALCITE-3599
> Project: Calcite
>  Issue Type: Improvement
>  Components: core
>Reporter: Chunwei Lei
>Assignee: Chunwei Lei
>Priority: Minor
>  Labels: pull-request-available
> Attachments: image-2019-12-12-23-49-18-977.png
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, the digest of {{RexRangeRef}} is always {{null}} which is 
> confusing when we try to debug the code. I suggest changing it to a more 
> meaningful string such as {{offset(0)}}.
> !image-2019-12-12-23-49-18-977.png|width=529,height=234!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CALCITE-3599) Initial the digest of RexRangeRef to avoid null string

2019-12-12 Thread Rui Wang (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994940#comment-16994940
 ] 

Rui Wang commented on CALCITE-3599:
---

+1 on this JIRA!

> Initial the digest of RexRangeRef to avoid null string
> --
>
> Key: CALCITE-3599
> URL: https://issues.apache.org/jira/browse/CALCITE-3599
> Project: Calcite
>  Issue Type: Improvement
>  Components: core
>Reporter: Chunwei Lei
>Assignee: Chunwei Lei
>Priority: Minor
>  Labels: pull-request-available
> Attachments: image-2019-12-12-23-49-18-977.png
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, the digest of {{RexRangeRef}} is always {{null}} which is 
> confusing when we try to debug the code. I suggest changing it to a more 
> meaningful string such as {{offset(0)}}.
> !image-2019-12-12-23-49-18-977.png|width=529,height=234!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)