[jira] [Commented] (CALCITE-3725) RelMetadataTest fails with NPE due to unsafe RelMetadataQuery.instance call

2020-01-12 Thread Jin Xing (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014034#comment-17014034
 ] 

Jin Xing commented on CALCITE-3725:
---

Hi, [~vladimirsitnikov] 
I proposed a fix for this issue, please take a look when you have time ~

> RelMetadataTest fails with NPE due to unsafe RelMetadataQuery.instance call
> ---
>
> Key: CALCITE-3725
> URL: https://issues.apache.org/jira/browse/CALCITE-3725
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.21.0
>Reporter: Vladimir Sitnikov
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.calcite.test.RelMetadataTest > 
> testColumnUniquenessForMinusWithConstantColumns() FAILED
> java.lang.NullPointerException
> at java.util.Objects.requireNonNull(Objects.java:203)
> at 
> org.apache.calcite.rel.metadata.RelMetadataQuery.(RelMetadataQuery.java:141)
> at 
> org.apache.calcite.rel.metadata.RelMetadataQuery.(RelMetadataQuery.java:106)
> at 
> org.apache.calcite.rel.metadata.RelMetadataQuery.instance(RelMetadataQuery.java:174)
> at 
> org.apache.calcite.test.RelMetadataTest.testColumnUniquenessForMinusWithConstantColumns(RelMetadataTest.java:1057)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CALCITE-3725) RelMetadataTest fails with NPE due to unsafe RelMetadataQuery.instance call

2020-01-11 Thread Vladimir Sitnikov (Jira) 


[ 
https://issues.apache.org/jira/browse/CALCITE-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013487#comment-17013487
 ] 

Vladimir Sitnikov commented on CALCITE-3725:


[~jinxing6...@126.com], would you please revise the metadata tests added in 
CALCITE-3428 so they do not use RelMetadataQuery.instance before it is actually 
initialized?

> RelMetadataTest fails with NPE due to unsafe RelMetadataQuery.instance call
> ---
>
> Key: CALCITE-3725
> URL: https://issues.apache.org/jira/browse/CALCITE-3725
> Project: Calcite
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.21.0
>Reporter: Vladimir Sitnikov
>Priority: Major
>
> {noformat}
> org.apache.calcite.test.RelMetadataTest > 
> testColumnUniquenessForMinusWithConstantColumns() FAILED
> java.lang.NullPointerException
> at java.util.Objects.requireNonNull(Objects.java:203)
> at 
> org.apache.calcite.rel.metadata.RelMetadataQuery.(RelMetadataQuery.java:141)
> at 
> org.apache.calcite.rel.metadata.RelMetadataQuery.(RelMetadataQuery.java:106)
> at 
> org.apache.calcite.rel.metadata.RelMetadataQuery.instance(RelMetadataQuery.java:174)
> at 
> org.apache.calcite.test.RelMetadataTest.testColumnUniquenessForMinusWithConstantColumns(RelMetadataTest.java:1057)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)