[jira] [Commented] (CALCITE-6213) The default behavior of NullCollation in Presto is LAST

2024-01-24 Thread hongyu guo (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810301#comment-17810301
 ] 

hongyu guo commented on CALCITE-6213:
-

Fixed in 
[aca7f02d|https://github.com/apache/calcite/commit/aca7f02dfd510297bd56b07ab94d41033a5146b4].
 
[~eveywu] Very nice work, thanks for your contribution!

> The default behavior of NullCollation in Presto is LAST
> ---
>
> Key: CALCITE-6213
> URL: https://issues.apache.org/jira/browse/CALCITE-6213
> Project: Calcite
>  Issue Type: Bug
>Reporter:  EveyWu
>Priority: Major
>  Labels: pull-request-available
> Attachments: image-2024-01-19-23-54-26-383.png, 
> image-2024-01-19-23-57-00-252.png
>
>
> [https://prestodb.io/docs/0.285/sql/select.html]
> Presto default null ordering is NULLS LAST
> !image-2024-01-19-23-54-26-383.png|width=511,height=168!
>  
> Demo:select by presto with nulls last 
> {code:java}
> select * from product order by brand_name; {code}
> !image-2024-01-19-23-57-00-252.png|width=517,height=83!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6213) The default behavior of NullCollation in Presto is LAST

2024-01-19 Thread EveyWu (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808736#comment-17808736
 ] 

EveyWu commented on CALCITE-6213:
-

[~tanclary] 
I have submitted the pull request,thank you for helping me review the code

> The default behavior of NullCollation in Presto is LAST
> ---
>
> Key: CALCITE-6213
> URL: https://issues.apache.org/jira/browse/CALCITE-6213
> Project: Calcite
>  Issue Type: Bug
>Reporter: EveyWu
>Priority: Major
>  Labels: pull-request-available
> Attachments: image-2024-01-19-23-54-26-383.png, 
> image-2024-01-19-23-57-00-252.png
>
>
> [https://prestodb.io/docs/0.285/sql/select.html]
> Presto default null ordering is NULLS LAST
> !image-2024-01-19-23-54-26-383.png|width=511,height=168!
>  
> Demo:select by presto with nulls last 
> {code:java}
> select * from product order by brand_name; {code}
> !image-2024-01-19-23-57-00-252.png|width=517,height=83!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (CALCITE-6213) The default behavior of NullCollation in Presto is LAST

2024-01-19 Thread Tanner Clary (Jira)


[ 
https://issues.apache.org/jira/browse/CALCITE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808716#comment-17808716
 ] 

Tanner Clary commented on CALCITE-6213:
---

Hi [~eveywu] the fix for this is probably ~1 line change and a test or two. Let 
me know if you need help with review and thanks for filing this issue.

> The default behavior of NullCollation in Presto is LAST
> ---
>
> Key: CALCITE-6213
> URL: https://issues.apache.org/jira/browse/CALCITE-6213
> Project: Calcite
>  Issue Type: Bug
>Reporter: EveyWu
>Priority: Major
> Attachments: image-2024-01-19-23-54-26-383.png, 
> image-2024-01-19-23-57-00-252.png
>
>
> [https://prestodb.io/docs/0.285/sql/select.html]
> Presto default null ordering is NULLS LAST
> !image-2024-01-19-23-54-26-383.png|width=511,height=168!
>  
> Demo:select by presto with nulls last 
> {code:java}
> select * from product order by brand_name; {code}
> !image-2024-01-19-23-57-00-252.png|width=517,height=83!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)