[ https://issues.apache.org/jira/browse/CALCITE-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821573#comment-17821573 ]
Stamatis Zampetakis commented on CALCITE-6271: ---------------------------------------------- [~eveywu] is right. This is a method that may be used by other projects. For instance, there are usages of this method in Hive (see [JDBCRexCallValidator.java|https://github.com/apache/hive/blob/8dc9cba8889206a1241d9cf037f65876df658c62/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/JDBCRexCallValidator.java#L63]). For the Hive use-case above it is true that it doesn't bring much value as it is right now but there may be projects who define new dialects and use this method in a more meaningful way. For Calcite, I think it would make sense to call the supportsFunction method in rules such as {{JdbcFilterRule}} etc. > The supportsFunction method of the SqlDialect class is never called in calcite > ------------------------------------------------------------------------------ > > Key: CALCITE-6271 > URL: https://issues.apache.org/jira/browse/CALCITE-6271 > Project: Calcite > Issue Type: Bug > Components: core > Reporter: Bertil Chapuis > Priority: Minor > > Several sql dialects implement the supportsFunction method. However, after > searching Calcite's code base, it looks like this function is never called. > I'm not sure if it was used in the past. We could either search the history > or clean this code. > This seems to affects the ablity to push functions down such as in > CALCITE-6239. -- This message was sent by Atlassian Jira (v8.20.10#820010)