[jira] [Commented] (CALCITE-836) Provide a way for the Avatica client to query the server versions
[ https://issues.apache.org/jira/browse/CALCITE-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217336#comment-15217336 ] Josh Elser commented on CALCITE-836: I missed a javadoc update (failed on the jdk8 linter). Fixed in https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=commit;h=3e25f2ffa0eab11051f6295fd3706d2397f2524c > Provide a way for the Avatica client to query the server versions > - > > Key: CALCITE-836 > URL: https://issues.apache.org/jira/browse/CALCITE-836 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Holman Lan >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > Currently there doesn't seem to be a way for Avatica clients to find out the > Avatica RPC protocol version and versions of other server components. > The use case here is to allow the Apache Phoenix clients to request the > Avatica version, Phoenix version and HBase version from the Phoenix Query > Server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-836) Provide a way for the Avatica client to query the server versions
[ https://issues.apache.org/jira/browse/CALCITE-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214978#comment-15214978 ] Josh Elser commented on CALCITE-836: Oh, nevermind. I'm a dummy. I didn't realize DatabaseMetaData extended Wrapper. > Provide a way for the Avatica client to query the server versions > - > > Key: CALCITE-836 > URL: https://issues.apache.org/jira/browse/CALCITE-836 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Holman Lan >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > Currently there doesn't seem to be a way for Avatica clients to find out the > Avatica RPC protocol version and versions of other server components. > The use case here is to allow the Apache Phoenix clients to request the > Avatica version, Phoenix version and HBase version from the Phoenix Query > Server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-836) Provide a way for the Avatica client to query the server versions
[
https://issues.apache.org/jira/browse/CALCITE-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214973#comment-15214973
]
Julian Hyde commented on CALCITE-836:
-
{{AvaticaDatabaseMetaData}} always implemented {{java.sql.Wrapper}}. The
"implement Wrapper" comment could have been "Wrapper methods" just like the
"Helper methods" and "JDBC methods" elsewhere in that class.
> Provide a way for the Avatica client to query the server versions
> -
>
> Key: CALCITE-836
> URL: https://issues.apache.org/jira/browse/CALCITE-836
> Project: Calcite
> Issue Type: New Feature
> Components: avatica
>Reporter: Holman Lan
>Assignee: Josh Elser
> Fix For: avatica-1.8.0
>
>
> Currently there doesn't seem to be a way for Avatica clients to find out the
> Avatica RPC protocol version and versions of other server components.
> The use case here is to allow the Apache Phoenix clients to request the
> Avatica version, Phoenix version and HBase version from the Phoenix Query
> Server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-836) Provide a way for the Avatica client to query the server versions
[ https://issues.apache.org/jira/browse/CALCITE-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212296#comment-15212296 ] Josh Elser commented on CALCITE-836: [~julianhyde], lmk what you think about https://github.com/apache/calcite/pull/216 > Provide a way for the Avatica client to query the server versions > - > > Key: CALCITE-836 > URL: https://issues.apache.org/jira/browse/CALCITE-836 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Holman Lan >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > Currently there doesn't seem to be a way for Avatica clients to find out the > Avatica RPC protocol version and versions of other server components. > The use case here is to allow the Apache Phoenix clients to request the > Avatica version, Phoenix version and HBase version from the Phoenix Query > Server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-836) Provide a way for the Avatica client to query the server versions
[
https://issues.apache.org/jira/browse/CALCITE-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204996#comment-15204996
]
Julian Hyde commented on CALCITE-836:
-
It's (to coin a phrase) a "specification dependency", which is one of the best
kinds of dependency because it doesn't cause link errors. :)
For instance, you could change MySQL's JDBC server (which does not use Avatica)
to emit a "server.version" property if someone were to call
{{unwrap(Map.class).get("server.version")}} on its driver. It would not need to
include any Avatica code. It would just require one of the MySQL developers to
have read the Avatica specification and thought "hey, that's a good idea".
> Provide a way for the Avatica client to query the server versions
> -
>
> Key: CALCITE-836
> URL: https://issues.apache.org/jira/browse/CALCITE-836
> Project: Calcite
> Issue Type: New Feature
> Components: avatica
>Reporter: Holman Lan
>Assignee: Josh Elser
> Fix For: avatica-1.8.0
>
>
> Currently there doesn't seem to be a way for Avatica clients to find out the
> Avatica RPC protocol version and versions of other server components.
> The use case here is to allow the Apache Phoenix clients to request the
> Avatica version, Phoenix version and HBase version from the Phoenix Query
> Server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-836) Provide a way for the Avatica client to query the server versions
[
https://issues.apache.org/jira/browse/CALCITE-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204287#comment-15204287
]
Josh Elser commented on CALCITE-836:
bq. The whole point of JDBC is to stop your application from becoming dependent
on the plumbing. And yes, Avatica is just plumbing.
Well, my gut reaction was that {{"server.version"}} is still a dependency on
Avatica itself (is that a well-defined constant somewhere?). It's a magic
string, but at least it isn't a compile time dependency to Avatica.
> Provide a way for the Avatica client to query the server versions
> -
>
> Key: CALCITE-836
> URL: https://issues.apache.org/jira/browse/CALCITE-836
> Project: Calcite
> Issue Type: New Feature
> Components: avatica
>Reporter: Holman Lan
>Assignee: Josh Elser
> Fix For: avatica-1.8.0
>
>
> Currently there doesn't seem to be a way for Avatica clients to find out the
> Avatica RPC protocol version and versions of other server components.
> The use case here is to allow the Apache Phoenix clients to request the
> Avatica version, Phoenix version and HBase version from the Phoenix Query
> Server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-836) Provide a way for the Avatica client to query the server versions
[
https://issues.apache.org/jira/browse/CALCITE-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200717#comment-15200717
]
Julian Hyde commented on CALCITE-836:
-
We could expose the extra properties as a (name, value) map, and define some
properties that we suggest every Avatica provider implements. It's a shame that
the DatabaseMetaData API doesn't allow any extension properties. Rather than
adding an API to DatabaseMetaData, maybe we can make clever use of the
{{unwrap}} method, like this:
{code}
Connection connection;
DatabaseMetaData metaData = connection.getMetaData();
Properties properties = metaData.unwrap(Properties.class);
String serverVersion = properties == null ? null :
properties.getProperty("server.version");
{code}
> Provide a way for the Avatica client to query the server versions
> -
>
> Key: CALCITE-836
> URL: https://issues.apache.org/jira/browse/CALCITE-836
> Project: Calcite
> Issue Type: New Feature
> Components: avatica
>Reporter: Holman Lan
>Assignee: Josh Elser
> Fix For: avatica-1.8.0
>
>
> Currently there doesn't seem to be a way for Avatica clients to find out the
> Avatica RPC protocol version and versions of other server components.
> The use case here is to allow the Apache Phoenix clients to request the
> Avatica version, Phoenix version and HBase version from the Phoenix Query
> Server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-836) Provide a way for the Avatica client to query the server versions
[ https://issues.apache.org/jira/browse/CALCITE-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191438#comment-15191438 ] Josh Elser commented on CALCITE-836: Had a chat with Holman today, who also suggested that there would be some worth in exposing the wrapped JDBC driver's version as a property too. I'm thinking that I might be able to expose the major/minor version from the Driver itself fairly easily (avoiding any Driver-implementation details) > Provide a way for the Avatica client to query the server versions > - > > Key: CALCITE-836 > URL: https://issues.apache.org/jira/browse/CALCITE-836 > Project: Calcite > Issue Type: New Feature > Components: avatica >Reporter: Holman Lan >Assignee: Josh Elser > Fix For: avatica-1.8.0 > > > Currently there doesn't seem to be a way for Avatica clients to find out the > Avatica RPC protocol version and versions of other server components. > The use case here is to allow the Apache Phoenix clients to request the > Avatica version, Phoenix version and HBase version from the Phoenix Query > Server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-836) Provide a way for the Avatica client to query the server versions
[
https://issues.apache.org/jira/browse/CALCITE-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189902#comment-15189902
]
Josh Elser commented on CALCITE-836:
Started looking into re-using DatabaseProperty for this. One downside is that
it was written to expect any property be defined in
{{java.sql.DatabaseMetaData}}. Just a little bit of hacking to make it also
return Avatica-specific properties.
> Provide a way for the Avatica client to query the server versions
> -
>
> Key: CALCITE-836
> URL: https://issues.apache.org/jira/browse/CALCITE-836
> Project: Calcite
> Issue Type: New Feature
> Components: avatica
>Reporter: Holman Lan
>Assignee: Josh Elser
> Fix For: 1.8.0
>
>
> Currently there doesn't seem to be a way for Avatica clients to find out the
> Avatica RPC protocol version and versions of other server components.
> The use case here is to allow the Apache Phoenix clients to request the
> Avatica version, Phoenix version and HBase version from the Phoenix Query
> Server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
