[jira] [Commented] (CALCITE-994) Calcite development under Eclipse IDE
[ https://issues.apache.org/jira/browse/CALCITE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15773115#comment-15773115 ] Julian Stenzel commented on CALCITE-994: [~julianhyde] I am referring to the checkstyle and maven plugin issues in eclipse. Didnt know if the "lifecycle-mapping-metadata.xml" is the "official" solution for that issue. > Calcite development under Eclipse IDE > - > > Key: CALCITE-994 > URL: https://issues.apache.org/jira/browse/CALCITE-994 > Project: Calcite > Issue Type: Improvement > Components: site >Reporter: Alexander Reshetov >Assignee: Julian Hyde >Priority: Minor > Attachments: lifecycle-mapping-metadata.xml > > > After "git clone" project could not be imported in Eclipse as existing Maven > project. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-994) Calcite development under Eclipse IDE
[ https://issues.apache.org/jira/browse/CALCITE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770647#comment-15770647 ] Julian Hyde commented on CALCITE-994: - [~JulianS91] I suspect the issues you are running into are caused by the fact that you are using JDK 1.9. In which case, make your comments on CALCITE-1258. > Calcite development under Eclipse IDE > - > > Key: CALCITE-994 > URL: https://issues.apache.org/jira/browse/CALCITE-994 > Project: Calcite > Issue Type: Improvement > Components: site >Reporter: Alexander Reshetov >Assignee: Julian Hyde >Priority: Minor > Attachments: lifecycle-mapping-metadata.xml > > > After "git clone" project could not be imported in Eclipse as existing Maven > project. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-994) Calcite development under Eclipse IDE
[ https://issues.apache.org/jira/browse/CALCITE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15769879#comment-15769879 ] Julian Stenzel commented on CALCITE-994: Any updates on that ? Still got all of that errors in eclipse mars and neon. > Calcite development under Eclipse IDE > - > > Key: CALCITE-994 > URL: https://issues.apache.org/jira/browse/CALCITE-994 > Project: Calcite > Issue Type: Improvement > Components: site >Reporter: Alexander Reshetov >Assignee: Julian Hyde >Priority: Minor > Attachments: lifecycle-mapping-metadata.xml > > > After "git clone" project could not be imported in Eclipse as existing Maven > project. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-994) Calcite development under Eclipse IDE
[
https://issues.apache.org/jira/browse/CALCITE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15041472#comment-15041472
]
Alexander Reshetov commented on CALCITE-994:
When I try "mvn checkstyle:checkstyle" in console, I got Checkstyle errors too.
{code}
mvn checkstyle:checkstyle
[INFO] Scanning for projects...
[INFO]
[INFO] Reactor Build Order:
[INFO]
[INFO] Calcite
[INFO] Calcite Avatica
[INFO] Calcite Avatica Server
[INFO] Calcite Linq4j
[INFO] Calcite Core
[INFO] Calcite Examples
[INFO] Calcite Example CSV
[INFO] Calcite Example Function
[INFO] Calcite MongoDB
[INFO] Calcite Piglet
[INFO] Calcite Plus
[INFO] Calcite Spark
[INFO] Calcite Splunk
[INFO] Calcite Ubenchmark
[INFO]
[INFO]
[INFO] Building Calcite 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @ calcite ---
[INFO]
[INFO]
[INFO] Building Calcite Avatica 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-avatica ---
[INFO]
[INFO] There are 24113 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO]
[INFO] Building Calcite Avatica Server 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-avatica-server ---
[INFO]
[INFO] There are 620 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO]
[INFO] Building Calcite Linq4j 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-linq4j ---
[INFO]
[INFO] There are 8547 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO]
[INFO] Building Calcite Core 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-core ---
[INFO]
[INFO] There are 35183 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO]
[INFO] Building Calcite Examples 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-example ---
[INFO]
[INFO]
[INFO] Building Calcite Example CSV 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-example-csv ---
[INFO]
[INFO] There are 241 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO]
[INFO] Building Calcite Example Function 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-example-function ---
[INFO]
[INFO] There are 92 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO]
[INFO] Building Calcite MongoDB 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-mongodb ---
[INFO]
[INFO] There
[jira] [Commented] (CALCITE-994) Calcite development under Eclipse IDE
[ https://issues.apache.org/jira/browse/CALCITE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15041826#comment-15041826 ] Josh Elser commented on CALCITE-994: [~areshetov], that is curious. I wonder why that isn't getting picked up. We might need to lift the configuration for the maven-checkstyle-plugin from the execution to the plugin itself for manual invocation of the goal to work as expected. Does that make sense? > Calcite development under Eclipse IDE > - > > Key: CALCITE-994 > URL: https://issues.apache.org/jira/browse/CALCITE-994 > Project: Calcite > Issue Type: Improvement > Components: site >Reporter: Alexander Reshetov >Assignee: Julian Hyde >Priority: Minor > Attachments: lifecycle-mapping-metadata.xml > > > After "git clone" project could not be imported in Eclipse as existing Maven > project. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-994) Calcite development under Eclipse IDE
[ https://issues.apache.org/jira/browse/CALCITE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15030042#comment-15030042 ] Josh Elser commented on CALCITE-994: bq. based on what I've seen in Hbase and Oodt it seems to be the norm. Yeah, that's my assessment. XML lends itself well to folding of unwanted sections ;) bq. by including a lifecycleMappingMetadata section in pom.xml. Could we do the same here? I would assume so. LIke Alexander pointed out, it would be nice to have m2e support for these plugins (esp the javacc plugin so that Eclipse would automagically get regenerated, but not critical since I assume it's not often changed), but is fine for most cases. I have a backlog of other stuff to look at today, but I'll try to circle around. Thanks for filing this, Alexander! > Calcite development under Eclipse IDE > - > > Key: CALCITE-994 > URL: https://issues.apache.org/jira/browse/CALCITE-994 > Project: Calcite > Issue Type: Improvement > Components: site >Reporter: Alexander Reshetov >Assignee: Julian Hyde >Priority: Minor > Attachments: lifecycle-mapping-metadata.xml > > > After "git clone" project could not be imported in Eclipse as existing Maven > project. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-994) Calcite development under Eclipse IDE
[
https://issues.apache.org/jira/browse/CALCITE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029191#comment-15029191
]
Alexander Reshetov commented on CALCITE-994:
Copies from mailing list.
{noformat}
Hello,
I tried to import Calcite project into Eclipse and faced some issues.
In newly created workspace I select File - Import - Maven - Existing
Maven Projects
Point "Root Directory" to git cloned dir. Press "Finish".
After this steps I got erros:
- fmpp-maven-plugin:1.0:generate (1 errors)
Description: No marketplace entries found to handle
fmpp-maven-plugin:1.0:generate in Eclipse. Please see Help for more
information.
\- Execution generate-fmpp-sources, in /calcite-core/pom.xml
Description: No marketplace entries found to handle Execution
generate-fmpp-sources, in /calcite-core/pom.xml in Eclipse. Please
see Help for more information.
- javacc-maven-plugin:2.4:javacc (2 errors)
Description: No marketplace entries found to handle
javacc-maven-plugin:2.4:javacc in Eclipse. Please see Help for more
information.
\- Execution javacc, in /calcite-core/pom.xml
Description: No marketplace entries found to handle Execution
javacc, in /calcite-core/pom.xml in Eclipse. Please see Help for more
information.
\- Execution javacc, in /calcite-piglet/pom.xml
Description: No marketplace entries found to handle Execution
javacc, in /calcite-piglet/pom.xml in Eclipse. Please see Help for
more information.
After some googling it pointed out that while Eclipse uses incremental
compilation,
his m2eclipse plugin should have information from maven plugins about
lifecycle management.
See [1] for more details regarding this behaviour.
I also found similar issue (already closed) in Apache Drill. See Jira
ticket [2] and pull request
for it [3].
I modified pom.xml in calcite-core and calcite-piglet modules, which
caused this issue and
it was fixed for me. See git diffs [4] and [5].
There is also errors from checkstyle checks, but probably it's just my
setup. Didn't investigate yet.
[1] - http://www.eclipse.org/m2e/documentation/m2e-execution-not-covered.html
[2] - https://issues.apache.org/jira/browse/DRILL-445
[3] -
https://github.com/apache/drill/commit/1e25c0d287b8ca55d7ae3242b638659c68d115da
[4] - http://pastebin.com/VsV4RcG2
[5] - http://pastebin.com/Dhf9VJrS
{noformat}
{noformat}
Checked out probably better solution. At least from project point of view.
While such behaviour Eclipse-specific, it may be better to manage
lifecycle mapping
directly in Eclipse without blowing up project's POMs.
This feature is available from Eclipse 4.2 as described in
https://www.eclipse.org/m2e/documentation/m2e-execution-not-covered.html
part "Eclipse 4.2 Adds Default Mapping".
Note: while this feature is experimental, it have some issues. At least for me
this setting is same across workspaces, while it should be unique for
each workspace or even project.
To solve early mentioned issue with project import you need to add next config
in specified lifecycle-mapping-metadata.xml
com.googlecode.fmpp-maven-plugin
fmpp-maven-plugin
[1.0,)
generate
false
true
org.codehaus.mojo
javacc-maven-plugin
[2.4,)
javacc
false
true
{noformat}
> Calcite development under Eclipse IDE
> -
>
> Key: CALCITE-994
> URL: https://issues.apache.org/jira/browse/CALCITE-994
> Project: Calcite
> Issue Type: Improvement
> Components: site
>Reporter: Alexander Reshetov
>Assignee: Julian Hyde
>Priority: Minor
>
> After "git clone" project could not be imported in Eclipse as existing Maven
> project.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-994) Calcite development under Eclipse IDE
[ https://issues.apache.org/jira/browse/CALCITE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029581#comment-15029581 ] Julian Hyde commented on CALCITE-994: - [~elserj], I saw you authored the fix to HBASE-13236 https://github.com/apache/hbase/commit/72855c584e53173471c44a284ef2e839b6f31564 by including a lifecycleMappingMetadata section in pom.xml. Could we do the same here? > Calcite development under Eclipse IDE > - > > Key: CALCITE-994 > URL: https://issues.apache.org/jira/browse/CALCITE-994 > Project: Calcite > Issue Type: Improvement > Components: site >Reporter: Alexander Reshetov >Assignee: Julian Hyde >Priority: Minor > Attachments: lifecycle-mapping-metadata.xml > > > After "git clone" project could not be imported in Eclipse as existing Maven > project. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
