[jira] [Updated] (CALCITE-3322) There are two same testcase in RelMetadataTest

2019-09-05 Thread Julian Hyde (Jira) 


 [ 
https://issues.apache.org/jira/browse/CALCITE-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Hyde updated CALCITE-3322:
-
Fix Version/s: 1.21.0

> There are two same testcase in RelMetadataTest
> --
>
> Key: CALCITE-3322
> URL: https://issues.apache.org/jira/browse/CALCITE-3322
> Project: Calcite
>  Issue Type: Test
>  Components: core
>Affects Versions: 1.20.0
>Reporter: Hong Shen
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.21.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> When I read the code, I found two identical testcases in RelMetadataTest, 
> except for the different names, which might need to be changed to limit 0, or 
> just need to keep one.
> {code:java}
>   @Test public void testRowCountSortLimit() {
> final String sql = "select * from emp order by ename limit 10";
> checkRowCount(sql, 10d, 0D, 10d);
>   }
>   @Test public void testRowCountSortLimit0() {
> final String sql = "select * from emp order by ename limit 10";
> checkRowCount(sql, 10d, 0D, 10d);
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (CALCITE-3322) There are two same testcase in RelMetadataTest

2019-09-03 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/CALCITE-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated CALCITE-3322:

Labels: pull-request-available  (was: )

> There are two same testcase in RelMetadataTest
> --
>
> Key: CALCITE-3322
> URL: https://issues.apache.org/jira/browse/CALCITE-3322
> Project: Calcite
>  Issue Type: Test
>  Components: core
>Affects Versions: 1.20.0
>Reporter: Hong Shen
>Priority: Minor
>  Labels: pull-request-available
>
> When I read the code, I found two identical testcases in RelMetadataTest, 
> except for the different names, which might need to be changed to limit 0, or 
> just need to keep one.
> {code:java}
>   @Test public void testRowCountSortLimit() {
> final String sql = "select * from emp order by ename limit 10";
> checkRowCount(sql, 10d, 0D, 10d);
>   }
>   @Test public void testRowCountSortLimit0() {
> final String sql = "select * from emp order by ename limit 10";
> checkRowCount(sql, 10d, 0D, 10d);
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (CALCITE-3322) There are two same testcase in RelMetadataTest

2019-09-03 Thread Hong Shen (Jira) 


 [ 
https://issues.apache.org/jira/browse/CALCITE-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hong Shen updated CALCITE-3322:
---
Description: 
When I read the code, I found two identical testcases in RelMetadataTest, 
except for the different names, which might need to be changed to limit 0, or 
just need to keep one.
{code:java}
  @Test public void testRowCountSortLimit() {
final String sql = "select * from emp order by ename limit 10";
checkRowCount(sql, 10d, 0D, 10d);
  }

  @Test public void testRowCountSortLimit0() {
final String sql = "select * from emp order by ename limit 10";
checkRowCount(sql, 10d, 0D, 10d);
  }
{code}

  was:
When I read the code, I found two identical testcases, except for the different 
names, which might need to be changed to limit 0, or just need to keep one.
{code:java}
  @Test public void testRowCountSortLimit() {
final String sql = "select * from emp order by ename limit 10";
checkRowCount(sql, 10d, 0D, 10d);
  }

  @Test public void testRowCountSortLimit0() {
final String sql = "select * from emp order by ename limit 10";
checkRowCount(sql, 10d, 0D, 10d);
  }
{code}


> There are two same testcase in RelMetadataTest
> --
>
> Key: CALCITE-3322
> URL: https://issues.apache.org/jira/browse/CALCITE-3322
> Project: Calcite
>  Issue Type: Test
>  Components: core
>Affects Versions: 1.20.0
>Reporter: Hong Shen
>Priority: Minor
>
> When I read the code, I found two identical testcases in RelMetadataTest, 
> except for the different names, which might need to be changed to limit 0, or 
> just need to keep one.
> {code:java}
>   @Test public void testRowCountSortLimit() {
> final String sql = "select * from emp order by ename limit 10";
> checkRowCount(sql, 10d, 0D, 10d);
>   }
>   @Test public void testRowCountSortLimit0() {
> final String sql = "select * from emp order by ename limit 10";
> checkRowCount(sql, 10d, 0D, 10d);
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (CALCITE-3322) There are two same testcase in RelMetadataTest

2019-09-03 Thread Hong Shen (Jira) 


 [ 
https://issues.apache.org/jira/browse/CALCITE-3322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hong Shen updated CALCITE-3322:
---
Description: 
When I read the code, I found two identical testcases, except for the different 
names, which might need to be changed to limit 0, or just need to keep one.
{code:java}
  @Test public void testRowCountSortLimit() {
final String sql = "select * from emp order by ename limit 10";
checkRowCount(sql, 10d, 0D, 10d);
  }

  @Test public void testRowCountSortLimit0() {
final String sql = "select * from emp order by ename limit 10";
checkRowCount(sql, 10d, 0D, 10d);
  }
{code}

  was:
When I read the code, I found two identical testcases, except for the different 
names, which might need to be changed to limit 0, or just need to keep one.

  @Test public void testRowCountSortLimit() {
final String sql = "select * from emp order by ename limit 10";
checkRowCount(sql, 10d, 0D, 10d);
  }

  @Test public void testRowCountSortLimit0() {
final String sql = "select * from emp order by ename limit 10";
checkRowCount(sql, 10d, 0D, 10d);
  }



> There are two same testcase in RelMetadataTest
> --
>
> Key: CALCITE-3322
> URL: https://issues.apache.org/jira/browse/CALCITE-3322
> Project: Calcite
>  Issue Type: Test
>  Components: core
>Affects Versions: 1.20.0
>Reporter: Hong Shen
>Priority: Minor
>
> When I read the code, I found two identical testcases, except for the 
> different names, which might need to be changed to limit 0, or just need to 
> keep one.
> {code:java}
>   @Test public void testRowCountSortLimit() {
> final String sql = "select * from emp order by ename limit 10";
> checkRowCount(sql, 10d, 0D, 10d);
>   }
>   @Test public void testRowCountSortLimit0() {
> final String sql = "select * from emp order by ename limit 10";
> checkRowCount(sql, 10d, 0D, 10d);
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)