[jira] [Created] (CAMEL-7528) Aggregate - Allow aggregation repository to report back in-flight exchanges for in-memory repos
Claus Ibsen created CAMEL-7528: -- Summary: Aggregate - Allow aggregation repository to report back in-flight exchanges for in-memory repos Key: CAMEL-7528 URL: https://issues.apache.org/jira/browse/CAMEL-7528 Project: Camel Issue Type: Improvement Components: camel-core, eip Reporter: Claus Ibsen Fix For: 2.14.0, Future See nabble http://camel.465427.n5.nabble.com/Calculation-of-in-flight-messages-in-DefaultShutdownStrategy-td5747034.html When you use aggregation repository that is in-memory only, and you shutdown Camel you may want these in-memory messages to be regarded as in-flight so Camel allows time to process these messages. For example when using the aggregete eip. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7050) camel-jms drops messages when errorHandler throws an exception
[ https://issues.apache.org/jira/browse/CAMEL-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040533#comment-14040533 ] ASF GitHub Bot commented on CAMEL-7050: --- GitHub user adessaigne opened a pull request: https://github.com/apache/camel/pull/192 CAMEL-7050 Added completionMaxTimeout option You can merge this pull request into a Git repository by running: $ git pull https://github.com/adessaigne/camel CAMEL-7015 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #192 commit 99b52e4b471958aec4ac48f9162270d3f9febb60 Author: Antoine DESSAIGNE antoine.dessai...@gmail.com Date: 2014-06-23T08:48:53Z CAMEL-7050 Added completionMaxTimeout option commit 620ebcc249d5a0376c3a4e5369e58e1779d42c73 Author: Antoine DESSAIGNE antoine.dessai...@gmail.com Date: 2014-06-23T08:55:15Z CAMEL-7050 codestyle camel-jms drops messages when errorHandler throws an exception -- Key: CAMEL-7050 URL: https://issues.apache.org/jira/browse/CAMEL-7050 Project: Camel Issue Type: Bug Components: camel-jms Affects Versions: 2.11.0, Future Reporter: Øyvind Ingebrigtsen Øvergaard Attachments: BadErrorHandler.java, JmsDeadLetterChannelHandlerExceptionTest.java When using camel-jms, messages are dropped when an exception is thrown in the deadLetterChannel error handler. See the attached failing unit test. Verified against 2.11 and HEAD -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7050) camel-jms drops messages when errorHandler throws an exception
[ https://issues.apache.org/jira/browse/CAMEL-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040535#comment-14040535 ] Antoine DESSAIGNE commented on CAMEL-7050: -- Sorry, wrong jira number in commit message... It's not CAMEL-7050 is CAMEL-7015 camel-jms drops messages when errorHandler throws an exception -- Key: CAMEL-7050 URL: https://issues.apache.org/jira/browse/CAMEL-7050 Project: Camel Issue Type: Bug Components: camel-jms Affects Versions: 2.11.0, Future Reporter: Øyvind Ingebrigtsen Øvergaard Attachments: BadErrorHandler.java, JmsDeadLetterChannelHandlerExceptionTest.java When using camel-jms, messages are dropped when an exception is thrown in the deadLetterChannel error handler. See the attached failing unit test. Verified against 2.11 and HEAD -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7015) Allow timeout on the first Exchange for aggregator
[ https://issues.apache.org/jira/browse/CAMEL-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040538#comment-14040538 ] Antoine DESSAIGNE commented on CAMEL-7015: -- I've added a pull request for this : https://github.com/apache/camel/pull/192 But my commit messages have a wrong jira number... Sorry about that. Allow timeout on the first Exchange for aggregator -- Key: CAMEL-7015 URL: https://issues.apache.org/jira/browse/CAMEL-7015 Project: Camel Issue Type: New Feature Reporter: ChrisS Labels: features Original Estimate: 168h Remaining Estimate: 168h It would be nice to have a possibility of a timeout starting from the first Exchange for messages having the same correlationExpression when using Aggregation. This scenario is currently not supported because Its a bit tougher to implement as it would require an improvement to TimeoutMap to support that as well. The full scenario is described in this thread: http://camel.465427.n5.nabble.com/A-simple-Aggregator-use-case-td5743633.html#a5743634 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (CAMEL-7050) camel-jms drops messages when errorHandler throws an exception
[ https://issues.apache.org/jira/browse/CAMEL-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040535#comment-14040535 ] Antoine DESSAIGNE edited comment on CAMEL-7050 at 6/23/14 9:01 AM: --- Sorry, wrong jira number in commit message... It's not CAMEL-7050 it's CAMEL-7015 was (Author: antoine.dessaigne): Sorry, wrong jira number in commit message... It's not CAMEL-7050 is CAMEL-7015 camel-jms drops messages when errorHandler throws an exception -- Key: CAMEL-7050 URL: https://issues.apache.org/jira/browse/CAMEL-7050 Project: Camel Issue Type: Bug Components: camel-jms Affects Versions: 2.11.0, Future Reporter: Øyvind Ingebrigtsen Øvergaard Attachments: BadErrorHandler.java, JmsDeadLetterChannelHandlerExceptionTest.java When using camel-jms, messages are dropped when an exception is thrown in the deadLetterChannel error handler. See the attached failing unit test. Verified against 2.11 and HEAD -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CAMEL-7529) Update HeaderFilterStrategyComponent to extend UriEndpointComponent
Kevin Earls created CAMEL-7529: -- Summary: Update HeaderFilterStrategyComponent to extend UriEndpointComponent Key: CAMEL-7529 URL: https://issues.apache.org/jira/browse/CAMEL-7529 Project: Camel Issue Type: Improvement Reporter: Kevin Earls Priority: Minor As part of exposing component options, we need to update HeaderFilterStrategyComponent to extend UriEndpointComponent instead of DefaultComponent, as certain components including CXF, CXFRS, and HTTP extend it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Reopened] (CAMEL-7476) cxfrs throwExceptionOnFailure option not working
[
https://issues.apache.org/jira/browse/CAMEL-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gareth Bird reopened CAMEL-7476:
Thank you for taking the time Willem for writing the test case to prove that
throwExceptionOnFailure=false suppresses exceptions.
I still do have exceptions being raised in the route.
I've been looking at my code, your code, and the cxfrs source - what I am now
thinking is that the exception may be being raised on this line in
(CxfRsProducer.java):
// invoke the client
Object response = null;
if (responseClass == null || Response.class.equals(responseClass)) {
response = client.invoke(httpMethod, body);
} else { ...
The exception type is javax.ws.rs.ClientErrorException, so it may be being
raised by CXF during invoke. The REST service being called is returning a
status of 412 (already exists).
For reference - this is how I am calling the service in the route:
.to(cxfrs://http://www.example.com:8080/opendj-rest2ldap-servlet-2.6.0-servlet/?httpClientAPI=truethrowExceptionOnFailure=falseproviders=#jaxproviders;)
[ As an aside I am invoking OpenDJ - LDAP REST service - to create a user ]
If response status 4xx, CXF will wrap response in
javax.ws.rs.ClientErrorException and throws out;
So to re-cap I think that CXF is raising the exception - should these type of
exception be caught by and suppressed in the method invokeHttpClient?
cxfrs throwExceptionOnFailure option not working
Key: CAMEL-7476
URL: https://issues.apache.org/jira/browse/CAMEL-7476
Project: Camel
Issue Type: Bug
Components: camel-cxf
Affects Versions: 2.13.0, 2.13.1
Reporter: Gareth Bird
Assignee: Willem Jiang
Priority: Minor
(1) The cxfrs option throwExceptionOnFailure=true does not suppress
exceptions from being thrown when an invoked REST service returns a http
status 207. i.e. the following does not work:
...
.to(cxfrs:bean:rsClient?throwExceptionOnFailure=false)
(2) The cxfrs throwExceptionOnFailure option should default to false; to make
it easier to process status codes in the route.
When invoking REST services, the logic is currently complicated by the fact
that common status' need to be processed in exception handlers. i,e (404 not
found, 412 precondition failed). It would be more useful to filter on
statuses with a main route.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CAMEL-7476) cxfrs throwExceptionOnFailure option not working
[ https://issues.apache.org/jira/browse/CAMEL-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040628#comment-14040628 ] Sergey Beryozkin commented on CAMEL-7476: - Hi, CXF itself won't throw the exception if response class is Response. WebClient has the following pseudo-code: if (r.getStatus() = 300 responseClass != Response.class) = throw the exception... So I wonder do we have responseClass set to something else in the route ? Cheers, Sergey cxfrs throwExceptionOnFailure option not working Key: CAMEL-7476 URL: https://issues.apache.org/jira/browse/CAMEL-7476 Project: Camel Issue Type: Bug Components: camel-cxf Affects Versions: 2.13.0, 2.13.1 Reporter: Gareth Bird Assignee: Willem Jiang Priority: Minor (1) The cxfrs option throwExceptionOnFailure=true does not suppress exceptions from being thrown when an invoked REST service returns a http status 207. i.e. the following does not work: ... .to(cxfrs:bean:rsClient?throwExceptionOnFailure=false) (2) The cxfrs throwExceptionOnFailure option should default to false; to make it easier to process status codes in the route. When invoking REST services, the logic is currently complicated by the fact that common status' need to be processed in exception handlers. i,e (404 not found, 412 precondition failed). It would be more useful to filter on statuses with a main route. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7476) cxfrs throwExceptionOnFailure option not working
[ https://issues.apache.org/jira/browse/CAMEL-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040649#comment-14040649 ] Gareth Bird commented on CAMEL-7476: Yes Sergey... .setHeader(CxfConstants.CAMEL_CXF_RS_RESPONSE_CLASS, constant(java.util.Map.class)) This allows CXF to unmarhsall (using Jackson) the JSON payload to a map. Is there another way I should be doing this? cxfrs throwExceptionOnFailure option not working Key: CAMEL-7476 URL: https://issues.apache.org/jira/browse/CAMEL-7476 Project: Camel Issue Type: Bug Components: camel-cxf Affects Versions: 2.13.0, 2.13.1 Reporter: Gareth Bird Assignee: Willem Jiang Priority: Minor (1) The cxfrs option throwExceptionOnFailure=true does not suppress exceptions from being thrown when an invoked REST service returns a http status 207. i.e. the following does not work: ... .to(cxfrs:bean:rsClient?throwExceptionOnFailure=false) (2) The cxfrs throwExceptionOnFailure option should default to false; to make it easier to process status codes in the route. When invoking REST services, the logic is currently complicated by the fact that common status' need to be processed in exception handlers. i,e (404 not found, 412 precondition failed). It would be more useful to filter on statuses with a main route. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7476) cxfrs throwExceptionOnFailure option not working
[ https://issues.apache.org/jira/browse/CAMEL-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040664#comment-14040664 ] Sergey Beryozkin commented on CAMEL-7476: - Do not let CXF do the unmarshalling, You can do response.readEntity(Map.class) later on on the received Response instance. There's another JIRA pending that would make it possible to integrate CXF Responses with Camel-level unmarshallers, you can do it right now too by extracting Response.getEntity() which will be InputStream before Camel unmarshaller is used. Cheers, Sergey cxfrs throwExceptionOnFailure option not working Key: CAMEL-7476 URL: https://issues.apache.org/jira/browse/CAMEL-7476 Project: Camel Issue Type: Bug Components: camel-cxf Affects Versions: 2.13.0, 2.13.1 Reporter: Gareth Bird Assignee: Willem Jiang Priority: Minor (1) The cxfrs option throwExceptionOnFailure=true does not suppress exceptions from being thrown when an invoked REST service returns a http status 207. i.e. the following does not work: ... .to(cxfrs:bean:rsClient?throwExceptionOnFailure=false) (2) The cxfrs throwExceptionOnFailure option should default to false; to make it easier to process status codes in the route. When invoking REST services, the logic is currently complicated by the fact that common status' need to be processed in exception handlers. i,e (404 not found, 412 precondition failed). It would be more useful to filter on statuses with a main route. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7529) Update HeaderFilterStrategyComponent to extend UriEndpointComponent
[ https://issues.apache.org/jira/browse/CAMEL-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040697#comment-14040697 ] ASF GitHub Bot commented on CAMEL-7529: --- GitHub user kevinearls opened a pull request: https://github.com/apache/camel/pull/193 Fix for CAMEL-7529 Modify HeaderFilterStrategyComponent to extend UriEnd... ...pointComponent instead of DefaultComponent. This is needed to expose component options in components where XXXComponent.java extended HeaderFilterStrategyComponent rather than DefaultComponent. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kevinearls/camel CAMEL-7529 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #193 commit 26f72c6fa5b2df324b5d457793143820535871a1 Author: Kevin Earls ke...@kevinearls.com Date: 2014-06-23T12:38:08Z Fix for CAMEL-7529 Modify HeaderFilterStrategyComponent to extend UriEndpointComponent instead of DefaultComponent Update HeaderFilterStrategyComponent to extend UriEndpointComponent --- Key: CAMEL-7529 URL: https://issues.apache.org/jira/browse/CAMEL-7529 Project: Camel Issue Type: Improvement Reporter: Kevin Earls Priority: Minor As part of exposing component options, we need to update HeaderFilterStrategyComponent to extend UriEndpointComponent instead of DefaultComponent, as certain components including CXF, CXFRS, and HTTP extend it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7297) Add remote querying feature to camel-infinispan component
[ https://issues.apache.org/jira/browse/CAMEL-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040950#comment-14040950 ] Bilgin Ibryam commented on CAMEL-7297: -- [~davsclaus]Thanks for taking care of the licensing issue. I will check whether there is another implementation. Add remote querying feature to camel-infinispan component - Key: CAMEL-7297 URL: https://issues.apache.org/jira/browse/CAMEL-7297 Project: Camel Issue Type: New Feature Reporter: Bilgin Ibryam Assignee: Bilgin Ibryam Priority: Minor Fix For: 2.14.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7504) Improve the throttler to have discarding/filtering capabilities
[
https://issues.apache.org/jira/browse/CAMEL-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041218#comment-14041218
]
David J. M. Karlsen commented on CAMEL-7504:
Works like a charm!:
{noformat}
2014-06-23 21:49:15,467 [Camel (camel-1) thread #0 -
timer://myTimer][][][][][][][] ERROR
org.apache.camel.processor.FatalFallbackErrorHandler:54 - \-- Previous
exception on exchangeId: ID-aap-prx-01-34540-140300
3938060-0-366007
java.util.concurrent.RejectedExecutionException: Exceed the max request limit!
at
org.apache.camel.processor.Throttler.processDelay(Throttler.java:215)
~[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.DelayProcessorSupport.process(DelayProcessorSupport.java:168)
~[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:72)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.interceptor.TraceInterceptor.process(TraceInterceptor.java:163)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:398)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:191)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:191)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.util.AsyncProcessorHelper.process(AsyncProcessorHelper.java:105)
~[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.DelegateAsyncProcessor.process(DelegateAsyncProcessor.java:87)
~[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:40)
~[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
com.davidkarlsen.httptest.MyRouteBuilder$2.process(MyRouteBuilder.java:113)
~[http-test-1.0-SNAPSHOT.jar:na]
at
org.apache.camel.processor.DelegateSyncProcessor.process(DelegateSyncProcessor.java:63)
~[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:72)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.interceptor.TraceInterceptor.process(TraceInterceptor.java:163)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:191)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.FatalFallbackErrorHandler.process(FatalFallbackErrorHandler.java:42)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.RedeliveryErrorHandler.deliverToFailureProcessor(RedeliveryErrorHandler.java:839)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:337)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:191)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at org.apache.camel.processor.Pipeline.process(Pipeline.java:118)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at org.apache.camel.processor.Pipeline.process(Pipeline.java:80)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:191)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.component.timer.TimerConsumer.sendTimerExchange(TimerConsumer.java:157)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.component.timer.TimerConsumer$1.run(TimerConsumer.java:68)
[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at java.util.Timer$TimerImpl.run(Timer.java:291) [na:na]
2014-06-23 21:49:15,470 [Camel (camel-1) thread #0 -
timer://myTimer][][][][][][][] ERROR
org.apache.camel.processor.FatalFallbackErrorHandler:55 - \-- New exception on
exchangeId: ID-aap-prx-01-34540-14030039380
60-0-366007
java.util.concurrent.RejectedExecutionException: Exceed the max request limit!
at
org.apache.camel.processor.Throttler.processDelay(Throttler.java:215)
~[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
org.apache.camel.processor.DelayProcessorSupport.process(DelayProcessorSupport.java:168)
~[camel-core-2.14-20140617.030729-34.jar:2.14-SNAPSHOT]
at
[jira] [Resolved] (CAMEL-7504) Improve the throttler to have discarding/filtering capabilities
[ https://issues.apache.org/jira/browse/CAMEL-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang resolved CAMEL-7504. - Resolution: Fixed Improve the throttler to have discarding/filtering capabilities --- Key: CAMEL-7504 URL: https://issues.apache.org/jira/browse/CAMEL-7504 Project: Camel Issue Type: Improvement Components: camel-core Reporter: David J. M. Karlsen Assignee: Willem Jiang It would be nice if the throttler, http://camel.apache.org/throttler.html, could discard/filter the messages exceeding the limit. My usecase is to send alerts to a alering route, and stick the trottler in front of an smtp endpoint to limit the number of emails sent during a period. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CAMEL-7050) camel-jms drops messages when errorHandler throws an exception
[ https://issues.apache.org/jira/browse/CAMEL-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang reassigned CAMEL-7050: --- Assignee: Willem Jiang camel-jms drops messages when errorHandler throws an exception -- Key: CAMEL-7050 URL: https://issues.apache.org/jira/browse/CAMEL-7050 Project: Camel Issue Type: Bug Components: camel-jms Affects Versions: 2.11.0, Future Reporter: Øyvind Ingebrigtsen Øvergaard Assignee: Willem Jiang Attachments: BadErrorHandler.java, JmsDeadLetterChannelHandlerExceptionTest.java When using camel-jms, messages are dropped when an exception is thrown in the deadLetterChannel error handler. See the attached failing unit test. Verified against 2.11 and HEAD -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (CAMEL-7015) Allow timeout on the first Exchange for aggregator
[ https://issues.apache.org/jira/browse/CAMEL-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang reassigned CAMEL-7015: --- Assignee: Willem Jiang Allow timeout on the first Exchange for aggregator -- Key: CAMEL-7015 URL: https://issues.apache.org/jira/browse/CAMEL-7015 Project: Camel Issue Type: New Feature Reporter: ChrisS Assignee: Willem Jiang Labels: features Original Estimate: 168h Remaining Estimate: 168h It would be nice to have a possibility of a timeout starting from the first Exchange for messages having the same correlationExpression when using Aggregation. This scenario is currently not supported because Its a bit tougher to implement as it would require an improvement to TimeoutMap to support that as well. The full scenario is described in this thread: http://camel.465427.n5.nabble.com/A-simple-Aggregator-use-case-td5743633.html#a5743634 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7504) Improve the throttler to have discarding/filtering capabilities
[
https://issues.apache.org/jira/browse/CAMEL-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041704#comment-14041704
]
Claus Ibsen commented on CAMEL-7504:
I wonder if we need an option to reject them messages silently? eg today you
get this exception which may be noisy in the logs out of the box. Maybe in some
use cases you do not care if the message was discarded?
Also {{RejectedExecutionException}} is a generic exception so you cannot easily
configure the error handler today to ignore this exception, as you would need
to check the exception message text being `Exceed the max request limit!` to
know its from a throttler
Improve the throttler to have discarding/filtering capabilities
---
Key: CAMEL-7504
URL: https://issues.apache.org/jira/browse/CAMEL-7504
Project: Camel
Issue Type: Improvement
Components: camel-core, eip
Reporter: David J. M. Karlsen
Assignee: Willem Jiang
Fix For: 2.14.0
It would be nice if the throttler, http://camel.apache.org/throttler.html,
could discard/filter the messages exceeding the limit.
My usecase is to send alerts to a alering route, and stick the trottler in
front of an smtp endpoint to limit the number of emails sent during a period.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (CAMEL-7504) Improve the throttler to have discarding/filtering capabilities
[ https://issues.apache.org/jira/browse/CAMEL-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-7504: --- Component/s: eip Improve the throttler to have discarding/filtering capabilities --- Key: CAMEL-7504 URL: https://issues.apache.org/jira/browse/CAMEL-7504 Project: Camel Issue Type: Improvement Components: camel-core, eip Reporter: David J. M. Karlsen Assignee: Willem Jiang Fix For: 2.14.0 It would be nice if the throttler, http://camel.apache.org/throttler.html, could discard/filter the messages exceeding the limit. My usecase is to send alerts to a alering route, and stick the trottler in front of an smtp endpoint to limit the number of emails sent during a period. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CAMEL-7504) Improve the throttler to have discarding/filtering capabilities
[ https://issues.apache.org/jira/browse/CAMEL-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-7504: --- Fix Version/s: 2.14.0 Improve the throttler to have discarding/filtering capabilities --- Key: CAMEL-7504 URL: https://issues.apache.org/jira/browse/CAMEL-7504 Project: Camel Issue Type: Improvement Components: camel-core, eip Reporter: David J. M. Karlsen Assignee: Willem Jiang Fix For: 2.14.0 It would be nice if the throttler, http://camel.apache.org/throttler.html, could discard/filter the messages exceeding the limit. My usecase is to send alerts to a alering route, and stick the trottler in front of an smtp endpoint to limit the number of emails sent during a period. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7050) camel-jms drops messages when errorHandler throws an exception
[ https://issues.apache.org/jira/browse/CAMEL-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041709#comment-14041709 ] Claus Ibsen commented on CAMEL-7050: Ah the JMS is this PR https://github.com/apache/camel/pull/190.patch camel-jms drops messages when errorHandler throws an exception -- Key: CAMEL-7050 URL: https://issues.apache.org/jira/browse/CAMEL-7050 Project: Camel Issue Type: Bug Components: camel-jms Affects Versions: 2.11.0, Future Reporter: Øyvind Ingebrigtsen Øvergaard Assignee: Willem Jiang Attachments: BadErrorHandler.java, JmsDeadLetterChannelHandlerExceptionTest.java When using camel-jms, messages are dropped when an exception is thrown in the deadLetterChannel error handler. See the attached failing unit test. Verified against 2.11 and HEAD -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7050) camel-jms drops messages when errorHandler throws an exception
[ https://issues.apache.org/jira/browse/CAMEL-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041707#comment-14041707 ] Claus Ibsen commented on CAMEL-7050: [~antoine.dessaigne] thanks for the PR. But please do *NOT* do any code formatting changes on the existing code as the code format should be left as-is. We only want patches that has code changes about the issue it fixes/improves etc. That makes it easier to see what is changed and why. Do you mind doing a new PR without any of the code formatting, and it only has the JMS changes? camel-jms drops messages when errorHandler throws an exception -- Key: CAMEL-7050 URL: https://issues.apache.org/jira/browse/CAMEL-7050 Project: Camel Issue Type: Bug Components: camel-jms Affects Versions: 2.11.0, Future Reporter: Øyvind Ingebrigtsen Øvergaard Assignee: Willem Jiang Attachments: BadErrorHandler.java, JmsDeadLetterChannelHandlerExceptionTest.java When using camel-jms, messages are dropped when an exception is thrown in the deadLetterChannel error handler. See the attached failing unit test. Verified against 2.11 and HEAD -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CAMEL-7050) camel-jms drops messages when errorHandler throws an exception
[ https://issues.apache.org/jira/browse/CAMEL-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-7050: --- Affects Version/s: (was: Future) camel-jms drops messages when errorHandler throws an exception -- Key: CAMEL-7050 URL: https://issues.apache.org/jira/browse/CAMEL-7050 Project: Camel Issue Type: Bug Components: camel-jms Affects Versions: 2.11.0 Reporter: Øyvind Ingebrigtsen Øvergaard Assignee: Willem Jiang Attachments: BadErrorHandler.java, JmsDeadLetterChannelHandlerExceptionTest.java When using camel-jms, messages are dropped when an exception is thrown in the deadLetterChannel error handler. See the attached failing unit test. Verified against 2.11 and HEAD -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7015) Allow timeout on the first Exchange for aggregator
[ https://issues.apache.org/jira/browse/CAMEL-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041728#comment-14041728 ] Claus Ibsen commented on CAMEL-7015: What is the idea with the maxCompletionTimeout? Will it not confuse end users that there is 2 timeouts now? Allow timeout on the first Exchange for aggregator -- Key: CAMEL-7015 URL: https://issues.apache.org/jira/browse/CAMEL-7015 Project: Camel Issue Type: New Feature Reporter: ChrisS Assignee: Willem Jiang Labels: features Original Estimate: 168h Remaining Estimate: 168h It would be nice to have a possibility of a timeout starting from the first Exchange for messages having the same correlationExpression when using Aggregation. This scenario is currently not supported because Its a bit tougher to implement as it would require an improvement to TimeoutMap to support that as well. The full scenario is described in this thread: http://camel.465427.n5.nabble.com/A-simple-Aggregator-use-case-td5743633.html#a5743634 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7015) Allow timeout on the first Exchange for aggregator
[ https://issues.apache.org/jira/browse/CAMEL-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041730#comment-14041730 ] Claus Ibsen commented on CAMEL-7015: Willem hold on any merges, as at first glance I think its confusing with that max timeout option. Allow timeout on the first Exchange for aggregator -- Key: CAMEL-7015 URL: https://issues.apache.org/jira/browse/CAMEL-7015 Project: Camel Issue Type: New Feature Reporter: ChrisS Assignee: Willem Jiang Labels: features Original Estimate: 168h Remaining Estimate: 168h It would be nice to have a possibility of a timeout starting from the first Exchange for messages having the same correlationExpression when using Aggregation. This scenario is currently not supported because Its a bit tougher to implement as it would require an improvement to TimeoutMap to support that as well. The full scenario is described in this thread: http://camel.465427.n5.nabble.com/A-simple-Aggregator-use-case-td5743633.html#a5743634 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CAMEL-7015) Allow timeout on the first Exchange for aggregator
[ https://issues.apache.org/jira/browse/CAMEL-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-7015: --- Component/s: eip camel-core Allow timeout on the first Exchange for aggregator -- Key: CAMEL-7015 URL: https://issues.apache.org/jira/browse/CAMEL-7015 Project: Camel Issue Type: New Feature Components: camel-core, eip Reporter: ChrisS Assignee: Willem Jiang Original Estimate: 168h Remaining Estimate: 168h It would be nice to have a possibility of a timeout starting from the first Exchange for messages having the same correlationExpression when using Aggregation. This scenario is currently not supported because Its a bit tougher to implement as it would require an improvement to TimeoutMap to support that as well. The full scenario is described in this thread: http://camel.465427.n5.nabble.com/A-simple-Aggregator-use-case-td5743633.html#a5743634 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CAMEL-7015) Allow timeout on the first Exchange for aggregator
[ https://issues.apache.org/jira/browse/CAMEL-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claus Ibsen updated CAMEL-7015: --- Labels: (was: features) Allow timeout on the first Exchange for aggregator -- Key: CAMEL-7015 URL: https://issues.apache.org/jira/browse/CAMEL-7015 Project: Camel Issue Type: New Feature Components: camel-core, eip Reporter: ChrisS Assignee: Willem Jiang Original Estimate: 168h Remaining Estimate: 168h It would be nice to have a possibility of a timeout starting from the first Exchange for messages having the same correlationExpression when using Aggregation. This scenario is currently not supported because Its a bit tougher to implement as it would require an improvement to TimeoutMap to support that as well. The full scenario is described in this thread: http://camel.465427.n5.nabble.com/A-simple-Aggregator-use-case-td5743633.html#a5743634 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CAMEL-7050) camel-jms drops messages when errorHandler throws an exception
[ https://issues.apache.org/jira/browse/CAMEL-7050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041738#comment-14041738 ] Claus Ibsen commented on CAMEL-7050: Yeah as there is a code change in redelivery error handler it affects *every* component in Camel. I wonder if the fix should not be in the fallback error handler, which is used for handling errors in error handlers. IMHO at first though that would see as a better solution. camel-jms drops messages when errorHandler throws an exception -- Key: CAMEL-7050 URL: https://issues.apache.org/jira/browse/CAMEL-7050 Project: Camel Issue Type: Bug Components: camel-jms Affects Versions: 2.11.0 Reporter: Øyvind Ingebrigtsen Øvergaard Assignee: Willem Jiang Attachments: BadErrorHandler.java, JmsDeadLetterChannelHandlerExceptionTest.java When using camel-jms, messages are dropped when an exception is thrown in the deadLetterChannel error handler. See the attached failing unit test. Verified against 2.11 and HEAD -- This message was sent by Atlassian JIRA (v6.2#6252)
