[jira] [Commented] (CAMEL-10040) camel-ahc - Upgrade AHC client to 2.x

2016-06-10 Thread Claus Ibsen (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15325738#comment-15325738
 ] 

Claus Ibsen commented on CAMEL-10040:
-

Yeah if possible we should rely on netty 4.1, and netty 4.1 should be backwards 
compatible with 4.0.x.

> camel-ahc - Upgrade AHC client to 2.x
> -
>
> Key: CAMEL-10040
> URL: https://issues.apache.org/jira/browse/CAMEL-10040
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-ahc
>Reporter: Claus Ibsen
> Fix For: 2.18.0
>
>
> We are using the older 1.9.x version today.
> There is a newer 2.0x that has changed maven coord to 
> org.asynchttpclient/async-http-client



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (CAMEL-10046) 'requestRequiredAcks' data type is wrongly set as integer

2016-06-10 Thread Kumar Abhinav (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kumar Abhinav closed CAMEL-10046.
-
Resolution: Implemented

I see it being implemented as string already.

> 'requestRequiredAcks' data type is wrongly set as integer
> -
>
> Key: CAMEL-10046
> URL: https://issues.apache.org/jira/browse/CAMEL-10046
> Project: Camel
>  Issue Type: Bug
>  Components: camel-kafka
>Affects Versions: 2.17.1
>Reporter: Kumar Abhinav
>
> Per documentation provided in kafka 
> (http://kafka.apache.org/documentation.html#producerconfigs) acks property 
> can have [all, -1, 0, 1] as value. Camel-kafka is mapping acks to 
> requestRequiredAcks which is set as Integer. The property must be a string or 
> an enum and definitely not an integer as 'all' leaves the number of 
> acknowledgements to the configuration on the broker, rather than providing 
> upfront in the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CAMEL-10046) 'requestRequiredAcks' data type is wrongly set as integer

2016-06-10 Thread Kumar Abhinav (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kumar Abhinav updated CAMEL-10046:
--
Description: Per documentation provided in kafka 
(http://kafka.apache.org/documentation.html#producerconfigs) acks property can 
have [all, -1, 0, 1] as value. Camel-kafka is mapping acks to 
requestRequiredAcks which is set as Integer. The property must be a string or 
an enum and definitely not an integer as 'all' leaves the number of 
acknowledgements to the configuration on the broker, rather than providing 
upfront in the client.  (was: Per documentation provided in kafka 
(http://kafka.apache.org/documentation.html#producerconfigs) acks property can 
have [all, -1, 0, 1] as value. Camel-kafka is mapping acks to 
requestRequiredAcks which is set as Integer. The property must be a string or 
an enum and definitely not an integer as 'all' leaves the number of 
acknowledgements to the configuration on the broker, rather than providing 
upfront in the configuration.)

> 'requestRequiredAcks' data type is wrongly set as integer
> -
>
> Key: CAMEL-10046
> URL: https://issues.apache.org/jira/browse/CAMEL-10046
> Project: Camel
>  Issue Type: Bug
>  Components: camel-kafka
>Affects Versions: 2.17.1
>Reporter: Kumar Abhinav
>
> Per documentation provided in kafka 
> (http://kafka.apache.org/documentation.html#producerconfigs) acks property 
> can have [all, -1, 0, 1] as value. Camel-kafka is mapping acks to 
> requestRequiredAcks which is set as Integer. The property must be a string or 
> an enum and definitely not an integer as 'all' leaves the number of 
> acknowledgements to the configuration on the broker, rather than providing 
> upfront in the client.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CAMEL-10040) camel-ahc - Upgrade AHC client to 2.x

2016-06-10 Thread Arno Noordover (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15325165#comment-15325165
 ] 

Arno Noordover commented on CAMEL-10040:


The new async-http-client has transitive dependecies e.g. to netty-codec-http 
(4.0.37.Final).
io.netty:netty was excluded from the old async-http-client and included in de 
project itself.
Should we exclude the 4.0.37.Final version and include 4.1.1.Final of netty?

> camel-ahc - Upgrade AHC client to 2.x
> -
>
> Key: CAMEL-10040
> URL: https://issues.apache.org/jira/browse/CAMEL-10040
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-ahc
>Reporter: Claus Ibsen
> Fix For: 2.18.0
>
>
> We are using the older 1.9.x version today.
> There is a newer 2.0x that has changed maven coord to 
> org.asynchttpclient/async-http-client



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CAMEL-10044) Mark secret options such as password/passphrase so tooling would be aware

2016-06-10 Thread Claus Ibsen (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324615#comment-15324615
 ] 

Claus Ibsen commented on CAMEL-10044:
-

We can then output to the json schema that an option is secret, eg 
secret=true|false

> Mark secret options such as password/passphrase so tooling would be aware
> -
>
> Key: CAMEL-10044
> URL: https://issues.apache.org/jira/browse/CAMEL-10044
> Project: Camel
>  Issue Type: Improvement
>Reporter: Claus Ibsen
>
> So we would be aware that this is a sensitive option such as password for the 
> FTP server and that we should not show/hide that in tooling / JMX attributes 
> etc.
> We can do this with some option to @Metadata annotation you can add to the 
> fields in the components/endpoints/data format options.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CAMEL-10045) camel-spring-boot - Allow to load sensitive options from external file

2016-06-10 Thread Claus Ibsen (JIRA) 
Claus Ibsen created CAMEL-10045:
---

 Summary: camel-spring-boot - Allow to load sensitive options from 
external file
 Key: CAMEL-10045
 URL: https://issues.apache.org/jira/browse/CAMEL-10045
 Project: Camel
  Issue Type: Improvement
  Components: camel-spring-boot
Reporter: Claus Ibsen


So you can configure this externally from your app / not hardcode. So options 
such as password can be loaded from a file mounted / ENV or something else.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (CAMEL-10043) Camel-Jaxb: objectFactory is never checked. This leads to performance degradation.

2016-06-10 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-10043.
--
Resolution: Fixed

> Camel-Jaxb: objectFactory is never checked. This leads to performance 
> degradation.
> --
>
> Key: CAMEL-10043
> URL: https://issues.apache.org/jira/browse/CAMEL-10043
> Project: Camel
>  Issue Type: Bug
>  Components: camel-jaxb
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
> Fix For: 2.17.2, 2.18.0
>
>
> Since the option is always true and we have performance degradation we need 
> to set the default to false too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (CAMEL-10042) camel-spring-boot - Add default values to auto configuration

2016-06-10 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-10042.
-
Resolution: Fixed

> camel-spring-boot - Add default values to auto configuration
> 
>
> Key: CAMEL-10042
> URL: https://issues.apache.org/jira/browse/CAMEL-10042
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
> Fix For: 2.18.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CAMEL-10043) Camel-Jaxb: objectFactory is never checked. This leads to performance degradation.

2016-06-10 Thread Andrea Cosentino (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324422#comment-15324422
 ] 

Andrea Cosentino commented on CAMEL-10043:
--

We should set the ObjectFactory option to false for the DataFormat too.

> Camel-Jaxb: objectFactory is never checked. This leads to performance 
> degradation.
> --
>
> Key: CAMEL-10043
> URL: https://issues.apache.org/jira/browse/CAMEL-10043
> Project: Camel
>  Issue Type: Bug
>  Components: camel-jaxb
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
> Fix For: 2.17.2, 2.18.0
>
>
> Since the option is always true and we have performance degradation we need 
> to set the default to false too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CAMEL-10043) Camel-Jaxb: objectFactory is never checked. This lead to performance degradation.

2016-06-10 Thread Andrea Cosentino (JIRA) 
Andrea Cosentino created CAMEL-10043:


 Summary: Camel-Jaxb: objectFactory is never checked. This lead to 
performance degradation.
 Key: CAMEL-10043
 URL: https://issues.apache.org/jira/browse/CAMEL-10043
 Project: Camel
  Issue Type: Bug
  Components: camel-jaxb
Reporter: Andrea Cosentino
Assignee: Andrea Cosentino
 Fix For: 2.17.2, 2.18.0


Since the option is always true and we have performance degradation we need to 
set the default to false too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CAMEL-10042) camel-spring-boot - Add default values to auto configuration

2016-06-10 Thread Claus Ibsen (JIRA) 
Claus Ibsen created CAMEL-10042:
---

 Summary: camel-spring-boot - Add default values to auto 
configuration
 Key: CAMEL-10042
 URL: https://issues.apache.org/jira/browse/CAMEL-10042
 Project: Camel
  Issue Type: Improvement
  Components: camel-spring-boot
Reporter: Claus Ibsen
Assignee: Claus Ibsen
 Fix For: 2.18.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (CAMEL-10041) camel-spring-boot - Add data format options as type-safe configuration properties

2016-06-10 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-10041.
-
   Resolution: Fixed
Fix Version/s: 2.18.0

> camel-spring-boot - Add data format options as type-safe configuration 
> properties
> -
>
> Key: CAMEL-10041
> URL: https://issues.apache.org/jira/browse/CAMEL-10041
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
> Fix For: 2.18.0
>
>
> Just as we generate for component options, we could do this for data formats 
> as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CAMEL-10002) camel-netty4 - Upgrade to Netty 4.1.x

2016-06-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324056#comment-15324056
 ] 

ASF GitHub Bot commented on CAMEL-10002:


Github user asfgit closed the pull request at:

https://github.com/apache/camel/pull/1022


> camel-netty4 - Upgrade to Netty 4.1.x
> -
>
> Key: CAMEL-10002
> URL: https://issues.apache.org/jira/browse/CAMEL-10002
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-netty4, camel-netty4-http
>Reporter: Claus Ibsen
>Assignee: Arno Noordover
> Fix For: 2.18.0
>
>
> We should upgrade to netty 4.1.x



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (CAMEL-10041) camel-spring-boot - Add data format options as type-safe configuration properties

2016-06-10 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen reassigned CAMEL-10041:
---

Assignee: Claus Ibsen

> camel-spring-boot - Add data format options as type-safe configuration 
> properties
> -
>
> Key: CAMEL-10041
> URL: https://issues.apache.org/jira/browse/CAMEL-10041
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>
> Just as we generate for component options, we could do this for data formats 
> as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CAMEL-10002) camel-netty4 - Upgrade to Netty 4.1.x

2016-06-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324035#comment-15324035
 ] 

ASF GitHub Bot commented on CAMEL-10002:


GitHub user anoordover opened a pull request:

https://github.com/apache/camel/pull/1022

removed netty41-version placeholder

As requested for CAMEL-10002.
Removed netty41-version placeholder

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anoordover/camel 
RemoveNetty41_versionPlaceholder

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1022.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1022


commit e59d3d7b22e480336f64b3e9827e131182754bf6
Author: Arno Noordover 
Date:   2016-06-10T07:40:30Z

removed netty41-version placeholder




> camel-netty4 - Upgrade to Netty 4.1.x
> -
>
> Key: CAMEL-10002
> URL: https://issues.apache.org/jira/browse/CAMEL-10002
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-netty4, camel-netty4-http
>Reporter: Claus Ibsen
>Assignee: Arno Noordover
> Fix For: 2.18.0
>
>
> We should upgrade to netty 4.1.x



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CAMEL-10041) camel-spring-boot - Add data format options as type-safe configuration properties

2016-06-10 Thread Claus Ibsen (JIRA) 
Claus Ibsen created CAMEL-10041:
---

 Summary: camel-spring-boot - Add data format options as type-safe 
configuration properties
 Key: CAMEL-10041
 URL: https://issues.apache.org/jira/browse/CAMEL-10041
 Project: Camel
  Issue Type: Improvement
  Components: camel-spring-boot
Reporter: Claus Ibsen


Just as we generate for component options, we could do this for data formats as 
well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (CAMEL-10002) camel-netty4 - Upgrade to Netty 4.1.x

2016-06-10 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-10002.
-
Resolution: Fixed

> camel-netty4 - Upgrade to Netty 4.1.x
> -
>
> Key: CAMEL-10002
> URL: https://issues.apache.org/jira/browse/CAMEL-10002
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-netty4, camel-netty4-http
>Reporter: Claus Ibsen
>Assignee: Arno Noordover
> Fix For: 2.18.0
>
>
> We should upgrade to netty 4.1.x



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CAMEL-10002) camel-netty4 - Upgrade to Netty 4.1.x

2016-06-10 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-10002:

Assignee: Arno Noordover

> camel-netty4 - Upgrade to Netty 4.1.x
> -
>
> Key: CAMEL-10002
> URL: https://issues.apache.org/jira/browse/CAMEL-10002
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-netty4, camel-netty4-http
>Reporter: Claus Ibsen
>Assignee: Arno Noordover
> Fix For: 2.18.0
>
>
> We should upgrade to netty 4.1.x



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CAMEL-10040) camel-ahc - Upgrade AHC client to 2.x

2016-06-10 Thread Claus Ibsen (JIRA) 
Claus Ibsen created CAMEL-10040:
---

 Summary: camel-ahc - Upgrade AHC client to 2.x
 Key: CAMEL-10040
 URL: https://issues.apache.org/jira/browse/CAMEL-10040
 Project: Camel
  Issue Type: Improvement
  Components: camel-ahc
Reporter: Claus Ibsen
 Fix For: 2.18.0


We are using the older 1.9.x version today.

There is a newer 2.0x that has changed maven coord to 
org.asynchttpclient/async-http-client





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CAMEL-10002) camel-netty4 - Upgrade to Netty 4.1.x

2016-06-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15324023#comment-15324023
 ] 

ASF GitHub Bot commented on CAMEL-10002:


Github user anoordover closed the pull request at:

https://github.com/apache/camel/pull/1019


> camel-netty4 - Upgrade to Netty 4.1.x
> -
>
> Key: CAMEL-10002
> URL: https://issues.apache.org/jira/browse/CAMEL-10002
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-netty4, camel-netty4-http
>Reporter: Claus Ibsen
> Fix For: 2.18.0
>
>
> We should upgrade to netty 4.1.x



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (CAMEL-10036) Dynamicaly Loaded XML Rests Bind to all RestConfigurations

2016-06-10 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-10036.
-
   Resolution: Fixed
Fix Version/s: 2.17.2

Thanks for the code suggestion

> Dynamicaly Loaded XML Rests Bind to all RestConfigurations
> --
>
> Key: CAMEL-10036
> URL: https://issues.apache.org/jira/browse/CAMEL-10036
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.17.1
>Reporter: Jay mann
>Assignee: Claus Ibsen
>Priority: Minor
> Fix For: 2.17.2, 2.18.0
>
>
> When dynamically loading a Rests xml, you need to call:
> {code}
> xmlDef.asRouteDefinition(camelContext); 
> {code}
> to created the routes, but it creates routes for every RestConfiguration in 
> the camelContext.  This can result in duplicate route errors. 
> We should also be able to choose which RestConfiguration to bind to.  Can we 
> get the following Method added to org.camel.model.rest.RestDefinition:
> {code}
> public List asRouteDefinition(CamelContext camelContext, 
> RestConfiguration restConfig) { 
> // sanity check this rest definition do not have duplicates 
> validateUniquePaths(); 
> List answer = new ArrayList(); 
> 
> addRouteDefinition(camelContext, answer, restConfig.getComponent()); 
> 
> return answer; 
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (CAMEL-10036) Dynamicaly Loaded XML Rests Bind to all RestConfigurations

2016-06-10 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen reassigned CAMEL-10036:
---

Assignee: Claus Ibsen

> Dynamicaly Loaded XML Rests Bind to all RestConfigurations
> --
>
> Key: CAMEL-10036
> URL: https://issues.apache.org/jira/browse/CAMEL-10036
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.17.1
>Reporter: Jay mann
>Assignee: Claus Ibsen
>Priority: Minor
> Fix For: 2.18.0
>
>
> When dynamically loading a Rests xml, you need to call:
> {code}
> xmlDef.asRouteDefinition(camelContext); 
> {code}
> to created the routes, but it creates routes for every RestConfiguration in 
> the camelContext.  This can result in duplicate route errors. 
> We should also be able to choose which RestConfiguration to bind to.  Can we 
> get the following Method added to org.camel.model.rest.RestDefinition:
> {code}
> public List asRouteDefinition(CamelContext camelContext, 
> RestConfiguration restConfig) { 
> // sanity check this rest definition do not have duplicates 
> validateUniquePaths(); 
> List answer = new ArrayList(); 
> 
> addRouteDefinition(camelContext, answer, restConfig.getComponent()); 
> 
> return answer; 
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CAMEL-10036) Dynamicaly Loaded XML Rests Bind to all RestConfigurations

2016-06-10 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-10036:

Issue Type: Improvement  (was: Bug)

> Dynamicaly Loaded XML Rests Bind to all RestConfigurations
> --
>
> Key: CAMEL-10036
> URL: https://issues.apache.org/jira/browse/CAMEL-10036
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.17.1
>Reporter: Jay mann
>Priority: Minor
> Fix For: 2.18.0
>
>
> When dynamically loading a Rests xml, you need to call:
> {code}
> xmlDef.asRouteDefinition(camelContext); 
> {code}
> to created the routes, but it creates routes for every RestConfiguration in 
> the camelContext.  This can result in duplicate route errors. 
> We should also be able to choose which RestConfiguration to bind to.  Can we 
> get the following Method added to org.camel.model.rest.RestDefinition:
> {code}
> public List asRouteDefinition(CamelContext camelContext, 
> RestConfiguration restConfig) { 
> // sanity check this rest definition do not have duplicates 
> validateUniquePaths(); 
> List answer = new ArrayList(); 
> 
> addRouteDefinition(camelContext, answer, restConfig.getComponent()); 
> 
> return answer; 
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (CAMEL-10036) Dynamicaly Loaded XML Rests Bind to all RestConfigurations

2016-06-10 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-10036:

Fix Version/s: 2.18.0

> Dynamicaly Loaded XML Rests Bind to all RestConfigurations
> --
>
> Key: CAMEL-10036
> URL: https://issues.apache.org/jira/browse/CAMEL-10036
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.17.1
>Reporter: Jay mann
>Priority: Minor
> Fix For: 2.18.0
>
>
> When dynamically loading a Rests xml, you need to call:
> {code}
> xmlDef.asRouteDefinition(camelContext); 
> {code}
> to created the routes, but it creates routes for every RestConfiguration in 
> the camelContext.  This can result in duplicate route errors. 
> We should also be able to choose which RestConfiguration to bind to.  Can we 
> get the following Method added to org.camel.model.rest.RestDefinition:
> {code}
> public List asRouteDefinition(CamelContext camelContext, 
> RestConfiguration restConfig) { 
> // sanity check this rest definition do not have duplicates 
> validateUniquePaths(); 
> List answer = new ArrayList(); 
> 
> addRouteDefinition(camelContext, answer, restConfig.getComponent()); 
> 
> return answer; 
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (CAMEL-10039) LinkedIn broke login in LinnkedIn component by adding a redundant reference to the callback url

2016-06-10 Thread Dhiraj Bokde (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-10039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dhiraj Bokde resolved CAMEL-10039.
--
Resolution: Fixed

Fixed on master with commit 
https://github.com/apache/camel/commit/fd57cfcabcb93e64d3a51737b470faf32de1404e 
and cherry-picked onto camel-2.17.x branch

> LinkedIn broke login in LinnkedIn component by adding a redundant reference 
> to the callback url
> ---
>
> Key: CAMEL-10039
> URL: https://issues.apache.org/jira/browse/CAMEL-10039
> Project: Camel
>  Issue Type: Bug
>Affects Versions: 2.17.1
>Reporter: Dhiraj Bokde
>Assignee: Dhiraj Bokde
>  Labels: camel-linkedin
> Fix For: 2.17.2, 2.18.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (CAMEL-10039) LinkedIn broke login in LinnkedIn component by adding a redundant reference to the callback url

2016-06-10 Thread Dhiraj Bokde (JIRA) 
Dhiraj Bokde created CAMEL-10039:


 Summary: LinkedIn broke login in LinnkedIn component by adding a 
redundant reference to the callback url
 Key: CAMEL-10039
 URL: https://issues.apache.org/jira/browse/CAMEL-10039
 Project: Camel
  Issue Type: Bug
Affects Versions: 2.17.1
Reporter: Dhiraj Bokde
Assignee: Dhiraj Bokde
 Fix For: 2.17.2, 2.18.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)