[jira] [Commented] (CAMEL-11332) Create a new camel-thrift data format

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035245#comment-16035245
 ] 

ASF GitHub Bot commented on CAMEL-11332:


Github user dmvolod closed the pull request at:

https://github.com/apache/camel/pull/1736


> Create a new camel-thrift data format
> -
>
> Key: CAMEL-11332
> URL: https://issues.apache.org/jira/browse/CAMEL-11332
> Project: Camel
>  Issue Type: Sub-task
>Reporter: Dmitry Volodin
>Assignee: Dmitry Volodin
>  Labels: thrift
> Fix For: 2.20.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Work started] (CAMEL-11333) Create a new camel-thrift RPC component

[Dmitry Volodin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on CAMEL-11333 started by Dmitry Volodin.
--
> Create a new camel-thrift RPC component
> ---
>
> Key: CAMEL-11333
> URL: https://issues.apache.org/jira/browse/CAMEL-11333
> Project: Camel
>  Issue Type: Sub-task
>Reporter: Dmitry Volodin
>Assignee: Dmitry Volodin
>  Labels: rpc, thrift
> Fix For: 2.20.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-11332) Create a new camel-thrift data format

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034701#comment-16034701
 ] 

ASF GitHub Bot commented on CAMEL-11332:


GitHub user dmvolod opened a pull request:

https://github.com/apache/camel/pull/1736

CAMEL-11332: Add missing karaf and springboot tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dmvolod/camel CAMEL-11332

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1736


commit 273a5fd770bc9ac81c7b1c40cd288406e9c4240f
Author: Dmitry Volodin 
Date:   2017-06-02T13:38:37Z

CAMEL-11332: Add missing karaf and springboot tests




> Create a new camel-thrift data format
> -
>
> Key: CAMEL-11332
> URL: https://issues.apache.org/jira/browse/CAMEL-11332
> Project: Camel
>  Issue Type: Sub-task
>Reporter: Dmitry Volodin
>Assignee: Dmitry Volodin
>  Labels: thrift
> Fix For: 2.20.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Work started] (CAMEL-11373) Create a Camel Twilio component

[Tadayoshi Sato (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on CAMEL-11373 started by Tadayoshi Sato.
--
> Create a Camel Twilio component
> ---
>
> Key: CAMEL-11373
> URL: https://issues.apache.org/jira/browse/CAMEL-11373
> Project: Camel
>  Issue Type: New Feature
>Reporter: Tadayoshi Sato
>Assignee: Tadayoshi Sato
> Fix For: 2.20.0
>
>
> Create a Camel component for [twilio.com|https://www.twilio.com/]. Twilio 
> provides an official MIT-based [Java 
> SDK|https://github.com/twilio/twilio-java].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-11373) Create a Camel Twilio component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034635#comment-16034635
 ] 

ASF GitHub Bot commented on CAMEL-11373:


Github user tadayosi closed the pull request at:

https://github.com/apache/camel/pull/1735


> Create a Camel Twilio component
> ---
>
> Key: CAMEL-11373
> URL: https://issues.apache.org/jira/browse/CAMEL-11373
> Project: Camel
>  Issue Type: New Feature
>Reporter: Tadayoshi Sato
>Assignee: Tadayoshi Sato
> Fix For: 2.20.0
>
>
> Create a Camel component for [twilio.com|https://www.twilio.com/]. Twilio 
> provides an official MIT-based [Java 
> SDK|https://github.com/twilio/twilio-java].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (CAMEL-11380) Optimise - Allow to turn DataType on or off on Message

[Claus Ibsen (JIRA)]

Claus Ibsen created CAMEL-11380:
---

 Summary: Optimise - Allow to turn DataType on or off on Message
 Key: CAMEL-11380
 URL: https://issues.apache.org/jira/browse/CAMEL-11380
 Project: Camel
  Issue Type: Improvement
  Components: camel-core
Reporter: Claus Ibsen
Priority: Minor
 Fix For: 2.20.0


We can optimise to not create DataType instances on the Message instance if its 
not really needed.

Its part of the new route contract where it is used to know the data type and 
then do contract enforcement and validation/conversion if needed.

But for regular use-cases it has not so much value ... yet.

So we should maybe turn it off by default, and allow to turn it on|off, and 
then turn it on if you use contract enforcement.





--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-11373) Create a Camel Twilio component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034573#comment-16034573
 ] 

ASF GitHub Bot commented on CAMEL-11373:


GitHub user tadayosi opened a pull request:

https://github.com/apache/camel/pull/1735

CAMEL-11373: Add camel-twilio Karaf feature and update doc

https://issues.apache.org/jira/browse/CAMEL-11373

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tadayosi/camel CAMEL-11373_2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1735.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1735


commit d2d0ebc1feaeeb9ac925dd8cb9ace2009b1104c8
Author: Tadayoshi Sato 
Date:   2017-06-02T11:54:03Z

CAMEL-11373: Add camel-twilio Karaf feature and update doc




> Create a Camel Twilio component
> ---
>
> Key: CAMEL-11373
> URL: https://issues.apache.org/jira/browse/CAMEL-11373
> Project: Camel
>  Issue Type: New Feature
>Reporter: Tadayoshi Sato
>Assignee: Tadayoshi Sato
> Fix For: 2.20.0
>
>
> Create a Camel component for [twilio.com|https://www.twilio.com/]. Twilio 
> provides an official MIT-based [Java 
> SDK|https://github.com/twilio/twilio-java].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (CAMEL-11379) Optimise - core type converters to be invoked faster

[Claus Ibsen (JIRA)]

Claus Ibsen created CAMEL-11379:
---

 Summary: Optimise - core type converters to be invoked faster 
 Key: CAMEL-11379
 URL: https://issues.apache.org/jira/browse/CAMEL-11379
 Project: Camel
  Issue Type: Improvement
  Components: camel-core
Reporter: Claus Ibsen
 Fix For: 2.20.0


Instead of adding the core type converters in a bit of dynamic way, we can 
hardcode how they are registered and invoked which will by pass some of the 
overhead that dynamic discovered type converters have.

The benefit is that these core type converters are used a lot more and 
therefore we can gain some memory footprint and performance by doing so.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (CAMEL-11332) Create a new camel-thrift data format

[Dmitry Volodin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-11332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Volodin resolved CAMEL-11332.

Resolution: Fixed

> Create a new camel-thrift data format
> -
>
> Key: CAMEL-11332
> URL: https://issues.apache.org/jira/browse/CAMEL-11332
> Project: Camel
>  Issue Type: Sub-task
>Reporter: Dmitry Volodin
>Assignee: Dmitry Volodin
>  Labels: thrift
> Fix For: 2.20.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-11332) Create a new camel-thrift data format

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034537#comment-16034537
 ] 

ASF GitHub Bot commented on CAMEL-11332:


Github user dmvolod closed the pull request at:

https://github.com/apache/camel/pull/1729


> Create a new camel-thrift data format
> -
>
> Key: CAMEL-11332
> URL: https://issues.apache.org/jira/browse/CAMEL-11332
> Project: Camel
>  Issue Type: Sub-task
>Reporter: Dmitry Volodin
>Assignee: Dmitry Volodin
>  Labels: thrift
> Fix For: 2.20.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (CAMEL-11369) camel-spring-boot-starter generator paste incorrect default value

[Dmitry Volodin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Volodin resolved CAMEL-11369.

Resolution: Fixed

> camel-spring-boot-starter generator paste incorrect default value
> -
>
> Key: CAMEL-11369
> URL: https://issues.apache.org/jira/browse/CAMEL-11369
> Project: Camel
>  Issue Type: Bug
>  Components: camel-spring-boot-starters, tooling
>Affects Versions: 2.20.0
>Reporter: Dmitry Volodin
>Assignee: Dmitry Volodin
> Fix For: 2.20.0
>
>
> I've created a new data component and submit it via PR
> https://github.com/apache/camel/pull/1729
> The spring-bootstarter *DataFormatConfiguration class contains incorrectly 
> defined default value:
> private String contentTypeFormat = String.binary;



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-11369) camel-spring-boot-starter generator paste incorrect default value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034499#comment-16034499
 ] 

ASF GitHub Bot commented on CAMEL-11369:


Github user dmvolod closed the pull request at:

https://github.com/apache/camel/pull/1734


> camel-spring-boot-starter generator paste incorrect default value
> -
>
> Key: CAMEL-11369
> URL: https://issues.apache.org/jira/browse/CAMEL-11369
> Project: Camel
>  Issue Type: Bug
>  Components: camel-spring-boot-starters, tooling
>Affects Versions: 2.20.0
>Reporter: Dmitry Volodin
>Assignee: Dmitry Volodin
> Fix For: 2.20.0
>
>
> I've created a new data component and submit it via PR
> https://github.com/apache/camel/pull/1729
> The spring-bootstarter *DataFormatConfiguration class contains incorrectly 
> defined default value:
> private String contentTypeFormat = String.binary;



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Issue Comment Deleted] (CAMEL-11369) camel-spring-boot-starter generator paste incorrect default value

[Dmitry Volodin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Volodin updated CAMEL-11369:
---
Comment: was deleted

(was: No, sorry, I have no time.)

> camel-spring-boot-starter generator paste incorrect default value
> -
>
> Key: CAMEL-11369
> URL: https://issues.apache.org/jira/browse/CAMEL-11369
> Project: Camel
>  Issue Type: Bug
>  Components: camel-spring-boot-starters, tooling
>Affects Versions: 2.20.0
>Reporter: Dmitry Volodin
>Assignee: Dmitry Volodin
> Fix For: 2.20.0
>
>
> I've created a new data component and submit it via PR
> https://github.com/apache/camel/pull/1729
> The spring-bootstarter *DataFormatConfiguration class contains incorrectly 
> defined default value:
> private String contentTypeFormat = String.binary;



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-11369) camel-spring-boot-starter generator paste incorrect default value

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034294#comment-16034294
 ] 

ASF GitHub Bot commented on CAMEL-11369:


GitHub user dmvolod opened a pull request:

https://github.com/apache/camel/pull/1734

CAMEL-11369: camel-spring-boot-starter generator paste incorrect default 
value

@davsclaus, the problem was in type comparison, not in enum processing at 
all
Other code looks like working fine, but need to be reviewed for better 
understanding, join reusable methods, common type comparison and using 
constants (classes) instead of string values 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dmvolod/camel CAMEL-11369

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1734


commit 838676fe6a92756a666d2907ae08cfaa75abd6df
Author: Dmitry Volodin 
Date:   2017-06-02T07:42:40Z

CAMEL-11369: camel-spring-boot-starter generator paste incorrect default
value




> camel-spring-boot-starter generator paste incorrect default value
> -
>
> Key: CAMEL-11369
> URL: https://issues.apache.org/jira/browse/CAMEL-11369
> Project: Camel
>  Issue Type: Bug
>  Components: camel-spring-boot-starters, tooling
>Affects Versions: 2.20.0
>Reporter: Dmitry Volodin
>Assignee: Dmitry Volodin
> Fix For: 2.20.0
>
>
> I've created a new data component and submit it via PR
> https://github.com/apache/camel/pull/1729
> The spring-bootstarter *DataFormatConfiguration class contains incorrectly 
> defined default value:
> private String contentTypeFormat = String.binary;



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-11373) Create a Camel Twilio component

[Tadayoshi Sato (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034269#comment-16034269
 ] 

Tadayoshi Sato commented on CAMEL-11373:


Good catch. I'll do them before closing it.

> Create a Camel Twilio component
> ---
>
> Key: CAMEL-11373
> URL: https://issues.apache.org/jira/browse/CAMEL-11373
> Project: Camel
>  Issue Type: New Feature
>Reporter: Tadayoshi Sato
>Assignee: Tadayoshi Sato
> Fix For: 2.20.0
>
>
> Create a Camel component for [twilio.com|https://www.twilio.com/]. Twilio 
> provides an official MIT-based [Java 
> SDK|https://github.com/twilio/twilio-java].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-11373) Create a Camel Twilio component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034272#comment-16034272
 ] 

ASF GitHub Bot commented on CAMEL-11373:


Github user tadayosi closed the pull request at:

https://github.com/apache/camel/pull/1732


> Create a Camel Twilio component
> ---
>
> Key: CAMEL-11373
> URL: https://issues.apache.org/jira/browse/CAMEL-11373
> Project: Camel
>  Issue Type: New Feature
>Reporter: Tadayoshi Sato
>Assignee: Tadayoshi Sato
> Fix For: 2.20.0
>
>
> Create a Camel component for [twilio.com|https://www.twilio.com/]. Twilio 
> provides an official MIT-based [Java 
> SDK|https://github.com/twilio/twilio-java].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-11373) Create a Camel Twilio component

[Claus Ibsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034268#comment-16034268
 ] 

Claus Ibsen commented on CAMEL-11373:
-

And can you add camel-twillio to the release notes, under new components
http://camel.apache.org/camel-2200-release.html

> Create a Camel Twilio component
> ---
>
> Key: CAMEL-11373
> URL: https://issues.apache.org/jira/browse/CAMEL-11373
> Project: Camel
>  Issue Type: New Feature
>Reporter: Tadayoshi Sato
>Assignee: Tadayoshi Sato
> Fix For: 2.20.0
>
>
> Create a Camel component for [twilio.com|https://www.twilio.com/]. Twilio 
> provides an official MIT-based [Java 
> SDK|https://github.com/twilio/twilio-java].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (CAMEL-11178) Default method on interface is invisible during Camel Simple evaluation

[Claus Ibsen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-11178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-11178.
-
Resolution: Fixed
  Assignee: Claus Ibsen

> Default method on interface is invisible during Camel Simple evaluation
> ---
>
> Key: CAMEL-11178
> URL: https://issues.apache.org/jira/browse/CAMEL-11178
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.16.1
>Reporter: Anton Sulim
>Assignee: Claus Ibsen
> Fix For: 2.20.0
>
>
> Issue can be reproduced with below unit test, I have not found it in tracker. 
> Essence: interface A has default method, interface B extends A, default 
> method is invisible during Simple language evaluation. 
> {code:java}
> import org.apache.camel.CamelContext;
> import org.apache.camel.Exchange;
> import org.apache.camel.builder.RouteBuilder;
> import org.apache.camel.impl.DefaultCamelContext;
> import org.apache.camel.impl.DefaultExchange;
> import org.junit.Assert;
> import org.junit.Test;
> public class DefaultMethodIsInvisibleTest {
> public static interface A {
> public default String defaultMethod() {
> return "default method result";
> }
> }
> public static interface B extends A {
> }
> @Test
> public void camelSimpleDoesNotSeeDefaultMethod() throws Exception {
> CamelContext context = new DefaultCamelContext();
> context.addRoutes(new RouteBuilder() {
> public void configure() {
> 
> from("direct:camelSimpleDoesNotSeeDefaultMethod").script().simple("${exchangeProperty.myObject.defaultMethod}");
> }
> });
> context.start();
> Exchange incomingExchange = new DefaultExchange(context);
> incomingExchange.setProperty("myObject", new B() {
> });
> Exchange result = 
> context.createProducerTemplate().send("direct:camelSimpleDoesNotSeeDefaultMethod",
>  incomingExchange);
> Assert.assertNull(result.getException());
> }
> }
> {code}
> Stacktrace:
> {code}
> Caused by: org.apache.camel.language.bean.RuntimeBeanExpressionException: 
> Failed to invoke method: defaultMethod on null due to: 
> org.apache.camel.component.bean.MethodNotFoundException: Method with name: 
> defaultMethod not found on bean: 
> com.ubs.wma.gfi.tradersbook.subscriber.DefaultMethodIsInvisibleTest$2@5dafbe45
>  of type: 
> com.ubs.wma.gfi.tradersbook.subscriber.DefaultMethodIsInvisibleTest$2. 
> Exchange[][Message: [Body is null]]
> at 
> org.apache.camel.language.bean.BeanExpression$OgnlInvokeProcessor.process(BeanExpression.java:290)
> at 
> org.apache.camel.language.bean.BeanExpression.evaluate(BeanExpression.java:114)
> ... 46 common frames omitted
> Caused by: org.apache.camel.component.bean.MethodNotFoundException: Method 
> with name: defaultMethod not found on bean: 
> com.ubs.wma.gfi.tradersbook.subscriber.DefaultMethodIsInvisibleTest$2@5dafbe45
>  of type: 
> com.ubs.wma.gfi.tradersbook.subscriber.DefaultMethodIsInvisibleTest$2. 
> Exchange[][Message: [Body is null]]
> at 
> org.apache.camel.component.bean.BeanInfo.createInvocation(BeanInfo.java:269)
> at 
> org.apache.camel.component.bean.BeanInfo.createInvocation(BeanInfo.java:183)
> at 
> org.apache.camel.component.bean.BeanProcessor.process(BeanProcessor.java:159)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (CAMEL-11373) Create a Camel Twilio component

[Claus Ibsen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CAMEL-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-11373:

Fix Version/s: 2.20.0

> Create a Camel Twilio component
> ---
>
> Key: CAMEL-11373
> URL: https://issues.apache.org/jira/browse/CAMEL-11373
> Project: Camel
>  Issue Type: New Feature
>Reporter: Tadayoshi Sato
>Assignee: Tadayoshi Sato
> Fix For: 2.20.0
>
>
> Create a Camel component for [twilio.com|https://www.twilio.com/]. Twilio 
> provides an official MIT-based [Java 
> SDK|https://github.com/twilio/twilio-java].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-11373) Create a Camel Twilio component

[Claus Ibsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034248#comment-16034248
 ] 

Claus Ibsen commented on CAMEL-11373:
-

Thanks merging the PR now.

I wonder if we can add it to camel-twillio in the karaf features file also

> Create a Camel Twilio component
> ---
>
> Key: CAMEL-11373
> URL: https://issues.apache.org/jira/browse/CAMEL-11373
> Project: Camel
>  Issue Type: New Feature
>Reporter: Tadayoshi Sato
>Assignee: Tadayoshi Sato
> Fix For: 2.20.0
>
>
> Create a Camel component for [twilio.com|https://www.twilio.com/]. Twilio 
> provides an official MIT-based [Java 
> SDK|https://github.com/twilio/twilio-java].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)