[jira] [Commented] (CAMEL-11609) camel-univocity-parsers: marshaller not thread safe

2017-07-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103904#comment-16103904
 ] 

ASF GitHub Bot commented on CAMEL-11609:


GitHub user onders86 opened a pull request:

https://github.com/apache/camel/pull/1855

CAMEL-11609:thread-safety if headers get modified on the fly



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/onders86/camel CAMEL-11609

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1855.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1855


commit d6ae2bfd0ba2bb7826e7b342094406a3daf4a85b
Author: onders86 
Date:   2017-07-27T20:54:18Z

CAMEL-11609:thread-safety if headers get modified on the fly




> camel-univocity-parsers: marshaller not thread safe
> ---
>
> Key: CAMEL-11609
> URL: https://issues.apache.org/jira/browse/CAMEL-11609
> Project: Camel
>  Issue Type: Bug
>  Components: camel-csv
>Affects Versions: 2.19.1
>Reporter: Daniel Baldes
>
> org.apache.camel.dataformat.univocity.Marshaller.java is not thread safe.
> When this.adaptheaders is true, this.headers is modified in the wirteRow() 
> method. This can lead to ConcurrentModificationExceptions (see below) and 
> jumbled headers, occasionally.
> I use a {{UnivocityCsvDataFormat}} for marshalling CSV in a route which is 
> called in parallel. The DataFormat creates a Marshaller with adaptheaders == 
> true when headers are not specified in the format.
> {code}java.util.ConcurrentModificationException: null
> at 
> java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
> at 
> java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:742)
> at 
> org.apache.camel.dataformat.univocity.Marshaller.writeRow(Marshaller.java:95)
> at 
> org.apache.camel.dataformat.univocity.Marshaller.marshal(Marshaller.java:67)
> at 
> org.apache.camel.dataformat.univocity.AbstractUniVocityDataFormat.marshal(AbstractUniVocityDataFormat.java:94)
> at 
> org.apache.camel.processor.MarshalProcessor.process(MarshalProcessor.java:69)
> at 
> org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)
> at 
> org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at org.apache.camel.processor.Pipeline.process(Pipeline.java:120)
> at org.apache.camel.processor.Pipeline.process(Pipeline.java:83)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at 
> org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:62)
> at 
> org.apache.camel.processor.SendDynamicProcessor$1.doInAsyncProducer(SendDynamicProcessor.java:124)
> at 
> org.apache.camel.impl.ProducerCache.doInAsyncProducer(ProducerCache.java:436)
> at 
> org.apache.camel.processor.SendDynamicProcessor.process(SendDynamicProcessor.java:119)
> at 
> org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at 
> org.apache.camel.processor.DelegateAsyncProcessor.process(DelegateAsyncProcessor.java:97)
> at 
> org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:137)
> at 
> org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:133)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11609) camel-univocity-parsers: marshaller not thread safe

2017-07-27 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/CAMEL-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103900#comment-16103900
 ] 

Önder Sezgin commented on CAMEL-11609:
--

As far as i can understand field matching is through the reconstruction of 
{{this.headers}}. so it is important part.
so my view currently, if you don't have frequently changing headers, it should 
not be problem. If it is to match the fields it seems lock on the resource 
getting updated seems to be a price to pay. in such sence providing a simple PR.

> camel-univocity-parsers: marshaller not thread safe
> ---
>
> Key: CAMEL-11609
> URL: https://issues.apache.org/jira/browse/CAMEL-11609
> Project: Camel
>  Issue Type: Bug
>  Components: camel-csv
>Affects Versions: 2.19.1
>Reporter: Daniel Baldes
>
> org.apache.camel.dataformat.univocity.Marshaller.java is not thread safe.
> When this.adaptheaders is true, this.headers is modified in the wirteRow() 
> method. This can lead to ConcurrentModificationExceptions (see below) and 
> jumbled headers, occasionally.
> I use a {{UnivocityCsvDataFormat}} for marshalling CSV in a route which is 
> called in parallel. The DataFormat creates a Marshaller with adaptheaders == 
> true when headers are not specified in the format.
> {code}java.util.ConcurrentModificationException: null
> at 
> java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
> at 
> java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:742)
> at 
> org.apache.camel.dataformat.univocity.Marshaller.writeRow(Marshaller.java:95)
> at 
> org.apache.camel.dataformat.univocity.Marshaller.marshal(Marshaller.java:67)
> at 
> org.apache.camel.dataformat.univocity.AbstractUniVocityDataFormat.marshal(AbstractUniVocityDataFormat.java:94)
> at 
> org.apache.camel.processor.MarshalProcessor.process(MarshalProcessor.java:69)
> at 
> org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)
> at 
> org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at org.apache.camel.processor.Pipeline.process(Pipeline.java:120)
> at org.apache.camel.processor.Pipeline.process(Pipeline.java:83)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at 
> org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:62)
> at 
> org.apache.camel.processor.SendDynamicProcessor$1.doInAsyncProducer(SendDynamicProcessor.java:124)
> at 
> org.apache.camel.impl.ProducerCache.doInAsyncProducer(ProducerCache.java:436)
> at 
> org.apache.camel.processor.SendDynamicProcessor.process(SendDynamicProcessor.java:119)
> at 
> org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at 
> org.apache.camel.processor.DelegateAsyncProcessor.process(DelegateAsyncProcessor.java:97)
> at 
> org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:137)
> at 
> org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:133)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (CAMEL-11611) Add a knownHosts option to the camel-ssh component

2017-07-27 Thread Daniel U. Thibault (JIRA) 
Daniel U. Thibault created CAMEL-11611:
--

 Summary: Add a knownHosts option to the camel-ssh component
 Key: CAMEL-11611
 URL: https://issues.apache.org/jira/browse/CAMEL-11611
 Project: Camel
  Issue Type: Improvement
  Components: camel-ssh
Affects Versions: Future
 Environment: Any.
Reporter: Daniel U. Thibault
Priority: Minor
 Fix For: Future


Currently, when one uses camel-ssh to connect to some server, one gets this 
message:

[sshd-SshClient[5be46f9d]-nio2-thread-1] WARN 
org.apache.sshd.client.keyverifier.AcceptAllServerKeyVerifier - Server at 
/: presented unverified EC key: ...

This is an annoyance that would readily be gotten rid of by adding a knownHosts 
option similar to certResource:

* name: knownHosts
* default value: null
* description: Path reference to a the list of known hosts public key 
certificates (typically ~/.ssh/known_hosts). Prefix path with classpath:, 
file:, or http:.

This value would be used by StaticServerKeyVerifier.java to avoid issuing the 
warning (as appropriate). com.jcraft.jsch.JSch uses this through its 
setKnownHosts method.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11473) camel-kafka - Use unique groupId by default

2017-07-27 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/CAMEL-11473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103298#comment-16103298
 ] 

Önder Sezgin commented on CAMEL-11473:
--

Not sure why PR is not accepted yet.

> camel-kafka - Use unique groupId by default
> ---
>
> Key: CAMEL-11473
> URL: https://issues.apache.org/jira/browse/CAMEL-11473
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-kafka
>Reporter: Jyrki Ruuskanen
>Priority: Minor
>
> In the spirit of providing useful defaults instead of error messages 
> camel-kafka consumer should generate a unique groupId if one is not given.
> This way {{from("kafka:host:9092?topic=test")}} consumers would behave in a 
> pub-sub manner, and {{from("kafka:host:9092?topic=test=something}} 
> consumers would behave like, well, like consumer groups on kafka do.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (CAMEL-11597) Adding support for setting authentication client properties for elasticsearch

2017-07-27 Thread Dmitry Volodin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Volodin reassigned CAMEL-11597:
--

Assignee: (was: Dmitry Volodin)

> Adding support for setting authentication client properties for elasticsearch
> -
>
> Key: CAMEL-11597
> URL: https://issues.apache.org/jira/browse/CAMEL-11597
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-elasticsearch5
>Affects Versions: 2.20.0
>Reporter: Flemming Harms
>Priority: Minor
>
> The current implementation does not allow to override the client instance or 
> setup client authentication.
> Adding following additional properties for support authentication
> {code:java}
> final Settings.Builder settings = Settings.builder()
>   .put("cluster.name", configuration.getClusterName())
>   .put("client.transport.ignore_cluster_name", false)
>   .put("client.transport.sniff", configuration.getClientTransportSniff())
>   .put("transport.ping_schedule", configuration.getPingSchedule())
>   .put("client.transport.ping_timeout", configuration.getPingTimeout())
>   .put("client.transport.sniff", configuration.getClientTransportSniff())
>   .put("xpack.security.transport.ssl.enabled", configuration.getEnabledSSL())
>   .put("request.headers.X-Found-Cluster", configuration.getClusterName());
>   if (configuration.getUser() != null && configuration.getPassword() != null) 
> {
>  settings.put("xpack.security.user", configuration.getUser() +":"+ 
> configuration.getPassword());
>}
>return settings.build();
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11597) Adding support for setting authentication client properties for elasticsearch

2017-07-27 Thread Flemming Harms (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103267#comment-16103267
 ] 

Flemming Harms commented on CAMEL-11597:


No, but I have a working branch.

I Just need to clear out a few things before I create the pull-request

> Adding support for setting authentication client properties for elasticsearch
> -
>
> Key: CAMEL-11597
> URL: https://issues.apache.org/jira/browse/CAMEL-11597
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-elasticsearch5
>Affects Versions: 2.20.0
>Reporter: Flemming Harms
>Assignee: Dmitry Volodin
>Priority: Minor
>
> The current implementation does not allow to override the client instance or 
> setup client authentication.
> Adding following additional properties for support authentication
> {code:java}
> final Settings.Builder settings = Settings.builder()
>   .put("cluster.name", configuration.getClusterName())
>   .put("client.transport.ignore_cluster_name", false)
>   .put("client.transport.sniff", configuration.getClientTransportSniff())
>   .put("transport.ping_schedule", configuration.getPingSchedule())
>   .put("client.transport.ping_timeout", configuration.getPingTimeout())
>   .put("client.transport.sniff", configuration.getClientTransportSniff())
>   .put("xpack.security.transport.ssl.enabled", configuration.getEnabledSSL())
>   .put("request.headers.X-Found-Cluster", configuration.getClusterName());
>   if (configuration.getUser() != null && configuration.getPassword() != null) 
> {
>  settings.put("xpack.security.user", configuration.getUser() +":"+ 
> configuration.getPassword());
>}
>return settings.build();
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (CAMEL-11597) Adding support for setting authentication client properties for elasticsearch

2017-07-27 Thread Dmitry Volodin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Volodin reassigned CAMEL-11597:
--

Assignee: Dmitry Volodin

> Adding support for setting authentication client properties for elasticsearch
> -
>
> Key: CAMEL-11597
> URL: https://issues.apache.org/jira/browse/CAMEL-11597
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-elasticsearch5
>Affects Versions: 2.20.0
>Reporter: Flemming Harms
>Assignee: Dmitry Volodin
>Priority: Minor
>
> The current implementation does not allow to override the client instance or 
> setup client authentication.
> Adding following additional properties for support authentication
> {code:java}
> final Settings.Builder settings = Settings.builder()
>   .put("cluster.name", configuration.getClusterName())
>   .put("client.transport.ignore_cluster_name", false)
>   .put("client.transport.sniff", configuration.getClientTransportSniff())
>   .put("transport.ping_schedule", configuration.getPingSchedule())
>   .put("client.transport.ping_timeout", configuration.getPingTimeout())
>   .put("client.transport.sniff", configuration.getClientTransportSniff())
>   .put("xpack.security.transport.ssl.enabled", configuration.getEnabledSSL())
>   .put("request.headers.X-Found-Cluster", configuration.getClusterName());
>   if (configuration.getUser() != null && configuration.getPassword() != null) 
> {
>  settings.put("xpack.security.user", configuration.getUser() +":"+ 
> configuration.getPassword());
>}
>return settings.build();
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (CAMEL-11610) UnsatisfiedDependencyException: Error creating bean with name 'openTracingEventNotifier'

2017-07-27 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-11610.
-
Resolution: Fixed

> UnsatisfiedDependencyException: Error creating bean with name 
> 'openTracingEventNotifier'
> 
>
> Key: CAMEL-11610
> URL: https://issues.apache.org/jira/browse/CAMEL-11610
> Project: Camel
>  Issue Type: Bug
>Affects Versions: 2.19.2, 2.20.0
>Reporter: Gary Brown
>Assignee: Claus Ibsen
> Fix For: 2.19.2, 2.20.0
>
>
> When testing the 2nd 2.19.2 release candidate, got the following when 
> starting up 'service1' in the camel-example-opentracing example. This service 
> started with no problems in the first release candidate, so not sure what has 
> changed - but from the initial messages it appears that something is still 
> being started up, i.e. "BeanCurrentlyInCreationException: Error creating bean 
> with name 'camelContext': Requested bean is currently in creation: Is there 
> an unresolvable circular reference?"
> {noformat}
> 2017-07-27 10:24:18.314  INFO 3829 --- [   main] 
> sample.camel.Service1Application : Starting Service1Application on 
> localhost.localdomain with PID 3829 
> (/home/gbrown/testing/apache/apache-camel-2.19.2/examples/camel-example-opentracing/service1/target/classes
>  started by gbrown in 
> /home/gbrown/testing/apache/apache-camel-2.19.2/examples/camel-example-opentracing/service1)
> 2017-07-27 10:24:18.316  INFO 3829 --- [   main] 
> sample.camel.Service1Application : No active profile set, falling 
> back to default profiles: default
> 2017-07-27 10:24:18.347  INFO 3829 --- [   main] 
> s.c.a.AnnotationConfigApplicationContext : Refreshing 
> org.springframework.context.annotation.AnnotationConfigApplicationContext@311592f:
>  startup date [Thu Jul 27 10:24:18 BST 2017]; root of context hierarchy
> 2017-07-27 10:24:19.098  WARN 3829 --- [   main] 
> s.c.a.AnnotationConfigApplicationContext : Exception encountered during 
> context initialization - cancelling refresh attempt: 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'cacheAutoConfigurationValidatorPostProcessor' 
> defined in class path resource 
> [org/apache/camel/component/http/springboot/HttpComponentSSLAutoConfiguration.class]:
>  Unsatisfied dependency expressed through method 
> 'cacheAutoConfigurationValidatorPostProcessor' parameter 0; nested exception 
> is org.springframework.beans.factory.BeanCreationException: Error creating 
> bean with name 'camelContext' defined in class path resource 
> [org/apache/camel/spring/boot/CamelAutoConfiguration.class]: Bean 
> instantiation via factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.camel.CamelContext]: Factory method 'camelContext' threw 
> exception; nested exception is 
> org.springframework.beans.factory.BeanCreationException: Error creating bean 
> with name 'rest-configuration' defined in class path resource 
> [org/apache/camel/model/rest/springboot/RestConfigurationDefinitionAutoConfiguration.class]:
>  Bean instantiation via factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.camel.spi.RestConfiguration]: Factory method 
> 'configureRestConfigurationDefinition' threw exception; nested exception is 
> java.lang.IllegalArgumentException: target must be specified
> Related cause: 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'openTracingEventNotifier' defined in 
> org.apache.camel.opentracing.starter.OpenTracingAutoConfiguration: 
> Unsatisfied dependency expressed through method 'openTracingEventNotifier' 
> parameter 0; nested exception is 
> org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
> creating bean with name 'camelContext': Requested bean is currently in 
> creation: Is there an unresolvable circular reference?
> 2017-07-27 10:24:19.102 ERROR 3829 --- [   main] 
> o.s.b.f.s.DefaultListableBeanFactory : Destroy method on bean with name 
> 'org.springframework.boot.autoconfigure.internalCachingMetadataReaderFactory' 
> threw an exception
> java.lang.IllegalStateException: ApplicationEventMulticaster not initialized 
> - call 'refresh' before multicasting events via the context: 
> org.springframework.context.annotation.AnnotationConfigApplicationContext@311592f:
>  startup date [Thu Jul 27 10:24:18 BST 2017]; root of context hierarchy
>   at 
> org.springframework.context.support.AbstractApplicationContext.getApplicationEventMulticaster(AbstractApplicationContext.java:414)
>

[jira] [Updated] (CAMEL-11610) UnsatisfiedDependencyException: Error creating bean with name 'openTracingEventNotifier'

2017-07-27 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-11610:

Affects Version/s: 2.20.0
   2.19.2

> UnsatisfiedDependencyException: Error creating bean with name 
> 'openTracingEventNotifier'
> 
>
> Key: CAMEL-11610
> URL: https://issues.apache.org/jira/browse/CAMEL-11610
> Project: Camel
>  Issue Type: Bug
>Affects Versions: 2.19.2, 2.20.0
>Reporter: Gary Brown
>Assignee: Claus Ibsen
> Fix For: 2.19.2, 2.20.0
>
>
> When testing the 2nd 2.19.2 release candidate, got the following when 
> starting up 'service1' in the camel-example-opentracing example. This service 
> started with no problems in the first release candidate, so not sure what has 
> changed - but from the initial messages it appears that something is still 
> being started up, i.e. "BeanCurrentlyInCreationException: Error creating bean 
> with name 'camelContext': Requested bean is currently in creation: Is there 
> an unresolvable circular reference?"
> {noformat}
> 2017-07-27 10:24:18.314  INFO 3829 --- [   main] 
> sample.camel.Service1Application : Starting Service1Application on 
> localhost.localdomain with PID 3829 
> (/home/gbrown/testing/apache/apache-camel-2.19.2/examples/camel-example-opentracing/service1/target/classes
>  started by gbrown in 
> /home/gbrown/testing/apache/apache-camel-2.19.2/examples/camel-example-opentracing/service1)
> 2017-07-27 10:24:18.316  INFO 3829 --- [   main] 
> sample.camel.Service1Application : No active profile set, falling 
> back to default profiles: default
> 2017-07-27 10:24:18.347  INFO 3829 --- [   main] 
> s.c.a.AnnotationConfigApplicationContext : Refreshing 
> org.springframework.context.annotation.AnnotationConfigApplicationContext@311592f:
>  startup date [Thu Jul 27 10:24:18 BST 2017]; root of context hierarchy
> 2017-07-27 10:24:19.098  WARN 3829 --- [   main] 
> s.c.a.AnnotationConfigApplicationContext : Exception encountered during 
> context initialization - cancelling refresh attempt: 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'cacheAutoConfigurationValidatorPostProcessor' 
> defined in class path resource 
> [org/apache/camel/component/http/springboot/HttpComponentSSLAutoConfiguration.class]:
>  Unsatisfied dependency expressed through method 
> 'cacheAutoConfigurationValidatorPostProcessor' parameter 0; nested exception 
> is org.springframework.beans.factory.BeanCreationException: Error creating 
> bean with name 'camelContext' defined in class path resource 
> [org/apache/camel/spring/boot/CamelAutoConfiguration.class]: Bean 
> instantiation via factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.camel.CamelContext]: Factory method 'camelContext' threw 
> exception; nested exception is 
> org.springframework.beans.factory.BeanCreationException: Error creating bean 
> with name 'rest-configuration' defined in class path resource 
> [org/apache/camel/model/rest/springboot/RestConfigurationDefinitionAutoConfiguration.class]:
>  Bean instantiation via factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.camel.spi.RestConfiguration]: Factory method 
> 'configureRestConfigurationDefinition' threw exception; nested exception is 
> java.lang.IllegalArgumentException: target must be specified
> Related cause: 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'openTracingEventNotifier' defined in 
> org.apache.camel.opentracing.starter.OpenTracingAutoConfiguration: 
> Unsatisfied dependency expressed through method 'openTracingEventNotifier' 
> parameter 0; nested exception is 
> org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
> creating bean with name 'camelContext': Requested bean is currently in 
> creation: Is there an unresolvable circular reference?
> 2017-07-27 10:24:19.102 ERROR 3829 --- [   main] 
> o.s.b.f.s.DefaultListableBeanFactory : Destroy method on bean with name 
> 'org.springframework.boot.autoconfigure.internalCachingMetadataReaderFactory' 
> threw an exception
> java.lang.IllegalStateException: ApplicationEventMulticaster not initialized 
> - call 'refresh' before multicasting events via the context: 
> org.springframework.context.annotation.AnnotationConfigApplicationContext@311592f:
>  startup date [Thu Jul 27 10:24:18 BST 2017]; root of context hierarchy
>   at 
>

[jira] [Updated] (CAMEL-11610) UnsatisfiedDependencyException: Error creating bean with name 'openTracingEventNotifier'

2017-07-27 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-11610:

Fix Version/s: 2.20.0

> UnsatisfiedDependencyException: Error creating bean with name 
> 'openTracingEventNotifier'
> 
>
> Key: CAMEL-11610
> URL: https://issues.apache.org/jira/browse/CAMEL-11610
> Project: Camel
>  Issue Type: Bug
>Affects Versions: 2.19.2, 2.20.0
>Reporter: Gary Brown
>Assignee: Claus Ibsen
> Fix For: 2.19.2, 2.20.0
>
>
> When testing the 2nd 2.19.2 release candidate, got the following when 
> starting up 'service1' in the camel-example-opentracing example. This service 
> started with no problems in the first release candidate, so not sure what has 
> changed - but from the initial messages it appears that something is still 
> being started up, i.e. "BeanCurrentlyInCreationException: Error creating bean 
> with name 'camelContext': Requested bean is currently in creation: Is there 
> an unresolvable circular reference?"
> {noformat}
> 2017-07-27 10:24:18.314  INFO 3829 --- [   main] 
> sample.camel.Service1Application : Starting Service1Application on 
> localhost.localdomain with PID 3829 
> (/home/gbrown/testing/apache/apache-camel-2.19.2/examples/camel-example-opentracing/service1/target/classes
>  started by gbrown in 
> /home/gbrown/testing/apache/apache-camel-2.19.2/examples/camel-example-opentracing/service1)
> 2017-07-27 10:24:18.316  INFO 3829 --- [   main] 
> sample.camel.Service1Application : No active profile set, falling 
> back to default profiles: default
> 2017-07-27 10:24:18.347  INFO 3829 --- [   main] 
> s.c.a.AnnotationConfigApplicationContext : Refreshing 
> org.springframework.context.annotation.AnnotationConfigApplicationContext@311592f:
>  startup date [Thu Jul 27 10:24:18 BST 2017]; root of context hierarchy
> 2017-07-27 10:24:19.098  WARN 3829 --- [   main] 
> s.c.a.AnnotationConfigApplicationContext : Exception encountered during 
> context initialization - cancelling refresh attempt: 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'cacheAutoConfigurationValidatorPostProcessor' 
> defined in class path resource 
> [org/apache/camel/component/http/springboot/HttpComponentSSLAutoConfiguration.class]:
>  Unsatisfied dependency expressed through method 
> 'cacheAutoConfigurationValidatorPostProcessor' parameter 0; nested exception 
> is org.springframework.beans.factory.BeanCreationException: Error creating 
> bean with name 'camelContext' defined in class path resource 
> [org/apache/camel/spring/boot/CamelAutoConfiguration.class]: Bean 
> instantiation via factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.camel.CamelContext]: Factory method 'camelContext' threw 
> exception; nested exception is 
> org.springframework.beans.factory.BeanCreationException: Error creating bean 
> with name 'rest-configuration' defined in class path resource 
> [org/apache/camel/model/rest/springboot/RestConfigurationDefinitionAutoConfiguration.class]:
>  Bean instantiation via factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.camel.spi.RestConfiguration]: Factory method 
> 'configureRestConfigurationDefinition' threw exception; nested exception is 
> java.lang.IllegalArgumentException: target must be specified
> Related cause: 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'openTracingEventNotifier' defined in 
> org.apache.camel.opentracing.starter.OpenTracingAutoConfiguration: 
> Unsatisfied dependency expressed through method 'openTracingEventNotifier' 
> parameter 0; nested exception is 
> org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
> creating bean with name 'camelContext': Requested bean is currently in 
> creation: Is there an unresolvable circular reference?
> 2017-07-27 10:24:19.102 ERROR 3829 --- [   main] 
> o.s.b.f.s.DefaultListableBeanFactory : Destroy method on bean with name 
> 'org.springframework.boot.autoconfigure.internalCachingMetadataReaderFactory' 
> threw an exception
> java.lang.IllegalStateException: ApplicationEventMulticaster not initialized 
> - call 'refresh' before multicasting events via the context: 
> org.springframework.context.annotation.AnnotationConfigApplicationContext@311592f:
>  startup date [Thu Jul 27 10:24:18 BST 2017]; root of context hierarchy
>   at 
> org.springframework.context.support.AbstractApplicationContext.getApplicationEventMulticaster(AbstractApplicationContext.java:414)
>

[jira] [Updated] (CAMEL-11607) NPE in MBeanInfoAssembler when debug is enabled

2017-07-27 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-11607:
-
Fix Version/s: 2.19.3
   2.18.5

> NPE in MBeanInfoAssembler when debug is enabled
> ---
>
> Key: CAMEL-11607
> URL: https://issues.apache.org/jira/browse/CAMEL-11607
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.20.0
>Reporter: Sarel Lugtenburg
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.18.5, 2.20.0, 2.19.3
>
>
> Commit f8e68bac676d9a1a43f1f2744aa467cba77ec169 caused a regression.
> An npe is thrown in MBeanInfoAssembler if debug logging is enabled and cache 
> is not initialised when component is stopped.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (CAMEL-11610) UnsatisfiedDependencyException: Error creating bean with name 'openTracingEventNotifier'

2017-07-27 Thread Claus Ibsen (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen reassigned CAMEL-11610:
---

Assignee: Claus Ibsen

> UnsatisfiedDependencyException: Error creating bean with name 
> 'openTracingEventNotifier'
> 
>
> Key: CAMEL-11610
> URL: https://issues.apache.org/jira/browse/CAMEL-11610
> Project: Camel
>  Issue Type: Bug
>Reporter: Gary Brown
>Assignee: Claus Ibsen
> Fix For: 2.19.2
>
>
> When testing the 2nd 2.19.2 release candidate, got the following when 
> starting up 'service1' in the camel-example-opentracing example. This service 
> started with no problems in the first release candidate, so not sure what has 
> changed - but from the initial messages it appears that something is still 
> being started up, i.e. "BeanCurrentlyInCreationException: Error creating bean 
> with name 'camelContext': Requested bean is currently in creation: Is there 
> an unresolvable circular reference?"
> {noformat}
> 2017-07-27 10:24:18.314  INFO 3829 --- [   main] 
> sample.camel.Service1Application : Starting Service1Application on 
> localhost.localdomain with PID 3829 
> (/home/gbrown/testing/apache/apache-camel-2.19.2/examples/camel-example-opentracing/service1/target/classes
>  started by gbrown in 
> /home/gbrown/testing/apache/apache-camel-2.19.2/examples/camel-example-opentracing/service1)
> 2017-07-27 10:24:18.316  INFO 3829 --- [   main] 
> sample.camel.Service1Application : No active profile set, falling 
> back to default profiles: default
> 2017-07-27 10:24:18.347  INFO 3829 --- [   main] 
> s.c.a.AnnotationConfigApplicationContext : Refreshing 
> org.springframework.context.annotation.AnnotationConfigApplicationContext@311592f:
>  startup date [Thu Jul 27 10:24:18 BST 2017]; root of context hierarchy
> 2017-07-27 10:24:19.098  WARN 3829 --- [   main] 
> s.c.a.AnnotationConfigApplicationContext : Exception encountered during 
> context initialization - cancelling refresh attempt: 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'cacheAutoConfigurationValidatorPostProcessor' 
> defined in class path resource 
> [org/apache/camel/component/http/springboot/HttpComponentSSLAutoConfiguration.class]:
>  Unsatisfied dependency expressed through method 
> 'cacheAutoConfigurationValidatorPostProcessor' parameter 0; nested exception 
> is org.springframework.beans.factory.BeanCreationException: Error creating 
> bean with name 'camelContext' defined in class path resource 
> [org/apache/camel/spring/boot/CamelAutoConfiguration.class]: Bean 
> instantiation via factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.camel.CamelContext]: Factory method 'camelContext' threw 
> exception; nested exception is 
> org.springframework.beans.factory.BeanCreationException: Error creating bean 
> with name 'rest-configuration' defined in class path resource 
> [org/apache/camel/model/rest/springboot/RestConfigurationDefinitionAutoConfiguration.class]:
>  Bean instantiation via factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.camel.spi.RestConfiguration]: Factory method 
> 'configureRestConfigurationDefinition' threw exception; nested exception is 
> java.lang.IllegalArgumentException: target must be specified
> Related cause: 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'openTracingEventNotifier' defined in 
> org.apache.camel.opentracing.starter.OpenTracingAutoConfiguration: 
> Unsatisfied dependency expressed through method 'openTracingEventNotifier' 
> parameter 0; nested exception is 
> org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
> creating bean with name 'camelContext': Requested bean is currently in 
> creation: Is there an unresolvable circular reference?
> 2017-07-27 10:24:19.102 ERROR 3829 --- [   main] 
> o.s.b.f.s.DefaultListableBeanFactory : Destroy method on bean with name 
> 'org.springframework.boot.autoconfigure.internalCachingMetadataReaderFactory' 
> threw an exception
> java.lang.IllegalStateException: ApplicationEventMulticaster not initialized 
> - call 'refresh' before multicasting events via the context: 
> org.springframework.context.annotation.AnnotationConfigApplicationContext@311592f:
>  startup date [Thu Jul 27 10:24:18 BST 2017]; root of context hierarchy
>   at 
> org.springframework.context.support.AbstractApplicationContext.getApplicationEventMulticaster(AbstractApplicationContext.java:414)
>

[jira] [Commented] (CAMEL-11597) Adding support for setting authentication client properties for elasticsearch

2017-07-27 Thread Pulkit Chhabra (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103211#comment-16103211
 ] 

Pulkit Chhabra commented on CAMEL-11597:


Hi Flemming,

Do you have any test case for this?


Regards
Pulkit




> Adding support for setting authentication client properties for elasticsearch
> -
>
> Key: CAMEL-11597
> URL: https://issues.apache.org/jira/browse/CAMEL-11597
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-elasticsearch5
>Affects Versions: 2.20.0
>Reporter: Flemming Harms
>Priority: Minor
>
> The current implementation does not allow to override the client instance or 
> setup client authentication.
> Adding following additional properties for support authentication
> {code:java}
> final Settings.Builder settings = Settings.builder()
>   .put("cluster.name", configuration.getClusterName())
>   .put("client.transport.ignore_cluster_name", false)
>   .put("client.transport.sniff", configuration.getClientTransportSniff())
>   .put("transport.ping_schedule", configuration.getPingSchedule())
>   .put("client.transport.ping_timeout", configuration.getPingTimeout())
>   .put("client.transport.sniff", configuration.getClientTransportSniff())
>   .put("xpack.security.transport.ssl.enabled", configuration.getEnabledSSL())
>   .put("request.headers.X-Found-Cluster", configuration.getClusterName());
>   if (configuration.getUser() != null && configuration.getPassword() != null) 
> {
>  settings.put("xpack.security.user", configuration.getUser() +":"+ 
> configuration.getPassword());
>}
>return settings.build();
>  }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11607) NPE in MBeanInfoAssembler when debug is enabled

2017-07-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103155#comment-16103155
 ] 

ASF GitHub Bot commented on CAMEL-11607:


Github user sarelp closed the pull request at:

https://github.com/apache/camel/pull/1853


> NPE in MBeanInfoAssembler when debug is enabled
> ---
>
> Key: CAMEL-11607
> URL: https://issues.apache.org/jira/browse/CAMEL-11607
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.20.0
>Reporter: Sarel Lugtenburg
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.20.0
>
>
> Commit f8e68bac676d9a1a43f1f2744aa467cba77ec169 caused a regression.
> An npe is thrown in MBeanInfoAssembler if debug logging is enabled and cache 
> is not initialised when component is stopped.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11605) Invalid accept header

2017-07-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103069#comment-16103069
 ] 

ASF GitHub Bot commented on CAMEL-11605:


Github user dmvolod closed the pull request at:

https://github.com/apache/camel/pull/1854


> Invalid accept header
> -
>
> Key: CAMEL-11605
> URL: https://issues.apache.org/jira/browse/CAMEL-11605
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.20.0
>Reporter: Marc Giger
>Assignee: Dmitry Volodin
> Fix For: 2.20.0
>
> Attachments: accept-header.diff
>
>
> Commit 958f7f33fa40868dec6a878f1c97f6d7339a9b3b introduced a regression
> to olingo4 (maybe olingo2 is also affected, not tested).
> The ACCEPT header doesn't include the subtype anymore: 
> ACCEPT: application
> Should be ACCEPT: application/json for example.
> Patch for olingo4 attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Reopened] (CAMEL-11601) change camel-file default value for readLockLoggingLevel from WARN to DEBUG

2017-07-27 Thread Andrea Tarocchi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Tarocchi reopened CAMEL-11601:
-

> change camel-file default value for readLockLoggingLevel from WARN to DEBUG
> ---
>
> Key: CAMEL-11601
> URL: https://issues.apache.org/jira/browse/CAMEL-11601
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Reporter: Andrea Tarocchi
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.20.0
>
>
> The default value setted at {{WARN}} for {{readLockLoggingLevel}} seems a 
> little bit aggressive for just not being able to acquire a read lock (there 
> are quite legitimate situations in which this can happen and is not a problem 
> at all but just the intended way of working), would be better to change it 
> {{DEBUG}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Issue Comment Deleted] (CAMEL-11601) change camel-file default value for readLockLoggingLevel from WARN to DEBUG

2017-07-27 Thread Andrea Tarocchi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Tarocchi updated CAMEL-11601:

Comment: was deleted

(was: Being merged.)

> change camel-file default value for readLockLoggingLevel from WARN to DEBUG
> ---
>
> Key: CAMEL-11601
> URL: https://issues.apache.org/jira/browse/CAMEL-11601
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Reporter: Andrea Tarocchi
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.20.0
>
>
> The default value setted at {{WARN}} for {{readLockLoggingLevel}} seems a 
> little bit aggressive for just not being able to acquire a read lock (there 
> are quite legitimate situations in which this can happen and is not a problem 
> at all but just the intended way of working), would be better to change it 
> {{DEBUG}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11601) change camel-file default value for readLockLoggingLevel from WARN to DEBUG

2017-07-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103041#comment-16103041
 ] 

ASF GitHub Bot commented on CAMEL-11601:


Github user valdar closed the pull request at:

https://github.com/apache/camel/pull/1851


> change camel-file default value for readLockLoggingLevel from WARN to DEBUG
> ---
>
> Key: CAMEL-11601
> URL: https://issues.apache.org/jira/browse/CAMEL-11601
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Reporter: Andrea Tarocchi
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.20.0
>
>
> The default value setted at {{WARN}} for {{readLockLoggingLevel}} seems a 
> little bit aggressive for just not being able to acquire a read lock (there 
> are quite legitimate situations in which this can happen and is not a problem 
> at all but just the intended way of working), would be better to change it 
> {{DEBUG}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (CAMEL-11601) change camel-file default value for readLockLoggingLevel from WARN to DEBUG

2017-07-27 Thread Andrea Tarocchi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Tarocchi closed CAMEL-11601.
---

Being merged.

> change camel-file default value for readLockLoggingLevel from WARN to DEBUG
> ---
>
> Key: CAMEL-11601
> URL: https://issues.apache.org/jira/browse/CAMEL-11601
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Reporter: Andrea Tarocchi
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.20.0
>
>
> The default value setted at {{WARN}} for {{readLockLoggingLevel}} seems a 
> little bit aggressive for just not being able to acquire a read lock (there 
> are quite legitimate situations in which this can happen and is not a problem 
> at all but just the intended way of working), would be better to change it 
> {{DEBUG}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (CAMEL-11601) change camel-file default value for readLockLoggingLevel from WARN to DEBUG

2017-07-27 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-11601.
--
Resolution: Fixed

> change camel-file default value for readLockLoggingLevel from WARN to DEBUG
> ---
>
> Key: CAMEL-11601
> URL: https://issues.apache.org/jira/browse/CAMEL-11601
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Reporter: Andrea Tarocchi
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.20.0
>
>
> The default value setted at {{WARN}} for {{readLockLoggingLevel}} seems a 
> little bit aggressive for just not being able to acquire a read lock (there 
> are quite legitimate situations in which this can happen and is not a problem 
> at all but just the intended way of working), would be better to change it 
> {{DEBUG}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CAMEL-11601) change camel-file default value for readLockLoggingLevel from WARN to DEBUG

2017-07-27 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-11601:
-
Fix Version/s: 2.20.0

> change camel-file default value for readLockLoggingLevel from WARN to DEBUG
> ---
>
> Key: CAMEL-11601
> URL: https://issues.apache.org/jira/browse/CAMEL-11601
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Reporter: Andrea Tarocchi
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.20.0
>
>
> The default value setted at {{WARN}} for {{readLockLoggingLevel}} seems a 
> little bit aggressive for just not being able to acquire a read lock (there 
> are quite legitimate situations in which this can happen and is not a problem 
> at all but just the intended way of working), would be better to change it 
> {{DEBUG}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (CAMEL-11601) change camel-file default value for readLockLoggingLevel from WARN to DEBUG

2017-07-27 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino reassigned CAMEL-11601:


Assignee: Andrea Cosentino

> change camel-file default value for readLockLoggingLevel from WARN to DEBUG
> ---
>
> Key: CAMEL-11601
> URL: https://issues.apache.org/jira/browse/CAMEL-11601
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Reporter: Andrea Tarocchi
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.20.0
>
>
> The default value setted at {{WARN}} for {{readLockLoggingLevel}} seems a 
> little bit aggressive for just not being able to acquire a read lock (there 
> are quite legitimate situations in which this can happen and is not a problem 
> at all but just the intended way of working), would be better to change it 
> {{DEBUG}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (CAMEL-11607) NPE in MBeanInfoAssembler when debug is enabled

2017-07-27 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-11607.
--
Resolution: Fixed

> NPE in MBeanInfoAssembler when debug is enabled
> ---
>
> Key: CAMEL-11607
> URL: https://issues.apache.org/jira/browse/CAMEL-11607
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.20.0
>Reporter: Sarel Lugtenburg
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.20.0
>
>
> Commit f8e68bac676d9a1a43f1f2744aa467cba77ec169 caused a regression.
> An npe is thrown in MBeanInfoAssembler if debug logging is enabled and cache 
> is not initialised when component is stopped.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (CAMEL-11607) NPE in MBeanInfoAssembler when debug is enabled

2017-07-27 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino reassigned CAMEL-11607:


Assignee: Andrea Cosentino

> NPE in MBeanInfoAssembler when debug is enabled
> ---
>
> Key: CAMEL-11607
> URL: https://issues.apache.org/jira/browse/CAMEL-11607
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.20.0
>Reporter: Sarel Lugtenburg
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.20.0
>
>
> Commit f8e68bac676d9a1a43f1f2744aa467cba77ec169 caused a regression.
> An npe is thrown in MBeanInfoAssembler if debug logging is enabled and cache 
> is not initialised when component is stopped.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CAMEL-11607) NPE in MBeanInfoAssembler when debug is enabled

2017-07-27 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-11607:
-
Fix Version/s: 2.20.0

> NPE in MBeanInfoAssembler when debug is enabled
> ---
>
> Key: CAMEL-11607
> URL: https://issues.apache.org/jira/browse/CAMEL-11607
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.20.0
>Reporter: Sarel Lugtenburg
>Assignee: Andrea Cosentino
>Priority: Minor
> Fix For: 2.20.0
>
>
> Commit f8e68bac676d9a1a43f1f2744aa467cba77ec169 caused a regression.
> An npe is thrown in MBeanInfoAssembler if debug logging is enabled and cache 
> is not initialised when component is stopped.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (CAMEL-11605) Invalid accept header

2017-07-27 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-11605.
--
Resolution: Fixed

> Invalid accept header
> -
>
> Key: CAMEL-11605
> URL: https://issues.apache.org/jira/browse/CAMEL-11605
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.20.0
>Reporter: Marc Giger
>Assignee: Dmitry Volodin
> Fix For: 2.20.0
>
> Attachments: accept-header.diff
>
>
> Commit 958f7f33fa40868dec6a878f1c97f6d7339a9b3b introduced a regression
> to olingo4 (maybe olingo2 is also affected, not tested).
> The ACCEPT header doesn't include the subtype anymore: 
> ACCEPT: application
> Should be ACCEPT: application/json for example.
> Patch for olingo4 attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (CAMEL-11610) UnsatisfiedDependencyException: Error creating bean with name 'openTracingEventNotifier'

2017-07-27 Thread Gary Brown (JIRA) 
Gary Brown created CAMEL-11610:
--

 Summary: UnsatisfiedDependencyException: Error creating bean with 
name 'openTracingEventNotifier'
 Key: CAMEL-11610
 URL: https://issues.apache.org/jira/browse/CAMEL-11610
 Project: Camel
  Issue Type: Bug
Reporter: Gary Brown
 Fix For: 2.19.2


When testing the 2nd 2.19.2 release candidate, got the following when starting 
up 'service1' in the camel-example-opentracing example. This service started 
with no problems in the first release candidate, so not sure what has changed - 
but from the initial messages it appears that something is still being started 
up, i.e. "BeanCurrentlyInCreationException: Error creating bean with name 
'camelContext': Requested bean is currently in creation: Is there an 
unresolvable circular reference?"

{noformat}
2017-07-27 10:24:18.314  INFO 3829 --- [   main] 
sample.camel.Service1Application : Starting Service1Application on 
localhost.localdomain with PID 3829 
(/home/gbrown/testing/apache/apache-camel-2.19.2/examples/camel-example-opentracing/service1/target/classes
 started by gbrown in 
/home/gbrown/testing/apache/apache-camel-2.19.2/examples/camel-example-opentracing/service1)
2017-07-27 10:24:18.316  INFO 3829 --- [   main] 
sample.camel.Service1Application : No active profile set, falling back 
to default profiles: default
2017-07-27 10:24:18.347  INFO 3829 --- [   main] 
s.c.a.AnnotationConfigApplicationContext : Refreshing 
org.springframework.context.annotation.AnnotationConfigApplicationContext@311592f:
 startup date [Thu Jul 27 10:24:18 BST 2017]; root of context hierarchy
2017-07-27 10:24:19.098  WARN 3829 --- [   main] 
s.c.a.AnnotationConfigApplicationContext : Exception encountered during context 
initialization - cancelling refresh attempt: 
org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
creating bean with name 'cacheAutoConfigurationValidatorPostProcessor' defined 
in class path resource 
[org/apache/camel/component/http/springboot/HttpComponentSSLAutoConfiguration.class]:
 Unsatisfied dependency expressed through method 
'cacheAutoConfigurationValidatorPostProcessor' parameter 0; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'camelContext' defined in class path resource 
[org/apache/camel/spring/boot/CamelAutoConfiguration.class]: Bean instantiation 
via factory method failed; nested exception is 
org.springframework.beans.BeanInstantiationException: Failed to instantiate 
[org.apache.camel.CamelContext]: Factory method 'camelContext' threw exception; 
nested exception is org.springframework.beans.factory.BeanCreationException: 
Error creating bean with name 'rest-configuration' defined in class path 
resource 
[org/apache/camel/model/rest/springboot/RestConfigurationDefinitionAutoConfiguration.class]:
 Bean instantiation via factory method failed; nested exception is 
org.springframework.beans.BeanInstantiationException: Failed to instantiate 
[org.apache.camel.spi.RestConfiguration]: Factory method 
'configureRestConfigurationDefinition' threw exception; nested exception is 
java.lang.IllegalArgumentException: target must be specified
Related cause: 
org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
creating bean with name 'openTracingEventNotifier' defined in 
org.apache.camel.opentracing.starter.OpenTracingAutoConfiguration: Unsatisfied 
dependency expressed through method 'openTracingEventNotifier' parameter 0; 
nested exception is 
org.springframework.beans.factory.BeanCurrentlyInCreationException: Error 
creating bean with name 'camelContext': Requested bean is currently in 
creation: Is there an unresolvable circular reference?
2017-07-27 10:24:19.102 ERROR 3829 --- [   main] 
o.s.b.f.s.DefaultListableBeanFactory : Destroy method on bean with name 
'org.springframework.boot.autoconfigure.internalCachingMetadataReaderFactory' 
threw an exception

java.lang.IllegalStateException: ApplicationEventMulticaster not initialized - 
call 'refresh' before multicasting events via the context: 
org.springframework.context.annotation.AnnotationConfigApplicationContext@311592f:
 startup date [Thu Jul 27 10:24:18 BST 2017]; root of context hierarchy
at 
org.springframework.context.support.AbstractApplicationContext.getApplicationEventMulticaster(AbstractApplicationContext.java:414)
 [spring-context-4.3.10.RELEASE.jar:4.3.10.RELEASE]
at 
org.springframework.context.support.ApplicationListenerDetector.postProcessBeforeDestruction(ApplicationListenerDetector.java:97)
 ~[spring-context-4.3.10.RELEASE.jar:4.3.10.RELEASE]
at 
org.springframework.beans.factory.support.DisposableBeanAdapter.destroy(DisposableBeanAdapter.java:253)
 ~[spring-beans-4.3.10.RELEASE.jar:4.3.10.RELEASE]
at

[jira] [Commented] (CAMEL-11609) camel-univocity-parsers: marshaller not thread safe

2017-07-27 Thread Daniel Baldes (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102963#comment-16102963
 ] 

Daniel Baldes commented on CAMEL-11609:
---

We have a workaround because in this case, we can specify fixed headers (which 
leads to this.adaptheaders == false, i.e. headers are not modified, so no 
issue).

Our routing structure is roughly as follows.  There is a "direct:persistCSV" 
route which uses marshal(univocityCsvDataFormat). This route may be called in 
parallel by multiple other routes (via to("direct:persistCSV")), these use 
split() and streaming(). Unfortunately I don't know much about camel and its 
threading model as I'm new to this project, so it is entirely possible that we 
are doing something wrong. So the question remains if this Marshaller is 
supposed to work in a multi-threaded environment at all - if it is, then this 
is an issue.

Simply using a synchronizedMap would rule out ConcurrentModificationException 
as far as I can tell, but in order to not get jumbled headers, they should not 
be kept and updated in the Marshaller instance at all I think - either always 
read the headers from this.headers and never change it, or read headers from 
the map into a local variable in the adaptheaders == true case. I don't know 
why changing headers would need to be kept as Marshaller state.

> camel-univocity-parsers: marshaller not thread safe
> ---
>
> Key: CAMEL-11609
> URL: https://issues.apache.org/jira/browse/CAMEL-11609
> Project: Camel
>  Issue Type: Bug
>  Components: camel-csv
>Affects Versions: 2.19.1
>Reporter: Daniel Baldes
>
> org.apache.camel.dataformat.univocity.Marshaller.java is not thread safe.
> When this.adaptheaders is true, this.headers is modified in the wirteRow() 
> method. This can lead to ConcurrentModificationExceptions (see below) and 
> jumbled headers, occasionally.
> I use a {{UnivocityCsvDataFormat}} for marshalling CSV in a route which is 
> called in parallel. The DataFormat creates a Marshaller with adaptheaders == 
> true when headers are not specified in the format.
> {code}java.util.ConcurrentModificationException: null
> at 
> java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
> at 
> java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:742)
> at 
> org.apache.camel.dataformat.univocity.Marshaller.writeRow(Marshaller.java:95)
> at 
> org.apache.camel.dataformat.univocity.Marshaller.marshal(Marshaller.java:67)
> at 
> org.apache.camel.dataformat.univocity.AbstractUniVocityDataFormat.marshal(AbstractUniVocityDataFormat.java:94)
> at 
> org.apache.camel.processor.MarshalProcessor.process(MarshalProcessor.java:69)
> at 
> org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)
> at 
> org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at org.apache.camel.processor.Pipeline.process(Pipeline.java:120)
> at org.apache.camel.processor.Pipeline.process(Pipeline.java:83)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at 
> org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:62)
> at 
> org.apache.camel.processor.SendDynamicProcessor$1.doInAsyncProducer(SendDynamicProcessor.java:124)
> at 
> org.apache.camel.impl.ProducerCache.doInAsyncProducer(ProducerCache.java:436)
> at 
> org.apache.camel.processor.SendDynamicProcessor.process(SendDynamicProcessor.java:119)
> at 
> org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at 
> org.apache.camel.processor.DelegateAsyncProcessor.process(DelegateAsyncProcessor.java:97)
> at 
> org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:137)
> at 
> org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:133)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11609) camel-univocity-parsers: marshaller not thread safe

2017-07-27 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/CAMEL-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102941#comment-16102941
 ] 

Önder Sezgin commented on CAMEL-11609:
--

I did not mean to argue it is obvious or not.

As you can see;

https://github.com/apache/camel/blob/master/components/camel-univocity-parsers/src/main/java/org/apache/camel/dataformat/univocity/Marshaller.java#L38

LinkedHashMap is not thread-safe.

What i wanted to understand your routing structure, maybe to help you suggest a 
workaround.

PR is much welcome with maybe with just 
{{Collections.synchronizedMap(this.headers);}}.
Camel loves contribution.




> camel-univocity-parsers: marshaller not thread safe
> ---
>
> Key: CAMEL-11609
> URL: https://issues.apache.org/jira/browse/CAMEL-11609
> Project: Camel
>  Issue Type: Bug
>  Components: camel-csv
>Affects Versions: 2.19.1
>Reporter: Daniel Baldes
>
> org.apache.camel.dataformat.univocity.Marshaller.java is not thread safe.
> When this.adaptheaders is true, this.headers is modified in the wirteRow() 
> method. This can lead to ConcurrentModificationExceptions (see below) and 
> jumbled headers, occasionally.
> I use a {{UnivocityCsvDataFormat}} for marshalling CSV in a route which is 
> called in parallel. The DataFormat creates a Marshaller with adaptheaders == 
> true when headers are not specified in the format.
> {code}java.util.ConcurrentModificationException: null
> at 
> java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
> at 
> java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:742)
> at 
> org.apache.camel.dataformat.univocity.Marshaller.writeRow(Marshaller.java:95)
> at 
> org.apache.camel.dataformat.univocity.Marshaller.marshal(Marshaller.java:67)
> at 
> org.apache.camel.dataformat.univocity.AbstractUniVocityDataFormat.marshal(AbstractUniVocityDataFormat.java:94)
> at 
> org.apache.camel.processor.MarshalProcessor.process(MarshalProcessor.java:69)
> at 
> org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)
> at 
> org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at org.apache.camel.processor.Pipeline.process(Pipeline.java:120)
> at org.apache.camel.processor.Pipeline.process(Pipeline.java:83)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at 
> org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:62)
> at 
> org.apache.camel.processor.SendDynamicProcessor$1.doInAsyncProducer(SendDynamicProcessor.java:124)
> at 
> org.apache.camel.impl.ProducerCache.doInAsyncProducer(ProducerCache.java:436)
> at 
> org.apache.camel.processor.SendDynamicProcessor.process(SendDynamicProcessor.java:119)
> at 
> org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at 
> org.apache.camel.processor.DelegateAsyncProcessor.process(DelegateAsyncProcessor.java:97)
> at 
> org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:137)
> at 
> org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:133)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11609) camel-univocity-parsers: marshaller not thread safe

2017-07-27 Thread Daniel Baldes (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102928#comment-16102928
 ] 

Daniel Baldes commented on CAMEL-11609:
---

Providing a unit test is difficult; we have one integration test which fails in 
about 1 in 100 cases due to this issue.

Given that the Marshaller holds and modifies a state in this.headers, it is 
obvious that it is not thread safe, though.

> camel-univocity-parsers: marshaller not thread safe
> ---
>
> Key: CAMEL-11609
> URL: https://issues.apache.org/jira/browse/CAMEL-11609
> Project: Camel
>  Issue Type: Bug
>  Components: camel-csv
>Affects Versions: 2.19.1
>Reporter: Daniel Baldes
>
> org.apache.camel.dataformat.univocity.Marshaller.java is not thread safe.
> When this.adaptheaders is true, this.headers is modified in the wirteRow() 
> method. This can lead to ConcurrentModificationExceptions (see below) and 
> jumbled headers, occasionally.
> I use a {{UnivocityCsvDataFormat}} for marshalling CSV in a route which is 
> called in parallel. The DataFormat creates a Marshaller with adaptheaders == 
> true when headers are not specified in the format.
> {code}java.util.ConcurrentModificationException: null
> at 
> java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
> at 
> java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:742)
> at 
> org.apache.camel.dataformat.univocity.Marshaller.writeRow(Marshaller.java:95)
> at 
> org.apache.camel.dataformat.univocity.Marshaller.marshal(Marshaller.java:67)
> at 
> org.apache.camel.dataformat.univocity.AbstractUniVocityDataFormat.marshal(AbstractUniVocityDataFormat.java:94)
> at 
> org.apache.camel.processor.MarshalProcessor.process(MarshalProcessor.java:69)
> at 
> org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)
> at 
> org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at org.apache.camel.processor.Pipeline.process(Pipeline.java:120)
> at org.apache.camel.processor.Pipeline.process(Pipeline.java:83)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at 
> org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:62)
> at 
> org.apache.camel.processor.SendDynamicProcessor$1.doInAsyncProducer(SendDynamicProcessor.java:124)
> at 
> org.apache.camel.impl.ProducerCache.doInAsyncProducer(ProducerCache.java:436)
> at 
> org.apache.camel.processor.SendDynamicProcessor.process(SendDynamicProcessor.java:119)
> at 
> org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
> at 
> org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
> at 
> org.apache.camel.processor.DelegateAsyncProcessor.process(DelegateAsyncProcessor.java:97)
> at 
> org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:137)
> at 
> org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:133)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (CAMEL-11609) camel-univocity-parsers: marshaller not thread safe

2017-07-27 Thread Daniel Baldes (JIRA) 
Daniel Baldes created CAMEL-11609:
-

 Summary: camel-univocity-parsers: marshaller not thread safe
 Key: CAMEL-11609
 URL: https://issues.apache.org/jira/browse/CAMEL-11609
 Project: Camel
  Issue Type: Bug
  Components: camel-csv
Affects Versions: 2.19.1
Reporter: Daniel Baldes


org.apache.camel.dataformat.univocity.Marshaller.java is not thread safe.

When this.adaptheaders is true, this.headers is modified in the wirteRow() 
method. This can lead to ConcurrentModificationExceptions (see below) and 
jumbled headers, occasionally.

I use a {{UnivocityCsvDataFormat}} for marshalling CSV in a route which is 
called in parallel. The DataFormat creates a Marshaller with adaptheaders == 
true when headers are not specified in the format.

{code}java.util.ConcurrentModificationException: null
at 
java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:719)
at 
java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:742)
at 
org.apache.camel.dataformat.univocity.Marshaller.writeRow(Marshaller.java:95)
at 
org.apache.camel.dataformat.univocity.Marshaller.marshal(Marshaller.java:67)
at 
org.apache.camel.dataformat.univocity.AbstractUniVocityDataFormat.marshal(AbstractUniVocityDataFormat.java:94)
at 
org.apache.camel.processor.MarshalProcessor.process(MarshalProcessor.java:69)
at 
org.apache.camel.management.InstrumentationProcessor.process(InstrumentationProcessor.java:77)
at 
org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
at 
org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
at org.apache.camel.processor.Pipeline.process(Pipeline.java:120)
at org.apache.camel.processor.Pipeline.process(Pipeline.java:83)
at 
org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
at 
org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:62)
at 
org.apache.camel.processor.SendDynamicProcessor$1.doInAsyncProducer(SendDynamicProcessor.java:124)
at 
org.apache.camel.impl.ProducerCache.doInAsyncProducer(ProducerCache.java:436)
at 
org.apache.camel.processor.SendDynamicProcessor.process(SendDynamicProcessor.java:119)
at 
org.apache.camel.processor.RedeliveryErrorHandler.process(RedeliveryErrorHandler.java:541)
at 
org.apache.camel.processor.CamelInternalProcessor.process(CamelInternalProcessor.java:198)
at 
org.apache.camel.processor.DelegateAsyncProcessor.process(DelegateAsyncProcessor.java:97)
at 
org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:137)
at 
org.apache.camel.processor.WireTapProcessor$1.call(WireTapProcessor.java:133)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CAMEL-11605) Invalid accept header

2017-07-27 Thread Dmitry Volodin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Volodin updated CAMEL-11605:
---
Fix Version/s: 2.20.0

> Invalid accept header
> -
>
> Key: CAMEL-11605
> URL: https://issues.apache.org/jira/browse/CAMEL-11605
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.20.0
>Reporter: Marc Giger
>Assignee: Dmitry Volodin
> Fix For: 2.20.0
>
> Attachments: accept-header.diff
>
>
> Commit 958f7f33fa40868dec6a878f1c97f6d7339a9b3b introduced a regression
> to olingo4 (maybe olingo2 is also affected, not tested).
> The ACCEPT header doesn't include the subtype anymore: 
> ACCEPT: application
> Should be ACCEPT: application/json for example.
> Patch for olingo4 attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11605) Invalid accept header

2017-07-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102884#comment-16102884
 ] 

ASF GitHub Bot commented on CAMEL-11605:


GitHub user dmvolod opened a pull request:

https://github.com/apache/camel/pull/1854

CAMEL-11605: Invalid accept header

This is regression introduced in CAMEL-11423

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dmvolod/camel CAMEL-11605

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1854.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1854


commit 87fef368ebf8cf93401bd4b594313bfd4ed31cd8
Author: Dmitry Volodin 
Date:   2017-07-27T07:43:03Z

CAMEL-11605: Invalid accept header




> Invalid accept header
> -
>
> Key: CAMEL-11605
> URL: https://issues.apache.org/jira/browse/CAMEL-11605
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.20.0
>Reporter: Marc Giger
>Assignee: Dmitry Volodin
> Attachments: accept-header.diff
>
>
> Commit 958f7f33fa40868dec6a878f1c97f6d7339a9b3b introduced a regression
> to olingo4 (maybe olingo2 is also affected, not tested).
> The ACCEPT header doesn't include the subtype anymore: 
> ACCEPT: application
> Should be ACCEPT: application/json for example.
> Patch for olingo4 attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11605) Invalid accept header

2017-07-27 Thread Dmitry Volodin (JIRA) 

[ 
https://issues.apache.org/jira/browse/CAMEL-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102883#comment-16102883
 ] 

Dmitry Volodin commented on CAMEL-11605:


[~giger], thanks for patch, PR submitted!

> Invalid accept header
> -
>
> Key: CAMEL-11605
> URL: https://issues.apache.org/jira/browse/CAMEL-11605
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.20.0
>Reporter: Marc Giger
>Assignee: Dmitry Volodin
> Attachments: accept-header.diff
>
>
> Commit 958f7f33fa40868dec6a878f1c97f6d7339a9b3b introduced a regression
> to olingo4 (maybe olingo2 is also affected, not tested).
> The ACCEPT header doesn't include the subtype anymore: 
> ACCEPT: application
> Should be ACCEPT: application/json for example.
> Patch for olingo4 attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Work started] (CAMEL-11605) Invalid accept header

2017-07-27 Thread Dmitry Volodin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on CAMEL-11605 started by Dmitry Volodin.
--
> Invalid accept header
> -
>
> Key: CAMEL-11605
> URL: https://issues.apache.org/jira/browse/CAMEL-11605
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.20.0
>Reporter: Marc Giger
>Assignee: Dmitry Volodin
> Attachments: accept-header.diff
>
>
> Commit 958f7f33fa40868dec6a878f1c97f6d7339a9b3b introduced a regression
> to olingo4 (maybe olingo2 is also affected, not tested).
> The ACCEPT header doesn't include the subtype anymore: 
> ACCEPT: application
> Should be ACCEPT: application/json for example.
> Patch for olingo4 attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (CAMEL-11605) Invalid accept header

2017-07-27 Thread Dmitry Volodin (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Volodin reassigned CAMEL-11605:
--

Assignee: Dmitry Volodin

> Invalid accept header
> -
>
> Key: CAMEL-11605
> URL: https://issues.apache.org/jira/browse/CAMEL-11605
> Project: Camel
>  Issue Type: Bug
>  Components: camel-olingo4
>Affects Versions: 2.20.0
>Reporter: Marc Giger
>Assignee: Dmitry Volodin
> Attachments: accept-header.diff
>
>
> Commit 958f7f33fa40868dec6a878f1c97f6d7339a9b3b introduced a regression
> to olingo4 (maybe olingo2 is also affected, not tested).
> The ACCEPT header doesn't include the subtype anymore: 
> ACCEPT: application
> Should be ACCEPT: application/json for example.
> Patch for olingo4 attached.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (CAMEL-11608) Camel-AWS: Camel-Kinesis needs Jackson Dataformat CBOR to work in OSGi

2017-07-27 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-11608.
--
Resolution: Fixed

> Camel-AWS: Camel-Kinesis needs Jackson Dataformat CBOR to work in OSGi
> --
>
> Key: CAMEL-11608
> URL: https://issues.apache.org/jira/browse/CAMEL-11608
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
> Fix For: 2.18.5, 2.20.0, 2.19.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CAMEL-11608) Camel-AWS: Camel-Kinesis needs Jackson Dataformat CBOR to work in OSGi

2017-07-27 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-11608:
-
Summary: Camel-AWS: Camel-Kinesis needs Jackson Dataformat CBOR to work in 
OSGi  (was: Camel-AWS: Camel-Kinesis need Jackson Dataformat CBOR to work in 
OSGi)

> Camel-AWS: Camel-Kinesis needs Jackson Dataformat CBOR to work in OSGi
> --
>
> Key: CAMEL-11608
> URL: https://issues.apache.org/jira/browse/CAMEL-11608
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
> Fix For: 2.18.5, 2.20.0, 2.19.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CAMEL-11608) Camel-AWS: Camel-Kinesis need Jackson Dataformat CBOR to work in OSGi

2017-07-27 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-11608:
-
Fix Version/s: 2.18.5

> Camel-AWS: Camel-Kinesis need Jackson Dataformat CBOR to work in OSGi
> -
>
> Key: CAMEL-11608
> URL: https://issues.apache.org/jira/browse/CAMEL-11608
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
> Fix For: 2.18.5, 2.20.0, 2.19.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (CAMEL-11608) Camel-AWS: Camel-Kinesis need Jackson Dataformat CBOR to work in OSGi

2017-07-27 Thread Andrea Cosentino (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CAMEL-11608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-11608:
-
Fix Version/s: 2.19.3

> Camel-AWS: Camel-Kinesis need Jackson Dataformat CBOR to work in OSGi
> -
>
> Key: CAMEL-11608
> URL: https://issues.apache.org/jira/browse/CAMEL-11608
> Project: Camel
>  Issue Type: Bug
>  Components: camel-aws
>Reporter: Andrea Cosentino
>Assignee: Andrea Cosentino
> Fix For: 2.20.0, 2.19.3
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (CAMEL-11608) Camel-AWS: Camel-Kinesis need Jackson Dataformat CBOR to work in OSGi

2017-07-27 Thread Andrea Cosentino (JIRA) 
Andrea Cosentino created CAMEL-11608:


 Summary: Camel-AWS: Camel-Kinesis need Jackson Dataformat CBOR to 
work in OSGi
 Key: CAMEL-11608
 URL: https://issues.apache.org/jira/browse/CAMEL-11608
 Project: Camel
  Issue Type: Bug
  Components: camel-aws
Reporter: Andrea Cosentino
Assignee: Andrea Cosentino
 Fix For: 2.20.0






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)