[jira] [Commented] (CAMEL-12672) Renovate Zipkin (brave) support
[ https://issues.apache.org/jira/browse/CAMEL-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551508#comment-16551508 ] Adrian Cole commented on CAMEL-12672: - to answer possibly a different question: why not just use OpenTracing? Well that can be used, with brave-opentracing, though the experience will be less efficient and impossible to take advantage of abstractions created by the zipkin community. For example, the runtime efficiency is worse due to factors including layers of wrapping and likely a future need to do extra context tracking unless some bugs are solved in opentracing's api design. Next, consistency is difficult as [data and sampling policy tools|https://github.com/openzipkin/brave/tree/master/instrumentation/http] tools, tools with stable apis, can't be used. OpenTracing data has poor data quality evidenced by complaints about things like nested json attributes. Even if you don't believe there are any problems, it would be intentionally not moving back into supporting what is by far the most popular java tracing library. If you choose for whatever reason to keep the zipkin integration as-is, and continue to not help it move forward, I would recommend removing it entirely. This way, the openzipkin community can create their own in another repo that is more friendly towards them. A rotting library is worse than no library, especially a rotting tracing library. > Renovate Zipkin (brave) support > --- > > Key: CAMEL-12672 > URL: https://issues.apache.org/jira/browse/CAMEL-12672 > Project: Camel > Issue Type: Improvement > Components: camel-zipkin >Reporter: Adrian Cole >Priority: Major > > With some hard effort, we've managed to maintain the original form of the > camel-zipkin integration. However, this integration's design is considerably > out of date, especially considering the work done in camel-opentracing. > camel-zipkin should be completely rewritten in order to improve experience > (and stop volunteers from having support questions in zipkin channel). > > I've been told folks don't know what to do, yet I think it is somewhat > simple. The work that was done in camel-opentracing.. do that in > camel-zipkin. Beyond that is polishing. > For example, the brave v4+ api is similar enough to opentracing to mostly > find/replace. This is a good start and can fix some considerable modeling > bugs in camel-zipkin around messaging. Once that is complete, we can move to > being more idiomatic and taking advantage of brave's features. > For example, `brave.Tracing` is injected by many things in spring. People use > it to configure advanced propagation things not possible in the normal api. > Similarly, `brave.http.HttpTracing` sets and verifies http-scoped > configuration so that when downstream systems are sensitive, data is > collected in ways not proprietary to camel. One such example is X-Ray. > Another example is that usually the data in opentracing is a lot bigger and > so more expensive for sites. Using tools like this helps keep costs down. > While the above steps are "going beyond" again, a relatively straight-forward > port of camel-opentracing would be a great way to re-enable the very large > OpenZipkin community and leverage the work you've done. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CAMEL-12672) Renovate Zipkin (brave) support
Adrian Cole created CAMEL-12672: --- Summary: Renovate Zipkin (brave) support Key: CAMEL-12672 URL: https://issues.apache.org/jira/browse/CAMEL-12672 Project: Camel Issue Type: Improvement Components: camel-zipkin Reporter: Adrian Cole With some hard effort, we've managed to maintain the original form of the camel-zipkin integration. However, this integration's design is considerably out of date, especially considering the work done in camel-opentracing. camel-zipkin should be completely rewritten in order to improve experience (and stop volunteers from having support questions in zipkin channel). I've been told folks don't know what to do, yet I think it is somewhat simple. The work that was done in camel-opentracing.. do that in camel-zipkin. Beyond that is polishing. For example, the brave v4+ api is similar enough to opentracing to mostly find/replace. This is a good start and can fix some considerable modeling bugs in camel-zipkin around messaging. Once that is complete, we can move to being more idiomatic and taking advantage of brave's features. For example, `brave.Tracing` is injected by many things in spring. People use it to configure advanced propagation things not possible in the normal api. Similarly, `brave.http.HttpTracing` sets and verifies http-scoped configuration so that when downstream systems are sensitive, data is collected in ways not proprietary to camel. One such example is X-Ray. Another example is that usually the data in opentracing is a lot bigger and so more expensive for sites. Using tools like this helps keep costs down. While the above steps are "going beyond" again, a relatively straight-forward port of camel-opentracing would be a great way to re-enable the very large OpenZipkin community and leverage the work you've done. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12195) camel redeliveries does not work with hystrix
[
https://issues.apache.org/jira/browse/CAMEL-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551202#comment-16551202
]
Mark Egan commented on CAMEL-12195:
---
[~davsclaus]: I share [~rahmnate] and [~rodrigoramalho]'s confusion and concern
regarding the capabilities of retries in with a circuit breaker enabled route.
From my understanding, retry and circuit breaker are two approaches that go
well together. A good description of this is found on [Rahul Rajat Singh's
DZone article "Understanding Retry Pattern With Exponential Back-Off and
Circuit Breaker Pattern"
|https://dzone.com/articles/understanding-retry-pattern-with-exponential-back].
If we're truly in a position where these are incompatible approaches, perhaps a
request for that feature within Hystrix is in order. Perhaps retries can be
incorporated into the Circuit Breaker implementation such that you can
configure retries similar to and along side of the circuit breaker parameters.
> camel redeliveries does not work with hystrix
> -
>
> Key: CAMEL-12195
> URL: https://issues.apache.org/jira/browse/CAMEL-12195
> Project: Camel
> Issue Type: Bug
> Components: camel-hystrix
>Reporter: Scott Feldstein
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.0
>
>
> Camel hystrix does not work with errorHander and redeliveries.
> I discussed this here ->
> [https://stackoverflow.com/questions/48396320/camel-exception-redelivery-with-hystrix]
> clone this repo to reproduce the issue
> {code:java}
> $ git clone g...@github.com:scottmf/camel-hystrix-bug.git
> $ cd camel-hystrix-bug
> $ gradlew clean test{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CAMEL-12642) No support for http4 feature authenticationPreemptive in pollEnrich
[
https://issues.apache.org/jira/browse/CAMEL-12642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551026#comment-16551026
]
ASF GitHub Bot commented on CAMEL-12642:
onderson commented on a change in pull request #2432: CAMEL-12642:Fix for http4
feature authenticationPreemptive in pollEnrich
URL: https://github.com/apache/camel/pull/2432#discussion_r204117717
##
File path:
components/camel-http4/src/main/java/org/apache/camel/component/http4/HttpPollingConsumer.java
##
@@ -33,21 +33,33 @@
import org.apache.http.client.methods.HttpGet;
import org.apache.http.client.methods.HttpRequestBase;
import org.apache.http.client.protocol.HttpClientContext;
+import org.apache.http.impl.auth.BasicScheme;
+import org.apache.http.protocol.HttpContext;
import org.apache.http.util.EntityUtils;
/**
* A polling HTTP consumer which by default performs a GET
*
* @version
*/
+@SuppressWarnings("deprecation")
Review comment:
I would not prefer supressing deprecation. Especially while we have java's 6
month release cycle..
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> No support for http4 feature authenticationPreemptive in pollEnrich
> ---
>
> Key: CAMEL-12642
> URL: https://issues.apache.org/jira/browse/CAMEL-12642
> Project: Camel
> Issue Type: New Feature
> Components: camel-http4
>Affects Versions: 2.23.0
>Reporter: Frank Olschewski
>Assignee: Ramu
>Priority: Major
>
> authenticationPreemptive=true does not work with pollEnrich.
> {code:java}
> .pollEnrich("https4:localhost?authenticationPreemptive=true" +
>"&authUsername=user&authPassword=passwd"){code}
> In Class /org/apache/camel/component/http4/HttpPollingConsumer.java:79 you
> see the following code:
> {code:java}
> HttpResponse response = httpClient.execute(method, httpClientContext);{code}
> The setup for authenticationPreemptive is missing.
> You can see what to do in
> org.apache.camel.component.http4.HttpProducer#executeMethod:
> {code:java}
> pprotected HttpResponse executeMethod(HttpUriRequest httpRequest) throws
> IOException {
> HttpContext localContext = new BasicHttpContext();
> if (getEndpoint().isAuthenticationPreemptive()) {
> BasicScheme basicAuth = new BasicScheme();
> localContext.setAttribute("preemptive-auth", basicAuth);
> }
> if (httpContext != null) {
> localContext = new BasicHttpContext(httpContext);
> }
> return httpClient.execute(httpRequest, localContext);
> }{code}
> In org.apache.camel.component.http4.HttpPollingConsumer#doReceive
> getEndpoint().isAuthenticationPreemptive() returns the correct value, so
> there is nothing against implementing this feature here as well.
> The problem behind the scene ist that the context attribute "preemptive-auth"
> is missing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550845#comment-16550845 ] Dmitry Volodin commented on CAMEL-12654: [~Srivastav], thanks for explanation. Looks like this is useful feature, but it must be added as an option (allowNullHeaders or something else) to provide backward compatibility. > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Priority: Minor > Labels: headers, rabbitmq > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12654) RabbitMQ Headers - Headers with null value are skipped.
[ https://issues.apache.org/jira/browse/CAMEL-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550831#comment-16550831 ] Prakhar commented on CAMEL-12654: - Consider this scenario. System A produces a message (For example Customer submitting his electric meter reading) to rabbitmq exchange. This message is passed in sequence through 3 systems --> System 1 (performs a check if submitted through the Online interface) --> Adds header (Online : /null) --> System 2 (more checks...) --> Adds header (PreviousBalance : /null) --> System 3 (more chesks) --> Adds header (ClearByInvoiceService : /null) ... ... ... --> System B --> Does final processing System B processes this message. If either of the headers is set, it does a microservice lookup to get more details to enrich the base message. This works fine until we started reading the message from another system C. System C can directly send this message to System B, but it needs to setup headers with a null value. So far we have been using a set of POJO based rabbit-mq consumers and producers to read messages and do ETL operations. Now we have started porting many of our integrations to apache camel, but we are not able to use camel-rabbitmq component, because headers with null values are skipped. It would be good to have camel-rabbitmq not to filter out the header with null values like the original rabbitmq java-client does. Another factor which adds to the complexity is, there are multiple systems similar to System A, owned by different IT teams (and different programming languages). Making changes to System B would mean breaking message structure for rest of the parties which is additional cost and effort. We can actually fork the camel-rabbitmq component and fix the changes. But that would mean, we have to maintain this fork for all the versions that we would use. > RabbitMQ Headers - Headers with null value are skipped. > --- > > Key: CAMEL-12654 > URL: https://issues.apache.org/jira/browse/CAMEL-12654 > Project: Camel > Issue Type: Bug > Components: camel-rabbitmq >Affects Versions: 2.21.1 >Reporter: Prakhar >Priority: Minor > Labels: headers, rabbitmq > > Reference: Conversation with Claus Ibsen on > [Stackoverflow|https://stackoverflow.com/questions/50583749/apache-camel-how-to-setheader-value-as-null] > org.apache.camel.component.rabbitmq.RabbitMQMessageConverter.buildProperties() > skips the headers which have value null. The actual java client for RabbitMQ > does not have this check. It accepts a basic Map which can > accept null value. > [Reference|https://rabbitmq.github.io/rabbitmq-java-client/api/current/com/rabbitmq/client/AMQP.BasicProperties.Builder.html] > . Check the definition of headers() method > *The business scenario where we use it*. On the RabbitMQ, we accept messages > from multiple sources. Depending on whether a specific header is null or not, > we route these message downstream in our processing pipeline. > If required, I could provide a working example of rabbitmq java-client to > demonstrate that the headers with null value are not skipped -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12669) Camel-Nats: add new client options available with client 2.x
[ https://issues.apache.org/jira/browse/CAMEL-12669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Cosentino resolved CAMEL-12669. -- Resolution: Fixed > Camel-Nats: add new client options available with client 2.x > > > Key: CAMEL-12669 > URL: https://issues.apache.org/jira/browse/CAMEL-12669 > Project: Camel > Issue Type: Improvement > Components: camel-nats >Reporter: Andrea Cosentino >Assignee: Andrea Cosentino >Priority: Major > Fix For: 2.23.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12671) camel-iec60870 - Add documentation for missing field
[ https://issues.apache.org/jira/browse/CAMEL-12671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550727#comment-16550727 ] Jens Reimann commented on CAMEL-12671: -- Yes, I can take care of that. However I can only come back to that issue in about two weeks. I hope you don't mind. > camel-iec60870 - Add documentation for missing field > > > Key: CAMEL-12671 > URL: https://issues.apache.org/jira/browse/CAMEL-12671 > Project: Camel > Issue Type: Task > Components: documentation >Reporter: Claus Ibsen >Assignee: Jens Reimann >Priority: Major > Fix For: 2.23.0 > > > This field did not have documentation. So I added something > https://github.com/apache/camel/blob/48539d7156a5d4795f0dc593c6334427fc8450e1/components/camel-iec60870/src/main/java/org/apache/camel/component/iec60870/client/ClientOptions.java#L48 > Jens do you mind taking a look, and add the correct documentation, and also > set the correct default value. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12649) Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API
[ https://issues.apache.org/jira/browse/CAMEL-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Burgazzoli updated CAMEL-12649: Priority: Minor (was: Major) > Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API > --- > > Key: CAMEL-12649 > URL: https://issues.apache.org/jira/browse/CAMEL-12649 > Project: Camel > Issue Type: New Feature > Components: camel-braintree >Reporter: Russ Johnson >Assignee: Luca Burgazzoli >Priority: Minor > Fix For: 2.23.0 > > > With the release of version 2.83.1 of the Braintree Java SDK > ([https://github.com/braintree/braintree_java/releases/tag/2.83.1|https://github.com/braintree/braintree_java/releases/tag/2.83.0]) > the transaction fees, the Transaction Level Fee Report has become available. > The intention of this ticket is to upgrade the Braintree Java SDK version and > expose the Braintree Transaction Level Fee Report in the Component. > Transaction Level Fees Reports are describe here: > [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] > but the API is not yet documented -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (CAMEL-12649) Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API
[ https://issues.apache.org/jira/browse/CAMEL-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Burgazzoli reassigned CAMEL-12649: --- Assignee: Luca Burgazzoli > Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API > --- > > Key: CAMEL-12649 > URL: https://issues.apache.org/jira/browse/CAMEL-12649 > Project: Camel > Issue Type: New Feature > Components: camel-braintree >Reporter: Russ Johnson >Assignee: Luca Burgazzoli >Priority: Major > Fix For: 2.23.0 > > > With the release of version 2.83.1 of the Braintree Java SDK > ([https://github.com/braintree/braintree_java/releases/tag/2.83.1|https://github.com/braintree/braintree_java/releases/tag/2.83.0]) > the transaction fees, the Transaction Level Fee Report has become available. > The intention of this ticket is to upgrade the Braintree Java SDK version and > expose the Braintree Transaction Level Fee Report in the Component. > Transaction Level Fees Reports are describe here: > [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] > but the API is not yet documented -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12649) Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API
[ https://issues.apache.org/jira/browse/CAMEL-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Burgazzoli updated CAMEL-12649: Fix Version/s: (was: 2.22.0) 2.23.0 > Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API > --- > > Key: CAMEL-12649 > URL: https://issues.apache.org/jira/browse/CAMEL-12649 > Project: Camel > Issue Type: New Feature > Components: camel-braintree >Reporter: Russ Johnson >Priority: Major > Fix For: 2.23.0 > > > With the release of version 2.83.1 of the Braintree Java SDK > ([https://github.com/braintree/braintree_java/releases/tag/2.83.1|https://github.com/braintree/braintree_java/releases/tag/2.83.0]) > the transaction fees, the Transaction Level Fee Report has become available. > The intention of this ticket is to upgrade the Braintree Java SDK version and > expose the Braintree Transaction Level Fee Report in the Component. > Transaction Level Fees Reports are describe here: > [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] > but the API is not yet documented -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12649) Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API
[ https://issues.apache.org/jira/browse/CAMEL-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Burgazzoli resolved CAMEL-12649. - Resolution: Fixed > Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API > --- > > Key: CAMEL-12649 > URL: https://issues.apache.org/jira/browse/CAMEL-12649 > Project: Camel > Issue Type: New Feature > Components: camel-braintree >Reporter: Russ Johnson >Assignee: Luca Burgazzoli >Priority: Minor > Fix For: 2.23.0 > > > With the release of version 2.83.1 of the Braintree Java SDK > ([https://github.com/braintree/braintree_java/releases/tag/2.83.1|https://github.com/braintree/braintree_java/releases/tag/2.83.0]) > the transaction fees, the Transaction Level Fee Report has become available. > The intention of this ticket is to upgrade the Braintree Java SDK version and > expose the Braintree Transaction Level Fee Report in the Component. > Transaction Level Fees Reports are describe here: > [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] > but the API is not yet documented -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12649) Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API
[ https://issues.apache.org/jira/browse/CAMEL-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550581#comment-16550581 ] Luca Burgazzoli commented on CAMEL-12649: - thank you > Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API > --- > > Key: CAMEL-12649 > URL: https://issues.apache.org/jira/browse/CAMEL-12649 > Project: Camel > Issue Type: New Feature > Components: camel-braintree >Reporter: Russ Johnson >Assignee: Luca Burgazzoli >Priority: Minor > Fix For: 2.23.0 > > > With the release of version 2.83.1 of the Braintree Java SDK > ([https://github.com/braintree/braintree_java/releases/tag/2.83.1|https://github.com/braintree/braintree_java/releases/tag/2.83.0]) > the transaction fees, the Transaction Level Fee Report has become available. > The intention of this ticket is to upgrade the Braintree Java SDK version and > expose the Braintree Transaction Level Fee Report in the Component. > Transaction Level Fees Reports are describe here: > [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] > but the API is not yet documented -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12649) Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API
[ https://issues.apache.org/jira/browse/CAMEL-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550565#comment-16550565 ] ASF GitHub Bot commented on CAMEL-12649: Github user lburgazzoli closed the pull request at: https://github.com/apache/camel/pull/2433 > Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API > --- > > Key: CAMEL-12649 > URL: https://issues.apache.org/jira/browse/CAMEL-12649 > Project: Camel > Issue Type: New Feature > Components: camel-braintree >Reporter: Russ Johnson >Priority: Major > Fix For: 2.22.0 > > > With the release of version 2.83.1 of the Braintree Java SDK > ([https://github.com/braintree/braintree_java/releases/tag/2.83.1|https://github.com/braintree/braintree_java/releases/tag/2.83.0]) > the transaction fees, the Transaction Level Fee Report has become available. > The intention of this ticket is to upgrade the Braintree Java SDK version and > expose the Braintree Transaction Level Fee Report in the Component. > Transaction Level Fees Reports are describe here: > [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] > but the API is not yet documented -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12649) Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API
[
https://issues.apache.org/jira/browse/CAMEL-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550564#comment-16550564
]
ASF GitHub Bot commented on CAMEL-12649:
lburgazzoli closed pull request #2433: CAMEL-12649: camel-braintree - Upgraded
Braintree Java SDK to 2.83.1 and exposed transaction level fees API
URL: https://github.com/apache/camel/pull/2433
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/components/camel-braintree/pom.xml
b/components/camel-braintree/pom.xml
index 7ba0c32e674..737a743baf7 100644
--- a/components/camel-braintree/pom.xml
+++ b/components/camel-braintree/pom.xml
@@ -225,6 +225,11 @@
com.braintreegateway.PlanGateway
+
+ report
+ com.braintreegateway.ReportGateway
+
+
settlementBatchSummary
com.braintreegateway.SettlementBatchSummaryGateway
diff --git a/components/camel-braintree/src/main/docs/braintree-component.adoc
b/components/camel-braintree/src/main/docs/braintree-component.adoc
index 202274a7552..686053991bc 100644
--- a/components/camel-braintree/src/main/docs/braintree-component.adoc
+++ b/components/camel-braintree/src/main/docs/braintree-component.adoc
@@ -121,6 +121,7 @@ Endpoint prefix can be one of:
* paymentmethod
* paymentmethodNonce
* plan
+* report
* settlementBatchSummary
* subscription
* transaction
@@ -568,7 +569,32 @@ braintree://plan/endpoint
|all | | |List
|
-
+
+ Endpoint prefix _report_
+
+The following endpoints can be invoked with the prefix *report* as
+follows:
+
+[source,java]
+-
+braintree://plan/report?[options]
+-
+
+[cols="<,<,<,<",options="header",]
+|==
+|Endpoint |Shorthand Alias |Options |Result Body Type
+|transactionLevelFees | | request
|com.braintreegateway.Result
+|==
+
+[[Braintree-URIOptionsfortreport]]
+URI Options for _report_
+
+[cols="<,<",options="header",]
+|==
+|Name |Type
+|request |com.braintreegateway.TransactionLevelFeeReportRequest
+|==
+
Endpoint prefix _settlementBatchSummary_
diff --git
a/components/camel-braintree/src/test/java/org/apache/camel/component/braintree/ReportGatewayIntegrationTest.java
b/components/camel-braintree/src/test/java/org/apache/camel/component/braintree/ReportGatewayIntegrationTest.java
new file mode 100644
index 000..ace38b42678
--- /dev/null
+++
b/components/camel-braintree/src/test/java/org/apache/camel/component/braintree/ReportGatewayIntegrationTest.java
@@ -0,0 +1,79 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.braintree;
+
+import java.text.SimpleDateFormat;
+import java.util.Calendar;
+import java.util.List;
+
+import com.braintreegateway.TransactionLevelFeeReport;
+import com.braintreegateway.TransactionLevelFeeReportRequest;
+import com.braintreegateway.TransactionLevelFeeReportRow;
+
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.braintree.internal.BraintreeApiCollection;
+import org.apache.camel.component.braintree.internal.ReportGatewayApiMethod;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Test class for {@link com.braintreegateway.ReportGateway} APIs.
+ */
+public class ReportGatewayIntegrationTest extends AbstractBraintreeTestSupport
{
+
+private static final Logger LOG =
LoggerFact
[jira] [Commented] (CAMEL-12649) Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API
[ https://issues.apache.org/jira/browse/CAMEL-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550369#comment-16550369 ] ASF GitHub Bot commented on CAMEL-12649: nofuss opened a new pull request #2433: CAMEL-12649: camel-braintree - Upgraded Braintree Java SDK to 2.83.1 and exposed transaction level fees API URL: https://github.com/apache/camel/pull/2433 Upgraded Braintree Java SDK to 2.83.1 and exposed transaction level fees API This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API > --- > > Key: CAMEL-12649 > URL: https://issues.apache.org/jira/browse/CAMEL-12649 > Project: Camel > Issue Type: New Feature > Components: camel-braintree >Reporter: Russ Johnson >Priority: Major > Fix For: 2.22.0 > > > With the release of version 2.83.1 of the Braintree Java SDK > ([https://github.com/braintree/braintree_java/releases/tag/2.83.1|https://github.com/braintree/braintree_java/releases/tag/2.83.0]) > the transaction fees, the Transaction Level Fee Report has become available. > The intention of this ticket is to upgrade the Braintree Java SDK version and > expose the Braintree Transaction Level Fee Report in the Component. > Transaction Level Fees Reports are describe here: > [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] > but the API is not yet documented -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12649) Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API
[ https://issues.apache.org/jira/browse/CAMEL-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550370#comment-16550370 ] ASF GitHub Bot commented on CAMEL-12649: GitHub user nofuss opened a pull request: https://github.com/apache/camel/pull/2433 CAMEL-12649: camel-braintree - Upgraded Braintree Java SDK to 2.83.1 and exposed transaction level fees API Upgraded Braintree Java SDK to 2.83.1 and exposed transaction level fees API You can merge this pull request into a Git repository by running: $ git pull https://github.com/nofuss/camel CAMEL-12649 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/2433.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2433 commit 62803d6f1e91c47c13a540ff422d1b78cdfa9be4 Author: Russ Johnson Date: 2018-07-20T07:45:43Z Upgraded Braintree Java SDK to 2.83.1 and exposed transaction level fees API > Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API > --- > > Key: CAMEL-12649 > URL: https://issues.apache.org/jira/browse/CAMEL-12649 > Project: Camel > Issue Type: New Feature > Components: camel-braintree >Reporter: Russ Johnson >Priority: Major > Fix For: 2.22.0 > > > With the release of version 2.83.1 of the Braintree Java SDK > ([https://github.com/braintree/braintree_java/releases/tag/2.83.1|https://github.com/braintree/braintree_java/releases/tag/2.83.0]) > the transaction fees, the Transaction Level Fee Report has become available. > The intention of this ticket is to upgrade the Braintree Java SDK version and > expose the Braintree Transaction Level Fee Report in the Component. > Transaction Level Fees Reports are describe here: > [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] > but the API is not yet documented -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CAMEL-12671) camel-iec60870 - Add documentation for missing field
Claus Ibsen created CAMEL-12671: --- Summary: camel-iec60870 - Add documentation for missing field Key: CAMEL-12671 URL: https://issues.apache.org/jira/browse/CAMEL-12671 Project: Camel Issue Type: Task Components: documentation Reporter: Claus Ibsen Assignee: Jens Reimann Fix For: 2.23.0 This field did not have documentation. So I added something https://github.com/apache/camel/blob/48539d7156a5d4795f0dc593c6334427fc8450e1/components/camel-iec60870/src/main/java/org/apache/camel/component/iec60870/client/ClientOptions.java#L48 Jens do you mind taking a look, and add the correct documentation, and also set the correct default value. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-11707) spring boot code generation: there should be a way to exclude some properties from the code generation
[
https://issues.apache.org/jira/browse/CAMEL-11707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550343#comment-16550343
]
Claus Ibsen commented on CAMEL-11707:
-
At first cut I added support for adding @XmlTransient annotation to the field
then its ignored (for components) as this was needed in some situations for the
spring-boot documentation.
> spring boot code generation: there should be a way to exclude some properties
> from the code generation
> --
>
> Key: CAMEL-11707
> URL: https://issues.apache.org/jira/browse/CAMEL-11707
> Project: Camel
> Issue Type: Improvement
> Components: tooling
>Reporter: Luca Burgazzoli
>Priority: Major
> Fix For: 2.23.0
>
>
> As today every property is exposed to spring boot auto configuration
> processor but sometimes you may want to hide some or them as they may be
> supposed to be used only internally or because you want to write your own
> code to manage complex configurations.
> As this may also be needed to hide info from the catalog, we may have
> something like:
> {code}
> @Metadata(key = "ignore", value = "true", labels = "spring-boot,catalog")
> {code}
> Or have specific annotations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CAMEL-12649) Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API
[ https://issues.apache.org/jira/browse/CAMEL-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550313#comment-16550313 ] Russ Johnson commented on CAMEL-12649: -- Updated to Braintree Java SDK version 2.83.1 . Version 2.83.0 was released without the javadoc jar resource, which is required for building in Camel. version 2.83.1 has all required resources. > Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API > --- > > Key: CAMEL-12649 > URL: https://issues.apache.org/jira/browse/CAMEL-12649 > Project: Camel > Issue Type: New Feature > Components: camel-braintree >Reporter: Russ Johnson >Priority: Major > Fix For: 2.22.0 > > > With the release of version 2.83.1 of the Braintree Java SDK > ([https://github.com/braintree/braintree_java/releases/tag/2.83.1|https://github.com/braintree/braintree_java/releases/tag/2.83.0]) > the transaction fees, the Transaction Level Fee Report has become available. > The intention of this ticket is to upgrade the Braintree Java SDK version and > expose the Braintree Transaction Level Fee Report in the Component. > Transaction Level Fees Reports are describe here: > [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] > but the API is not yet documented -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12649) Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API
[ https://issues.apache.org/jira/browse/CAMEL-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Russ Johnson updated CAMEL-12649: - Description: With the release of version 2.83.1 of the Braintree Java SDK ([https://github.com/braintree/braintree_java/releases/tag/2.83.1|https://github.com/braintree/braintree_java/releases/tag/2.83.0]) the transaction fees, the Transaction Level Fee Report has become available. The intention of this ticket is to upgrade the Braintree Java SDK version and expose the Braintree Transaction Level Fee Report in the Component. Transaction Level Fees Reports are describe here: [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] but the API is not yet documented was: With the release of version 2.83.0 of the Braintree Java SDK ([https://github.com/braintree/braintree_java/releases/tag/2.83.0]) the transaction fees, the Transaction Level Fee Report has become available. The intention of this ticket is to upgrade the Braintree Java SDK version and expose the Braintree Transaction Level Fee Report in the Component. Transaction Level Fees Reports are describe here: [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] but the API is not yet documented > Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API > --- > > Key: CAMEL-12649 > URL: https://issues.apache.org/jira/browse/CAMEL-12649 > Project: Camel > Issue Type: New Feature > Components: camel-braintree >Reporter: Russ Johnson >Priority: Major > Fix For: 2.22.0 > > > With the release of version 2.83.1 of the Braintree Java SDK > ([https://github.com/braintree/braintree_java/releases/tag/2.83.1|https://github.com/braintree/braintree_java/releases/tag/2.83.0]) > the transaction fees, the Transaction Level Fee Report has become available. > The intention of this ticket is to upgrade the Braintree Java SDK version and > expose the Braintree Transaction Level Fee Report in the Component. > Transaction Level Fees Reports are describe here: > [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] > but the API is not yet documented -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-12649) Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API
[ https://issues.apache.org/jira/browse/CAMEL-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Russ Johnson updated CAMEL-12649: - Summary: Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API (was: Upgrade Braintree SDK to 2.83.0 and Expose Transaction Fees API) > Upgrade Braintree SDK to 2.83.1 and Expose Transaction Fees API > --- > > Key: CAMEL-12649 > URL: https://issues.apache.org/jira/browse/CAMEL-12649 > Project: Camel > Issue Type: New Feature > Components: camel-braintree >Reporter: Russ Johnson >Priority: Major > Fix For: 2.22.0 > > > With the release of version 2.83.0 of the Braintree Java SDK > ([https://github.com/braintree/braintree_java/releases/tag/2.83.0]) the > transaction fees, the Transaction Level Fee Report has become available. > The intention of this ticket is to upgrade the Braintree Java SDK version and > expose the Braintree Transaction Level Fee Report in the Component. > Transaction Level Fees Reports are describe here: > [https://articles.braintreepayments.com/control-panel/reporting/transaction-level-fee-report] > but the API is not yet documented -- This message was sent by Atlassian JIRA (v7.6.3#76005)
