[jira] [Commented] (CAMEL-12726) FindBugs warnings: Invocation of toString on an array

2018-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577003#comment-16577003
 ] 

ASF GitHub Bot commented on CAMEL-12726:


hiroakiy opened a new pull request #2467: CAMEL-12726: Fix FindBugs warnings: 
Invocation of toString on an array
URL: https://github.com/apache/camel/pull/2467
 
 
   FindBugs-3.0.1 
([http://findbugs.sourceforge.net/](http://findbugs.sourceforge.net/)) reported 
4 DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
   ```
   H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext, 
RemoveHeadersProcessor, ProcessorDefinition)  At 
ManagedRemoveHeaders.java:[line 37]
   H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext, 
RemovePropertiesProcessor, ProcessorDefinition)  At 
ManagedRemoveProperties.java:[line 37]
   M C USELESS_STRING: Invocation of toString on 
ScpConfiguration.getPrivateKeyBytes() in 
org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)  
At ScpOperations.java:[line 262]
   M C USELESS_STRING: Invocation of toString on path in 
org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String, 
String[])  At BoxFoldersManager.java:[line 204]
   ```
   The description of the bug is as follows:
   > USELESS_STRING: Invocation of toString on an array 
(DMI_INVOKING_TOSTRING_ON_ARRAY)
   >  The code invokes toString on an array, which will generate a fairly 
useless result such as [C@16f0472. Consider using Arrays.toString to convert 
the array into a readable String that gives the contents of the array. See 
Programming Puzzlers, chapter 3, puzzle 12.

[http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY](http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FindBugs warnings: Invocation of toString on an array
> -
>
> Key: CAMEL-12726
> URL: https://issues.apache.org/jira/browse/CAMEL-12726
> Project: Camel
>  Issue Type: Bug
>  Components: camel-box, camel-core, camel-jsch
>Reporter: Hiroaki Yoshida
>Priority: Major
>
> FindBugs-3.0.1 ([http://findbugs.sourceforge.net/]) reported 4 
> DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
> {code:java}
> H C USELESS_STRING: Invocation of toString on 
> org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new 
> org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext, 
> RemoveHeadersProcessor, ProcessorDefinition)  At 
> ManagedRemoveHeaders.java:[line 37]
> H C USELESS_STRING: Invocation of toString on 
> org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in 
> new org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext, 
> RemovePropertiesProcessor, ProcessorDefinition)  At 
> ManagedRemoveProperties.java:[line 37]
> M C USELESS_STRING: Invocation of toString on 
> ScpConfiguration.getPrivateKeyBytes() in 
> org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)  
> At ScpOperations.java:[line 262]
> M C USELESS_STRING: Invocation of toString on path in 
> org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String, 
> String[])  At BoxFoldersManager.java:[line 204]
> {code}
> The description of the bug is as follows:
> {quote}*USELESS_STRING: Invocation of toString on an array 
> (DMI_INVOKING_TOSTRING_ON_ARRAY)*
>  The code invokes toString on an array, which will generate a fairly useless 
> result such as [C@16f0472. Consider using Arrays.toString to convert the 
> array into a readable String that gives the contents of the array. See 
> Programming Puzzlers, chapter 3, puzzle 12.
>  
> [http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY]
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12726) FindBugs warnings: Invocation of toString on an array

2018-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577004#comment-16577004
 ] 

ASF GitHub Bot commented on CAMEL-12726:


GitHub user hiroakiy opened a pull request:

https://github.com/apache/camel/pull/2467

CAMEL-12726: Fix FindBugs warnings: Invocation of toString on an array

FindBugs-3.0.1 
([http://findbugs.sourceforge.net/](http://findbugs.sourceforge.net/)) reported 
4 DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
```
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext, 
RemoveHeadersProcessor, ProcessorDefinition)  At 
ManagedRemoveHeaders.java:[line 37]
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext, 
RemovePropertiesProcessor, ProcessorDefinition)  At 
ManagedRemoveProperties.java:[line 37]
M C USELESS_STRING: Invocation of toString on 
ScpConfiguration.getPrivateKeyBytes() in 
org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)  
At ScpOperations.java:[line 262]
M C USELESS_STRING: Invocation of toString on path in 
org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String, 
String[])  At BoxFoldersManager.java:[line 204]
```
The description of the bug is as follows:
> USELESS_STRING: Invocation of toString on an array 
(DMI_INVOKING_TOSTRING_ON_ARRAY)
>  The code invokes toString on an array, which will generate a fairly 
useless result such as [C@16f0472. Consider using Arrays.toString to convert 
the array into a readable String that gives the contents of the array. See 
Programming Puzzlers, chapter 3, puzzle 12.
 
[http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY](http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hiroakiy/camel CAMEL-12726

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2467.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2467


commit 28627fe3301f8e5854194c92bdf4d961996d6e92
Author: Hiroaki Yoshida 
Date:   2018-08-11T01:33:09Z

CAMEL-12726: Fix FindBugs warnings: Invocation of toString on an array




> FindBugs warnings: Invocation of toString on an array
> -
>
> Key: CAMEL-12726
> URL: https://issues.apache.org/jira/browse/CAMEL-12726
> Project: Camel
>  Issue Type: Bug
>  Components: camel-box, camel-core, camel-jsch
>Reporter: Hiroaki Yoshida
>Priority: Major
>
> FindBugs-3.0.1 ([http://findbugs.sourceforge.net/]) reported 4 
> DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
> {code:java}
> H C USELESS_STRING: Invocation of toString on 
> org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new 
> org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext, 
> RemoveHeadersProcessor, ProcessorDefinition)  At 
> ManagedRemoveHeaders.java:[line 37]
> H C USELESS_STRING: Invocation of toString on 
> org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in 
> new org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext, 
> RemovePropertiesProcessor, ProcessorDefinition)  At 
> ManagedRemoveProperties.java:[line 37]
> M C USELESS_STRING: Invocation of toString on 
> ScpConfiguration.getPrivateKeyBytes() in 
> org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)  
> At ScpOperations.java:[line 262]
> M C USELESS_STRING: Invocation of toString on path in 
> org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String, 
> String[])  At BoxFoldersManager.java:[line 204]
> {code}
> The description of the bug is as follows:
> {quote}*USELESS_STRING: Invocation of toString on an array 
> (DMI_INVOKING_TOSTRING_ON_ARRAY)*
>  The code invokes toString on an array, which will generate a fairly useless 
> result such as [C@16f0472. Consider using Arrays.toString to convert the 
> array into a readable String that gives the contents of the array. See 
> Programming Puzzlers, chapter 3, puzzle 12.
>  
> [http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY]
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-12726) FindBugs warnings: Invocation of toString on an array

2018-08-10 Thread Hiroaki Yoshida (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hiroaki Yoshida updated CAMEL-12726:

Description: 
FindBugs-3.0.1 ([http://findbugs.sourceforge.net/]) reported 4 
DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
{code:java}
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext, 
RemoveHeadersProcessor, ProcessorDefinition)  At 
ManagedRemoveHeaders.java:[line 37]
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext, 
RemovePropertiesProcessor, ProcessorDefinition)  At 
ManagedRemoveProperties.java:[line 37]
M C USELESS_STRING: Invocation of toString on 
ScpConfiguration.getPrivateKeyBytes() in 
org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)  
At ScpOperations.java:[line 262]
M C USELESS_STRING: Invocation of toString on path in 
org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String, 
String[])  At BoxFoldersManager.java:[line 204]
{code}
The description of the bug is as follows:
{quote}*USELESS_STRING: Invocation of toString on an array 
(DMI_INVOKING_TOSTRING_ON_ARRAY)*
 The code invokes toString on an array, which will generate a fairly useless 
result such as [C@16f0472. Consider using Arrays.toString to convert the array 
into a readable String that gives the contents of the array. See Programming 
Puzzlers, chapter 3, puzzle 12.
 
[http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY]
{quote}

  was:
FindBugs-3.0.1 ([http://findbugs.sourceforge.net/]) reported 4 
DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
{code:java}
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext, 
RemoveHeadersProcessor, ProcessorDefinition)  At 
ManagedRemoveHeaders.java:[line 37]
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext, 
RemovePropertiesProcessor, ProcessorDefinition)  At 
ManagedRemoveProperties.java:[line 37]
M C USELESS_STRING: Invocation of toString on 
ScpConfiguration.getPrivateKeyBytes() in 
org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)  
At ScpOperations.java:[line 262]
M C USELESS_STRING: Invocation of toString on path in 
org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String, 
String[])  At BoxFoldersManager.java:[line 204]
{code}
The description of the bug is as follows:
{quote}*USELESS_STRING: Invocation of toString on an array 
(DMI_INVOKING_TOSTRING_ON_ARRAY)*
 The code invokes toString on an array, which will generate a fairly useless 
result such as [C@16f0472. Consider using Arrays.toString to convert the array 
into a readable String that gives the contents of the array. See Programming 
Puzzlers, chapter 3, puzzle 12.
 
[http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY|http://example.com/]
{quote}


> FindBugs warnings: Invocation of toString on an array
> -
>
> Key: CAMEL-12726
> URL: https://issues.apache.org/jira/browse/CAMEL-12726
> Project: Camel
>  Issue Type: Bug
>  Components: camel-box, camel-core, camel-jsch
>Reporter: Hiroaki Yoshida
>Priority: Major
>
> FindBugs-3.0.1 ([http://findbugs.sourceforge.net/]) reported 4 
> DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
> {code:java}
> H C USELESS_STRING: Invocation of toString on 
> org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new 
> org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext, 
> RemoveHeadersProcessor, ProcessorDefinition)  At 
> ManagedRemoveHeaders.java:[line 37]
> H C USELESS_STRING: Invocation of toString on 
> org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in 
> new org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext, 
> RemovePropertiesProcessor, ProcessorDefinition)  At 
> ManagedRemoveProperties.java:[line 37]
> M C USELESS_STRING: Invocation of toString on 
> ScpConfiguration.getPrivateKeyBytes() in 
> org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)  
> At ScpOperations.java:[line 262]
> M C USELESS_STRING: Invocation of toString on path in 
> org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String, 
> String[])  At BoxFoldersManager.java:[line 204]
> {code}
> The description of the bug is as 

[jira] [Updated] (CAMEL-12726) FindBugs warnings: Invocation of toString on an array

2018-08-10 Thread Hiroaki Yoshida (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hiroaki Yoshida updated CAMEL-12726:

Description: 
FindBugs-3.0.1 ([http://findbugs.sourceforge.net/]) reported 4 
DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
{code:java}
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext, 
RemoveHeadersProcessor, ProcessorDefinition)  At 
ManagedRemoveHeaders.java:[line 37]
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext, 
RemovePropertiesProcessor, ProcessorDefinition)  At 
ManagedRemoveProperties.java:[line 37]
M C USELESS_STRING: Invocation of toString on 
ScpConfiguration.getPrivateKeyBytes() in 
org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)  
At ScpOperations.java:[line 262]
M C USELESS_STRING: Invocation of toString on path in 
org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String, 
String[])  At BoxFoldersManager.java:[line 204]
{code}
The description of the bug is as follows:
{quote}*USELESS_STRING: Invocation of toString on an array 
(DMI_INVOKING_TOSTRING_ON_ARRAY)*
 The code invokes toString on an array, which will generate a fairly useless 
result such as [C@16f0472. Consider using Arrays.toString to convert the array 
into a readable String that gives the contents of the array. See Programming 
Puzzlers, chapter 3, puzzle 12.
 
[http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY|http://example.com/]
{quote}

  was:
FindBugs-3.0.1 ([http://findbugs.sourceforge.net/|http://example.com/]) 
reported 4 DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
{code:java}
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext, 
RemoveHeadersProcessor, ProcessorDefinition)  At 
ManagedRemoveHeaders.java:[line 37]
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext, 
RemovePropertiesProcessor, ProcessorDefinition)  At 
ManagedRemoveProperties.java:[line 37]
M C USELESS_STRING: Invocation of toString on 
ScpConfiguration.getPrivateKeyBytes() in 
org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)  
At ScpOperations.java:[line 262]
M C USELESS_STRING: Invocation of toString on path in 
org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String, 
String[])  At BoxFoldersManager.java:[line 204]
{code}
The description of the bug is as follows:
{quote}*USELESS_STRING: Invocation of toString on an array 
(DMI_INVOKING_TOSTRING_ON_ARRAY)*
 The code invokes toString on an array, which will generate a fairly useless 
result such as [C@16f0472. Consider using Arrays.toString to convert the array 
into a readable String that gives the contents of the array. See Programming 
Puzzlers, chapter 3, puzzle 12.
 
[http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY|http://example.com/]
{quote}


> FindBugs warnings: Invocation of toString on an array
> -
>
> Key: CAMEL-12726
> URL: https://issues.apache.org/jira/browse/CAMEL-12726
> Project: Camel
>  Issue Type: Bug
>  Components: camel-box, camel-core, camel-jsch
>Reporter: Hiroaki Yoshida
>Priority: Major
>
> FindBugs-3.0.1 ([http://findbugs.sourceforge.net/]) reported 4 
> DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
> {code:java}
> H C USELESS_STRING: Invocation of toString on 
> org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new 
> org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext, 
> RemoveHeadersProcessor, ProcessorDefinition)  At 
> ManagedRemoveHeaders.java:[line 37]
> H C USELESS_STRING: Invocation of toString on 
> org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in 
> new org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext, 
> RemovePropertiesProcessor, ProcessorDefinition)  At 
> ManagedRemoveProperties.java:[line 37]
> M C USELESS_STRING: Invocation of toString on 
> ScpConfiguration.getPrivateKeyBytes() in 
> org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)  
> At ScpOperations.java:[line 262]
> M C USELESS_STRING: Invocation of toString on path in 
> org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String, 
> String[])  At BoxFoldersManager.java:[line 204]
> 

[jira] [Created] (CAMEL-12726) FindBugs warnings: Invocation of toString on an array

2018-08-10 Thread Hiroaki Yoshida (JIRA)
Hiroaki Yoshida created CAMEL-12726:
---

 Summary: FindBugs warnings: Invocation of toString on an array
 Key: CAMEL-12726
 URL: https://issues.apache.org/jira/browse/CAMEL-12726
 Project: Camel
  Issue Type: Bug
  Components: camel-box, camel-core, camel-jsch
Reporter: Hiroaki Yoshida


FindBugs-3.0.1 ([http://findbugs.sourceforge.net/|http://example.com/]) 
reported 4 DMI_INVOKING_TOSTRING_ON_ARRAY warnings on master:
{code:java}
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemoveHeadersProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveHeaders(CamelContext, 
RemoveHeadersProcessor, ProcessorDefinition)  At 
ManagedRemoveHeaders.java:[line 37]
H C USELESS_STRING: Invocation of toString on 
org.apache.camel.processor.RemovePropertiesProcessor.getExcludePattern() in new 
org.apache.camel.management.mbean.ManagedRemoveProperties(CamelContext, 
RemovePropertiesProcessor, ProcessorDefinition)  At 
ManagedRemoveProperties.java:[line 37]
M C USELESS_STRING: Invocation of toString on 
ScpConfiguration.getPrivateKeyBytes() in 
org.apache.camel.component.scp.ScpOperations.createSession(ScpConfiguration)  
At ScpOperations.java:[line 262]
M C USELESS_STRING: Invocation of toString on path in 
org.apache.camel.component.box.api.BoxFoldersManager.createFolder(String, 
String[])  At BoxFoldersManager.java:[line 204]
{code}
The description of the bug is as follows:
{quote}*USELESS_STRING: Invocation of toString on an array 
(DMI_INVOKING_TOSTRING_ON_ARRAY)*
 The code invokes toString on an array, which will generate a fairly useless 
result such as [C@16f0472. Consider using Arrays.toString to convert the array 
into a readable String that gives the contents of the array. See Programming 
Puzzlers, chapter 3, puzzle 12.
 
[http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_TOSTRING_ON_ARRAY|http://example.com/]
{quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12715) camel-script - Upgrade to Groovy 2.5.1 and check camel-itest-karaf and feature.

2018-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576619#comment-16576619
 ] 

ASF GitHub Bot commented on CAMEL-12715:


GitHub user aldettinger opened a pull request:

https://github.com/apache/camel/pull/2465

CAMEL-12715: Fixed camel-script dependencies

I have it running with this PR in karaf-itests and also manual install in 
karaf 4.1.2. Could anyone double-check please ?

More context in 
[CAMEL-12715](https://issues.apache.org/jira/browse/CAMEL-12715).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aldettinger/camel master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2465


commit 3644cbc0de50aca971a64e3382291057b57bdc09
Author: aldettinger 
Date:   2018-08-10T17:26:15Z

CAMEL-12715: Fixed camel-script dependencies




> camel-script  - Upgrade to Groovy 2.5.1 and check camel-itest-karaf and 
> feature.
> 
>
> Key: CAMEL-12715
> URL: https://issues.apache.org/jira/browse/CAMEL-12715
> Project: Camel
>  Issue Type: Task
>  Components: camel-script, tests
>Reporter: Önder Sezgin
>Priority: Minor
> Fix For: 2.23.0
>
>
> Groovy 2.5.1 was released. many components upgraded but camel-script karaf 
> itest fails with the following error. 
>  
> Cannot get language with name: Groovy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12715) camel-script - Upgrade to Groovy 2.5.1 and check camel-itest-karaf and feature.

2018-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576618#comment-16576618
 ] 

ASF GitHub Bot commented on CAMEL-12715:


aldettinger opened a new pull request #2465: CAMEL-12715: Fixed camel-script 
dependencies
URL: https://github.com/apache/camel/pull/2465
 
 
   I have it running with this PR in karaf-itests and also manual install in 
karaf 4.1.2. Could anyone double-check please ?
   
   More context in 
[CAMEL-12715](https://issues.apache.org/jira/browse/CAMEL-12715).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> camel-script  - Upgrade to Groovy 2.5.1 and check camel-itest-karaf and 
> feature.
> 
>
> Key: CAMEL-12715
> URL: https://issues.apache.org/jira/browse/CAMEL-12715
> Project: Camel
>  Issue Type: Task
>  Components: camel-script, tests
>Reporter: Önder Sezgin
>Priority: Minor
> Fix For: 2.23.0
>
>
> Groovy 2.5.1 was released. many components upgraded but camel-script karaf 
> itest fails with the following error. 
>  
> Cannot get language with name: Groovy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (CAMEL-12715) camel-script - Upgrade to Groovy 2.5.1 and check camel-itest-karaf and feature.

2018-08-10 Thread Alex Dettinger (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Dettinger reassigned CAMEL-12715:
--

Assignee: Alex Dettinger

> camel-script  - Upgrade to Groovy 2.5.1 and check camel-itest-karaf and 
> feature.
> 
>
> Key: CAMEL-12715
> URL: https://issues.apache.org/jira/browse/CAMEL-12715
> Project: Camel
>  Issue Type: Task
>  Components: camel-script, tests
>Reporter: Önder Sezgin
>Assignee: Alex Dettinger
>Priority: Minor
> Fix For: 2.23.0
>
>
> Groovy 2.5.1 was released. many components upgraded but camel-script karaf 
> itest fails with the following error. 
>  
> Cannot get language with name: Groovy



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12308) Upgrade to CXF 3.2.2

2018-08-10 Thread Martin Lichtin (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576387#comment-16576387
 ] 

Martin Lichtin commented on CAMEL-12308:


That's true of course. 
Staying with Karaf 4.0.x we cannot go beyond 2.20.x (2.21 requires a newer 
Jetty that is only in newer Karafs). Guess we're stuck with Camel 2.19 then for 
that Karaf version.

> Upgrade to CXF 3.2.2
> 
>
> Key: CAMEL-12308
> URL: https://issues.apache.org/jira/browse/CAMEL-12308
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-cxf
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.0
>
>
> There is a newer version and it also fixes a problem on JDK9 in the 
> camel-itests



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (CAMEL-12410) No type converter from java.lang.String to java.math.BigInteger required for firstIndex

2018-08-10 Thread Viachaslau Tsikhanovich (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viachaslau Tsikhanovich reopened CAMEL-12410:
-

[Added 
logic|https://github.com/apache/camel/commit/13451671ffdcb748aeb708a46b3346521dea726c]
 for conversion to BigInteger doesn't work correctly. For example, for input 
string "14350442579497085228" it first will try to convert to Long and fail 
with NumberFormatException:
{quote}
Caused by: java.lang.NumberFormatException: For input string: 
"14350442579497085228"
  at 
java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
  at java.lang.Long.parseLong(Long.java:592)
  at java.lang.Long.valueOf(Long.java:803)
  at 
org.apache.camel.converter.ObjectConverter.toBigInteger(ObjectConverter.java:210)
{quote}

> No type converter from java.lang.String to java.math.BigInteger required for 
> firstIndex
> ---
>
> Key: CAMEL-12410
> URL: https://issues.apache.org/jira/browse/CAMEL-12410
> Project: Camel
>  Issue Type: Bug
>  Components: camel-consul
>Affects Versions: 2.21.0
>Reporter: Viachaslau Tsikhanovich
>Assignee: Claus Ibsen
>Priority: Minor
> Fix For: 2.21.1, 2.22.0
>
>
> After CAMEL-12065 fix the type of _firstIndex_ parameter became 
> _java.math.BigInteger_.
> However _org.apache.camel.impl.converter.OptimisedTypeConverter_ has no 
> converter from java.lang.String to java.math.BigInteger.
> As result _firstIndex_ parameter fails to be set and enpoint creation fails 
> with the following exception:
> {quote}
> org.apache.camel.ResolveEndpointFailedException: Failed to resolve endpoint: 
> consul://event?firstIndex=0=EVENT_ID1=http%3A%2F%2Fconsul-client%3A8500
>  due to: Could not find a suitable setter for property: firstIndex as there 
> isn't a setter method with same type: java.lang.String nor type conversion 
> possible: No type converter available to convert from type: java.lang.String 
> to the required type: java.math.BigInteger with value 0
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12722) java.util.ConcurrentModificationException: KafkaConsumer is not safe for multi-threaded access

2018-08-10 Thread Dmitry Volodin (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576117#comment-16576117
 ] 

Dmitry Volodin commented on CAMEL-12722:


[~michael992] clone Camel project from github, create a separate branch on top 
of master, in KafkaConsumerManualCommitTest.java remove Ignored test 
annotation, add your host and port capabilities and run with maven command as 
'mvn clean test -Dtest=KafkaConsumerManualCommitTest'

> java.util.ConcurrentModificationException: KafkaConsumer is not safe for 
> multi-threaded access
> --
>
> Key: CAMEL-12722
> URL: https://issues.apache.org/jira/browse/CAMEL-12722
> Project: Camel
>  Issue Type: Bug
>  Components: camel-kafka
>Affects Versions: 2.22.0
>Reporter: michael elbaz
>Priority: Major
>
> I got an exception when i try to use manual commit on camel kafka component
>  
> {code:java}
> from("kafka:{{kafka.hostname}}:{{kafka.port}}?topic={{kafka.topic}}={{kafka.consumer.groupid}}=false=true")
> .process(new Processor() {
> @Override
> public void process(Exchange exchange) throws Exception {
> KafkaManualCommit manual =
> 
> exchange.getIn().getHeader(KafkaConstants.MANUAL_COMMIT, 
> KafkaManualCommit.class);
> manual.commitSync();
> }
> }).to("...")
> {code}
> The exception
> {code:java}
> Trace: java.util.ConcurrentModificationException: KafkaConsumer is not safe 
> for multi-threaded access
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.acquire(KafkaConsumer.java:1824)
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.acquireAndEnsureOpen(KafkaConsumer.java:1808)
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.commitSync(KafkaConsumer.java:1255)
>     at 
> org.apache.camel.component.kafka.DefaultKafkaManualCommit.commitOffset(DefaultKafkaManualCommit.java:60)
>     at 
> org.apache.camel.component.kafka.DefaultKafkaManualCommit.commitSync(DefaultKafkaManualCommit.java:51)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12722) java.util.ConcurrentModificationException: KafkaConsumer is not safe for multi-threaded access

2018-08-10 Thread michael elbaz (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576116#comment-16576116
 ] 

michael elbaz commented on CAMEL-12722:
---

@dmitry how I suppose to enable it ?

> java.util.ConcurrentModificationException: KafkaConsumer is not safe for 
> multi-threaded access
> --
>
> Key: CAMEL-12722
> URL: https://issues.apache.org/jira/browse/CAMEL-12722
> Project: Camel
>  Issue Type: Bug
>  Components: camel-kafka
>Affects Versions: 2.22.0
>Reporter: michael elbaz
>Priority: Major
>
> I got an exception when i try to use manual commit on camel kafka component
>  
> {code:java}
> from("kafka:{{kafka.hostname}}:{{kafka.port}}?topic={{kafka.topic}}={{kafka.consumer.groupid}}=false=true")
> .process(new Processor() {
> @Override
> public void process(Exchange exchange) throws Exception {
> KafkaManualCommit manual =
> 
> exchange.getIn().getHeader(KafkaConstants.MANUAL_COMMIT, 
> KafkaManualCommit.class);
> manual.commitSync();
> }
> }).to("...")
> {code}
> The exception
> {code:java}
> Trace: java.util.ConcurrentModificationException: KafkaConsumer is not safe 
> for multi-threaded access
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.acquire(KafkaConsumer.java:1824)
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.acquireAndEnsureOpen(KafkaConsumer.java:1808)
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.commitSync(KafkaConsumer.java:1255)
>     at 
> org.apache.camel.component.kafka.DefaultKafkaManualCommit.commitOffset(DefaultKafkaManualCommit.java:60)
>     at 
> org.apache.camel.component.kafka.DefaultKafkaManualCommit.commitSync(DefaultKafkaManualCommit.java:51)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12719) Ability to load an SSLContextParameter with a Keystore containing multiple keys (aliases)

2018-08-10 Thread Dmitry Volodin (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576022#comment-16576022
 ] 

Dmitry Volodin commented on CAMEL-12719:


[~Boosy] you are welcome to provide solution as github PR.

> Ability to load an SSLContextParameter with a Keystore containing multiple 
> keys (aliases)
> -
>
> Key: CAMEL-12719
> URL: https://issues.apache.org/jira/browse/CAMEL-12719
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.22.0
> Environment: Apache Tomcat 7, Camel 2.22.0, java 8, redHat 6.6
> 1 TrustStore.jks (12 certificats CA => 12 alias)
> 1 Keystore.jsk (5 clés => 5 alias => 5 passwords différents)
> > 200 camelRoutes (file, soap, rest) secure, non-secure
>Reporter: Florian B.
>Priority: Major
>  Labels: features
> Fix For: 2.23.0
>
>
> Hello,
> I wish I could initialize a single SSLContextParameters at camel startup 
> containing my truststore.jks (> 1 alias) and my keystore.jks (> 1 alias) in 
> order to call it (refer to) in Routes (FTPs, HTTPs) without have to redefine 
> a new SSLContextParameter for each EndPoint.
> __
>  __
>  _  _resource="${truststore.jks.file.location}" />_
>  __
>  __
>  _  _resource="${keystore.jks.file.location}" />_
>  __
>  __
> When my Keystore contains more than 1 alias, I have the following error when 
> creating the Route at startup : 
> *Caused by: org.apache.camel.ResolveEndpointFailedException: Failed to 
> resolve endpoint: 
> https4://:/?authPassword=RAW(password)=login=true=true=sslContextParameters=true
>  due to: Cannot recover key*
> due to
> *Caused by: java.security.UnrecoverableKeyException: Cannot recover key*
>  
> When my keystore contains only one key, it works very well.
> __
>  __
>  _  _resource="${truststore.jks.file.location}" />_
>  __
>  __
>  _  _resource="${keystore.jks.file.location}" />_
>  __
>  __
>  
> So I would like to be able to call my SSLContextParameter for different 
> EndPoint by specifying (if necessary) the alias of the Keystore needed (by 
> specifying the alias and / or password of the key)
>  
> Objectif in my project :
>  * 1 TrustStore.jks 
>  * 1 Keystore.jsk
>  * 1 unique SSLContextParameter
>  * > 200 camelRoutes FTPs/HTTPs (ssl one way ou two way)
>  
> Thank a lot
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (CAMEL-12719) Ability to load an SSLContextParameter with a Keystore containing multiple keys (aliases)

2018-08-10 Thread Florian B. (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576015#comment-16576015
 ] 

Florian B. edited comment on CAMEL-12719 at 8/10/18 9:32 AM:
-

Hi,

Does your "SSL-based component" refer to 'camel:keyManagers' ?

Because I think it is this component which can refer only 1 key in a Keystore. 
(I currently use this component too in a  Ability to load an SSLContextParameter with a Keystore containing multiple 
> keys (aliases)
> -
>
> Key: CAMEL-12719
> URL: https://issues.apache.org/jira/browse/CAMEL-12719
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.22.0
> Environment: Apache Tomcat 7, Camel 2.22.0, java 8, redHat 6.6
> 1 TrustStore.jks (12 certificats CA => 12 alias)
> 1 Keystore.jsk (5 clés => 5 alias => 5 passwords différents)
> > 200 camelRoutes (file, soap, rest) secure, non-secure
>Reporter: Florian B.
>Priority: Major
>  Labels: features
> Fix For: 2.23.0
>
>
> Hello,
> I wish I could initialize a single SSLContextParameters at camel startup 
> containing my truststore.jks (> 1 alias) and my keystore.jks (> 1 alias) in 
> order to call it (refer to) in Routes (FTPs, HTTPs) without have to redefine 
> a new SSLContextParameter for each EndPoint.
> __
>  __
>  _  _resource="${truststore.jks.file.location}" />_
>  __
>  __
>  _  _resource="${keystore.jks.file.location}" />_
>  __
>  __
> When my Keystore contains more than 1 alias, I have the following error when 
> creating the Route at startup : 
> *Caused by: org.apache.camel.ResolveEndpointFailedException: Failed to 
> resolve endpoint: 
> https4://:/?authPassword=RAW(password)=login=true=true=sslContextParameters=true
>  due to: Cannot recover key*
> due to
> *Caused by: java.security.UnrecoverableKeyException: Cannot recover key*
>  
> When my keystore contains only one key, it works very well.
> __
>  __
>  _  _resource="${truststore.jks.file.location}" />_
>  __
>  __
>  _  _resource="${keystore.jks.file.location}" />_
>  __
>  __
>  
> So I would like to be able to call my SSLContextParameter for different 
> EndPoint by specifying (if necessary) the alias of the Keystore needed (by 
> specifying the alias and / or password of the key)
>  
> Objectif in my project :
>  * 1 TrustStore.jks 
>  * 1 Keystore.jsk
>  * 1 unique SSLContextParameter
>  * > 200 camelRoutes FTPs/HTTPs (ssl one way ou two way)
>  
> Thank a lot
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12719) Ability to load an SSLContextParameter with a Keystore containing multiple keys (aliases)

2018-08-10 Thread Florian B. (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576015#comment-16576015
 ] 

Florian B. commented on CAMEL-12719:


Hi,

Does your "SSL-based component" refer to 'camel:keyManagers' ?

Because I think it is this component which can refer only 1 key in a Keystore.

If I may add some which, it would be
 * Possibility to create a camel:keyManagers as a camel:trustManagers
 * Add an optional alias management in the camel:keyManagers
 * Add an optional alias in the endPoint ?

May I add some draft in attachment ?

 

Thanks a lot

 

 

 

 

> Ability to load an SSLContextParameter with a Keystore containing multiple 
> keys (aliases)
> -
>
> Key: CAMEL-12719
> URL: https://issues.apache.org/jira/browse/CAMEL-12719
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.22.0
> Environment: Apache Tomcat 7, Camel 2.22.0, java 8, redHat 6.6
> 1 TrustStore.jks (12 certificats CA => 12 alias)
> 1 Keystore.jsk (5 clés => 5 alias => 5 passwords différents)
> > 200 camelRoutes (file, soap, rest) secure, non-secure
>Reporter: Florian B.
>Priority: Major
>  Labels: features
> Fix For: 2.23.0
>
>
> Hello,
> I wish I could initialize a single SSLContextParameters at camel startup 
> containing my truststore.jks (> 1 alias) and my keystore.jks (> 1 alias) in 
> order to call it (refer to) in Routes (FTPs, HTTPs) without have to redefine 
> a new SSLContextParameter for each EndPoint.
> __
>  __
>  _  _resource="${truststore.jks.file.location}" />_
>  __
>  __
>  _  _resource="${keystore.jks.file.location}" />_
>  __
>  __
> When my Keystore contains more than 1 alias, I have the following error when 
> creating the Route at startup : 
> *Caused by: org.apache.camel.ResolveEndpointFailedException: Failed to 
> resolve endpoint: 
> https4://:/?authPassword=RAW(password)=login=true=true=sslContextParameters=true
>  due to: Cannot recover key*
> due to
> *Caused by: java.security.UnrecoverableKeyException: Cannot recover key*
>  
> When my keystore contains only one key, it works very well.
> __
>  __
>  _  _resource="${truststore.jks.file.location}" />_
>  __
>  __
>  _  _resource="${keystore.jks.file.location}" />_
>  __
>  __
>  
> So I would like to be able to call my SSLContextParameter for different 
> EndPoint by specifying (if necessary) the alias of the Keystore needed (by 
> specifying the alias and / or password of the key)
>  
> Objectif in my project :
>  * 1 TrustStore.jks 
>  * 1 Keystore.jsk
>  * 1 unique SSLContextParameter
>  * > 200 camelRoutes FTPs/HTTPs (ssl one way ou two way)
>  
> Thank a lot
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-12711) SFTP: Cannot specify bind address of local network interface

2018-08-10 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-12711.
-
Resolution: Fixed
  Assignee: Claus Ibsen

Thanks for reporting and the PR

> SFTP: Cannot specify bind address of local network interface
> 
>
> Key: CAMEL-12711
> URL: https://issues.apache.org/jira/browse/CAMEL-12711
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-ftp
>Affects Versions: 2.22.0
>Reporter: Felix Feisst
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.23.0
>
>
> In an environment with multiple network interfaces, it might be necessary to 
> specify the address of the local interface, to which the SFTP connection 
> should bind. Unfortunately, this is not possible with the latest version of 
> camel-ftp.
>  
> A new URI parameter 'bindAddress' should be introduces which can then be set 
> to the IP-Address of the local network interface against which the SFTP 
> connection should bind.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12711) SFTP: Cannot specify bind address of local network interface

2018-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575991#comment-16575991
 ] 

ASF GitHub Bot commented on CAMEL-12711:


davsclaus commented on issue #2452: [CAMEL-12711] Add configuration property 
'bindAddress' for SFTP
URL: https://github.com/apache/camel/pull/2452#issuecomment-412024782
 
 
   I am merging this, then we can do another PR if we manage to build an unit 
test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SFTP: Cannot specify bind address of local network interface
> 
>
> Key: CAMEL-12711
> URL: https://issues.apache.org/jira/browse/CAMEL-12711
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-ftp
>Affects Versions: 2.22.0
>Reporter: Felix Feisst
>Priority: Major
> Fix For: 2.23.0
>
>
> In an environment with multiple network interfaces, it might be necessary to 
> specify the address of the local interface, to which the SFTP connection 
> should bind. Unfortunately, this is not possible with the latest version of 
> camel-ftp.
>  
> A new URI parameter 'bindAddress' should be introduces which can then be set 
> to the IP-Address of the local network interface against which the SFTP 
> connection should bind.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12711) SFTP: Cannot specify bind address of local network interface

2018-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575984#comment-16575984
 ] 

ASF GitHub Bot commented on CAMEL-12711:


Github user davsclaus closed the pull request at:

https://github.com/apache/camel/pull/2452


> SFTP: Cannot specify bind address of local network interface
> 
>
> Key: CAMEL-12711
> URL: https://issues.apache.org/jira/browse/CAMEL-12711
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-ftp
>Affects Versions: 2.22.0
>Reporter: Felix Feisst
>Priority: Major
> Fix For: 2.23.0
>
>
> In an environment with multiple network interfaces, it might be necessary to 
> specify the address of the local interface, to which the SFTP connection 
> should bind. Unfortunately, this is not possible with the latest version of 
> camel-ftp.
>  
> A new URI parameter 'bindAddress' should be introduces which can then be set 
> to the IP-Address of the local network interface against which the SFTP 
> connection should bind.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12711) SFTP: Cannot specify bind address of local network interface

2018-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575983#comment-16575983
 ] 

ASF GitHub Bot commented on CAMEL-12711:


davsclaus closed pull request #2452: [CAMEL-12711] Add configuration property 
'bindAddress' for SFTP
URL: https://github.com/apache/camel/pull/2452
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/components/camel-ftp/src/main/docs/sftp-component.adoc 
b/components/camel-ftp/src/main/docs/sftp-component.adoc
index e127442a0e0..cf8d95046c6 100644
--- a/components/camel-ftp/src/main/docs/sftp-component.adoc
+++ b/components/camel-ftp/src/main/docs/sftp-component.adoc
@@ -51,7 +51,7 @@ with the following path and query parameters:
 |===
 
 
- Query Parameters (115 parameters):
+ Query Parameters (116 parameters):
 
 
 [width="100%",cols="2,5,^1,2",options="header"]
@@ -111,6 +111,7 @@ with the following path and query parameters:
 | *synchronous* (advanced) | Sets whether synchronous processing should be 
strictly used, or Camel is allowed to use asynchronous processing (if 
supported). | false | boolean
 | *throwExceptionOnConnect Failed* (advanced) | Should an exception be thrown 
if connection failed (exhausted) By default exception is not thrown and a WARN 
is logged. You can use this to enable exception being thrown and handle the 
thrown exception from the org.apache.camel.spi.PollingConsumerPollStrategy 
rollback method. | false | boolean
 | *timeout* (advanced) | Sets the data timeout for waiting for reply Used only 
by FTPClient | 3 | int
+| *bindAddress* (bindAddress) | Specifies the address of the local interface 
against which the connection should bind. |  | String
 | *antExclude* (filter) | Ant style filter exclusion. If both antInclude and 
antExclude are used, antExclude takes precedence over antInclude. Multiple 
exclusions may be specified in comma-delimited format. |  | String
 | *antFilterCaseSensitive* (filter) | Sets case sensitive flag on ant filter | 
true | boolean
 | *antInclude* (filter) | Ant style filter inclusion. Multiple inclusions may 
be specified in comma-delimited format. |  | String
diff --git 
a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpConfiguration.java
 
b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpConfiguration.java
index 8fc377ad9aa..9be8751aa2d 100644
--- 
a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpConfiguration.java
+++ 
b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpConfiguration.java
@@ -69,6 +69,8 @@
 private LoggingLevel jschLoggingLevel = LoggingLevel.WARN;
 @UriParam(label = "advanced")
 private Integer bulkRequests;
+@UriParam(label = "bindAddress")
+private String bindAddress;
 
 public SftpConfiguration() {
 setProtocol("sftp");
@@ -296,4 +298,15 @@ public void setBulkRequests(Integer bulkRequests) {
 public Integer getBulkRequests() {
 return bulkRequests;
 }
+
+/**
+ * Specifies the address of the local interface against which the 
connection should bind.
+ */
+public void setBindAddress(String bindAddress) {
+this.bindAddress = bindAddress;
+}
+
+public String getBindAddress() {
+return bindAddress;
+}
 }
diff --git 
a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java
 
b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java
index ff82e72b9da..494eeb1544c 100644
--- 
a/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java
+++ 
b/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java
@@ -24,6 +24,9 @@
 import java.io.InputStream;
 import java.io.OutputStream;
 import java.io.UnsupportedEncodingException;
+import java.net.InetAddress;
+import java.net.Socket;
+import java.net.UnknownHostException;
 import java.security.KeyPair;
 import java.security.interfaces.DSAPrivateKey;
 import java.security.interfaces.DSAPublicKey;
@@ -41,11 +44,13 @@
 import com.jcraft.jsch.Proxy;
 import com.jcraft.jsch.Session;
 import com.jcraft.jsch.SftpException;
+import com.jcraft.jsch.SocketFactory;
 import com.jcraft.jsch.UIKeyboardInteractive;
 import com.jcraft.jsch.UserInfo;
 import org.apache.camel.Exchange;
 import org.apache.camel.InvalidPayloadException;
 import org.apache.camel.LoggingLevel;
+import org.apache.camel.RuntimeCamelException;
 import org.apache.camel.component.file.FileComponent;
 import org.apache.camel.component.file.GenericFile;
 import 

[jira] [Commented] (CAMEL-12722) java.util.ConcurrentModificationException: KafkaConsumer is not safe for multi-threaded access

2018-08-10 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575969#comment-16575969
 ] 

Claus Ibsen commented on CAMEL-12722:
-

Yeah test containers would be nice for testing kafka - that may be easier than 
what is there today

> java.util.ConcurrentModificationException: KafkaConsumer is not safe for 
> multi-threaded access
> --
>
> Key: CAMEL-12722
> URL: https://issues.apache.org/jira/browse/CAMEL-12722
> Project: Camel
>  Issue Type: Bug
>  Components: camel-kafka
>Affects Versions: 2.22.0
>Reporter: michael elbaz
>Priority: Major
>
> I got an exception when i try to use manual commit on camel kafka component
>  
> {code:java}
> from("kafka:{{kafka.hostname}}:{{kafka.port}}?topic={{kafka.topic}}={{kafka.consumer.groupid}}=false=true")
> .process(new Processor() {
> @Override
> public void process(Exchange exchange) throws Exception {
> KafkaManualCommit manual =
> 
> exchange.getIn().getHeader(KafkaConstants.MANUAL_COMMIT, 
> KafkaManualCommit.class);
> manual.commitSync();
> }
> }).to("...")
> {code}
> The exception
> {code:java}
> Trace: java.util.ConcurrentModificationException: KafkaConsumer is not safe 
> for multi-threaded access
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.acquire(KafkaConsumer.java:1824)
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.acquireAndEnsureOpen(KafkaConsumer.java:1808)
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.commitSync(KafkaConsumer.java:1255)
>     at 
> org.apache.camel.component.kafka.DefaultKafkaManualCommit.commitOffset(DefaultKafkaManualCommit.java:60)
>     at 
> org.apache.camel.component.kafka.DefaultKafkaManualCommit.commitSync(DefaultKafkaManualCommit.java:51)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-12725) [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.

2018-08-10 Thread Zoran Regvart (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zoran Regvart resolved CAMEL-12725.
---
   Resolution: Fixed
 Assignee: Zoran Regvart
Fix Version/s: 2.23.0
   2.22.1
   2.21.3

Thanks for the pull request!

> [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.
> 
>
> Key: CAMEL-12725
> URL: https://issues.apache.org/jira/browse/CAMEL-12725
> Project: Camel
>  Issue Type: Bug
>  Components: camel-salesforce
>Affects Versions: 2.21.0, 2.21.1, 2.21.2, 2.22.0
>Reporter: Tinus Aamand Norstved
>Assignee: Zoran Regvart
>Priority: Trivial
> Fix For: 2.21.3, 2.22.1, 2.23.0
>
>
> When using "optionals" in the camel-salesforce-maven-plugin it will throw an 
> error like the following:
> {{[INFO] Generating Java Classes...}}
> {{[ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.}}
> {{Was expecting one of:}}
> {{  ...}}
> {{  ...}}
> {{  ...}}
> {{ "{" ...}}
> {{[ERROR] ResourceManager: parse exception: Encountered "(" at 
> /sobject-pojo-optional.vm[line 64, column 8]}}
> {{Was expecting one of:}}
> {{  ...}}
> {{  ...}}
> {{  ...}}
> {{ "{" ...}}
>  
> This is caused by a change in 
> [https://github.com/apache/camel/commit/2a4038c66ddc86d081e96a69eb9200f9ff498fb4#diff-ecf95a5795fc049a5d3c45ffcaf5ef00]
>  which sets the following line:
> #set ( ($fieldType = $utility.getFieldType($desc, $field)) && ($fieldType) )
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12722) java.util.ConcurrentModificationException: KafkaConsumer is not safe for multi-threaded access

2018-08-10 Thread Dmitry Volodin (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575949#comment-16575949
 ] 

Dmitry Volodin commented on CAMEL-12722:


[~michael992], in upstream we have a KafkaConsumerManualCommitTest.java which 
is ignored by default.

Could you please to enable it and test on your env to better understand is it 
correct reproducer or not?

[~davsclaus] is it a good candidate for test with camel-testcontaners or use 
separate maven profile as integration test?

> java.util.ConcurrentModificationException: KafkaConsumer is not safe for 
> multi-threaded access
> --
>
> Key: CAMEL-12722
> URL: https://issues.apache.org/jira/browse/CAMEL-12722
> Project: Camel
>  Issue Type: Bug
>  Components: camel-kafka
>Affects Versions: 2.22.0
>Reporter: michael elbaz
>Priority: Major
>
> I got an exception when i try to use manual commit on camel kafka component
>  
> {code:java}
> from("kafka:{{kafka.hostname}}:{{kafka.port}}?topic={{kafka.topic}}={{kafka.consumer.groupid}}=false=true")
> .process(new Processor() {
> @Override
> public void process(Exchange exchange) throws Exception {
> KafkaManualCommit manual =
> 
> exchange.getIn().getHeader(KafkaConstants.MANUAL_COMMIT, 
> KafkaManualCommit.class);
> manual.commitSync();
> }
> }).to("...")
> {code}
> The exception
> {code:java}
> Trace: java.util.ConcurrentModificationException: KafkaConsumer is not safe 
> for multi-threaded access
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.acquire(KafkaConsumer.java:1824)
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.acquireAndEnsureOpen(KafkaConsumer.java:1808)
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.commitSync(KafkaConsumer.java:1255)
>     at 
> org.apache.camel.component.kafka.DefaultKafkaManualCommit.commitOffset(DefaultKafkaManualCommit.java:60)
>     at 
> org.apache.camel.component.kafka.DefaultKafkaManualCommit.commitSync(DefaultKafkaManualCommit.java:51)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12308) Upgrade to CXF 3.2.2

2018-08-10 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575918#comment-16575918
 ] 

Claus Ibsen commented on CAMEL-12308:
-

Camel 2.20.x is EOL

> Upgrade to CXF 3.2.2
> 
>
> Key: CAMEL-12308
> URL: https://issues.apache.org/jira/browse/CAMEL-12308
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-cxf
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.21.0
>
>
> There is a newer version and it also fixes a problem on JDK9 in the 
> camel-itests



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-12660) Spring Boot configuration documentation should be polished

2018-08-10 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-12660.
-
Resolution: Fixed

> Spring Boot configuration documentation should be polished
> --
>
> Key: CAMEL-12660
> URL: https://issues.apache.org/jira/browse/CAMEL-12660
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-spring-boot-starters
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
>Priority: Major
> Fix For: 2.23.0
>
>
> Some of the options have descriptions with html tags for advanced javadoc. We 
> should remove those to make it plain then the spring tooling that generates 
> the metadata json file will be improved for tooling, and also our own online 
> ascii docs
> For example
> https://github.com/apache/camel/blob/camel-12644/components/camel-spring-boot/src/main/docs/spring-boot.adoc#spring-boot-auto-configuration



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12722) java.util.ConcurrentModificationException: KafkaConsumer is not safe for multi-threaded access

2018-08-10 Thread michael elbaz (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575911#comment-16575911
 ] 

michael elbaz commented on CAMEL-12722:
---

Yeah all the time in fact my route is pretty simple I have an aggregator just 
before my commit tentative. then even in debug I got the exception at the first 
message. 


> java.util.ConcurrentModificationException: KafkaConsumer is not safe for 
> multi-threaded access
> --
>
> Key: CAMEL-12722
> URL: https://issues.apache.org/jira/browse/CAMEL-12722
> Project: Camel
>  Issue Type: Bug
>  Components: camel-kafka
>Affects Versions: 2.22.0
>Reporter: michael elbaz
>Priority: Major
>
> I got an exception when i try to use manual commit on camel kafka component
>  
> {code:java}
> from("kafka:{{kafka.hostname}}:{{kafka.port}}?topic={{kafka.topic}}={{kafka.consumer.groupid}}=false=true")
> .process(new Processor() {
> @Override
> public void process(Exchange exchange) throws Exception {
> KafkaManualCommit manual =
> 
> exchange.getIn().getHeader(KafkaConstants.MANUAL_COMMIT, 
> KafkaManualCommit.class);
> manual.commitSync();
> }
> }).to("...")
> {code}
> The exception
> {code:java}
> Trace: java.util.ConcurrentModificationException: KafkaConsumer is not safe 
> for multi-threaded access
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.acquire(KafkaConsumer.java:1824)
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.acquireAndEnsureOpen(KafkaConsumer.java:1808)
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.commitSync(KafkaConsumer.java:1255)
>     at 
> org.apache.camel.component.kafka.DefaultKafkaManualCommit.commitOffset(DefaultKafkaManualCommit.java:60)
>     at 
> org.apache.camel.component.kafka.DefaultKafkaManualCommit.commitSync(DefaultKafkaManualCommit.java:51)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (CAMEL-12724) Simple SFTP-to-File integration with charset options fails

2018-08-10 Thread Tadayoshi Sato (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tadayoshi Sato resolved CAMEL-12724.

Resolution: Fixed

> Simple SFTP-to-File integration with charset options fails
> --
>
> Key: CAMEL-12724
> URL: https://issues.apache.org/jira/browse/CAMEL-12724
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core, camel-ftp
>Affects Versions: 2.22.0
>Reporter: Tadayoshi Sato
>Assignee: Tadayoshi Sato
>Priority: Major
> Fix For: 2.21.3, 2.22.1, 2.23.0
>
> Attachments: SftpToFileTest.zip
>
>
> Simple SFTP-to-File integrations with {{charset}} conversion like:
> {code:java}
> from("sftp://sample@localhost:/in?password=password=true=ISO-8859-1;)
> .to("file:/tmp/samples-camel/SftpToFileTest/out?charset=UTF-8");
> {code}
> fails to output a file in {{/tmp/samples-camel/SftpToFileTest/out/}} 
> correctly. Depending on the combinations, it sometimes converts the charset 
> wrongly and sometimes it simply doesn't output a file to the target dir.
> The root cause is that {{SftpOperations}} puts {{ByteArrayOutputStream}} 
> instead of {{byte[]}} or {{InputStream}} to the exchange file body when 
> retrieving a file:
> https://github.com/apache/camel/blob/camel-2.22.0/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java#L718-L720
> which then results in no converter from {{OutputStream}} to 
> {{java.io.Reader}} being found in {{GenericFileConverter}} downstream, and 
> thus the File producer handles a {{RemoteFile}} awkwardly when outputting a 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12725) [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.

2018-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575895#comment-16575895
 ] 

ASF GitHub Bot commented on CAMEL-12725:


zregvart closed pull request #2464: CAMEL-12725: [ERROR] 
/sobject-pojo-optional.vm
URL: https://github.com/apache/camel/pull/2464
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/components/camel-salesforce/camel-salesforce-maven-plugin/src/main/resources/sobject-pojo-optional.vm
 
b/components/camel-salesforce/camel-salesforce-maven-plugin/src/main/resources/sobject-pojo-optional.vm
index 3caea042b82..55d9ce16255 100644
--- 
a/components/camel-salesforce/camel-salesforce-maven-plugin/src/main/resources/sobject-pojo-optional.vm
+++ 
b/components/camel-salesforce/camel-salesforce-maven-plugin/src/main/resources/sobject-pojo-optional.vm
@@ -61,7 +61,7 @@ import 
com.fasterxml.jackson.databind.annotation.JsonSerialize;
 public class ${desc.Name}Optional extends AbstractSObjectBase {
 
 #foreach ( $field in $desc.Fields )
-#set ( ($fieldType = $utility.getFieldType($desc, $field)) && ($fieldType) )
+#set ( $fieldType = $utility.getFieldType($desc, $field) )
 #if ( $utility.notBaseField($field.Name) )
 #set ( $fieldName = $field.Name )
 #set ( $isMultiSelectPicklist = $utility.isMultiSelectPicklist($field) )


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.
> 
>
> Key: CAMEL-12725
> URL: https://issues.apache.org/jira/browse/CAMEL-12725
> Project: Camel
>  Issue Type: Bug
>  Components: camel-salesforce
>Affects Versions: 2.21.0, 2.21.1, 2.21.2, 2.22.0
>Reporter: Tinus Aamand Norstved
>Priority: Trivial
>
> When using "optionals" in the camel-salesforce-maven-plugin it will throw an 
> error like the following:
> {{[INFO] Generating Java Classes...}}
> {{[ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.}}
> {{Was expecting one of:}}
> {{  ...}}
> {{  ...}}
> {{  ...}}
> {{ "{" ...}}
> {{[ERROR] ResourceManager: parse exception: Encountered "(" at 
> /sobject-pojo-optional.vm[line 64, column 8]}}
> {{Was expecting one of:}}
> {{  ...}}
> {{  ...}}
> {{  ...}}
> {{ "{" ...}}
>  
> This is caused by a change in 
> [https://github.com/apache/camel/commit/2a4038c66ddc86d081e96a69eb9200f9ff498fb4#diff-ecf95a5795fc049a5d3c45ffcaf5ef00]
>  which sets the following line:
> #set ( ($fieldType = $utility.getFieldType($desc, $field)) && ($fieldType) )
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12725) [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.

2018-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575896#comment-16575896
 ] 

ASF GitHub Bot commented on CAMEL-12725:


Github user zregvart closed the pull request at:

https://github.com/apache/camel/pull/2464


> [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.
> 
>
> Key: CAMEL-12725
> URL: https://issues.apache.org/jira/browse/CAMEL-12725
> Project: Camel
>  Issue Type: Bug
>  Components: camel-salesforce
>Affects Versions: 2.21.0, 2.21.1, 2.21.2, 2.22.0
>Reporter: Tinus Aamand Norstved
>Priority: Trivial
>
> When using "optionals" in the camel-salesforce-maven-plugin it will throw an 
> error like the following:
> {{[INFO] Generating Java Classes...}}
> {{[ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.}}
> {{Was expecting one of:}}
> {{  ...}}
> {{  ...}}
> {{  ...}}
> {{ "{" ...}}
> {{[ERROR] ResourceManager: parse exception: Encountered "(" at 
> /sobject-pojo-optional.vm[line 64, column 8]}}
> {{Was expecting one of:}}
> {{  ...}}
> {{  ...}}
> {{  ...}}
> {{ "{" ...}}
>  
> This is caused by a change in 
> [https://github.com/apache/camel/commit/2a4038c66ddc86d081e96a69eb9200f9ff498fb4#diff-ecf95a5795fc049a5d3c45ffcaf5ef00]
>  which sets the following line:
> #set ( ($fieldType = $utility.getFieldType($desc, $field)) && ($fieldType) )
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12723) Camel ftp component does not support IPV6

2018-08-10 Thread Zhangbo (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575893#comment-16575893
 ] 

Zhangbo commented on CAMEL-12723:
-

I recommend that other components also consider IPV6 address support

> Camel ftp component does not support  IPV6
> --
>
> Key: CAMEL-12723
> URL: https://issues.apache.org/jira/browse/CAMEL-12723
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Reporter: Zhangbo
>Priority: Major
> Fix For: 2.23.0
>
>
> Dear Camel team, we are just verifying our migrated application to Apache 
> Camel. Today we found an issue that is not described on the web, in the faq 
> nor among the existing issues. We are creating endpoints via String literals 
> and when we started the IPv6 tests we failed on this issue. The Camel 
> transforms the orginal address 
> \{noformat}ftp://[2a00:8a00:6000:40::1413]:8080\{noformat} to this format 
> \{noformat}ftp://%5B2a00:8a00:6000:40::1413%5D:8080\{noformat} which causes 
> this exception \{noformat}instance1 2013-10-30 13:25:23,914 
> org.apache.camel.processor.DefaultErrorHandler DEBUG 
> (MarkerIgnoringBase.java:debug:72) [Camel (camel-1) thread #74 - 
> JmsConsumer[XXX-RR-TEST]] | Failed delivery for (MessageId: 
> ID:mch30-pgd02-b-45068-1383134137465-8:5:1:1:3 on ExchangeId: 
> ID-mch30-pgd02-b-35624-1383134141407-0-176). On delivery attempt: 0 caught: 
> org.apache.commons.httpclient.URIException: IPv6reference\{noformat} The 
> suggested solution is to remove the square brackets \{noformat}[ ]\{noformat} 
> from the \{noformat}unsafeCharacters\{noformat} in the 
> \{noformat}org.apache.camel.util.UnsafeUriCharactersEncoder\{noformat} since 
> the square brackets are valid IPv6 characters. Thanks! Best regards, Laci



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-12725) [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.

2018-08-10 Thread Tinus Aamand Norstved (JIRA)
Tinus Aamand Norstved created CAMEL-12725:
-

 Summary: [ERROR] /sobject-pojo-optional.vm: Encountered "(" at 
line 64, column 8.
 Key: CAMEL-12725
 URL: https://issues.apache.org/jira/browse/CAMEL-12725
 Project: Camel
  Issue Type: Bug
  Components: camel-salesforce
Affects Versions: 2.22.0, 2.21.2, 2.21.1, 2.21.0
Reporter: Tinus Aamand Norstved


When using "optionals" in the camel-salesforce-maven-plugin it will throw an 
error like the following:

{{[INFO] Generating Java Classes...}}
{{[ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.}}
{{Was expecting one of:}}
{{  ...}}
{{  ...}}
{{  ...}}
{{ "{" ...}}

{{[ERROR] ResourceManager: parse exception: Encountered "(" at 
/sobject-pojo-optional.vm[line 64, column 8]}}
{{Was expecting one of:}}
{{  ...}}
{{  ...}}
{{  ...}}
{{ "{" ...}}

 

This is caused by a change in 
[https://github.com/apache/camel/commit/2a4038c66ddc86d081e96a69eb9200f9ff498fb4#diff-ecf95a5795fc049a5d3c45ffcaf5ef00]
 which sets the following line:

#set ( ($fieldType = $utility.getFieldType($desc, $field)) && ($fieldType) )

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12725) [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.

2018-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575884#comment-16575884
 ] 

ASF GitHub Bot commented on CAMEL-12725:


tinusn opened a new pull request #2464: CAMEL-12725: [ERROR] 
/sobject-pojo-optional.vm
URL: https://github.com/apache/camel/pull/2464
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.
> 
>
> Key: CAMEL-12725
> URL: https://issues.apache.org/jira/browse/CAMEL-12725
> Project: Camel
>  Issue Type: Bug
>  Components: camel-salesforce
>Affects Versions: 2.21.0, 2.21.1, 2.21.2, 2.22.0
>Reporter: Tinus Aamand Norstved
>Priority: Trivial
>
> When using "optionals" in the camel-salesforce-maven-plugin it will throw an 
> error like the following:
> {{[INFO] Generating Java Classes...}}
> {{[ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.}}
> {{Was expecting one of:}}
> {{  ...}}
> {{  ...}}
> {{  ...}}
> {{ "{" ...}}
> {{[ERROR] ResourceManager: parse exception: Encountered "(" at 
> /sobject-pojo-optional.vm[line 64, column 8]}}
> {{Was expecting one of:}}
> {{  ...}}
> {{  ...}}
> {{  ...}}
> {{ "{" ...}}
>  
> This is caused by a change in 
> [https://github.com/apache/camel/commit/2a4038c66ddc86d081e96a69eb9200f9ff498fb4#diff-ecf95a5795fc049a5d3c45ffcaf5ef00]
>  which sets the following line:
> #set ( ($fieldType = $utility.getFieldType($desc, $field)) && ($fieldType) )
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12725) [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.

2018-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575885#comment-16575885
 ] 

ASF GitHub Bot commented on CAMEL-12725:


GitHub user tinusn opened a pull request:

https://github.com/apache/camel/pull/2464

CAMEL-12725: [ERROR] /sobject-pojo-optional.vm



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tinusn/camel master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2464


commit b0652d9707cbd4696d31467b258c2bd61f784980
Author: Tinus Aamand Norstved 
Date:   2018-08-10T07:13:05Z

Update sobject-pojo-optional.vm

Fixed error in setting the $fieldType - the syntax in the template document 
throws the  following error upon running:

[ERROR] Failed to execute goal 
org.apache.camel.maven:camel-salesforce-maven-plugin:2.21.0:generate 
(executable pom) on project test-project: Execution executable pom of goal 
org.apache.camel.maven:camel-salesforce-maven-plugin:2.21.0:generate failed: 
Encountered "(" at /sobject-pojo-optional.vm[line 64, column 8]
[ERROR] Was expecting one of:
[ERROR]  ...
[ERROR]  ...
[ERROR]  ...
[ERROR] "{" ...


This change fixes that.

commit 3aa87a7d67332139e69085881d55c7914a7b8efd
Author: Tinus Aamand Norstved 
Date:   2018-08-10T07:30:00Z

Merge pull request #1 from tinusn/tinusn-patch-1

Update sobject-pojo-optional.vm




> [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.
> 
>
> Key: CAMEL-12725
> URL: https://issues.apache.org/jira/browse/CAMEL-12725
> Project: Camel
>  Issue Type: Bug
>  Components: camel-salesforce
>Affects Versions: 2.21.0, 2.21.1, 2.21.2, 2.22.0
>Reporter: Tinus Aamand Norstved
>Priority: Trivial
>
> When using "optionals" in the camel-salesforce-maven-plugin it will throw an 
> error like the following:
> {{[INFO] Generating Java Classes...}}
> {{[ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.}}
> {{Was expecting one of:}}
> {{  ...}}
> {{  ...}}
> {{  ...}}
> {{ "{" ...}}
> {{[ERROR] ResourceManager: parse exception: Encountered "(" at 
> /sobject-pojo-optional.vm[line 64, column 8]}}
> {{Was expecting one of:}}
> {{  ...}}
> {{  ...}}
> {{  ...}}
> {{ "{" ...}}
>  
> This is caused by a change in 
> [https://github.com/apache/camel/commit/2a4038c66ddc86d081e96a69eb9200f9ff498fb4#diff-ecf95a5795fc049a5d3c45ffcaf5ef00]
>  which sets the following line:
> #set ( ($fieldType = $utility.getFieldType($desc, $field)) && ($fieldType) )
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12725) [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.

2018-08-10 Thread Tinus Aamand Norstved (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575886#comment-16575886
 ] 

Tinus Aamand Norstved commented on CAMEL-12725:
---

Created a pull request at github: [https://github.com/apache/camel/pull/2464]

> [ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.
> 
>
> Key: CAMEL-12725
> URL: https://issues.apache.org/jira/browse/CAMEL-12725
> Project: Camel
>  Issue Type: Bug
>  Components: camel-salesforce
>Affects Versions: 2.21.0, 2.21.1, 2.21.2, 2.22.0
>Reporter: Tinus Aamand Norstved
>Priority: Trivial
>
> When using "optionals" in the camel-salesforce-maven-plugin it will throw an 
> error like the following:
> {{[INFO] Generating Java Classes...}}
> {{[ERROR] /sobject-pojo-optional.vm: Encountered "(" at line 64, column 8.}}
> {{Was expecting one of:}}
> {{  ...}}
> {{  ...}}
> {{  ...}}
> {{ "{" ...}}
> {{[ERROR] ResourceManager: parse exception: Encountered "(" at 
> /sobject-pojo-optional.vm[line 64, column 8]}}
> {{Was expecting one of:}}
> {{  ...}}
> {{  ...}}
> {{  ...}}
> {{ "{" ...}}
>  
> This is caused by a change in 
> [https://github.com/apache/camel/commit/2a4038c66ddc86d081e96a69eb9200f9ff498fb4#diff-ecf95a5795fc049a5d3c45ffcaf5ef00]
>  which sets the following line:
> #set ( ($fieldType = $utility.getFieldType($desc, $field)) && ($fieldType) )
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12724) Simple SFTP-to-File integration with charset options fails

2018-08-10 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575880#comment-16575880
 ] 

ASF GitHub Bot commented on CAMEL-12724:


Github user davsclaus closed the pull request at:

https://github.com/apache/camel/pull/2463


> Simple SFTP-to-File integration with charset options fails
> --
>
> Key: CAMEL-12724
> URL: https://issues.apache.org/jira/browse/CAMEL-12724
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core, camel-ftp
>Affects Versions: 2.22.0
>Reporter: Tadayoshi Sato
>Assignee: Tadayoshi Sato
>Priority: Major
> Fix For: 2.21.3, 2.22.1, 2.23.0
>
> Attachments: SftpToFileTest.zip
>
>
> Simple SFTP-to-File integrations with {{charset}} conversion like:
> {code:java}
> from("sftp://sample@localhost:/in?password=password=true=ISO-8859-1;)
> .to("file:/tmp/samples-camel/SftpToFileTest/out?charset=UTF-8");
> {code}
> fails to output a file in {{/tmp/samples-camel/SftpToFileTest/out/}} 
> correctly. Depending on the combinations, it sometimes converts the charset 
> wrongly and sometimes it simply doesn't output a file to the target dir.
> The root cause is that {{SftpOperations}} puts {{ByteArrayOutputStream}} 
> instead of {{byte[]}} or {{InputStream}} to the exchange file body when 
> retrieving a file:
> https://github.com/apache/camel/blob/camel-2.22.0/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java#L718-L720
> which then results in no converter from {{OutputStream}} to 
> {{java.io.Reader}} being found in {{GenericFileConverter}} downstream, and 
> thus the File producer handles a {{RemoteFile}} awkwardly when outputting a 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-12711) SFTP: Cannot specify bind address of local network interface

2018-08-10 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-12711:

Issue Type: Improvement  (was: Bug)

> SFTP: Cannot specify bind address of local network interface
> 
>
> Key: CAMEL-12711
> URL: https://issues.apache.org/jira/browse/CAMEL-12711
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-ftp
>Affects Versions: 2.22.0
>Reporter: Felix Feisst
>Priority: Major
> Fix For: 2.23.0
>
>
> In an environment with multiple network interfaces, it might be necessary to 
> specify the address of the local interface, to which the SFTP connection 
> should bind. Unfortunately, this is not possible with the latest version of 
> camel-ftp.
>  
> A new URI parameter 'bindAddress' should be introduces which can then be set 
> to the IP-Address of the local network interface against which the SFTP 
> connection should bind.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12722) java.util.ConcurrentModificationException: KafkaConsumer is not safe for multi-threaded access

2018-08-10 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575877#comment-16575877
 ] 

Claus Ibsen commented on CAMEL-12722:
-

Do you get this exception every time, or only sometimes?

> java.util.ConcurrentModificationException: KafkaConsumer is not safe for 
> multi-threaded access
> --
>
> Key: CAMEL-12722
> URL: https://issues.apache.org/jira/browse/CAMEL-12722
> Project: Camel
>  Issue Type: Bug
>  Components: camel-kafka
>Affects Versions: 2.22.0
>Reporter: michael elbaz
>Priority: Major
>
> I got an exception when i try to use manual commit on camel kafka component
>  
> {code:java}
> from("kafka:{{kafka.hostname}}:{{kafka.port}}?topic={{kafka.topic}}={{kafka.consumer.groupid}}=false=true")
> .process(new Processor() {
> @Override
> public void process(Exchange exchange) throws Exception {
> KafkaManualCommit manual =
> 
> exchange.getIn().getHeader(KafkaConstants.MANUAL_COMMIT, 
> KafkaManualCommit.class);
> manual.commitSync();
> }
> }).to("...")
> {code}
> The exception
> {code:java}
> Trace: java.util.ConcurrentModificationException: KafkaConsumer is not safe 
> for multi-threaded access
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.acquire(KafkaConsumer.java:1824)
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.acquireAndEnsureOpen(KafkaConsumer.java:1808)
>     at 
> org.apache.kafka.clients.consumer.KafkaConsumer.commitSync(KafkaConsumer.java:1255)
>     at 
> org.apache.camel.component.kafka.DefaultKafkaManualCommit.commitOffset(DefaultKafkaManualCommit.java:60)
>     at 
> org.apache.camel.component.kafka.DefaultKafkaManualCommit.commitSync(DefaultKafkaManualCommit.java:51)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-12711) SFTP: Cannot specify bind address of local network interface

2018-08-10 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-12711:

Fix Version/s: 2.23.0

> SFTP: Cannot specify bind address of local network interface
> 
>
> Key: CAMEL-12711
> URL: https://issues.apache.org/jira/browse/CAMEL-12711
> Project: Camel
>  Issue Type: Bug
>  Components: camel-ftp
>Affects Versions: 2.22.0
>Reporter: Felix Feisst
>Priority: Major
> Fix For: 2.23.0
>
>
> In an environment with multiple network interfaces, it might be necessary to 
> specify the address of the local interface, to which the SFTP connection 
> should bind. Unfortunately, this is not possible with the latest version of 
> camel-ftp.
>  
> A new URI parameter 'bindAddress' should be introduces which can then be set 
> to the IP-Address of the local network interface against which the SFTP 
> connection should bind.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-12719) Ability to load an SSLContextParameter with a Keystore containing multiple keys (aliases)

2018-08-10 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-12719:

Fix Version/s: 2.23.0

> Ability to load an SSLContextParameter with a Keystore containing multiple 
> keys (aliases)
> -
>
> Key: CAMEL-12719
> URL: https://issues.apache.org/jira/browse/CAMEL-12719
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Affects Versions: 2.22.0
> Environment: Apache Tomcat 7, Camel 2.22.0, java 8, redHat 6.6
> 1 TrustStore.jks (12 certificats CA => 12 alias)
> 1 Keystore.jsk (5 clés => 5 alias => 5 passwords différents)
> > 200 camelRoutes (file, soap, rest) secure, non-secure
>Reporter: Florian B.
>Priority: Major
>  Labels: features
> Fix For: 2.23.0
>
>
> Hello,
> I wish I could initialize a single SSLContextParameters at camel startup 
> containing my truststore.jks (> 1 alias) and my keystore.jks (> 1 alias) in 
> order to call it (refer to) in Routes (FTPs, HTTPs) without have to redefine 
> a new SSLContextParameter for each EndPoint.
> __
>  __
>  _  _resource="${truststore.jks.file.location}" />_
>  __
>  __
>  _  _resource="${keystore.jks.file.location}" />_
>  __
>  __
> When my Keystore contains more than 1 alias, I have the following error when 
> creating the Route at startup : 
> *Caused by: org.apache.camel.ResolveEndpointFailedException: Failed to 
> resolve endpoint: 
> https4://:/?authPassword=RAW(password)=login=true=true=sslContextParameters=true
>  due to: Cannot recover key*
> due to
> *Caused by: java.security.UnrecoverableKeyException: Cannot recover key*
>  
> When my keystore contains only one key, it works very well.
> __
>  __
>  _  _resource="${truststore.jks.file.location}" />_
>  __
>  __
>  _  _resource="${keystore.jks.file.location}" />_
>  __
>  __
>  
> So I would like to be able to call my SSLContextParameter for different 
> EndPoint by specifying (if necessary) the alias of the Keystore needed (by 
> specifying the alias and / or password of the key)
>  
> Objectif in my project :
>  * 1 TrustStore.jks 
>  * 1 Keystore.jsk
>  * 1 unique SSLContextParameter
>  * > 200 camelRoutes FTPs/HTTPs (ssl one way ou two way)
>  
> Thank a lot
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12723) Camel ftp component does not support IPV6

2018-08-10 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575875#comment-16575875
 ] 

Claus Ibsen commented on CAMEL-12723:
-

You are welcome to provide a github PR with a suggested fix
http://camel.apache.org/contributing

> Camel ftp component does not support  IPV6
> --
>
> Key: CAMEL-12723
> URL: https://issues.apache.org/jira/browse/CAMEL-12723
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Reporter: Zhangbo
>Priority: Major
> Fix For: 2.23.0
>
>
> Dear Camel team, we are just verifying our migrated application to Apache 
> Camel. Today we found an issue that is not described on the web, in the faq 
> nor among the existing issues. We are creating endpoints via String literals 
> and when we started the IPv6 tests we failed on this issue. The Camel 
> transforms the orginal address 
> \{noformat}ftp://[2a00:8a00:6000:40::1413]:8080\{noformat} to this format 
> \{noformat}ftp://%5B2a00:8a00:6000:40::1413%5D:8080\{noformat} which causes 
> this exception \{noformat}instance1 2013-10-30 13:25:23,914 
> org.apache.camel.processor.DefaultErrorHandler DEBUG 
> (MarkerIgnoringBase.java:debug:72) [Camel (camel-1) thread #74 - 
> JmsConsumer[XXX-RR-TEST]] | Failed delivery for (MessageId: 
> ID:mch30-pgd02-b-45068-1383134137465-8:5:1:1:3 on ExchangeId: 
> ID-mch30-pgd02-b-35624-1383134141407-0-176). On delivery attempt: 0 caught: 
> org.apache.commons.httpclient.URIException: IPv6reference\{noformat} The 
> suggested solution is to remove the square brackets \{noformat}[ ]\{noformat} 
> from the \{noformat}unsafeCharacters\{noformat} in the 
> \{noformat}org.apache.camel.util.UnsafeUriCharactersEncoder\{noformat} since 
> the square brackets are valid IPv6 characters. Thanks! Best regards, Laci



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-12723) Camel ftp component does not support IPV6

2018-08-10 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-12723:

Issue Type: Improvement  (was: Bug)

> Camel ftp component does not support  IPV6
> --
>
> Key: CAMEL-12723
> URL: https://issues.apache.org/jira/browse/CAMEL-12723
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Reporter: Zhangbo
>Priority: Major
> Fix For: 2.23.0
>
>
> Dear Camel team, we are just verifying our migrated application to Apache 
> Camel. Today we found an issue that is not described on the web, in the faq 
> nor among the existing issues. We are creating endpoints via String literals 
> and when we started the IPv6 tests we failed on this issue. The Camel 
> transforms the orginal address 
> \{noformat}ftp://[2a00:8a00:6000:40::1413]:8080\{noformat} to this format 
> \{noformat}ftp://%5B2a00:8a00:6000:40::1413%5D:8080\{noformat} which causes 
> this exception \{noformat}instance1 2013-10-30 13:25:23,914 
> org.apache.camel.processor.DefaultErrorHandler DEBUG 
> (MarkerIgnoringBase.java:debug:72) [Camel (camel-1) thread #74 - 
> JmsConsumer[XXX-RR-TEST]] | Failed delivery for (MessageId: 
> ID:mch30-pgd02-b-45068-1383134137465-8:5:1:1:3 on ExchangeId: 
> ID-mch30-pgd02-b-35624-1383134141407-0-176). On delivery attempt: 0 caught: 
> org.apache.commons.httpclient.URIException: IPv6reference\{noformat} The 
> suggested solution is to remove the square brackets \{noformat}[ ]\{noformat} 
> from the \{noformat}unsafeCharacters\{noformat} in the 
> \{noformat}org.apache.camel.util.UnsafeUriCharactersEncoder\{noformat} since 
> the square brackets are valid IPv6 characters. Thanks! Best regards, Laci



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-12723) Camel ftp component does not support IPV6

2018-08-10 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-12723:

Fix Version/s: 2.23.0

> Camel ftp component does not support  IPV6
> --
>
> Key: CAMEL-12723
> URL: https://issues.apache.org/jira/browse/CAMEL-12723
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-core
>Reporter: Zhangbo
>Priority: Major
> Fix For: 2.23.0
>
>
> Dear Camel team, we are just verifying our migrated application to Apache 
> Camel. Today we found an issue that is not described on the web, in the faq 
> nor among the existing issues. We are creating endpoints via String literals 
> and when we started the IPv6 tests we failed on this issue. The Camel 
> transforms the orginal address 
> \{noformat}ftp://[2a00:8a00:6000:40::1413]:8080\{noformat} to this format 
> \{noformat}ftp://%5B2a00:8a00:6000:40::1413%5D:8080\{noformat} which causes 
> this exception \{noformat}instance1 2013-10-30 13:25:23,914 
> org.apache.camel.processor.DefaultErrorHandler DEBUG 
> (MarkerIgnoringBase.java:debug:72) [Camel (camel-1) thread #74 - 
> JmsConsumer[XXX-RR-TEST]] | Failed delivery for (MessageId: 
> ID:mch30-pgd02-b-45068-1383134137465-8:5:1:1:3 on ExchangeId: 
> ID-mch30-pgd02-b-35624-1383134141407-0-176). On delivery attempt: 0 caught: 
> org.apache.commons.httpclient.URIException: IPv6reference\{noformat} The 
> suggested solution is to remove the square brackets \{noformat}[ ]\{noformat} 
> from the \{noformat}unsafeCharacters\{noformat} in the 
> \{noformat}org.apache.camel.util.UnsafeUriCharactersEncoder\{noformat} since 
> the square brackets are valid IPv6 characters. Thanks! Best regards, Laci



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-12724) Simple SFTP-to-File integration with charset options fails

2018-08-10 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-12724:

Fix Version/s: 2.23.0
   2.22.1
   2.21.3

> Simple SFTP-to-File integration with charset options fails
> --
>
> Key: CAMEL-12724
> URL: https://issues.apache.org/jira/browse/CAMEL-12724
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core, camel-ftp
>Affects Versions: 2.22.0
>Reporter: Tadayoshi Sato
>Assignee: Tadayoshi Sato
>Priority: Major
> Fix For: 2.21.3, 2.22.1, 2.23.0
>
> Attachments: SftpToFileTest.zip
>
>
> Simple SFTP-to-File integrations with {{charset}} conversion like:
> {code:java}
> from("sftp://sample@localhost:/in?password=password=true=ISO-8859-1;)
> .to("file:/tmp/samples-camel/SftpToFileTest/out?charset=UTF-8");
> {code}
> fails to output a file in {{/tmp/samples-camel/SftpToFileTest/out/}} 
> correctly. Depending on the combinations, it sometimes converts the charset 
> wrongly and sometimes it simply doesn't output a file to the target dir.
> The root cause is that {{SftpOperations}} puts {{ByteArrayOutputStream}} 
> instead of {{byte[]}} or {{InputStream}} to the exchange file body when 
> retrieving a file:
> https://github.com/apache/camel/blob/camel-2.22.0/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java#L718-L720
> which then results in no converter from {{OutputStream}} to 
> {{java.io.Reader}} being found in {{GenericFileConverter}} downstream, and 
> thus the File producer handles a {{RemoteFile}} awkwardly when outputting a 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-12724) Simple SFTP-to-File integration with charset options fails

2018-08-10 Thread Tadayoshi Sato (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tadayoshi Sato updated CAMEL-12724:
---
Attachment: SftpToFileTest.zip

> Simple SFTP-to-File integration with charset options fails
> --
>
> Key: CAMEL-12724
> URL: https://issues.apache.org/jira/browse/CAMEL-12724
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core, camel-ftp
>Affects Versions: 2.22.0
>Reporter: Tadayoshi Sato
>Assignee: Tadayoshi Sato
>Priority: Major
> Attachments: SftpToFileTest.zip
>
>
> Simple SFTP-to-File integrations with {{charset}} conversion like:
> {code:java}
> from("sftp://sample@localhost:/in?password=password=true=ISO-8859-1;)
> .to("file:/tmp/samples-camel/SftpToFileTest/out?charset=UTF-8");
> {code}
> fails to output a file in {{/tmp/samples-camel/SftpToFileTest/out/}} 
> correctly. Depending on the combinations, it sometimes converts the charset 
> wrongly and sometimes it simply doesn't output a file to the target dir.
> The root cause is that {{SftpOperations}} puts {{ByteArrayOutputStream}} 
> instead of {{byte[]}} or {{InputStream}} to the exchange file body when 
> retrieving a file:
> https://github.com/apache/camel/blob/camel-2.22.0/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java#L718-L720
> which then results in no converter from {{OutputStream}} to 
> {{java.io.Reader}} being found in {{GenericFileConverter}} downstream, and 
> thus the File producer handles a {{RemoteFile}} awkwardly when outputting a 
> file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12720) Krati implementation does not work properly persistence after put operation.

2018-08-10 Thread Claus Ibsen (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575869#comment-16575869
 ] 

Claus Ibsen commented on CAMEL-12720:
-

Yes its deprecated. But if we can fix bugs in it then that is okay also.

> Krati implementation does not work properly persistence after put operation.
> 
>
> Key: CAMEL-12720
> URL: https://issues.apache.org/jira/browse/CAMEL-12720
> Project: Camel
>  Issue Type: Bug
>  Components: camel-krati
>Reporter: Vladimir Cibulka
>Priority: Major
>
> In KratiProducer class 
> } else {
>            Object value = getValue(exchange);
>            //Its required to have only one thread putting stuff there at any 
> given time per store.
>             synchronized (endpoint.getPath().intern()) {
>             dataStore.put(key, value);
>             {color:#FF}dataStore.persist();  {color:#d04437}// Here 
> should be this{color}{color}
>            }
>  }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-12724) Simple SFTP-to-File integration with charset options fails

2018-08-10 Thread Tadayoshi Sato (JIRA)
Tadayoshi Sato created CAMEL-12724:
--

 Summary: Simple SFTP-to-File integration with charset options fails
 Key: CAMEL-12724
 URL: https://issues.apache.org/jira/browse/CAMEL-12724
 Project: Camel
  Issue Type: Bug
  Components: camel-core, camel-ftp
Affects Versions: 2.22.0
Reporter: Tadayoshi Sato
Assignee: Tadayoshi Sato


Simple SFTP-to-File integrations with {{charset}} conversion like:
{code:java}
from("sftp://sample@localhost:/in?password=password=true=ISO-8859-1;)
.to("file:/tmp/samples-camel/SftpToFileTest/out?charset=UTF-8");
{code}
fails to output a file in {{/tmp/samples-camel/SftpToFileTest/out/}} correctly. 
Depending on the combinations, it sometimes converts the charset wrongly and 
sometimes it simply doesn't output a file to the target dir.

The root cause is that {{SftpOperations}} puts {{ByteArrayOutputStream}} 
instead of {{byte[]}} or {{InputStream}} to the exchange file body when 
retrieving a file:
https://github.com/apache/camel/blob/camel-2.22.0/components/camel-ftp/src/main/java/org/apache/camel/component/file/remote/SftpOperations.java#L718-L720
which then results in no converter from {{OutputStream}} to {{java.io.Reader}} 
being found in {{GenericFileConverter}} downstream, and thus the File producer 
handles a {{RemoteFile}} awkwardly when outputting a file.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CAMEL-12723) Camel ftp component does not support IPV6

2018-08-10 Thread Zhangbo (JIRA)
Zhangbo created CAMEL-12723:
---

 Summary: Camel ftp component does not support  IPV6
 Key: CAMEL-12723
 URL: https://issues.apache.org/jira/browse/CAMEL-12723
 Project: Camel
  Issue Type: Bug
  Components: camel-core
Reporter: Zhangbo


Dear Camel team, we are just verifying our migrated application to Apache 
Camel. Today we found an issue that is not described on the web, in the faq nor 
among the existing issues. We are creating endpoints via String literals and 
when we started the IPv6 tests we failed on this issue. The Camel transforms 
the orginal address \{noformat}ftp://[2a00:8a00:6000:40::1413]:8080\{noformat} 
to this format \{noformat}ftp://%5B2a00:8a00:6000:40::1413%5D:8080\{noformat} 
which causes this exception \{noformat}instance1 2013-10-30 13:25:23,914 
org.apache.camel.processor.DefaultErrorHandler DEBUG 
(MarkerIgnoringBase.java:debug:72) [Camel (camel-1) thread #74 - 
JmsConsumer[XXX-RR-TEST]] | Failed delivery for (MessageId: 
ID:mch30-pgd02-b-45068-1383134137465-8:5:1:1:3 on ExchangeId: 
ID-mch30-pgd02-b-35624-1383134141407-0-176). On delivery attempt: 0 caught: 
org.apache.commons.httpclient.URIException: IPv6reference\{noformat} The 
suggested solution is to remove the square brackets \{noformat}[ ]\{noformat} 
from the \{noformat}unsafeCharacters\{noformat} in the 
\{noformat}org.apache.camel.util.UnsafeUriCharactersEncoder\{noformat} since 
the square brackets are valid IPv6 characters. Thanks! Best regards, Laci



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (CAMEL-12720) Krati implementation does not work properly persistence after put operation.

2018-08-10 Thread Dmitry Volodin (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575847#comment-16575847
 ] 

Dmitry Volodin edited comment on CAMEL-12720 at 8/10/18 7:12 AM:
-

[~vcibulka], you are welcome to provide a fix and fix/add JUnit test.

However, Krati is not updated for more than 5 years and we need to understand 
is this component still actual or not.

[~davsclaus], [~ancosen] what do you think about this component deprecation?


was (Author: dmvolod):
[~vcibulka], you are welcome to provide a fix and fix/add JUnit test.

> Krati implementation does not work properly persistence after put operation.
> 
>
> Key: CAMEL-12720
> URL: https://issues.apache.org/jira/browse/CAMEL-12720
> Project: Camel
>  Issue Type: Bug
>  Components: camel-krati
>Reporter: Vladimir Cibulka
>Priority: Major
>
> In KratiProducer class 
> } else {
>            Object value = getValue(exchange);
>            //Its required to have only one thread putting stuff there at any 
> given time per store.
>             synchronized (endpoint.getPath().intern()) {
>             dataStore.put(key, value);
>             {color:#FF}dataStore.persist();  {color:#d04437}// Here 
> should be this{color}{color}
>            }
>  }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (CAMEL-12720) Krati implementation does not work properly persistence after put operation.

2018-08-10 Thread Dmitry Volodin (JIRA)


[ 
https://issues.apache.org/jira/browse/CAMEL-12720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575847#comment-16575847
 ] 

Dmitry Volodin commented on CAMEL-12720:


[~vcibulka], you are welcome to provide a fix and fix/add JUnit test.

> Krati implementation does not work properly persistence after put operation.
> 
>
> Key: CAMEL-12720
> URL: https://issues.apache.org/jira/browse/CAMEL-12720
> Project: Camel
>  Issue Type: Bug
>  Components: camel-krati
>Reporter: Vladimir Cibulka
>Priority: Major
>
> In KratiProducer class 
> } else {
>            Object value = getValue(exchange);
>            //Its required to have only one thread putting stuff there at any 
> given time per store.
>             synchronized (endpoint.getPath().intern()) {
>             dataStore.put(key, value);
>             {color:#FF}dataStore.persist();  {color:#d04437}// Here 
> should be this{color}{color}
>            }
>  }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-12720) Krati implementation does not work properly persistence after put operation.

2018-08-10 Thread Dmitry Volodin (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Volodin updated CAMEL-12720:
---
Component/s: camel-krati

> Krati implementation does not work properly persistence after put operation.
> 
>
> Key: CAMEL-12720
> URL: https://issues.apache.org/jira/browse/CAMEL-12720
> Project: Camel
>  Issue Type: Bug
>  Components: camel-krati
>Reporter: Vladimir Cibulka
>Priority: Major
>
> In KratiProducer class 
> } else {
>            Object value = getValue(exchange);
>            //Its required to have only one thread putting stuff there at any 
> given time per store.
>             synchronized (endpoint.getPath().intern()) {
>             dataStore.put(key, value);
>             {color:#FF}dataStore.persist();  {color:#d04437}// Here 
> should be this{color}{color}
>            }
>  }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)