[jira] [Commented] (CAMEL-12588) AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call
[ https://issues.apache.org/jira/browse/CAMEL-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523704#comment-16523704 ] Sudharsan Govindarajan commented on CAMEL-12588: OK, will change the code to use the boolean iso null check and run the tests again.. On Tue, Jun 26, 2018 at 3:13 PM ASF GitHub Bot (JIRA) > AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call > - > > Key: CAMEL-12588 > URL: https://issues.apache.org/jira/browse/CAMEL-12588 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.21.1 >Reporter: Sudharsan Govindarajan >Assignee: Andrea Cosentino >Priority: Major > > When a Aggregator route is stopped, only the AggregateRecoveryChecker threads > are stopped and not the AggregateTimeoutChecker threads. They keep lingering > around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (CAMEL-12588) AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call
[ https://issues.apache.org/jira/browse/CAMEL-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudharsan Govindarajan reopened CAMEL-12588: The problem still exists eventhough the previous fix PR had caused regression > AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call > - > > Key: CAMEL-12588 > URL: https://issues.apache.org/jira/browse/CAMEL-12588 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.21.1 >Reporter: Sudharsan Govindarajan >Assignee: Andrea Cosentino >Priority: Major > > When a Aggregator route is stopped, only the AggregateRecoveryChecker threads > are stopped and not the AggregateTimeoutChecker threads. They keep lingering > around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12588) AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call
[ https://issues.apache.org/jira/browse/CAMEL-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518261#comment-16518261 ] Sudharsan Govindarajan commented on CAMEL-12588: doStart() starts back timeoutCheckerExecutorService only if it is null (it does not consider the state of the pool) So, I have set timeoutCheckerExecutorService to null in doStop() (like in doShutDown()) and made a new PR [https://github.com/apache/camel/pull/2387] I have tested this a bit more thorough than the previous times. Both the recovery checker and timeout checker threads now stop and start as per the method calls. Sorry about the previous oversight > AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call > - > > Key: CAMEL-12588 > URL: https://issues.apache.org/jira/browse/CAMEL-12588 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.21.1 >Reporter: Sudharsan Govindarajan >Assignee: Andrea Cosentino >Priority: Major > > When a Aggregator route is stopped, only the AggregateRecoveryChecker threads > are stopped and not the AggregateTimeoutChecker threads. They keep lingering > around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12588) AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call
[ https://issues.apache.org/jira/browse/CAMEL-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518148#comment-16518148 ] Sudharsan Govindarajan commented on CAMEL-12588: Thanks! > AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call > - > > Key: CAMEL-12588 > URL: https://issues.apache.org/jira/browse/CAMEL-12588 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.21.1 >Reporter: Sudharsan Govindarajan >Assignee: Andrea Cosentino >Priority: Major > > When a Aggregator route is stopped, only the AggregateRecoveryChecker threads > are stopped and not the AggregateTimeoutChecker threads. They keep lingering > around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12588) AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call
[ https://issues.apache.org/jira/browse/CAMEL-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518132#comment-16518132 ] Sudharsan Govindarajan commented on CAMEL-12588: Hmm, that is weird. AggregateRecoveryChecker threads are stopped already in doStop(). I just made the working of AggregateTimeoutChecker threads consistent to how AggregateRecoveryChecker threads work. > AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call > - > > Key: CAMEL-12588 > URL: https://issues.apache.org/jira/browse/CAMEL-12588 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.21.1 >Reporter: Sudharsan Govindarajan >Assignee: Andrea Cosentino >Priority: Major > > When a Aggregator route is stopped, only the AggregateRecoveryChecker threads > are stopped and not the AggregateTimeoutChecker threads. They keep lingering > around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12588) AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call
[ https://issues.apache.org/jira/browse/CAMEL-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16518114#comment-16518114 ] Sudharsan Govindarajan commented on CAMEL-12588: But this option shutdownTimeoutCheckerExecutorService is not checked for / used in doStop() method. > AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call > - > > Key: CAMEL-12588 > URL: https://issues.apache.org/jira/browse/CAMEL-12588 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.21.1 >Reporter: Sudharsan Govindarajan >Assignee: Andrea Cosentino >Priority: Major > > When a Aggregator route is stopped, only the AggregateRecoveryChecker threads > are stopped and not the AggregateTimeoutChecker threads. They keep lingering > around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (CAMEL-12588) AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call
[ https://issues.apache.org/jira/browse/CAMEL-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudharsan Govindarajan resolved CAMEL-12588. Resolution: Fixed Fix Version/s: Future > AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call > - > > Key: CAMEL-12588 > URL: https://issues.apache.org/jira/browse/CAMEL-12588 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.21.1 >Reporter: Sudharsan Govindarajan >Priority: Major > Fix For: Future > > > When a Aggregator route is stopped, only the AggregateRecoveryChecker threads > are stopped and not the AggregateTimeoutChecker threads. They keep lingering > around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12588) AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call
[ https://issues.apache.org/jira/browse/CAMEL-12588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516982#comment-16516982 ] Sudharsan Govindarajan commented on CAMEL-12588: PR here [https://github.com/apache/camel/pull/2384] Thanks! > AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call > - > > Key: CAMEL-12588 > URL: https://issues.apache.org/jira/browse/CAMEL-12588 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.21.1 >Reporter: Sudharsan Govindarajan >Priority: Major > > When a Aggregator route is stopped, only the AggregateRecoveryChecker threads > are stopped and not the AggregateTimeoutChecker threads. They keep lingering > around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (CAMEL-12588) AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call
Sudharsan Govindarajan created CAMEL-12588: -- Summary: AggregateProcessor does not stop AggregateTimeoutChecker threads on stop call Key: CAMEL-12588 URL: https://issues.apache.org/jira/browse/CAMEL-12588 Project: Camel Issue Type: Improvement Components: camel-core Affects Versions: 2.21.1 Reporter: Sudharsan Govindarajan When a Aggregator route is stopped, only the AggregateRecoveryChecker threads are stopped and not the AggregateTimeoutChecker threads. They keep lingering around. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
