[jira] [Commented] (CAMEL-13032) camel-core - cs checks fixes
[ https://issues.apache.org/jira/browse/CAMEL-13032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16735804#comment-16735804 ] VINEET GANDHI1 commented on CAMEL-13032: Does this require fix as suggested by checkstyle for declaring classes with private constructor as private classes? > camel-core - cs checks fixes > > > Key: CAMEL-13032 > URL: https://issues.apache.org/jira/browse/CAMEL-13032 > Project: Camel > Issue Type: Task >Reporter: Önder Sezgin >Priority: Minor > > There is two more. Needs more attention because applying what needs to be > done according to cs check output misleads and causes other problems. > > [INFO] Starting audit... > [ERROR] > C:\gitrepo\camel\camel-core\src\main\java\org\apache\camel\processor\interceptor\BacklogDebugger.java:64: > Class BacklogDebugger should be declared as final. [FinalClass] > [ERROR] > C:\gitrepo\camel\camel-core\src\main\java\org\apache\camel\support\AsyncProcessorConverterHelper.java:50: > Class ProcessorToAsyncProcessorBridge should be declared as final. > [FinalClass] > Audit done. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-13034) Implement 'checkout' operation for Git component
[ https://issues.apache.org/jira/browse/CAMEL-13034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734233#comment-16734233 ] VINEET GANDHI1 commented on CAMEL-13034: Ok.Thanks for the info :) > Implement 'checkout' operation for Git component > -- > > Key: CAMEL-13034 > URL: https://issues.apache.org/jira/browse/CAMEL-13034 > Project: Camel > Issue Type: Improvement > Components: camel-git >Affects Versions: 2.23.0 >Reporter: Dmitry Shultz >Assignee: Andrea Cosentino >Priority: Minor > > Triggered by this > [http://camel.465427.n5.nabble.com/Checkout-tag-using-Git-component-td5827950.html] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-13034) Implement 'checkout' operation for Git component
[ https://issues.apache.org/jira/browse/CAMEL-13034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16734183#comment-16734183 ] VINEET GANDHI1 commented on CAMEL-13034: Has someone started working on this enhancement ? > Implement 'checkout' operation for Git component > -- > > Key: CAMEL-13034 > URL: https://issues.apache.org/jira/browse/CAMEL-13034 > Project: Camel > Issue Type: Improvement > Components: camel-git >Affects Versions: 2.23.0 >Reporter: Dmitry Shultz >Assignee: Andrea Cosentino >Priority: Minor > > Triggered by this > [http://camel.465427.n5.nabble.com/Checkout-tag-using-Git-component-td5827950.html] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (CAMEL-13035) Camel telegram - Update made to channel not received by camel application
[
https://issues.apache.org/jira/browse/CAMEL-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
VINEET GANDHI1 updated CAMEL-13035:
---
Description:
In telegram we can create a public channel which anyone can join as subscriber
and for private channel it requires a link to get added in channel. We can also
add bot to channel as administrator for sending and receiving messages from
subscribed channel.
In case there is any update available in channel camel will poll using telegram
API and bring the update.
Currently the mapping from update json received from telegram is not getting
correctly mapped to Update POJO and hence failing.
Json :
{code:xml}
result": [
{
"update_id": 219398823,
*"channel_post"*: {
"message_id": 67,
"chat":
{ "id": -1001245756934,
"title": "cameltemp",
"username": "cameltelegram",
"type": "channel"
}
,
"date": 1546505413,
"text": "test"
}
}
]
{code}
Update.java :
{code:java}
public class Update implements Serializable {
private static final long serialVersionUID = -4001092937174853655L;
@JsonProperty("update_id")
private Long updateId;
private IncomingMessage message;
}
{code}
[Telegram doc |https://core.telegram.org/bots/api#getting-updates]
was:
In telegram we can create a public channel which anyone can join as subscriber
and for private channel it requires a link to get added in channel. We can also
add bot to channel as administrator for sending and receiving messages from
subscribed channel.
In case there is any update available in channel camel will poll using telegram
API and bring the update.
Currently the mapping from update json received from telegram is not getting
correctly mapped to Update POJO and hence failing.
Json :
{{{code:xml}}}
result": [
{
"update_id": 219398823,
*"channel_post"*: {
"message_id": 67,
"chat":
{ "id": -1001245756934,
"title": "cameltemp",
"username": "cameltelegram",
"type": "channel"
}
,
"date": 1546505413,
"text": "test"
}
}
]
{{{code}}}
Update.java :
{code:java}
public class Update implements Serializable {
private static final long serialVersionUID = -4001092937174853655L;
@JsonProperty("update_id")
private Long updateId;
private IncomingMessage message;
}
{code}
[Telegram doc |https://core.telegram.org/bots/api#getting-updates]
> Camel telegram - Update made to channel not received by camel application
> --
>
> Key: CAMEL-13035
> URL: https://issues.apache.org/jira/browse/CAMEL-13035
> Project: Camel
> Issue Type: Improvement
> Components: camel-telegram
>Affects Versions: 3.0.0
>Reporter: VINEET GANDHI1
>Priority: Minor
>
> In telegram we can create a public channel which anyone can join as
> subscriber and for private channel it requires a link to get added in
> channel. We can also add bot to channel as administrator for sending and
> receiving messages from subscribed channel.
> In case there is any update available in channel camel will poll using
> telegram API and bring the update.
> Currently the mapping from update json received from telegram is not getting
> correctly mapped to Update POJO and hence failing.
>
> Json :
>
>
> {code:xml}
> result": [
> {
> "update_id": 219398823,
> *"channel_post"*: {
> "message_id": 67,
> "chat":
> { "id": -1001245756934,
> "title": "cameltemp",
> "username": "cameltelegram",
> "type": "channel"
> }
> ,
> "date": 1546505413,
> "text": "test"
> }
> }
> ]
> {code}
> Update.java :
>
> {code:java}
> public class Update implements Serializable {
>
> private static final long serialVersionUID = -4001092937174853655L;
>
> @JsonProperty("update_id")
> private Long updateId;
>
>
> private IncomingMessage message;
> }
> {code}
>
> [Telegram doc |https://core.telegram.org/bots/api#getting-updates]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (CAMEL-13035) Camel telegram - Update made to channel not received by camel application
[
https://issues.apache.org/jira/browse/CAMEL-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
VINEET GANDHI1 updated CAMEL-13035:
---
Description:
In telegram we can create a public channel which anyone can join as subscriber
and for private channel it requires a link to get added in channel. We can also
add bot to channel as administrator for sending and receiving messages from
subscribed channel.
In case there is any update available in channel camel will poll using telegram
API and bring the update.
Currently the mapping from update json received from telegram is not getting
correctly mapped to Update POJO and hence failing.
Json :
{{{code:xml}}}
result": [
{
"update_id": 219398823,
*"channel_post"*: {
"message_id": 67,
"chat":
{ "id": -1001245756934,
"title": "cameltemp",
"username": "cameltelegram",
"type": "channel"
}
,
"date": 1546505413,
"text": "test"
}
}
]
{{{code}}}
Update.java :
{code:java}
public class Update implements Serializable {
private static final long serialVersionUID = -4001092937174853655L;
@JsonProperty("update_id")
private Long updateId;
private IncomingMessage message;
}
{code}
[Telegram doc |https://core.telegram.org/bots/api#getting-updates]
was:
In telegram we can create a public channel which anyone can join as subscriber
and for private channel it requires a link to get added in channel. We can also
add bot to channel as administrator for sending and receiving messages from
subscribed channel.
In case there is any update available in channel camel will poll using telegram
API and bring the update.
Currently the mapping from update json received from telegram is not getting
correctly mapped to Update POJO and hence failing.
Json :
result": [
{
"update_id": 219398823,
*"channel_post"*: {
"message_id": 67,
"chat": {
"id": -1001245756934,
"title": "cameltemp",
"username": "cameltelegram",
"type": "channel"
},
"date": 1546505413,
"text": "test"
}
}
]
Update.java :
{code:java}
public class Update implements Serializable {
private static final long serialVersionUID = -4001092937174853655L;
@JsonProperty("update_id")
private Long updateId;
private IncomingMessage message;
}
{code}
[Telegram doc |https://core.telegram.org/bots/api#getting-updates]
> Camel telegram - Update made to channel not received by camel application
> --
>
> Key: CAMEL-13035
> URL: https://issues.apache.org/jira/browse/CAMEL-13035
> Project: Camel
> Issue Type: Improvement
> Components: camel-telegram
>Affects Versions: 3.0.0
>Reporter: VINEET GANDHI1
>Priority: Minor
>
> In telegram we can create a public channel which anyone can join as
> subscriber and for private channel it requires a link to get added in
> channel. We can also add bot to channel as administrator for sending and
> receiving messages from subscribed channel.
> In case there is any update available in channel camel will poll using
> telegram API and bring the update.
> Currently the mapping from update json received from telegram is not getting
> correctly mapped to Update POJO and hence failing.
>
> Json :
>
> {{{code:xml}}}
> result": [
> {
> "update_id": 219398823,
> *"channel_post"*: {
> "message_id": 67,
> "chat":
> { "id": -1001245756934,
> "title": "cameltemp",
> "username": "cameltelegram",
> "type": "channel"
> }
> ,
> "date": 1546505413,
> "text": "test"
> }
> }
> ]
> {{{code}}}
> Update.java :
>
> {code:java}
> public class Update implements Serializable {
>
> private static final long serialVersionUID = -4001092937174853655L;
>
> @JsonProperty("update_id")
> private Long updateId;
>
>
> private IncomingMessage message;
> }
> {code}
>
> [Telegram doc |https://core.telegram.org/bots/api#getting-updates]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (CAMEL-13035) Camel telegram - Update made to channel not received by camel application
VINEET GANDHI1 created CAMEL-13035:
--
Summary: Camel telegram - Update made to channel not received by
camel application
Key: CAMEL-13035
URL: https://issues.apache.org/jira/browse/CAMEL-13035
Project: Camel
Issue Type: Improvement
Components: camel-telegram
Affects Versions: 3.0.0
Reporter: VINEET GANDHI1
In telegram we can create a public channel which anyone can join as subscriber
and for private channel it requires a link to get added in channel. We can also
add bot to channel as administrator for sending and receiving messages from
subscribed channel.
In case there is any update available in channel camel will poll using telegram
API and bring the update.
Currently the mapping from update json received from telegram is not getting
correctly mapped to Update POJO and hence failing.
Json :
result": [
{
"update_id": 219398823,
*"channel_post"*: {
"message_id": 67,
"chat": {
"id": -1001245756934,
"title": "cameltemp",
"username": "cameltelegram",
"type": "channel"
},
"date": 1546505413,
"text": "test"
}
}
]
Update.java :
{code:java}
public class Update implements Serializable {
private static final long serialVersionUID = -4001092937174853655L;
@JsonProperty("update_id")
private Long updateId;
private IncomingMessage message;
}
{code}
[Telegram doc |https://core.telegram.org/bots/api#getting-updates]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop
[ https://issues.apache.org/jira/browse/CAMEL-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727472#comment-16727472 ] VINEET GANDHI1 commented on CAMEL-13025: Ok Should I go ahead and do that in ftp component also if that's fine > camel-core - File read lock changed - If file gets deleted then break out loop > -- > > Key: CAMEL-13025 > URL: https://issues.apache.org/jira/browse/CAMEL-13025 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.18.5 >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Major > Fix For: 2.21.4, 2.22.3, 3.0.0, 2.24.0, 2.23.1 > > Time Spent: 40m > Remaining Estimate: 0h > > See SO > https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940 > So if the target file gets deleted during the check interval and you have > timeout = 0, then it will keep looping. So we should add a check if the file > still exists in the looping. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-13025) camel-core - File read lock changed - If file gets deleted then break out loop
[ https://issues.apache.org/jira/browse/CAMEL-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16727399#comment-16727399 ] VINEET GANDHI1 commented on CAMEL-13025: FileLockExclusiveReadLockStrategy.java file also needs change I think. > camel-core - File read lock changed - If file gets deleted then break out loop > -- > > Key: CAMEL-13025 > URL: https://issues.apache.org/jira/browse/CAMEL-13025 > Project: Camel > Issue Type: Improvement > Components: camel-core >Affects Versions: 2.18.5 >Reporter: Claus Ibsen >Assignee: Claus Ibsen >Priority: Major > Fix For: 2.21.4, 2.22.3, 3.0.0, 2.24.0, 2.23.1 > > Time Spent: 40m > Remaining Estimate: 0h > > See SO > https://stackoverflow.com/questions/53865940/apache-camel-route-hangs-when-file-is-deleted-during-processing?noredirect=1#comment94587192_53865940 > So if the target file gets deleted during the check interval and you have > timeout = 0, then it will keep looping. So we should add a check if the file > still exists in the looping. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
