[jira] [Comment Edited] (CAMEL-11756) camel-spring-boot2 - Create experimental spring boot 2 component

2017-09-13 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164325#comment-16164325
 ] 

Claus Ibsen edited comment on CAMEL-11756 at 9/13/17 8:42 AM:
--

If you run this example you get a spring boot 2 error
{code}
examples/camel-example-spring-boot-supervising-route-controller (boot2)/$  mvn 
spring-boot:run -Pspring-boot2
[INFO] --- spring-boot-maven-plugin:2.0.0.M3:run (default-cli) @ 
camel-example-spring-boot-supervising-route-controller ---
[WARNING]
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.springframework.boot.maven.AbstractRunMojo$LaunchRunner.run(AbstractRunMojo.java:496)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NoSuchMethodError: 
org.springframework.boot.SpringApplication.run(Ljava/lang/Object;[Ljava/lang/String;)Lorg/springframework/context/ConfigurableApplicationContext;
at sample.camel.Application.main(Application.java:33)
... 6 more
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 7.039 s
[INFO] Finished at: 2017-09-13T10:38:01+02:00
[INFO] Final Memory: 53M/1019M
[INFO] 
{code}

I checked the classpath, and there is only Spring Boot 2 and Spring Framework 5 
JARs.
{code}
camel/examples/camel-example-spring-boot-supervising-route-controller (boot2)/$ 
mvn dependency:tree -P spring-boot2
[INFO] Scanning for projects...
[INFO]
[INFO] 
[INFO] Building Camel :: Example :: Spring Boot :: Supervising Route Controller 
2.20.0-SNAPSHOT
[INFO] 
[INFO]
[INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ 
camel-example-spring-boot-supervising-route-controller ---
[INFO] 
org.apache.camel.example:camel-example-spring-boot-supervising-route-controller:jar:2.20.0-SNAPSHOT
[INFO] +- org.jolokia:jolokia-core:jar:1.3.7:compile
[INFO] |  \- com.googlecode.json-simple:json-simple:jar:1.1.1:compile
[INFO] +- org.springframework.boot:spring-boot-starter-web:jar:2.0.0.M3:compile
[INFO] |  +- org.springframework.boot:spring-boot-starter:jar:2.0.0.M3:compile
[INFO] |  |  +- 
org.springframework.boot:spring-boot-starter-logging:jar:2.0.0.M3:compile
[INFO] |  |  |  +- ch.qos.logback:logback-classic:jar:1.2.3:compile
[INFO] |  |  |  |  \- ch.qos.logback:logback-core:jar:1.2.3:compile
[INFO] |  |  |  +- org.slf4j:jul-to-slf4j:jar:1.7.22:compile
[INFO] |  |  |  \- org.slf4j:log4j-over-slf4j:jar:1.7.22:compile
[INFO] |  |  \- org.yaml:snakeyaml:jar:1.18:runtime
[INFO] |  +- 
org.springframework.boot:spring-boot-starter-json:jar:2.0.0.M3:compile
[INFO] |  |  +- 
com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.9.0.pr4:compile
[INFO] |  |  +- 
com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.9.0.pr4:compile
[INFO] |  |  +- 
com.fasterxml.jackson.module:jackson-module-parameter-names:jar:2.9.0.pr4:compile
[INFO] |  |  \- 
com.fasterxml.jackson.module:jackson-module-kotlin:jar:2.9.0.pr4:compile
[INFO] |  +- 
org.springframework.boot:spring-boot-starter-tomcat:jar:2.0.0.M3:compile
[INFO] |  |  +- org.apache.tomcat.embed:tomcat-embed-core:jar:8.5.16:compile
[INFO] |  |  +- org.apache.tomcat.embed:tomcat-embed-el:jar:8.5.16:compile
[INFO] |  |  \- 
org.apache.tomcat.embed:tomcat-embed-websocket:jar:8.5.16:compile
[INFO] |  +- org.hibernate:hibernate-validator:jar:5.4.1.Final:compile
[INFO] |  |  +- javax.validation:validation-api:jar:1.1.0.Final:compile
[INFO] |  |  +- org.jboss.logging:jboss-logging:jar:3.3.1.Final:compile
[INFO] |  |  \- com.fasterxml:classmate:jar:1.3.3:compile
[INFO] |  +- org.springframework:spring-web:jar:5.0.0.RC3:compile
[INFO] |  |  \- org.springframework:spring-beans:jar:5.0.0.RC3:compile
[INFO] |  \- org.springframework:spring-webmvc:jar:5.0.0.RC3:compile
[INFO] | +- org.springframework:spring-aop:jar:5.0.0.RC3:compile
[INFO] | \- org.springframework:spring-expression:jar:5.0.0.RC3:compile
[INFO] +- 
org.springframework.boot:spring-boot-starter-undertow:jar:2.0.0.M3:compile
[INFO] |  +- io.undertow:undertow-core:jar:1.4.18.Final:compile
[INFO] |  |  +- org.jboss.xnio:xnio-api:jar:3.3.8.Final:compile
[INFO] |  |  \- org.jboss.xnio:xnio-nio:jar:3.3.8.Final:runtime
[INFO] |  +- io.undertow:undertow-servlet:jar:1.4.18.Final:compile
[INFO] |  |  \- 

[jira] [Comment Edited] (CAMEL-11756) camel-spring-boot2 - Create experimental spring boot 2 component

2017-09-11 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160299#comment-16160299
 ] 

Claus Ibsen edited comment on CAMEL-11756 at 9/11/17 6:36 PM:
--

TODO:
- fix unit test in camel-spring when running with spring framework v5 *DONE*
- look at the complex auto configuration of those cloud unit tests from 
camel-spring-boot2 (these tests do some extra trick when setting up properties 
that does not work the same in spring 5 / spring boot2)
- fix/migrate those two examples that does not compile (make them as 
spring-boot v1 only) *DONE*
- unit test more camel components with spring framework v5 *DONE*
- spring-boot source code generator for the -starter has some code disabled 
which from earlier one was enabled. But this was also the case, before this 
spring boot 2 experiment (Luca will cleanup)
- commons-logging seems to be a required dependency now with spring boot v2 - 
this may need to be in the generated BOM
- make tests/camel-itest-spring-boot work with spring boot 2 (eg mvn clean 
install -P spring-boot2 should work) 
- make BOM generate do a Spring Boot 2 artefact: camel-spring-boot2-dependencies




was (Author: davsclaus):
TODO:
- fix unit test in camel-spring when running with spring framework v5 *DONE*
- look at the complex auto configuration of those cloud unit tests from 
camel-spring-boot2
- fix/migrate those two examples that does not compile (make them as 
spring-boot v1 only) *DONE*
- unit test more camel components with spring framework v5
- spring-boot source code generator for the -starter has some code disabled 
which from earlier one was enabled. But this was also the case, before this 
spring boot 2 experiment (Luca will cleanup)
- commons-logging seems to be a required dependency now with spring boot v2 - 
this may need to be in the generated BOM
- make tests/camel-itest-spring-boot work with spring boot 2 (eg mvn clean 
install -P spring-boot2 should work) 
- make BOM generate do a Spring Boot 2 artefact: camel-spring-boot2-dependencies



> camel-spring-boot2 - Create experimental spring boot 2 component
> 
>
> Key: CAMEL-11756
> URL: https://issues.apache.org/jira/browse/CAMEL-11756
> Project: Camel
>  Issue Type: Task
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
> Fix For: 2.20.0
>
>
> We should try get started with the migration effort for getting Camel running 
> on Spring Boot 2.0.x.
> There may be issues with the starter component as Spring Boot guys changed 
> stuff how auto configuration and setting properties works. So we may need to 
> have some kind of interface in camel-spring-boot and camel-spring-boot2 where 
> we can have different implementation that the -starter can use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (CAMEL-11756) camel-spring-boot2 - Create experimental spring boot 2 component

2017-09-11 Thread Stephane Nicoll (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161692#comment-16161692
 ] 

Stephane Nicoll edited comment on CAMEL-11756 at 9/11/17 6:01 PM:
--

Are you using Spring Framework 5? Spring Boot 2 requires Spring Framework 5 so 
my best guess is that you are overriding that somewhere. 

{{spring-jcl}} is a transitive dependency of {{spring-core}} (see [this 
pom|http://repo.spring.io/milestone/org/springframework/spring-core/5.0.0.RC4/spring-core-5.0.0.RC4.pom])
 so adding anything yourself is a smell. Can you please double check?


was (Author: snicoll):
Are you using Spring Framework 5? Spring Boot 2 requires Spring Framework 5 so 
my best guess is that you are overriding that somewhere. 

{{spring-jcl}} is a transitive dependency of {{spring-core}} (see [this 
pom|http://repo.spring.io/milestone/org/springframework/spring-core/5.0.0.RC4/spring-core-5.0.0.RC4.pom]
 so adding anything yourself is a smell. Can you please double check?

> camel-spring-boot2 - Create experimental spring boot 2 component
> 
>
> Key: CAMEL-11756
> URL: https://issues.apache.org/jira/browse/CAMEL-11756
> Project: Camel
>  Issue Type: Task
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
> Fix For: 2.20.0
>
>
> We should try get started with the migration effort for getting Camel running 
> on Spring Boot 2.0.x.
> There may be issues with the starter component as Spring Boot guys changed 
> stuff how auto configuration and setting properties works. So we may need to 
> have some kind of interface in camel-spring-boot and camel-spring-boot2 where 
> we can have different implementation that the -starter can use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (CAMEL-11756) camel-spring-boot2 - Create experimental spring boot 2 component

2017-09-11 Thread Stephane Nicoll (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161615#comment-16161615
 ] 

Stephane Nicoll edited comment on CAMEL-11756 at 9/11/17 5:18 PM:
--

Are you using {{commons-logging}} yourself? I guess not from your comment. I'd 
be curious to understand what led to this regression. It should have been 
completely transparent. I don't think you should add a dependency to 
{{spring-jcl}} yourself.


was (Author: snicoll):
Are you using {{commons-logging}} yourself? I guess not from your comment. I'd 
be curious to understand what led to this regression. It should have been 
completely transparent.

> camel-spring-boot2 - Create experimental spring boot 2 component
> 
>
> Key: CAMEL-11756
> URL: https://issues.apache.org/jira/browse/CAMEL-11756
> Project: Camel
>  Issue Type: Task
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
> Fix For: 2.20.0
>
>
> We should try get started with the migration effort for getting Camel running 
> on Spring Boot 2.0.x.
> There may be issues with the starter component as Spring Boot guys changed 
> stuff how auto configuration and setting properties works. So we may need to 
> have some kind of interface in camel-spring-boot and camel-spring-boot2 where 
> we can have different implementation that the -starter can use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (CAMEL-11756) camel-spring-boot2 - Create experimental spring boot 2 component

2017-09-11 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161463#comment-16161463
 ] 

Claus Ibsen edited comment on CAMEL-11756 at 9/11/17 3:45 PM:
--

Ah thanks Stephane

I think what got us confused was that it fails with some classes from 
org.apache.commons.logging missing.

And now I can see spring-jcl provides those OOTB
https://github.com/spring-projects/spring-framework/tree/master/spring-jcl/src/main/java/org/apache/commons/logging

So its maybe a matter of adding spring-jcl as a dependency somewhere.


was (Author: davsclaus):
Ah thanks Stephane

I think what got us confused was that it fails with some classes from 
org.apache.commons.logging missing.

And now I can see spring-jcr provides those OOTB
https://github.com/spring-projects/spring-framework/tree/master/spring-jcl/src/main/java/org/apache/commons/logging

So its maybe a matter of adding spring-jcl as a dependency somewhere.

> camel-spring-boot2 - Create experimental spring boot 2 component
> 
>
> Key: CAMEL-11756
> URL: https://issues.apache.org/jira/browse/CAMEL-11756
> Project: Camel
>  Issue Type: Task
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
> Fix For: 2.20.0
>
>
> We should try get started with the migration effort for getting Camel running 
> on Spring Boot 2.0.x.
> There may be issues with the starter component as Spring Boot guys changed 
> stuff how auto configuration and setting properties works. So we may need to 
> have some kind of interface in camel-spring-boot and camel-spring-boot2 where 
> we can have different implementation that the -starter can use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (CAMEL-11756) camel-spring-boot2 - Create experimental spring boot 2 component

2017-09-11 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160299#comment-16160299
 ] 

Claus Ibsen edited comment on CAMEL-11756 at 9/11/17 12:43 PM:
---

TODO:
- fix unit test in camel-spring when running with spring framework v5 *DONE*
- look at the complex auto configuration of those cloud unit tests from 
camel-spring-boot2
- fix/migrate those two examples that does not compile (make them as 
spring-boot v1 only) *DONE*
- unit test more camel components with spring framework v5
- spring-boot source code generator for the -starter has some code disabled 
which from earlier one was enabled. But this was also the case, before this 
spring boot 2 experiment (Luca will cleanup)
- commons-logging seems to be a required dependency now with spring boot v2 - 
this may need to be in the generated BOM
- make tests/camel-itest-spring-boot work with spring boot 2 (eg mvn clean 
install -P spring-boot2 should work) 
- make BOM generate do a Spring Boot 2 artefact: camel-spring-boot2-dependencies




was (Author: davsclaus):
TODO:
- fix unit test in camel-spring when running with spring framework v5 *DONE*
- look at the complex auto configuration of those cloud unit tests from 
camel-spring-boot2
- fix/migrate those two examples that does not compile (make them as 
spring-boot v1 only) *DONE*
- unit test more camel components with spring framework v5
- spring-boot source code generator for the -starter has some code disabled 
which from earlier one was enabled. But this was also the case, before this 
spring boot 2 experiment (Luca will cleanup)
- commons-logging seems to be a required dependency now with spring boot v2 - 
this may need to be in the generated BOM
- make tests/camel-itest-spring-boot work with spring boot 2 (eg mvn clean 
install -P spring-boot2 should work) 



> camel-spring-boot2 - Create experimental spring boot 2 component
> 
>
> Key: CAMEL-11756
> URL: https://issues.apache.org/jira/browse/CAMEL-11756
> Project: Camel
>  Issue Type: Task
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
> Fix For: 2.20.0
>
>
> We should try get started with the migration effort for getting Camel running 
> on Spring Boot 2.0.x.
> There may be issues with the starter component as Spring Boot guys changed 
> stuff how auto configuration and setting properties works. So we may need to 
> have some kind of interface in camel-spring-boot and camel-spring-boot2 where 
> we can have different implementation that the -starter can use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (CAMEL-11756) camel-spring-boot2 - Create experimental spring boot 2 component

2017-09-11 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160299#comment-16160299
 ] 

Claus Ibsen edited comment on CAMEL-11756 at 9/11/17 12:42 PM:
---

TODO:
- fix unit test in camel-spring when running with spring framework v5 *DONE*
- look at the complex auto configuration of those cloud unit tests from 
camel-spring-boot2
- fix/migrate those two examples that does not compile (make them as 
spring-boot v1 only) *DONE*
- unit test more camel components with spring framework v5
- spring-boot source code generator for the -starter has some code disabled 
which from earlier one was enabled. But this was also the case, before this 
spring boot 2 experiment (Luca will cleanup)
- commons-logging seems to be a required dependency now with spring boot v2 - 
this may need to be in the generated BOM
- make tests/camel-itest-spring-boot work with spring boot 2 (eg mvn clean 
install -P spring-boot2 should work) 




was (Author: davsclaus):
TODO:
- fix unit test in camel-spring when running with spring framework v5 *DONE*
- look at the complex auto configuration of those cloud unit tests from 
camel-spring-boot2
- fix/migrate those two examples that does not compile (make them either as 
spring-boot v1 only)
- unit test more camel components with spring framework v5
- spring-boot source code generator for the -starter has some code disabled 
which from earlier one was enabled. But this was also the case, before this 
spring boot 2 experiment (Luca will cleanup)
- commons-logging seems to be a required dependency now with spring boot v2 - 
this may need to be in the generated BOM
- make tests/camel-itest-spring-boot work with spring boot 2 (eg mvn clean 
install -P spring-boot2 should work) 



> camel-spring-boot2 - Create experimental spring boot 2 component
> 
>
> Key: CAMEL-11756
> URL: https://issues.apache.org/jira/browse/CAMEL-11756
> Project: Camel
>  Issue Type: Task
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
> Fix For: 2.20.0
>
>
> We should try get started with the migration effort for getting Camel running 
> on Spring Boot 2.0.x.
> There may be issues with the starter component as Spring Boot guys changed 
> stuff how auto configuration and setting properties works. So we may need to 
> have some kind of interface in camel-spring-boot and camel-spring-boot2 where 
> we can have different implementation that the -starter can use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (CAMEL-11756) camel-spring-boot2 - Create experimental spring boot 2 component

2017-09-11 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160299#comment-16160299
 ] 

Claus Ibsen edited comment on CAMEL-11756 at 9/11/17 12:04 PM:
---

TODO:
- fix unit test in camel-spring when running with spring framework v5 *DONE*
- look at the complex auto configuration of those cloud unit tests from 
camel-spring-boot2
- fix/migrate those two examples that does not compile (make them either as 
spring-boot v1 only)
- unit test more camel components with spring framework v5
- spring-boot source code generator for the -starter has some code disabled 
which from earlier one was enabled. But this was also the case, before this 
spring boot 2 experiment (Luca will cleanup)
- commons-logging seems to be a required dependency now with spring boot v2 - 
this may need to be in the generated BOM
- make tests/camel-itest-spring-boot work with spring boot 2 (eg mvn clean 
install -P spring-boot2 should work) 




was (Author: davsclaus):
TODO:
- fix unit test in camel-spring when running with spring framework v5 *DONE*
- look at the complex auto configuration of those cloud unit tests from 
camel-spring-boot2
- fix/migrate those two examples that does not compile (make them either as 
spring-boot v1 only)
- unit test more camel components with spring framework v5
- spring-boot source code generator for the -starter has some code disabled 
which from earlier one was enabled. But this was also the case, before this 
spring boot 2 experiment
- commons-logging seems to be a required dependency now with spring boot v2 - 
this may need to be in the generated BOM
- make tests/camel-itest-spring-boot work with spring boot 2 (eg mvn clean 
install -P spring-boot2 should work) 



> camel-spring-boot2 - Create experimental spring boot 2 component
> 
>
> Key: CAMEL-11756
> URL: https://issues.apache.org/jira/browse/CAMEL-11756
> Project: Camel
>  Issue Type: Task
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
> Fix For: 2.20.0
>
>
> We should try get started with the migration effort for getting Camel running 
> on Spring Boot 2.0.x.
> There may be issues with the starter component as Spring Boot guys changed 
> stuff how auto configuration and setting properties works. So we may need to 
> have some kind of interface in camel-spring-boot and camel-spring-boot2 where 
> we can have different implementation that the -starter can use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (CAMEL-11756) camel-spring-boot2 - Create experimental spring boot 2 component

2017-09-11 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160299#comment-16160299
 ] 

Claus Ibsen edited comment on CAMEL-11756 at 9/11/17 12:01 PM:
---

TODO:
- fix unit test in camel-spring when running with spring framework v5 *DONE*
- look at the complex auto configuration of those cloud unit tests from 
camel-spring-boot2
- fix/migrate those two examples that does not compile (make them either as 
spring-boot v1 only)
- unit test more camel components with spring framework v5
- spring-boot source code generator for the -starter has some code disabled 
which from earlier one was enabled. But this was also the case, before this 
spring boot 2 experiment
- commons-logging seems to be a required dependency now with spring boot v2 - 
this may need to be in the generated BOM
- make tests/camel-itest-spring-boot work with spring boot 2 (eg mvn clean 
install -P spring-boot2 should work) 




was (Author: davsclaus):
TODO:
- fix unit test in camel-spring when running with spring framework v5
- look at the complex auto configuration of those cloud unit tests from 
camel-spring-boot2
- fix/migrate those two examples that does not compile (make them either as 
spring-boot v1 only)
- unit test more camel components with spring framework v5
- spring-boot source code generator for the -starter has some code disabled 
which from earlier one was enabled. But this was also the case, before this 
spring boot 2 experiment
- commons-logging seems to be a required dependency now with spring boot v2 - 
this may need to be in the generated BOM
- make tests/camel-itest-spring-boot work with spring boot 2 (eg mvn clean 
install -P spring-boot2 should work) 



> camel-spring-boot2 - Create experimental spring boot 2 component
> 
>
> Key: CAMEL-11756
> URL: https://issues.apache.org/jira/browse/CAMEL-11756
> Project: Camel
>  Issue Type: Task
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
> Fix For: 2.20.0
>
>
> We should try get started with the migration effort for getting Camel running 
> on Spring Boot 2.0.x.
> There may be issues with the starter component as Spring Boot guys changed 
> stuff how auto configuration and setting properties works. So we may need to 
> have some kind of interface in camel-spring-boot and camel-spring-boot2 where 
> we can have different implementation that the -starter can use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (CAMEL-11756) camel-spring-boot2 - Create experimental spring boot 2 component

2017-09-10 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160299#comment-16160299
 ] 

Claus Ibsen edited comment on CAMEL-11756 at 9/10/17 10:58 AM:
---

TODO:
- fix unit test in camel-spring when running with spring framework v5
- look at the complex auto configuration of those cloud unit tests from 
camel-spring-boot2
- fix/migrate those two examples that does not compile (make them either as 
spring-boot v1 only)
- unit test more camel components with spring framework v5
- spring-boot source code generator for the -starter has some code disabled 
which from earlier one was enabled. But this was also the case, before this 
spring boot 2 experiment
- commons-logging seems to be a required dependency now with spring boot v2 - 
this may need to be in the generated BOM
- make tests/camel-itest-spring-boot work with spring boot 2 (eg mvn clean 
install -P spring-boot2 should work) 




was (Author: davsclaus):
TODO:
- fix unit test in camel-spring when running with spring framework v5
- look at the complex auto configuration of those cloud unit tests from 
camel-spring-boot2
- fix/migrate those two examples that does not compile (make them either as 
spring-boot v1 only)
- unit test more camel components with spring framework v5
- spring-boot source code generator for the -starter has some code disabled 
which from earlier one was enabled. But this was also the case, before this 
spring boot 2 experiment
- commons-logging seems to be a required dependency now with spring boot v2 - 
this may need to be in the generated BOM



> camel-spring-boot2 - Create experimental spring boot 2 component
> 
>
> Key: CAMEL-11756
> URL: https://issues.apache.org/jira/browse/CAMEL-11756
> Project: Camel
>  Issue Type: Task
>  Components: camel-spring-boot
>Reporter: Claus Ibsen
>Assignee: Claus Ibsen
> Fix For: 2.20.0
>
>
> We should try get started with the migration effort for getting Camel running 
> on Spring Boot 2.0.x.
> There may be issues with the starter component as Spring Boot guys changed 
> stuff how auto configuration and setting properties works. So we may need to 
> have some kind of interface in camel-spring-boot and camel-spring-boot2 where 
> we can have different implementation that the -starter can use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)