[jira] [Comment Edited] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall

2018-03-27 Thread Tomohisa Igarashi (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416094#comment-16416094
 ] 

Tomohisa Igarashi edited comment on CAMEL-12378 at 3/27/18 6:56 PM:


The UndertowComponent is looked up via spring application context with name 
"undertow-component" on upstream master, but not on boot2ga branch. Tested to 
change camel.rest.component to undertow on upstream master, and it works. 
Something wrong with Camel component resolution via spring application context.


was (Author: igarashitm):
The UndertowComponent is looked up via spring application context with name 
"undertow-component" on upstream master, but not on boot2ga branch.

> Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
> --
>
> Key: CAMEL-12378
> URL: https://issues.apache.org/jira/browse/CAMEL-12378
> Project: Camel
>  Issue Type: Sub-task
>Reporter: Claus Ibsen
>Assignee: Tomohisa Igarashi
>Priority: Major
> Fix For: 2.22.0
>
>
> This example fails with starting the consumer. Some weird SB classpath 
> problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall

2018-03-23 Thread Tomohisa Igarashi (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16411922#comment-16411922
 ] 

Tomohisa Igarashi edited comment on CAMEL-12378 at 3/23/18 9:10 PM:


-It seems we need to bump spring-cloud to one of 2.0 milestone releases.- 
turned out it's already overridden in camel-spring-cloud/pom.xml

If I put "spring.application.instance_id=test" then I got
{code:none}
Caused by: org.apache.camel.NoSuchBeanException: No bean could be found in the 
registry for: undertow of type: org.apache.camel.spi.RestConsumerFactory
at org.apache.camel.component.rest.RestEndpoint.createConsumer 
(RestEndpoint.java:406)
at org.apache.camel.impl.EventDrivenConsumerRoute.addServices 
(EventDrivenConsumerRoute.java:69)
{code}
I'll look into until an expert arrives :-)


was (Author: igarashitm):
It seems we need to bump spring-cloud to one of 2.0 milestone releases.

http://projects.spring.io/spring-cloud/
> Finchley builds and works with Spring Boot 2.0.x, and is not expected to work 
> with Spring Boot 1.5.x.
> The Dalston and Edgware release trains build on Spring Boot 1.5.x, and are 
> not expected to work with Spring Boot 2.0.x. 


> Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
> --
>
> Key: CAMEL-12378
> URL: https://issues.apache.org/jira/browse/CAMEL-12378
> Project: Camel
>  Issue Type: Sub-task
>Reporter: Claus Ibsen
>Assignee: Tomohisa Igarashi
>Priority: Major
> Fix For: 2.22.0
>
>
> This example fails with starting the consumer. Some weird SB classpath 
> problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall

2018-03-22 Thread Tomohisa Igarashi (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408910#comment-16408910
 ] 

Tomohisa Igarashi edited comment on CAMEL-12378 at 3/22/18 11:27 PM:
-

-For example this commit added @Ignore on some of ServiceCall tests-

-[https://github.com/apache/camel/commit/7ea22963f245b1090b52c8d56de0658af62d9c07]-

It seems not related. While many of above now passes, consumer for this example 
still fails.
{code:java}
19:08:47.453 [main ] ERROR amework.boot.SpringApplication - Application run 
failed
org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
creating bean with name 
'org.springframework.cloud.client.serviceregistry.AutoServiceRegistrationAutoConfiguration':
 Unsatisfied dependency expressed through field 'autoServiceRegistration'; 
nested exception is 
org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
creating bean with name 'consulAutoServiceRegistration' defined in class path 
resource 
[org/springframework/cloud/consul/serviceregistry/ConsulAutoServiceRegistrationAutoConfiguration.class]:
 Unsatisfied dependency expressed through method 
'consulAutoServiceRegistration' parameter 3; nested exception is 
org.springframework.beans.factory.BeanCreationException: Error creating bean 
with name 'consulRegistration' defined in class path resource 
[org/springframework/cloud/consul/serviceregistry/ConsulAutoServiceRegistrationAutoConfiguration.class]:
 Bean instantiation via factory method failed; nested exception is 
org.springframework.beans.BeanInstantiationException: Failed to instantiate 
[org.springframework.cloud.consul.serviceregistry.ConsulAutoRegistration]: 
Factory method 'consulRegistration' threw exception; nested exception is 
java.lang.IllegalArgumentException: Consul service ids must not be empty, must 
start with a letter, end with a letter or digit, and have as interior 
characters only letters, digits, and hyphen: null
at 
org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:587)
at 
org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:91)

...

Caused by: java.lang.IllegalArgumentException: Consul service ids must not be 
empty, must start with a letter, end with a letter or digit, and have as 
interior characters only letters, digits, and hyphen: null
at 
org.springframework.cloud.consul.serviceregistry.ConsulAutoRegistration.normalizeForDns(ConsulAutoRegistration.java:179)
at 
org.springframework.cloud.consul.serviceregistry.ConsulAutoRegistration.getInstanceId(ConsulAutoRegistration.java:170){code}


was (Author: igarashitm):
For example this commit added @Ignore on some of ServiceCall tests

[https://github.com/apache/camel/commit/7ea22963f245b1090b52c8d56de0658af62d9c07]

> Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
> --
>
> Key: CAMEL-12378
> URL: https://issues.apache.org/jira/browse/CAMEL-12378
> Project: Camel
>  Issue Type: Sub-task
>Reporter: Claus Ibsen
>Assignee: Tomohisa Igarashi
>Priority: Major
> Fix For: 2.22.0
>
>
> This example fails with starting the consumer. Some weird SB classpath 
> problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall

2018-03-21 Thread Ramu kakarla (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408856#comment-16408856
 ] 

 Ramu kakarla edited comment on CAMEL-12378 at 3/22/18 12:51 AM:
-

Example builds success in my tests. am I  Testing  something different (mvn 
clean install) ?


was (Author: kramu.k7):
Example builds success in my tests. am I  Testing  something different (mvn 
clean install) 

> Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
> --
>
> Key: CAMEL-12378
> URL: https://issues.apache.org/jira/browse/CAMEL-12378
> Project: Camel
>  Issue Type: Sub-task
>Reporter: Claus Ibsen
>Priority: Major
> Fix For: 2.22.0
>
>
> This example fails with starting the consumer. Some weird SB classpath 
> problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)