[jira] [Commented] (CAMEL-10343) Camel Netty4 allowSerializedHeaders
[
https://issues.apache.org/jira/browse/CAMEL-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536035#comment-15536035
]
ASF GitHub Bot commented on CAMEL-10343:
Github user nd4av closed the pull request at:
https://github.com/apache/camel/pull/1192
> Camel Netty4 allowSerializedHeaders
> ---
>
> Key: CAMEL-10343
> URL: https://issues.apache.org/jira/browse/CAMEL-10343
> Project: Camel
> Issue Type: Improvement
> Components: camel-netty4
>Affects Versions: 2.17.2
>Reporter: Nicolas Duffillot
>Assignee: Andrea Cosentino
>Priority: Minor
> Labels: patch
> Fix For: 2.18.0
>
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> When transferExchange = true, NettyPayloadHelper.getIn(NettyEndpoint,
> Exchange) calls DefaultExchangeHolder.marshal(exchange) that calls
> DefaultExchangeHolder.marshal(exchange, true, false);
> Third parameter "allowSerializedHeaders" is forced to false and there seems
> to be no way to call the marshal method with this parameter set to true.
> Because of that, the marshalling of the exchange properties doesn't include
> the serializable pojos as the "DefaultExchangeHolder.getValidHeaderValue"
> method excludes those serailizable object when allowSerializedHeaders=false :
> if (allowSerializedHeaders) {
> if (headerValue instanceof Serializable) {
> return headerValue;
> }
> }
> Hoping to be clear enough.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CAMEL-10343) Camel Netty4 allowSerializedHeaders
[
https://issues.apache.org/jira/browse/CAMEL-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529965#comment-15529965
]
Nicolas Duffillot commented on CAMEL-10343:
---
Andrea,
New pull request created #1192 by me as "nd4av".
Thanks a lot for your help.
ND
> Camel Netty4 allowSerializedHeaders
> ---
>
> Key: CAMEL-10343
> URL: https://issues.apache.org/jira/browse/CAMEL-10343
> Project: Camel
> Issue Type: Improvement
> Components: camel-netty4
>Affects Versions: 2.17.2
>Reporter: Nicolas Duffillot
>Assignee: Andrea Cosentino
>Priority: Minor
> Labels: patch
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> When transferExchange = true, NettyPayloadHelper.getIn(NettyEndpoint,
> Exchange) calls DefaultExchangeHolder.marshal(exchange) that calls
> DefaultExchangeHolder.marshal(exchange, true, false);
> Third parameter "allowSerializedHeaders" is forced to false and there seems
> to be no way to call the marshal method with this parameter set to true.
> Because of that, the marshalling of the exchange properties doesn't include
> the serializable pojos as the "DefaultExchangeHolder.getValidHeaderValue"
> method excludes those serailizable object when allowSerializedHeaders=false :
> if (allowSerializedHeaders) {
> if (headerValue instanceof Serializable) {
> return headerValue;
> }
> }
> Hoping to be clear enough.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CAMEL-10343) Camel Netty4 allowSerializedHeaders
[
https://issues.apache.org/jira/browse/CAMEL-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529961#comment-15529961
]
ASF GitHub Bot commented on CAMEL-10343:
GitHub user nd4av opened a pull request:
https://github.com/apache/camel/pull/1192
New configuration parameter added : allowSerializedHeaders
Only used for TCP when transferExchange is true. When set to true,
serializable objects in headers and properties will be added to the exchange.
see issue https://issues.apache.org/jira/browse/CAMEL-10343
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nd4av/camel master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/camel/pull/1192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1192
> Camel Netty4 allowSerializedHeaders
> ---
>
> Key: CAMEL-10343
> URL: https://issues.apache.org/jira/browse/CAMEL-10343
> Project: Camel
> Issue Type: Improvement
> Components: camel-netty4
>Affects Versions: 2.17.2
>Reporter: Nicolas Duffillot
>Assignee: Andrea Cosentino
>Priority: Minor
> Labels: patch
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> When transferExchange = true, NettyPayloadHelper.getIn(NettyEndpoint,
> Exchange) calls DefaultExchangeHolder.marshal(exchange) that calls
> DefaultExchangeHolder.marshal(exchange, true, false);
> Third parameter "allowSerializedHeaders" is forced to false and there seems
> to be no way to call the marshal method with this parameter set to true.
> Because of that, the marshalling of the exchange properties doesn't include
> the serializable pojos as the "DefaultExchangeHolder.getValidHeaderValue"
> method excludes those serailizable object when allowSerializedHeaders=false :
> if (allowSerializedHeaders) {
> if (headerValue instanceof Serializable) {
> return headerValue;
> }
> }
> Hoping to be clear enough.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CAMEL-10343) Camel Netty4 allowSerializedHeaders
[
https://issues.apache.org/jira/browse/CAMEL-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528539#comment-15528539
]
Andrea Cosentino commented on CAMEL-10343:
--
Hello Nicholas,
usually we use Github to open a Pull Request or alternatively you can create a
patch file add attach here that. How do you prefer.
Can you please do your modifications against the Apache Camel master branch?
Then we will backport the fix on the 2.17 branch.
I will take care of your contribution.
Thanks a lot.
> Camel Netty4 allowSerializedHeaders
> ---
>
> Key: CAMEL-10343
> URL: https://issues.apache.org/jira/browse/CAMEL-10343
> Project: Camel
> Issue Type: Improvement
> Components: camel-netty4
>Affects Versions: 2.17.2
>Reporter: Nicolas Duffillot
>Assignee: Andrea Cosentino
> Labels: patch
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> When transferExchange = true, NettyPayloadHelper.getIn(NettyEndpoint,
> Exchange) calls DefaultExchangeHolder.marshal(exchange) that calls
> DefaultExchangeHolder.marshal(exchange, true, false);
> Third parameter "allowSerializedHeaders" is forced to false and there seems
> to be no way to call the marshal method with this parameter set to true.
> Because of that, the marshalling of the exchange properties doesn't include
> the serializable pojos as the "DefaultExchangeHolder.getValidHeaderValue"
> method excludes those serailizable object when allowSerializedHeaders=false :
> if (allowSerializedHeaders) {
> if (headerValue instanceof Serializable) {
> return headerValue;
> }
> }
> Hoping to be clear enough.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CAMEL-10343) Camel Netty4 allowSerializedHeaders
[
https://issues.apache.org/jira/browse/CAMEL-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528540#comment-15528540
]
Andrea Cosentino commented on CAMEL-10343:
--
Hello Nicholas,
usually we use Github to open a Pull Request or alternatively you can create a
patch file add attach here that. How do you prefer.
Can you please do your modifications against the Apache Camel master branch?
Then we will backport the fix on the 2.17 branch.
I will take care of your contribution.
Thanks a lot.
> Camel Netty4 allowSerializedHeaders
> ---
>
> Key: CAMEL-10343
> URL: https://issues.apache.org/jira/browse/CAMEL-10343
> Project: Camel
> Issue Type: Improvement
> Components: camel-netty4
>Affects Versions: 2.17.2
>Reporter: Nicolas Duffillot
>Assignee: Andrea Cosentino
> Labels: patch
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> When transferExchange = true, NettyPayloadHelper.getIn(NettyEndpoint,
> Exchange) calls DefaultExchangeHolder.marshal(exchange) that calls
> DefaultExchangeHolder.marshal(exchange, true, false);
> Third parameter "allowSerializedHeaders" is forced to false and there seems
> to be no way to call the marshal method with this parameter set to true.
> Because of that, the marshalling of the exchange properties doesn't include
> the serializable pojos as the "DefaultExchangeHolder.getValidHeaderValue"
> method excludes those serailizable object when allowSerializedHeaders=false :
> if (allowSerializedHeaders) {
> if (headerValue instanceof Serializable) {
> return headerValue;
> }
> }
> Hoping to be clear enough.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CAMEL-10343) Camel Netty4 allowSerializedHeaders
[
https://issues.apache.org/jira/browse/CAMEL-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526472#comment-15526472
]
Nicolas Duffillot commented on CAMEL-10343:
---
Andrea,
I've made a minor change in my local camel-netty4 (2.17.4-SNAPSHOT) :
1 new param in NettyConfiguration :
@UriParam(label = "advanced", defaultValue = "false")
private boolean allowSerializedHeaders;
1 line changed in NettyPayloadHelper :
- return DefaultExchangeHolder.marshal(exchange);
+ return DefaultExchangeHolder.marshal(exchange, true,
endpoint.getConfiguration().isAllowSerializedHeaders());
As I'm not familiar with this, how am I supposed to do now ?
Thanks for your help,
Nicolas
> Camel Netty4 allowSerializedHeaders
> ---
>
> Key: CAMEL-10343
> URL: https://issues.apache.org/jira/browse/CAMEL-10343
> Project: Camel
> Issue Type: Improvement
> Components: camel-netty4
>Affects Versions: 2.17.2
>Reporter: Nicolas Duffillot
>Assignee: Andrea Cosentino
> Labels: patch
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> When transferExchange = true, NettyPayloadHelper.getIn(NettyEndpoint,
> Exchange) calls DefaultExchangeHolder.marshal(exchange) that calls
> DefaultExchangeHolder.marshal(exchange, true, false);
> Third parameter "allowSerializedHeaders" is forced to false and there seems
> to be no way to call the marshal method with this parameter set to true.
> Because of that, the marshalling of the exchange properties doesn't include
> the serializable pojos as the "DefaultExchangeHolder.getValidHeaderValue"
> method excludes those serailizable object when allowSerializedHeaders=false :
> if (allowSerializedHeaders) {
> if (headerValue instanceof Serializable) {
> return headerValue;
> }
> }
> Hoping to be clear enough.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CAMEL-10343) Camel Netty4 allowSerializedHeaders
[
https://issues.apache.org/jira/browse/CAMEL-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523252#comment-15523252
]
Nicolas Duffillot commented on CAMEL-10343:
---
Hi !
No I'm not. I'd first like to know if I'm missing something.
I'd also like to know why the "transferExchange" option leads to the dead code :
if (headerValue instanceof Serializable){ return headerValue; }
If anyone knows ?
> Camel Netty4 allowSerializedHeaders
> ---
>
> Key: CAMEL-10343
> URL: https://issues.apache.org/jira/browse/CAMEL-10343
> Project: Camel
> Issue Type: Improvement
> Components: camel-netty4
>Affects Versions: 2.17.2
>Reporter: Nicolas Duffillot
>Assignee: Andrea Cosentino
> Labels: patch
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> When transferExchange = true, NettyPayloadHelper.getIn(NettyEndpoint,
> Exchange) calls DefaultExchangeHolder.marshal(exchange) that calls
> DefaultExchangeHolder.marshal(exchange, true, false);
> Third parameter "allowSerializedHeaders" is forced to false and there seems
> to be no way to call the marshal method with this parameter set to true.
> Because of that, the marshalling of the exchange properties doesn't include
> the serializable pojos as the "DefaultExchangeHolder.getValidHeaderValue"
> method excludes those serailizable object when allowSerializedHeaders=false :
> if (allowSerializedHeaders) {
> if (headerValue instanceof Serializable) {
> return headerValue;
> }
> }
> Hoping to be clear enough.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CAMEL-10343) Camel Netty4 allowSerializedHeaders
[
https://issues.apache.org/jira/browse/CAMEL-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523235#comment-15523235
]
Andrea Cosentino commented on CAMEL-10343:
--
Are you working on a patch?
> Camel Netty4 allowSerializedHeaders
> ---
>
> Key: CAMEL-10343
> URL: https://issues.apache.org/jira/browse/CAMEL-10343
> Project: Camel
> Issue Type: Improvement
> Components: camel-netty4
>Affects Versions: 2.17.2
>Reporter: Nicolas Duffillot
>Assignee: Andrea Cosentino
> Labels: patch
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> When transferExchange = true, NettyPayloadHelper.getIn(NettyEndpoint,
> Exchange) calls DefaultExchangeHolder.marshal(exchange) that calls
> DefaultExchangeHolder.marshal(exchange, true, false);
> Third parameter "allowSerializedHeaders" is forced to false and there seems
> to be no way to call the marshal method with this parameter set to true.
> Because of that, the marshalling of the exchange properties doesn't include
> the serializable pojos as the "DefaultExchangeHolder.getValidHeaderValue"
> method excludes those serailizable object when allowSerializedHeaders=false :
> if (allowSerializedHeaders) {
> if (headerValue instanceof Serializable) {
> return headerValue;
> }
> }
> Hoping to be clear enough.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
