[jira] [Commented] (CAMEL-10502) Camel-git : Copy headers from in to out

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15686070#comment-15686070
 ] 

ASF GitHub Bot commented on CAMEL-10502:


Github user asfgit closed the pull request at:

https://github.com/apache/camel/pull/1291


> Camel-git : Copy headers from in to out
> ---
>
> Key: CAMEL-10502
> URL: https://issues.apache.org/jira/browse/CAMEL-10502
> Project: Camel
>  Issue Type: Task
>  Components: camel-git
>Affects Versions: 2.18.0
>Reporter: Olivier Antibi
>Assignee: Andrea Cosentino
> Fix For: 2.19.0
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Camel-git has been thought to be used as different separate commands, so a 
> new message is built after each git commands(use of exchange.getOut()). If 
> you try to chain 2 different commands (add and commit), you will loose the 
> camel headers in between.
> The idea is to copy headers from in to out. Another solution could be to 
> modify "exchange.getIn()" instead of using "exchange.getOut()".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CAMEL-10502) Camel-git : Copy headers from in to out

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684842#comment-15684842
 ] 

ASF GitHub Bot commented on CAMEL-10502:


GitHub user chenapan opened a pull request:

https://github.com/apache/camel/pull/1291

CAMEL-10502 - Camel-git : Copy headers from in to out

Preferred working on separate branches instead of master as it moves a lot. 
Sorry for that. You can accept PRs the order you want, I'll fix the conflicts 
as soon as master changes...

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chenapan/camel CAMEL-10502

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1291


commit 8ab374b1ea3074d64bbde4cfca25a6751572f622
Author: Olivier Antibi 
Date:   2016-11-21T17:09:36Z

CAMEL-10502 - Camel-git : Copy headers from in to out




> Camel-git : Copy headers from in to out
> ---
>
> Key: CAMEL-10502
> URL: https://issues.apache.org/jira/browse/CAMEL-10502
> Project: Camel
>  Issue Type: Task
>  Components: camel-git
>Affects Versions: 2.18.0
>Reporter: Olivier Antibi
>Assignee: Andrea Cosentino
> Fix For: 2.19.0
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Camel-git has been thought to be used as different separate commands, so a 
> new message is built after each git commands(use of exchange.getOut()). If 
> you try to chain 2 different commands (add and commit), you will loose the 
> camel headers in between.
> The idea is to copy headers from in to out. Another solution could be to 
> modify "exchange.getIn()" instead of using "exchange.getOut()".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CAMEL-10502) Camel-git : Copy headers from in to out

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684825#comment-15684825
 ] 

ASF GitHub Bot commented on CAMEL-10502:


Github user chenapan closed the pull request at:

https://github.com/apache/camel/pull/1287


> Camel-git : Copy headers from in to out
> ---
>
> Key: CAMEL-10502
> URL: https://issues.apache.org/jira/browse/CAMEL-10502
> Project: Camel
>  Issue Type: Task
>  Components: camel-git
>Affects Versions: 2.18.0
>Reporter: Olivier Antibi
>Assignee: Andrea Cosentino
> Fix For: 2.19.0
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Camel-git has been thought to be used as different separate commands, so a 
> new message is built after each git commands(use of exchange.getOut()). If 
> you try to chain 2 different commands (add and commit), you will loose the 
> camel headers in between.
> The idea is to copy headers from in to out. Another solution could be to 
> modify "exchange.getIn()" instead of using "exchange.getOut()".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CAMEL-10502) Camel-git : Copy headers from in to out

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15684193#comment-15684193
 ] 

ASF GitHub Bot commented on CAMEL-10502:


GitHub user chenapan opened a pull request:

https://github.com/apache/camel/pull/1287

CAMEL-10502 - Camel-git : Copy headers from in to out

I set up common methods (validateGitLogs, and updateExchange) that I used 
for my issue only, if fine with you I could refactor existing tests using them.

I suggest using utility functions in JGit to prepare git repository before 
calling camel-git features, we could then decouple the tests that uses 
camel-git and then assumes they work fine. 

Let me know if such a refactoring could be done.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chenapan/camel master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1287.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1287






> Camel-git : Copy headers from in to out
> ---
>
> Key: CAMEL-10502
> URL: https://issues.apache.org/jira/browse/CAMEL-10502
> Project: Camel
>  Issue Type: Task
>  Components: camel-git
>Affects Versions: 2.18.0
>Reporter: Olivier Antibi
>Assignee: Andrea Cosentino
> Fix For: 2.19.0
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Camel-git has been thought to be used as different separate commands, so a 
> new message is built after each git commands(use of exchange.getOut()). If 
> you try to chain 2 different commands (add and commit), you will loose the 
> camel headers in between.
> The idea is to copy headers from in to out. Another solution could be to 
> modify "exchange.getIn()" instead of using "exchange.getOut()".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CAMEL-10502) Camel-git : Copy headers from in to out

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15683645#comment-15683645
 ] 

Andrea Cosentino commented on CAMEL-10502:
--

Good improvement. +1 for me. Thanks!

> Camel-git : Copy headers from in to out
> ---
>
> Key: CAMEL-10502
> URL: https://issues.apache.org/jira/browse/CAMEL-10502
> Project: Camel
>  Issue Type: Task
>  Components: camel-git
>Affects Versions: 2.18.0
>Reporter: Olivier Antibi
> Fix For: 2.19.0
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Camel-git has been thought to be used as different separate commands, so a 
> new message is built after each git commands(use of exchange.getOut()). If 
> you try to chain 2 different commands (add and commit), you will loose the 
> camel headers in between.
> The idea is to copy headers from in to out. Another solution could be to 
> modify "exchange.getIn()" instead of using "exchange.getOut()".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)