[jira] [Commented] (CAMEL-10768) Dropbox component should support specifying route params using headers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027849#comment-16027849
 ] 

ASF GitHub Bot commented on CAMEL-10768:


Github user tlehoux closed the pull request at:

https://github.com/apache/camel/pull/1722


> Dropbox component should support specifying route params using headers
> --
>
> Key: CAMEL-10768
> URL: https://issues.apache.org/jira/browse/CAMEL-10768
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-dropbox
>Reporter: Tim Dudgeon
>Assignee: Claus Ibsen
> Fix For: 2.20.0
>
>
> Unlike similar components it seems that the Dropbox component does not allow 
> to specify key parameters (such as the file name) using headers.
> Doing so would make it much more useful.
> See discussion here:
> http://camel.465427.n5.nabble.com/Specifying-file-names-using-Dropbox-component-td5793105.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-10768) Dropbox component should support specifying route params using headers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027697#comment-16027697
 ] 

ASF GitHub Bot commented on CAMEL-10768:


GitHub user tlehoux opened a pull request:

https://github.com/apache/camel/pull/1722

CAMEL-10768: Dropbox component support specifying route params using headers

This a patch to support setting options with headers for dropbox component. 
It's for all endpoint options except accessToken and clientIdentifier, for 
which, IMO, it was not relevant. 
- remotePath
- localPath
- newRemotePath
- uploadMode
- query

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tlehoux/camel master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1722.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1722


commit 1a544e57af3afb21c39c26edfaab98456472c9c9
Author: Thomas Lehoux 
Date:   2017-05-28T04:11:43Z

Dropbox component support specifying route params using headers




> Dropbox component should support specifying route params using headers
> --
>
> Key: CAMEL-10768
> URL: https://issues.apache.org/jira/browse/CAMEL-10768
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-dropbox
>Reporter: Tim Dudgeon
> Fix For: Future
>
>
> Unlike similar components it seems that the Dropbox component does not allow 
> to specify key parameters (such as the file name) using headers.
> Doing so would make it much more useful.
> See discussion here:
> http://camel.465427.n5.nabble.com/Specifying-file-names-using-Dropbox-component-td5793105.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-10768) Dropbox component should support specifying route params using headers

[Thomas Lehoux (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027585#comment-16027585
 ] 

Thomas Lehoux commented on CAMEL-10768:
---

[~davsclaus] You speak about camel-dropbox and not camel-box, right ?

I took a look of the camel-dropbox component and made a patch in order to 
support setting options with headers. It's for all endpoint options except 
accessToken and clientIdentifier, for which, IMO, it was not relevant. I can 
create a PR if you want.

> Dropbox component should support specifying route params using headers
> --
>
> Key: CAMEL-10768
> URL: https://issues.apache.org/jira/browse/CAMEL-10768
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-dropbox
>Reporter: Tim Dudgeon
> Fix For: Future
>
>
> Unlike similar components it seems that the Dropbox component does not allow 
> to specify key parameters (such as the file name) using headers.
> Doing so would make it much more useful.
> See discussion here:
> http://camel.465427.n5.nabble.com/Specifying-file-names-using-Dropbox-component-td5793105.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-10768) Dropbox component should support specifying route params using headers

[Claus Ibsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899385#comment-15899385
 ] 

Claus Ibsen commented on CAMEL-10768:
-

The camel-box is now using the new v2 api. 

People is welcome to look into if headers is supported today and if not 
contribute support for this.

> Dropbox component should support specifying route params using headers
> --
>
> Key: CAMEL-10768
> URL: https://issues.apache.org/jira/browse/CAMEL-10768
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-dropbox
>Reporter: Tim Dudgeon
> Fix For: Future
>
>
> Unlike similar components it seems that the Dropbox component does not allow 
> to specify key parameters (such as the file name) using headers.
> Doing so would make it much more useful.
> See discussion here:
> http://camel.465427.n5.nabble.com/Specifying-file-names-using-Dropbox-component-td5793105.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (CAMEL-10768) Dropbox component should support specifying route params using headers

[Claus Ibsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15889832#comment-15889832
 ] 

Claus Ibsen commented on CAMEL-10768:
-

Contributions is welcome

> Dropbox component should support specifying route params using headers
> --
>
> Key: CAMEL-10768
> URL: https://issues.apache.org/jira/browse/CAMEL-10768
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-dropbox
>Reporter: Tim Dudgeon
> Fix For: Future
>
>
> Unlike similar components it seems that the Dropbox component does not allow 
> to specify key parameters (such as the file name) using headers.
> Doing so would make it much more useful.
> See discussion here:
> http://camel.465427.n5.nabble.com/Specifying-file-names-using-Dropbox-component-td5793105.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)