[jira] [Commented] (CAMEL-10803) Base undertow component on http-common
[ https://issues.apache.org/jira/browse/CAMEL-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817904#comment-16817904 ] Zoran Regvart commented on CAMEL-10803: --- [~tadayosi] this was never implemented fully so never merged. Seems that undertow producer is not as trivial and supporting all the options in the producer is a difficult. > Base undertow component on http-common > -- > > Key: CAMEL-10803 > URL: https://issues.apache.org/jira/browse/CAMEL-10803 > Project: Camel > Issue Type: Improvement > Components: camel-undertow >Affects Versions: 2.19.0 >Reporter: Zoran Regvart >Priority: Major > > To facilitate reuse, the Undertow component should be based on http-common > component. > The `UndertowComponent` should extend `HttpCommonComponent` and > `UndertowEndpoint` should extend `HttpCommonEndpoint`. > Following that options defined in the http-common component should be also > supported in the Undertow component. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-10803) Base undertow component on http-common
[ https://issues.apache.org/jira/browse/CAMEL-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817890#comment-16817890 ] Tadayoshi Sato commented on CAMEL-10803: [~zregvart] Just came across this JIRA. Isn't it already resolved? Maybe it's good idea to close it too. > Base undertow component on http-common > -- > > Key: CAMEL-10803 > URL: https://issues.apache.org/jira/browse/CAMEL-10803 > Project: Camel > Issue Type: Improvement > Components: camel-undertow >Affects Versions: 2.19.0 >Reporter: Zoran Regvart >Priority: Major > > To facilitate reuse, the Undertow component should be based on http-common > component. > The `UndertowComponent` should extend `HttpCommonComponent` and > `UndertowEndpoint` should extend `HttpCommonEndpoint`. > Following that options defined in the http-common component should be also > supported in the Undertow component. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-10803) Base undertow component on http-common
[ https://issues.apache.org/jira/browse/CAMEL-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471736#comment-16471736 ] ASF GitHub Bot commented on CAMEL-10803: zregvart closed pull request #1450: CAMEL-10803 Base undertow component on http-common URL: https://github.com/apache/camel/pull/1450 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/components/camel-undertow/src/main/docs/undertow-component.adoc b/components/camel-undertow/src/main/docs/undertow-component.adoc index 68fdea4fde9..5de51f9bdf5 100644 --- a/components/camel-undertow/src/main/docs/undertow-component.adoc +++ b/components/camel-undertow/src/main/docs/undertow-component.adoc @@ -38,7 +38,7 @@ You can append query options to the URI in the following format, // component options: START -The Undertow component supports 4 options which are listed below. +The Undertow component supports 8 options which are listed below. @@ -48,6 +48,10 @@ The Undertow component supports 4 options which are listed below. | **undertowHttpBinding** (advanced) | To use a custom HttpBinding to control the mapping between Camel message and HttpClient. | | UndertowHttpBinding | **sslContextParameters** (security) | To configure security using SSLContextParameters | | SSLContextParameters | **hostOptions** (advanced) | To configure common options such as thread pools | | UndertowHostOptions +| **httpBinding** (advanced) | To use a custom HttpBinding to control the mapping between Camel message and HttpClient. | | HttpBinding +| **httpConfiguration** (advanced) | To use the shared HttpConfiguration as base configuration. | | HttpConfiguration +| **allowJavaSerialized Object** (advanced) | Whether to allow java serialization when a request uses context-type=application/x-java-serialized-object. This is by default turned off. If you enable this then be aware that Java will deserialize the incoming data from the request to Java and that can be a potential security risk. | false | boolean +| **headerFilterStrategy** (filter) | To use a custom org.apache.camel.spi.HeaderFilterStrategy to filter header to and from Camel message. | | HeaderFilterStrategy | **resolveProperty Placeholders** (advanced) | Whether the component should resolve property placeholders on itself when starting. Only properties which are of String type can use property placeholders. | true | boolean |=== // component options: END @@ -70,30 +74,63 @@ with the following path and query parameters: [width="100%",cols="2,5,^1,2",options="header"] |=== | Name | Description | Default | Type -| **httpURI** | *Required* The url of the HTTP endpoint to use. | | URI +| **httpUri** | *Required* The url of the HTTP endpoint to call. | | URI |=== - Query Parameters (17 parameters): + Query Parameters (50 parameters): [width="100%",cols="2,5,^1,2",options="header"] |=== | Name | Description | Default | Type +| **chunked** (common) | If this option is false the Servlet will disable the HTTP streaming and set the content-length header on the response | true | boolean +| **disableStreamCache** (common) | Determines whether or not the raw input stream from Servlet is cached or not (Camel will read the stream into a in memory/overflow to file Stream caching) cache. By default Camel will cache the Servlet input stream to support reading it multiple times to ensure it Camel can retrieve all data from the stream. However you can set this option to true when you for example need to access the raw stream such as streaming it directly to a file or other persistent store. DefaultHttpBinding will copy the request input stream into a stream cache and put it into message body if this option is false to support reading the stream multiple times. If you use Servlet to bridge/proxy an endpoint then consider enabling this option to improve performance in case you do not need to read the message payload multiple times. The http/http4 producer will by default cache the response body stream. If setting this option to true then the producers will not cache the response body stream but use the response stream as-is as the message body. | false | boolean +| **headerFilterStrategy** (common) | To use a custom HeaderFilterStrategy to filter header to and from Camel message. | | HeaderFilterStrategy +| **transferException** (common) | If enabled and an Exchange failed processing on
[jira] [Commented] (CAMEL-10803) Base undertow component on http-common
[ https://issues.apache.org/jira/browse/CAMEL-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471737#comment-16471737 ] ASF GitHub Bot commented on CAMEL-10803: Github user zregvart closed the pull request at: https://github.com/apache/camel/pull/1450 > Base undertow component on http-common > -- > > Key: CAMEL-10803 > URL: https://issues.apache.org/jira/browse/CAMEL-10803 > Project: Camel > Issue Type: Improvement > Components: camel-undertow >Affects Versions: 2.19.0 >Reporter: Zoran Regvart >Assignee: Zoran Regvart >Priority: Major > > To facilitate reuse, the Undertow component should be based on http-common > component. > The `UndertowComponent` should extend `HttpCommonComponent` and > `UndertowEndpoint` should extend `HttpCommonEndpoint`. > Following that options defined in the http-common component should be also > supported in the Undertow component. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-10803) Base undertow component on http-common
[ https://issues.apache.org/jira/browse/CAMEL-10803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856443#comment-15856443 ] ASF GitHub Bot commented on CAMEL-10803: GitHub user zregvart opened a pull request: https://github.com/apache/camel/pull/1450 CAMEL-10803 Base undertow component on http-common # Please don't merge I would like some feedback on this first. Still to do: - [x] Make `UndertowComponent` and `UndertowEndpoint` extend `HttpCommonComponent` and `HttpCommonEndpoint` - [ ] Implement support for options from `http-common` component You can merge this pull request into a Git repository by running: $ git pull https://github.com/zregvart/camel CAMEL-10803 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/camel/pull/1450.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1450 > Base undertow component on http-common > -- > > Key: CAMEL-10803 > URL: https://issues.apache.org/jira/browse/CAMEL-10803 > Project: Camel > Issue Type: Improvement > Components: camel-undertow >Affects Versions: 2.19.0 >Reporter: Zoran Regvart >Assignee: Zoran Regvart > > To facilitate reuse, the Undertow component should be based on http-common > component. > The `UndertowComponent` should extend `HttpCommonComponent` and > `UndertowEndpoint` should extend `HttpCommonEndpoint`. > Following that options defined in the http-common component should be also > supported in the Undertow component. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
