[jira] [Commented] (CAMEL-11672) Input stream infinitive loop
[
https://issues.apache.org/jira/browse/CAMEL-11672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162719#comment-16162719
]
Claus Ibsen commented on CAMEL-11672:
-
Okay working on adding a workaround where we regard it as EOL if the first read
byte is a zero value
> Input stream infinitive loop
>
>
> Key: CAMEL-11672
> URL: https://issues.apache.org/jira/browse/CAMEL-11672
> Project: Camel
> Issue Type: Bug
> Components: camel-http
>Affects Versions: 2.12.4
> Environment: IBM Websphere Liberty Core 17.0.0.1
> IBM Websphere Liberty Core 17.0.0.2
> Reproducible using both IBM JDK 8 and Oracle JDK 8
>Reporter: Zeljko Vukovic
>Assignee: Claus Ibsen
>Priority: Minor
>
> Dear Camel team,
> While working on one integration we found issue related to camel-http
> component when solution is deployed on IBM Liberty core.
> Same issue is not reproducible on Jetty and Tomcat.
> Issue is connected to the code in IOHelper and
> CachedOutputStream$WrappedInputStream
> We are using version 2.12.4 but I can see that same code is used also in
> latest versions.
> https://github.com/apache/camel/blob/camel-2.12.4/camel-core/src/main/java/org/apache/camel/util/IOHelper.java
> Problematic part are lines 196, 198 and 204.
> Basically stream reader which is used
> org.apache.camel.converter.stream.CachedOutputStream$WrappedInputStream is
> not returning -1 like response of read method if empty string is provided on
> input.
> This is wrong by specification of InputReader interface.
>// in the case there is input which is empty string
>while ( -1 != n) {
> …
> int n = input.read(buffer); ---> this is never -1 if string is
> empty "" already 0 and we have infinitive loop !!!
> }
>
> For our use case we have applied change in IOHelper to check and directly
> cover if stream reader produce same (non-valid) response to not produce
> infinitive loop.
> If any questions around reproducing issue please let me know
> Best regards,
> Zeljko
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CAMEL-11672) Input stream infinitive loop
[
https://issues.apache.org/jira/browse/CAMEL-11672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151741#comment-16151741
]
Claus Ibsen commented on CAMEL-11672:
-
Try with newer Camel version even so as 2.12.x is EOL.
> Input stream infinitive loop
>
>
> Key: CAMEL-11672
> URL: https://issues.apache.org/jira/browse/CAMEL-11672
> Project: Camel
> Issue Type: Bug
> Components: camel-http
>Affects Versions: 2.12.4
> Environment: IBM Websphere Liberty Core 17.0.0.1
> IBM Websphere Liberty Core 17.0.0.2
> Reproducible using both IBM JDK 8 and Oracle JDK 8
>Reporter: Zeljko Vukovic
>Priority: Minor
>
> Dear Camel team,
> While working on one integration we found issue related to camel-http
> component when solution is deployed on IBM Liberty core.
> Same issue is not reproducible on Jetty and Tomcat.
> Issue is connected to the code in IOHelper and
> CachedOutputStream$WrappedInputStream
> We are using version 2.12.4 but I can see that same code is used also in
> latest versions.
> https://github.com/apache/camel/blob/camel-2.12.4/camel-core/src/main/java/org/apache/camel/util/IOHelper.java
> Problematic part are lines 196, 198 and 204.
> Basically stream reader which is used
> org.apache.camel.converter.stream.CachedOutputStream$WrappedInputStream is
> not returning -1 like response of read method if empty string is provided on
> input.
> This is wrong by specification of InputReader interface.
>// in the case there is input which is empty string
>while ( -1 != n) {
> …
> int n = input.read(buffer); ---> this is never -1 if string is
> empty "" already 0 and we have infinitive loop !!!
> }
>
> For our use case we have applied change in IOHelper to check and directly
> cover if stream reader produce same (non-valid) response to not produce
> infinitive loop.
> If any questions around reproducing issue please let me know
> Best regards,
> Zeljko
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CAMEL-11672) Input stream infinitive loop
[
https://issues.apache.org/jira/browse/CAMEL-11672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136569#comment-16136569
]
Zeljko Vukovic commented on CAMEL-11672:
Hi [~davsclaus],
Actually IOHelper is in camel-core but in our case call was made from
DefaultHttpBinding in camel-http that is the reason why I have specified
camel-http as component.
Thanks,
Zeljko
> Input stream infinitive loop
>
>
> Key: CAMEL-11672
> URL: https://issues.apache.org/jira/browse/CAMEL-11672
> Project: Camel
> Issue Type: Bug
> Components: camel-http
>Affects Versions: 2.12.4
> Environment: IBM Websphere Liberty Core 17.0.0.1
> IBM Websphere Liberty Core 17.0.0.2
> Reproducible using both IBM JDK 8 and Oracle JDK 8
>Reporter: Zeljko Vukovic
>Priority: Minor
>
> Dear Camel team,
> While working on one integration we found issue related to camel-http
> component when solution is deployed on IBM Liberty core.
> Same issue is not reproducible on Jetty and Tomcat.
> Issue is connected to the code in IOHelper and
> CachedOutputStream$WrappedInputStream
> We are using version 2.12.4 but I can see that same code is used also in
> latest versions.
> https://github.com/apache/camel/blob/camel-2.12.4/camel-core/src/main/java/org/apache/camel/util/IOHelper.java
> Problematic part are lines 196, 198 and 204.
> Basically stream reader which is used
> org.apache.camel.converter.stream.CachedOutputStream$WrappedInputStream is
> not returning -1 like response of read method if empty string is provided on
> input.
> This is wrong by specification of InputReader interface.
>// in the case there is input which is empty string
>while ( -1 != n) {
> …
> int n = input.read(buffer); ---> this is never -1 if string is
> empty "" already 0 and we have infinitive loop !!!
> }
>
> For our use case we have applied change in IOHelper to check and directly
> cover if stream reader produce same (non-valid) response to not produce
> infinitive loop.
> If any questions around reproducing issue please let me know
> Best regards,
> Zeljko
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (CAMEL-11672) Input stream infinitive loop
[
https://issues.apache.org/jira/browse/CAMEL-11672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136036#comment-16136036
]
Claus Ibsen commented on CAMEL-11672:
-
camel-http is deprecated
> Input stream infinitive loop
>
>
> Key: CAMEL-11672
> URL: https://issues.apache.org/jira/browse/CAMEL-11672
> Project: Camel
> Issue Type: Bug
> Components: camel-http
>Affects Versions: 2.12.4
> Environment: IBM Websphere Liberty Core 17.0.0.1
> IBM Websphere Liberty Core 17.0.0.2
> Reproducible using both IBM JDK 8 and Oracle JDK 8
>Reporter: Zeljko Vukovic
>Priority: Minor
>
> Dear Camel team,
> While working on one integration we found issue related to camel-http
> component when solution is deployed on IBM Liberty core.
> Same issue is not reproducible on Jetty and Tomcat.
> Issue is connected to the code in IOHelper and
> CachedOutputStream$WrappedInputStream
> We are using version 2.12.4 but I can see that same code is used also in
> latest versions.
> https://github.com/apache/camel/blob/camel-2.12.4/camel-core/src/main/java/org/apache/camel/util/IOHelper.java
> Problematic part are lines 196, 198 and 204.
> Basically stream reader which is used
> org.apache.camel.converter.stream.CachedOutputStream$WrappedInputStream is
> not returning -1 like response of read method if empty string is provided on
> input.
> This is wrong by specification of InputReader interface.
>// in the case there is input which is empty string
>while ( -1 != n) {
> …
> int n = input.read(buffer); ---> this is never -1 if string is
> empty "" already 0 and we have infinitive loop !!!
> }
>
> For our use case we have applied change in IOHelper to check and directly
> cover if stream reader produce same (non-valid) response to not produce
> infinitive loop.
> If any questions around reproducing issue please let me know
> Best regards,
> Zeljko
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
