[jira] [Commented] (CAMEL-11690) Done() called two times in RoutingSlip processor

2017-09-07 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156777#comment-16156777
 ] 

Claus Ibsen commented on CAMEL-11690:
-

I am currently testing a fix to only call the done once for the interceptor 
strategy.

> Done() called two times in RoutingSlip processor
> 
>
> Key: CAMEL-11690
> URL: https://issues.apache.org/jira/browse/CAMEL-11690
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.17.7, 2.18.4, 2.19.1
>Reporter: Stefan Boller
>Assignee: Claus Ibsen
>Priority: Minor
> Attachments: RoutingSlipWithInterceptorTest.java
>
>
> Hi,
> I found the following issue, if I use the RoutingSlip with an 
> InterceptStrategy. The done()-method of the interceptor, which intercepts the 
> RoutingSlip, is called twice instead of only once. The attached test case 
> reproduces this behavior.
> Best regards
> STefan  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CAMEL-11690) Done() called two times in RoutingSlip processor

2017-09-07 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156672#comment-16156672
 ] 

Claus Ibsen commented on CAMEL-11690:
-

Yeah its being called for the routing slip itself, and each slip endpoint that 
was sent to, eg in your example there is 1 slip, so its 1 + 1 = 2.

However yes ideally it should only be called when the routing slip itself is 
done, and be 1. This is how some of the other EIPs do it like recipient list, 
splitter etc.

But routing slip is implemented on a different foundation than those, and hence 
why it was different.



> Done() called two times in RoutingSlip processor
> 
>
> Key: CAMEL-11690
> URL: https://issues.apache.org/jira/browse/CAMEL-11690
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.17.7, 2.18.4, 2.19.1
>Reporter: Stefan Boller
>Assignee: Claus Ibsen
>Priority: Minor
> Attachments: RoutingSlipWithInterceptorTest.java
>
>
> Hi,
> I found the following issue, if I use the RoutingSlip with an 
> InterceptStrategy. The done()-method of the interceptor, which intercepts the 
> RoutingSlip, is called twice instead of only once. The attached test case 
> reproduces this behavior.
> Best regards
> STefan  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CAMEL-11690) Done() called two times in RoutingSlip processor

2017-09-07 Thread Stefan Boller (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156637#comment-16156637
 ] 

Stefan Boller commented on CAMEL-11690:
---

We use it for monitoring the message processing in the camel routes.

But independent of the InterceptStrategy: Shouldn't the done()-method be called 
only once by an asynchronous processor?

> Done() called two times in RoutingSlip processor
> 
>
> Key: CAMEL-11690
> URL: https://issues.apache.org/jira/browse/CAMEL-11690
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.17.7, 2.18.4, 2.19.1
>Reporter: Stefan Boller
>Assignee: Claus Ibsen
>Priority: Minor
> Attachments: RoutingSlipWithInterceptorTest.java
>
>
> Hi,
> I found the following issue, if I use the RoutingSlip with an 
> InterceptStrategy. The done()-method of the interceptor, which intercepts the 
> RoutingSlip, is called twice instead of only once. The attached test case 
> reproduces this behavior.
> Best regards
> STefan  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CAMEL-11690) Done() called two times in RoutingSlip processor

2017-09-07 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156623#comment-16156623
 ] 

Claus Ibsen commented on CAMEL-11690:
-

Its being deprecated onwards and intended as internal API from Camel 3.0 
onwards. The API is a bit too low-level and complex for end users.

What is your use-case?

> Done() called two times in RoutingSlip processor
> 
>
> Key: CAMEL-11690
> URL: https://issues.apache.org/jira/browse/CAMEL-11690
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.17.7, 2.18.4, 2.19.1
>Reporter: Stefan Boller
>Priority: Minor
> Attachments: RoutingSlipWithInterceptorTest.java
>
>
> Hi,
> I found the following issue, if I use the RoutingSlip with an 
> InterceptStrategy. The done()-method of the interceptor, which intercepts the 
> RoutingSlip, is called twice instead of only once. The attached test case 
> reproduces this behavior.
> Best regards
> STefan  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CAMEL-11690) Done() called two times in RoutingSlip processor

2017-09-04 Thread Stefan Boller (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152188#comment-16152188
 ] 

Stefan Boller commented on CAMEL-11690:
---

What should I use instead?

> Done() called two times in RoutingSlip processor
> 
>
> Key: CAMEL-11690
> URL: https://issues.apache.org/jira/browse/CAMEL-11690
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.17.7, 2.18.4, 2.19.1
>Reporter: Stefan Boller
>Priority: Minor
> Attachments: RoutingSlipWithInterceptorTest.java
>
>
> Hi,
> I found the following issue, if I use the RoutingSlip with an 
> InterceptStrategy. The done()-method of the interceptor, which intercepts the 
> RoutingSlip, is called twice instead of only once. The attached test case 
> reproduces this behavior.
> Best regards
> STefan  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CAMEL-11690) Done() called two times in RoutingSlip processor

2017-09-03 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151734#comment-16151734
 ] 

Claus Ibsen commented on CAMEL-11690:
-

Dont use InterceptStrategy its being deprecated

> Done() called two times in RoutingSlip processor
> 
>
> Key: CAMEL-11690
> URL: https://issues.apache.org/jira/browse/CAMEL-11690
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.17.7, 2.18.4, 2.19.1
>Reporter: Stefan Boller
> Attachments: RoutingSlipWithInterceptorTest.java
>
>
> Hi,
> I found the following issue, if I use the RoutingSlip with an 
> InterceptStrategy. The done()-method of the interceptor, which intercepts the 
> RoutingSlip, is called twice instead of only once. The attached test case 
> reproduces this behavior.
> Best regards
> STefan  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (CAMEL-11690) Done() called two times in RoutingSlip processor

2017-08-28 Thread Stefan Boller (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-11690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143476#comment-16143476
 ] 

Stefan Boller commented on CAMEL-11690:
---

Any comments on this?

> Done() called two times in RoutingSlip processor
> 
>
> Key: CAMEL-11690
> URL: https://issues.apache.org/jira/browse/CAMEL-11690
> Project: Camel
>  Issue Type: Bug
>  Components: camel-core
>Affects Versions: 2.17.7, 2.18.4, 2.19.1
>Reporter: Stefan Boller
> Attachments: RoutingSlipWithInterceptorTest.java
>
>
> Hi,
> I found the following issue, if I use the RoutingSlip with an 
> InterceptStrategy. The done()-method of the interceptor, which intercepts the 
> RoutingSlip, is called twice instead of only once. The attached test case 
> reproduces this behavior.
> Best regards
> STefan  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)