[jira] [Commented] (CAMEL-11691) Should resubscribe when reconnect MQTT

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159850#comment-16159850
 ] 

ASF GitHub Bot commented on CAMEL-11691:


Github user abccbaandy closed the pull request at:

https://github.com/apache/camel/pull/1928


> Should resubscribe when reconnect MQTT
> --
>
> Key: CAMEL-11691
> URL: https://issues.apache.org/jira/browse/CAMEL-11691
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-paho
>Affects Versions: 2.19.2
>Reporter: abccbaandy
>Assignee: Claus Ibsen
> Fix For: 2.19.3, 2.20.0
>
>
> There is a feature in MqttConnectOptions called setAutomaticReconnect
> https://www.eclipse.org/paho/files/javadoc/org/eclipse/paho/client/mqttv3/MqttConnectOptions.html#setAutomaticReconnect-boolean-
> But, when it reconnect, it doesn't resubscribe the topics. Paho provide a 
> callback : MqttCallbackExtended, it got called when connect completed. So we 
> can subscribe the topics again in that callback.
> https://www.eclipse.org/paho/files/javadoc/org/eclipse/paho/client/mqttv3/MqttCallbackExtended.html
> I check camel-paho source code, seems it use MqttCallback instead 
> MqttCallbackExtended.
> Can anyone implement this feature?
> Thanks



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11691) Should resubscribe when reconnect MQTT

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159844#comment-16159844
 ] 

ASF GitHub Bot commented on CAMEL-11691:


GitHub user abccbaandy opened a pull request:

https://github.com/apache/camel/pull/1928

fix CAMEL-11691

https://issues.apache.org/jira/browse/CAMEL-11691

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/abccbaandy/camel CAMEL-11691

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1928.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1928


commit 030527860cd4753fc99dc849b5dc2416ee0f1147
Author: abccbaandy 
Date:   2017-09-09T08:56:24Z

fix CAMEL-11691




> Should resubscribe when reconnect MQTT
> --
>
> Key: CAMEL-11691
> URL: https://issues.apache.org/jira/browse/CAMEL-11691
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-paho
>Affects Versions: 2.19.2
>Reporter: abccbaandy
>
> There is a feature in MqttConnectOptions called setAutomaticReconnect
> https://www.eclipse.org/paho/files/javadoc/org/eclipse/paho/client/mqttv3/MqttConnectOptions.html#setAutomaticReconnect-boolean-
> But, when it reconnect, it doesn't resubscribe the topics. Paho provide a 
> callback : MqttCallbackExtended, it got called when connect completed. So we 
> can subscribe the topics again in that callback.
> https://www.eclipse.org/paho/files/javadoc/org/eclipse/paho/client/mqttv3/MqttCallbackExtended.html
> I check camel-paho source code, seems it use MqttCallback instead 
> MqttCallbackExtended.
> Can anyone implement this feature?
> Thanks



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (CAMEL-11691) Should resubscribe when reconnect MQTT

[Claus Ibsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-11691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151739#comment-16151739
 ] 

Claus Ibsen commented on CAMEL-11691:
-

Contributions is welcome

> Should resubscribe when reconnect MQTT
> --
>
> Key: CAMEL-11691
> URL: https://issues.apache.org/jira/browse/CAMEL-11691
> Project: Camel
>  Issue Type: Bug
>  Components: camel-paho
>Affects Versions: 2.19.2
>Reporter: abccbaandy
>
> There is a feature in MqttConnectOptions called setAutomaticReconnect
> https://www.eclipse.org/paho/files/javadoc/org/eclipse/paho/client/mqttv3/MqttConnectOptions.html#setAutomaticReconnect-boolean-
> But, when it reconnect, it doesn't resubscribe the topics. Paho provide a 
> callback : MqttCallbackExtended, it got called when connect completed. So we 
> can subscribe the topics again in that callback.
> https://www.eclipse.org/paho/files/javadoc/org/eclipse/paho/client/mqttv3/MqttCallbackExtended.html
> I check camel-paho source code, seems it use MqttCallback instead 
> MqttCallbackExtended.
> Can anyone implement this feature?
> Thanks



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)