[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[Andrea Cosentino (Jira)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079029#comment-17079029
 ] 

Andrea Cosentino commented on CAMEL-12260:
--

You're welcome to help. In the old website we tried to track this stuff, but 
with 250 components is not as easy as it seems. With the new website the 
situation is different as we are able to autogenerate some documentation and we 
have a migration guide for 2.x-> 3.x and 3.1.x -> 3.2.x

> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[Pauli Borodulin (Jira)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079018#comment-17079018
 ] 

Pauli Borodulin commented on CAMEL-12260:
-

I don't argue against making breaking changes. But we should
 # identify these breaking changes and provide information to the users about 
them and
 # when possible, provide an easy migration path. A possibility to configure 
these default values for types would be a great solution.

As an example of no 1 is that this bug/change should be labeled as a breaking 
change -> ability to automatically provide users a list of changes that 
introduce a breaking change.

> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[Andrea Cosentino (Jira)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079013#comment-17079013
 ] 

Andrea Cosentino commented on CAMEL-12260:
--

2.x has been around for more than 10 years, if didn't allow breaking changes 
this project couldn't evolve like it did.

> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[Andrea Cosentino (Jira)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079012#comment-17079012
 ] 

Andrea Cosentino commented on CAMEL-12260:
--

"We decided to introduce breaking change" is a general statement. You can 
expect breaking changes between 2.20.0 and 2.21.0 (for example). For Camel 2.x 
it has been like that from the beginning.

> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[Pauli Borodulin (Jira)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079008#comment-17079008
 ] 

Pauli Borodulin commented on CAMEL-12260:
-

We will adjust to the change, but I am worried about other users who will 
stumble upon this change. "We decided to introduce breaking change" - is this 
breaking change mentioned in the release notes / migration or upgrade guide?

> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[Dmitry Volodin (Jira)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079001#comment-17079001
 ] 

Dmitry Volodin commented on CAMEL-12260:


The minimal Camel 2.x version we are maintaining is 2.25.x. You are welcome to 
provide PR on top of master and backport it to the 2.25.1.

> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[Andrea Cosentino (Jira)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078997#comment-17078997
 ] 

Andrea Cosentino commented on CAMEL-12260:
--

2.21.0 is an old version for the fix, I don't know what version are you using, 
but while we were working on 2.x, since it was a longtime existing project we 
decided to introduce breaking change between 2.x and 2.x + 1 version, so the 
backward compatibility is not guaranteed anyway.

> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[Pauli Borodulin (Jira)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078991#comment-17078991
 ] 

Pauli Borodulin commented on CAMEL-12260:
-

This fix is backwards incompatible and the change was something very different 
than the problem I reported. The change may cause a lot of problems for Camel 
users when upgrading.

Before the default value for Strings was "null", which was ok. The problem I 
stumbled upon was that setting defaultValue = "" in binding annotation did not 
change the default value to empty string, but the default value remained null.

Now the default value has been changed to empty string and there seems to be no 
way of making it null again.

> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367450#comment-16367450
 ] 

ASF GitHub Bot commented on CAMEL-12260:


Github user oscerd closed the pull request at:

https://github.com/apache/camel/pull/2228


> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367449#comment-16367449
 ] 

ASF GitHub Bot commented on CAMEL-12260:


oscerd closed pull request #2228: CAMEL-12260: Default value for String field 
results is null for CSV/Bindy
URL: https://github.com/apache/camel/pull/2228
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java
 
b/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java
index f0bc611708c..fd1c1490209 100644
--- 
a/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java
+++ 
b/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java
@@ -79,6 +79,7 @@ public void initModel() throws Exception {
  *  
  * @param root
  */
+@SuppressWarnings("rawtypes")
 private void loadModels(Class root) {
 models.add(root);
 modelClassNames.add(root.getName());
@@ -231,6 +232,8 @@ public static Object getDefaultValueForPrimitive(Class 
clazz) throws Exceptio
 return Character.MIN_VALUE;
 } else if (clazz == boolean.class) {
 return false;
+} else if (clazz == String.class) {
+return ""; 
 } else {
 return null;
 }
diff --git 
a/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/fixed/BindyFixedLengthDataFormat.java
 
b/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/fixed/BindyFixedLengthDataFormat.java
index 5585abb5cd2..d5c9799bd88 100644
--- 
a/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/fixed/BindyFixedLengthDataFormat.java
+++ 
b/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/fixed/BindyFixedLengthDataFormat.java
@@ -313,6 +313,7 @@ private boolean 
isTrimmingNeededAndEnabled(BindyFixedLengthFactory factory, Stri
 return factory.isIgnoreTrailingChars() && myLine.length() > 
factory.recordLength();
 }
 
+@SuppressWarnings("unused")
 private String rightPad(String myLine, int length) {
 return String.format("%1$-" + length + "s", myLine);
 }
diff --git 
a/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindyRecordFieldStartingWithSeperatorCharTest.java
 
b/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindyRecordFieldStartingWithSeperatorCharTest.java
index bee2c7b1659..144429f704f 100644
--- 
a/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindyRecordFieldStartingWithSeperatorCharTest.java
+++ 
b/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindyRecordFieldStartingWithSeperatorCharTest.java
@@ -61,7 +61,7 @@ public void 
testUnmarshallCsvRecordFieldStartingWithSeparatorChar() throws Excep
 assertEquals(BigDecimal.valueOf(3), row.getNumber());
 
 row = 
mockEndPoint.getExchanges().get(3).getIn().getBody(BindyCsvRowFormat.class);
-assertEquals(null, row.getFirstField());
+assertEquals("", row.getFirstField());
 assertEquals(",val2,", row.getSecondField());
 assertEquals(BigDecimal.valueOf(4), row.getNumber());
 }
@@ -79,6 +79,7 @@ public void configure() throws Exception {
 }
 
 //from https://issues.apache.org/jira/browse/CAMEL-11065
+@SuppressWarnings("serial")
 @CsvRecord(separator = ",", quote = "'")
 public static class BindyCsvRowFormat implements Serializable {
 
diff --git 
a/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvUnmarshallTest.java
 
b/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvUnmarshallTest.java
index 277c26c0b98..d507c3f2e99 100644
--- 
a/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvUnmarshallTest.java
+++ 
b/components/camel-bindy/src/test/java/org/apache/camel/dataformat/bindy/csv/BindySimpleCsvUnmarshallTest.java
@@ -25,6 +25,7 @@
 import org.apache.camel.ProducerTemplate;
 import org.apache.camel.builder.RouteBuilder;
 import org.apache.camel.component.mock.MockEndpoint;
+import org.apache.camel.dataformat.bindy.annotation.DataField;
 import org.apache.camel.dataformat.bindy.format.FormatException;
 import org.apache.camel.dataformat.bindy.model.simple.oneclass.Order;
 import org.apache.camel.processor.interceptor.Tracer;
@@ -127,8 +128,13 @@ public void testUnMarshallMessageWithMissingFields() 
throws Exception {
 
 assertNotNull(orders);
 // As 

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367448#comment-16367448
 ] 

ASF GitHub Bot commented on CAMEL-12260:


oscerd commented on issue #2228: CAMEL-12260: Default value for String field 
results is null for CSV/Bindy
URL: https://github.com/apache/camel/pull/2228#issuecomment-366260532
 
 
   Thanks for the PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367438#comment-16367438
 ] 

ASF GitHub Bot commented on CAMEL-12260:


oscerd commented on issue #2228: CAMEL-12260: Default value for String field 
results is null for CSV/Bindy
URL: https://github.com/apache/camel/pull/2228#issuecomment-366259140
 
 
   LGTM, since this is a change in the current behavior of 2.20.x I'll merge 
this one only on master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367433#comment-16367433
 ] 

ASF GitHub Bot commented on CAMEL-12260:


GitHub user dmvolod opened a pull request:

https://github.com/apache/camel/pull/2228

CAMEL-12260: Default value for String field results is null for CSV/Bindy

The DataField.defaultValue always "" for String by default.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dmvolod/camel CAMEL-12260

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/2228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2228


commit e16251daa7ed03c9fd4ffef54a03c1947bad5e03
Author: Dmitry Volodin 
Date:   2018-02-16T14:55:00Z

CAMEL-12260: Default value for String field results is null for
CSV/Bindy




> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.20.3, 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367432#comment-16367432
 ] 

ASF GitHub Bot commented on CAMEL-12260:


dmvolod opened a new pull request #2228: CAMEL-12260: Default value for String 
field results is null for CSV/Bindy
URL: https://github.com/apache/camel/pull/2228
 
 
   The DataField.defaultValue always "" for String by default.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Assignee: Dmitry Volodin
>Priority: Minor
> Fix For: 2.20.3, 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CAMEL-12260) Default value for String field results in null for CSV / Bindy

[Claus Ibsen (JIRA)]

[ 
https://issues.apache.org/jira/browse/CAMEL-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362363#comment-16362363
 ] 

Claus Ibsen commented on CAMEL-12260:
-

Contributions is welcome

http://camel.apache.org/contributing

> Default value for String field results in null for CSV / Bindy
> --
>
> Key: CAMEL-12260
> URL: https://issues.apache.org/jira/browse/CAMEL-12260
> Project: Camel
>  Issue Type: Bug
>  Components: camel-bindy
>Affects Versions: 2.20.2
>Reporter: Pauli Borodulin
>Priority: Minor
> Fix For: 2.20.3, 2.21.0
>
>
> **CAMEL-5018 added "support the set the default value on the field of bindy 
> CVS", which is nice, but the default value is useless for Strings, because 
> BindyCSVFactory turns the empty value to null even when defaultValue = "", see
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyCsvFactory.java#L230]
> and
> [https://github.com/apache/camel/blob/camel-2.20.x/components/camel-bindy/src/main/java/org/apache/camel/dataformat/bindy/BindyAbstractFactory.java#L234]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)