[jira] [Commented] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
[
https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417814#comment-16417814
]
Tomohisa Igarashi commented on CAMEL-12378:
---
OK, I changed it to use camel-servlet and the example now works. But it seems
the consumer is still working with tomcat. I did see undertow with SB1 (master).
{code:none}
13:25:15.869 [main ] INFO oyote.http11.Http11NioProtocol - Starting
ProtocolHandler ["http-nio-8080"]
13:25:15.891 [main ] INFO omcat.util.net.NioSelectorPool - Using a
shared selector for servlet write/read
13:25:15.974 [main ] INFO vlet.CamelHttpTransportServlet -
Initialized CamelHttpTransportServlet[name=CamelServlet, contextPath=]
13:25:15.975 [main ] INFO mbedded.tomcat.TomcatWebServer - Tomcat
started on port(s): 8080 (http) with context path ''
13:25:15.981 [main ] INFO el.example.ConsumerApplication - Started
ConsumerApplication in 6.704 seconds (JVM running for 15.96)
{code}
> Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
> --
>
> Key: CAMEL-12378
> URL: https://issues.apache.org/jira/browse/CAMEL-12378
> Project: Camel
> Issue Type: Sub-task
>Reporter: Claus Ibsen
>Assignee: Tomohisa Igarashi
>Priority: Major
> Fix For: 2.22.0
>
>
> This example fails with starting the consumer. Some weird SB classpath
> problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
[ https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417028#comment-16417028 ] Claus Ibsen commented on CAMEL-12378: - See this example https://github.com/apache/camel/tree/master/examples/camel-example-spring-boot-rest-swagger > Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall > -- > > Key: CAMEL-12378 > URL: https://issues.apache.org/jira/browse/CAMEL-12378 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Tomohisa Igarashi >Priority: Major > Fix For: 2.22.0 > > > This example fails with starting the consumer. Some weird SB classpath > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
[ https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417019#comment-16417019 ] Claus Ibsen commented on CAMEL-12378: - You should use servlet in rest-dsl, and then use spring boot undertow-starter to have it use undertow instead of tomcat. > Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall > -- > > Key: CAMEL-12378 > URL: https://issues.apache.org/jira/browse/CAMEL-12378 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Tomohisa Igarashi >Priority: Major > Fix For: 2.22.0 > > > This example fails with starting the consumer. Some weird SB classpath > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
[ https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416163#comment-16416163 ] Tomohisa Igarashi commented on CAMEL-12378: --- It turned out to be just a missing dependency on camel-undertow-starter... but still undertow component is not working well with REST DSL, something wrong with path templating and port. Changing camel.rest.component back to servlet shows another problem, consumer immediately finishes without any warn/error... > Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall > -- > > Key: CAMEL-12378 > URL: https://issues.apache.org/jira/browse/CAMEL-12378 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Tomohisa Igarashi >Priority: Major > Fix For: 2.22.0 > > > This example fails with starting the consumer. Some weird SB classpath > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
[ https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416107#comment-16416107 ] Tomohisa Igarashi commented on CAMEL-12378: --- UndertowComponent is resolved here with name "undertow-component" on upstream master while it doesn't on boot2ga branch https://github.com/apache/camel/blob/688cffe19375f8fd5248b7af9e92fa17dfd14d59/components/camel-spring/src/main/java/org/apache/camel/spring/spi/ApplicationContextRegistry.java#L71 > Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall > -- > > Key: CAMEL-12378 > URL: https://issues.apache.org/jira/browse/CAMEL-12378 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Tomohisa Igarashi >Priority: Major > Fix For: 2.22.0 > > > This example fails with starting the consumer. Some weird SB classpath > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
[ https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416094#comment-16416094 ] Tomohisa Igarashi commented on CAMEL-12378: --- The UndertowComponent is looked up via spring application context with name "undertow-component" on upstream master, but not on boot2ga branch. > Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall > -- > > Key: CAMEL-12378 > URL: https://issues.apache.org/jira/browse/CAMEL-12378 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Tomohisa Igarashi >Priority: Major > Fix For: 2.22.0 > > > This example fails with starting the consumer. Some weird SB classpath > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
[ https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414570#comment-16414570 ] Tomohisa Igarashi commented on CAMEL-12378: --- So in 1.x, the instanceId is generated from ApplicationContext.getId() which has default value, but in 2.0 it's generated from spring.application.name or spring.application.instance_id where they are null if not explicitly specified. So specifying one of them looks legit at least for now. > Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall > -- > > Key: CAMEL-12378 > URL: https://issues.apache.org/jira/browse/CAMEL-12378 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Tomohisa Igarashi >Priority: Major > Fix For: 2.22.0 > > > This example fails with starting the consumer. Some weird SB classpath > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
[ https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411922#comment-16411922 ] Tomohisa Igarashi commented on CAMEL-12378: --- It seems we need to bump spring-cloud to one of 2.0 milestone releases. http://projects.spring.io/spring-cloud/ > Finchley builds and works with Spring Boot 2.0.x, and is not expected to work > with Spring Boot 1.5.x. > The Dalston and Edgware release trains build on Spring Boot 1.5.x, and are > not expected to work with Spring Boot 2.0.x. > Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall > -- > > Key: CAMEL-12378 > URL: https://issues.apache.org/jira/browse/CAMEL-12378 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Tomohisa Igarashi >Priority: Major > Fix For: 2.22.0 > > > This example fails with starting the consumer. Some weird SB classpath > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
[ https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411101#comment-16411101 ] Luca Burgazzoli commented on CAMEL-12378: - Looks like something has changed in spring-cloud so as workaround set spring.application.instance_id = test in application.properties (consumer). There are other issues related to camel's rest setup then but I have no time at the moment to digg int them further. > Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall > -- > > Key: CAMEL-12378 > URL: https://issues.apache.org/jira/browse/CAMEL-12378 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Tomohisa Igarashi >Priority: Major > Fix For: 2.22.0 > > > This example fails with starting the consumer. Some weird SB classpath > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
[ https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410974#comment-16410974 ] Claus Ibsen commented on CAMEL-12378: - Ah it may be some consul client upgrade etc. Wonder if Luca may help? > Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall > -- > > Key: CAMEL-12378 > URL: https://issues.apache.org/jira/browse/CAMEL-12378 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Assignee: Tomohisa Igarashi >Priority: Major > Fix For: 2.22.0 > > > This example fails with starting the consumer. Some weird SB classpath > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
[ https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408910#comment-16408910 ] Tomohisa Igarashi commented on CAMEL-12378: --- For example this commit added @Ignore on some of ServiceCall tests [https://github.com/apache/camel/commit/7ea22963f245b1090b52c8d56de0658af62d9c07] > Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall > -- > > Key: CAMEL-12378 > URL: https://issues.apache.org/jira/browse/CAMEL-12378 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Priority: Major > Fix For: 2.22.0 > > > This example fails with starting the consumer. Some weird SB classpath > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12378) Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall
[ https://issues.apache.org/jira/browse/CAMEL-12378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408856#comment-16408856 ] Ramu kakarla commented on CAMEL-12378: --- Example builds success in my tests. am I Testing something different (mvn clean install) > Spring Boot 2 - Fix the camel-example-spring-cloud-servicecall > -- > > Key: CAMEL-12378 > URL: https://issues.apache.org/jira/browse/CAMEL-12378 > Project: Camel > Issue Type: Sub-task >Reporter: Claus Ibsen >Priority: Major > Fix For: 2.22.0 > > > This example fails with starting the consumer. Some weird SB classpath > problem. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
