[jira] [Commented] (CAMEL-12957) camel-cxf - Swagger/OpenAPI feature should not involve the Camel route
[ https://issues.apache.org/jira/browse/CAMEL-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906274#comment-16906274 ] Freeman Fang commented on CAMEL-12957: -- CXF 3.3.3 is out, I will update to use it and close this issue > camel-cxf - Swagger/OpenAPI feature should not involve the Camel route > -- > > Key: CAMEL-12957 > URL: https://issues.apache.org/jira/browse/CAMEL-12957 > Project: Camel > Issue Type: Improvement > Components: camel-cxfrs >Affects Versions: 2.22.2 >Reporter: Jens Kleine-Herzbruch >Assignee: Freeman Fang >Priority: Minor > Fix For: 3.0.0 > > Attachments: camel-openapi-test-swagger2feature.tar, > camel-openapi-test.zip > > > Currently, when adding Swagger2Feature or OpenApiFeature to a CXFRS endpoint, > the calls to the API descriptions go through the Camel route, ie. one has to > implement an additional Camel route in order to make those features work. > Using runAsFilter=false a call to > http://localhost:8080/services/myCamelService/openapi.json > results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > results in call of the Camel route with an operation "getResource" > Using runAsFilter=true the situation improves marginally: > http://localhost:8080/services/myCamelService/openapi.json > still results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > at least now shows the Swagger UI page frame but still fails to load the > actual service description since it again calls the Camel route with the > "getOpenApi" operation. > Supposedly that means the filter correctly intercepts the getResource call > but not the getOpenApi call. It would be great if this worked out of the box. > A custom implementation would still be possible by not running as a filter. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (CAMEL-12957) camel-cxf - Swagger/OpenAPI feature should not involve the Camel route
[ https://issues.apache.org/jira/browse/CAMEL-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901163#comment-16901163 ] Claus Ibsen commented on CAMEL-12957: - Okay we are waiting for CXF 3.3.3 release > camel-cxf - Swagger/OpenAPI feature should not involve the Camel route > -- > > Key: CAMEL-12957 > URL: https://issues.apache.org/jira/browse/CAMEL-12957 > Project: Camel > Issue Type: Improvement > Components: camel-cxfrs >Affects Versions: 2.22.2 >Reporter: Jens Kleine-Herzbruch >Assignee: Freeman Fang >Priority: Minor > Attachments: camel-openapi-test-swagger2feature.tar, > camel-openapi-test.zip > > > Currently, when adding Swagger2Feature or OpenApiFeature to a CXFRS endpoint, > the calls to the API descriptions go through the Camel route, ie. one has to > implement an additional Camel route in order to make those features work. > Using runAsFilter=false a call to > http://localhost:8080/services/myCamelService/openapi.json > results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > results in call of the Camel route with an operation "getResource" > Using runAsFilter=true the situation improves marginally: > http://localhost:8080/services/myCamelService/openapi.json > still results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > at least now shows the Swagger UI page frame but still fails to load the > actual service description since it again calls the Camel route with the > "getOpenApi" operation. > Supposedly that means the filter correctly intercepts the getResource call > but not the getOpenApi call. It would be great if this worked out of the box. > A custom implementation would still be possible by not running as a filter. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (CAMEL-12957) camel-cxf - Swagger/OpenAPI feature should not involve the Camel route
[ https://issues.apache.org/jira/browse/CAMEL-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881259#comment-16881259 ] Freeman Fang commented on CAMEL-12957: -- [~jen...@gmx.net], great! thanks for the feedback, will mark this issue as "resolved" once we upgrade new cxf version contains the fix > camel-cxf - Swagger/OpenAPI feature should not involve the Camel route > -- > > Key: CAMEL-12957 > URL: https://issues.apache.org/jira/browse/CAMEL-12957 > Project: Camel > Issue Type: Improvement > Components: camel-cxfrs >Affects Versions: 2.22.2 >Reporter: Jens Kleine-Herzbruch >Assignee: Freeman Fang >Priority: Minor > Attachments: camel-openapi-test-swagger2feature.tar, > camel-openapi-test.zip > > > Currently, when adding Swagger2Feature or OpenApiFeature to a CXFRS endpoint, > the calls to the API descriptions go through the Camel route, ie. one has to > implement an additional Camel route in order to make those features work. > Using runAsFilter=false a call to > http://localhost:8080/services/myCamelService/openapi.json > results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > results in call of the Camel route with an operation "getResource" > Using runAsFilter=true the situation improves marginally: > http://localhost:8080/services/myCamelService/openapi.json > still results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > at least now shows the Swagger UI page frame but still fails to load the > actual service description since it again calls the Camel route with the > "getOpenApi" operation. > Supposedly that means the filter correctly intercepts the getResource call > but not the getOpenApi call. It would be great if this worked out of the box. > A custom implementation would still be possible by not running as a filter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12957) camel-cxf - Swagger/OpenAPI feature should not involve the Camel route
[ https://issues.apache.org/jira/browse/CAMEL-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880965#comment-16880965 ] Jens Kleine-Herzbruch commented on CAMEL-12957: --- [~ffang]: Seems to work fine now with CXF snapshot versions. Thank you! > camel-cxf - Swagger/OpenAPI feature should not involve the Camel route > -- > > Key: CAMEL-12957 > URL: https://issues.apache.org/jira/browse/CAMEL-12957 > Project: Camel > Issue Type: Improvement > Components: camel-cxfrs >Affects Versions: 2.22.2 >Reporter: Jens Kleine-Herzbruch >Assignee: Freeman Fang >Priority: Minor > Attachments: camel-openapi-test-swagger2feature.tar, > camel-openapi-test.zip > > > Currently, when adding Swagger2Feature or OpenApiFeature to a CXFRS endpoint, > the calls to the API descriptions go through the Camel route, ie. one has to > implement an additional Camel route in order to make those features work. > Using runAsFilter=false a call to > http://localhost:8080/services/myCamelService/openapi.json > results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > results in call of the Camel route with an operation "getResource" > Using runAsFilter=true the situation improves marginally: > http://localhost:8080/services/myCamelService/openapi.json > still results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > at least now shows the Swagger UI page frame but still fails to load the > actual service description since it again calls the Camel route with the > "getOpenApi" operation. > Supposedly that means the filter correctly intercepts the getResource call > but not the getOpenApi call. It would be great if this worked out of the box. > A custom implementation would still be possible by not running as a filter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12957) camel-cxf - Swagger/OpenAPI feature should not involve the Camel route
[ https://issues.apache.org/jira/browse/CAMEL-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879444#comment-16879444 ] Freeman Fang commented on CAMEL-12957: -- [~jen...@gmx.net], FYI, this is addressed on CXF side, could you test with lastest CXF snapshot with your testcase? Freeman > camel-cxf - Swagger/OpenAPI feature should not involve the Camel route > -- > > Key: CAMEL-12957 > URL: https://issues.apache.org/jira/browse/CAMEL-12957 > Project: Camel > Issue Type: Improvement > Components: camel-cxfrs >Affects Versions: 2.22.2 >Reporter: Jens Kleine-Herzbruch >Assignee: Freeman Fang >Priority: Minor > Attachments: camel-openapi-test-swagger2feature.tar, > camel-openapi-test.zip > > > Currently, when adding Swagger2Feature or OpenApiFeature to a CXFRS endpoint, > the calls to the API descriptions go through the Camel route, ie. one has to > implement an additional Camel route in order to make those features work. > Using runAsFilter=false a call to > http://localhost:8080/services/myCamelService/openapi.json > results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > results in call of the Camel route with an operation "getResource" > Using runAsFilter=true the situation improves marginally: > http://localhost:8080/services/myCamelService/openapi.json > still results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > at least now shows the Swagger UI page frame but still fails to load the > actual service description since it again calls the Camel route with the > "getOpenApi" operation. > Supposedly that means the filter correctly intercepts the getResource call > but not the getOpenApi call. It would be great if this worked out of the box. > A custom implementation would still be possible by not running as a filter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12957) camel-cxf - Swagger/OpenAPI feature should not involve the Camel route
[ https://issues.apache.org/jira/browse/CAMEL-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875192#comment-16875192 ] Freeman Fang commented on CAMEL-12957: -- As for OpenApiFeature(OpenApi V3), created CXF-8064 on CXF side to address this issue > camel-cxf - Swagger/OpenAPI feature should not involve the Camel route > -- > > Key: CAMEL-12957 > URL: https://issues.apache.org/jira/browse/CAMEL-12957 > Project: Camel > Issue Type: Improvement > Components: camel-cxfrs >Affects Versions: 2.22.2 >Reporter: Jens Kleine-Herzbruch >Assignee: Freeman Fang >Priority: Minor > Attachments: camel-openapi-test-swagger2feature.tar, > camel-openapi-test.zip > > > Currently, when adding Swagger2Feature or OpenApiFeature to a CXFRS endpoint, > the calls to the API descriptions go through the Camel route, ie. one has to > implement an additional Camel route in order to make those features work. > Using runAsFilter=false a call to > http://localhost:8080/services/myCamelService/openapi.json > results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > results in call of the Camel route with an operation "getResource" > Using runAsFilter=true the situation improves marginally: > http://localhost:8080/services/myCamelService/openapi.json > still results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > at least now shows the Swagger UI page frame but still fails to load the > actual service description since it again calls the Camel route with the > "getOpenApi" operation. > Supposedly that means the filter correctly intercepts the getResource call > but not the getOpenApi call. It would be great if this worked out of the box. > A custom implementation would still be possible by not running as a filter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12957) camel-cxf - Swagger/OpenAPI feature should not involve the Camel route
[ https://issues.apache.org/jira/browse/CAMEL-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871751#comment-16871751 ] Freeman Fang commented on CAMEL-12957: -- Hi [~jen...@gmx.net], A quick update, you do need to set "runAsFilter" as true, this is by design to avoid swagger request run into the camel router. And I can confirm that this way Swagger2Feature works, please see attached camel-openapi-test-swagger2feature.tar, you can access http://localhost:8080/api-docs?url=/swagger.json (to get the swagger UI render) or http://localhost:8080/swagger.json (to get the raw swagger payload). I'm still checking the OpenApiFeature(OpenApi V3), to see it's just a configuration problem or we do need some work in cxf OpenApiFeature to make it work with camel-cxfrs. Cheers Freeman > camel-cxf - Swagger/OpenAPI feature should not involve the Camel route > -- > > Key: CAMEL-12957 > URL: https://issues.apache.org/jira/browse/CAMEL-12957 > Project: Camel > Issue Type: Improvement > Components: camel-cxfrs >Affects Versions: 2.22.2 >Reporter: Jens Kleine-Herzbruch >Assignee: Freeman Fang >Priority: Minor > Attachments: camel-openapi-test-swagger2feature.tar, > camel-openapi-test.zip > > > Currently, when adding Swagger2Feature or OpenApiFeature to a CXFRS endpoint, > the calls to the API descriptions go through the Camel route, ie. one has to > implement an additional Camel route in order to make those features work. > Using runAsFilter=false a call to > http://localhost:8080/services/myCamelService/openapi.json > results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > results in call of the Camel route with an operation "getResource" > Using runAsFilter=true the situation improves marginally: > http://localhost:8080/services/myCamelService/openapi.json > still results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > at least now shows the Swagger UI page frame but still fails to load the > actual service description since it again calls the Camel route with the > "getOpenApi" operation. > Supposedly that means the filter correctly intercepts the getResource call > but not the getOpenApi call. It would be great if this worked out of the box. > A custom implementation would still be possible by not running as a filter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12957) camel-cxf - Swagger/OpenAPI feature should not involve the Camel route
[ https://issues.apache.org/jira/browse/CAMEL-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871536#comment-16871536 ] Freeman Fang commented on CAMEL-12957: -- Thanks [~jen...@gmx.net]! I will take a close look! Freeman > camel-cxf - Swagger/OpenAPI feature should not involve the Camel route > -- > > Key: CAMEL-12957 > URL: https://issues.apache.org/jira/browse/CAMEL-12957 > Project: Camel > Issue Type: Improvement > Components: camel-cxfrs >Affects Versions: 2.22.2 >Reporter: Jens Kleine-Herzbruch >Assignee: Freeman Fang >Priority: Minor > Attachments: camel-openapi-test.zip > > > Currently, when adding Swagger2Feature or OpenApiFeature to a CXFRS endpoint, > the calls to the API descriptions go through the Camel route, ie. one has to > implement an additional Camel route in order to make those features work. > Using runAsFilter=false a call to > http://localhost:8080/services/myCamelService/openapi.json > results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > results in call of the Camel route with an operation "getResource" > Using runAsFilter=true the situation improves marginally: > http://localhost:8080/services/myCamelService/openapi.json > still results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > at least now shows the Swagger UI page frame but still fails to load the > actual service description since it again calls the Camel route with the > "getOpenApi" operation. > Supposedly that means the filter correctly intercepts the getResource call > but not the getOpenApi call. It would be great if this worked out of the box. > A custom implementation would still be possible by not running as a filter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12957) camel-cxf - Swagger/OpenAPI feature should not involve the Camel route
[ https://issues.apache.org/jira/browse/CAMEL-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870884#comment-16870884 ] Jens Kleine-Herzbruch commented on CAMEL-12957: --- Hi Freeman, here's a small test project that shows the problem. Cheers, Jens > camel-cxf - Swagger/OpenAPI feature should not involve the Camel route > -- > > Key: CAMEL-12957 > URL: https://issues.apache.org/jira/browse/CAMEL-12957 > Project: Camel > Issue Type: Improvement > Components: camel-cxfrs >Affects Versions: 2.22.2 >Reporter: Jens Kleine-Herzbruch >Priority: Minor > Attachments: camel-openapi-test.zip > > > Currently, when adding Swagger2Feature or OpenApiFeature to a CXFRS endpoint, > the calls to the API descriptions go through the Camel route, ie. one has to > implement an additional Camel route in order to make those features work. > Using runAsFilter=false a call to > http://localhost:8080/services/myCamelService/openapi.json > results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > results in call of the Camel route with an operation "getResource" > Using runAsFilter=true the situation improves marginally: > http://localhost:8080/services/myCamelService/openapi.json > still results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > at least now shows the Swagger UI page frame but still fails to load the > actual service description since it again calls the Camel route with the > "getOpenApi" operation. > Supposedly that means the filter correctly intercepts the getResource call > but not the getOpenApi call. It would be great if this worked out of the box. > A custom implementation would still be possible by not running as a filter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CAMEL-12957) camel-cxf - Swagger/OpenAPI feature should not involve the Camel route
[ https://issues.apache.org/jira/browse/CAMEL-12957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855767#comment-16855767 ] Freeman Fang commented on CAMEL-12957: -- Hi [~jen...@gmx.net], Any chance you can append a testcase project? (github project or a zipped one here both are OK) Thanks! Freeman > camel-cxf - Swagger/OpenAPI feature should not involve the Camel route > -- > > Key: CAMEL-12957 > URL: https://issues.apache.org/jira/browse/CAMEL-12957 > Project: Camel > Issue Type: Improvement > Components: camel-cxfrs >Affects Versions: 2.22.2 >Reporter: Jens Kleine-Herzbruch >Priority: Minor > > Currently, when adding Swagger2Feature or OpenApiFeature to a CXFRS endpoint, > the calls to the API descriptions go through the Camel route, ie. one has to > implement an additional Camel route in order to make those features work. > Using runAsFilter=false a call to > http://localhost:8080/services/myCamelService/openapi.json > results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > results in call of the Camel route with an operation "getResource" > Using runAsFilter=true the situation improves marginally: > http://localhost:8080/services/myCamelService/openapi.json > still results in a call of the Camel route with an operation "getOpenApi" > http://localhost:8080/services/myCamelServive/api-docs?url=openapi.json > at least now shows the Swagger UI page frame but still fails to load the > actual service description since it again calls the Camel route with the > "getOpenApi" operation. > Supposedly that means the filter correctly intercepts the getResource call > but not the getOpenApi call. It would be great if this worked out of the box. > A custom implementation would still be possible by not running as a filter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
