[jira] [Commented] (CAMEL-8729) Add query all capabilities in hazelcast map producers
[ https://issues.apache.org/jira/browse/CAMEL-8729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525737#comment-14525737 ] Juan Jose Vazquez Delgado commented on CAMEL-8729: -- Thank you for paying attention to this ticket that fast!. In fact, I were going to share a pull request today but you were ahead :-). My implementation is quite similar so I'll stick to yours. Thanks! Add query all capabilities in hazelcast map producers - Key: CAMEL-8729 URL: https://issues.apache.org/jira/browse/CAMEL-8729 Project: Camel Issue Type: Improvement Components: camel-hazelcast Affects Versions: 2.15.1 Reporter: Juan Jose Vazquez Delgado Assignee: Andrea Cosentino Fix For: 2.16.0 Currently, it's not possible to get all map entries. In the current implementation, get operation requires some key specified. Also, query operation requires a non-empty sql predicate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8729) Add query all capabilities in hazelcast map producers
[ https://issues.apache.org/jira/browse/CAMEL-8729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523800#comment-14523800 ] Andrea Cosentino commented on CAMEL-8729: - Thanks for opening this ticket :-) Add query all capabilities in hazelcast map producers - Key: CAMEL-8729 URL: https://issues.apache.org/jira/browse/CAMEL-8729 Project: Camel Issue Type: Improvement Components: camel-hazelcast Affects Versions: 2.15.1 Reporter: Juan Jose Vazquez Delgado Assignee: Andrea Cosentino Fix For: 2.15.2, 2.16.0 Currently, it's not possible to get all map entries. In the current implementation, get operation requires some key specified. Also, query operation requires a non-empty sql predicate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8729) Add query all capabilities in hazelcast map producers
[ https://issues.apache.org/jira/browse/CAMEL-8729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523948#comment-14523948 ] Babak Vahdat commented on CAMEL-8729: - [~ancosen] {{ObjectHelper.isNotEmpty(foo)}} checks for {{null}} as well so that an extra {{foo != null}} condition check is obsolete / not required. There’re also similar logic being added for camel-openshift recently, like [here|https://github.com/apache/camel/blob/master/components/camel-openshift/src/main/java/org/apache/camel/component/openshift/OpenShiftProducer.java#L432]. Also I guess we can remove the Fix version of 2.15.2 for this ticket as it’s not a bug which we need to back port, right? BTW thanks for all your contributions and welcome aboard :) Add query all capabilities in hazelcast map producers - Key: CAMEL-8729 URL: https://issues.apache.org/jira/browse/CAMEL-8729 Project: Camel Issue Type: Improvement Components: camel-hazelcast Affects Versions: 2.15.1 Reporter: Juan Jose Vazquez Delgado Assignee: Andrea Cosentino Fix For: 2.15.2, 2.16.0 Currently, it's not possible to get all map entries. In the current implementation, get operation requires some key specified. Also, query operation requires a non-empty sql predicate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CAMEL-8729) Add query all capabilities in hazelcast map producers
[ https://issues.apache.org/jira/browse/CAMEL-8729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523958#comment-14523958 ] Andrea Cosentino commented on CAMEL-8729: - Hi Babak :-) Yes. You're right! :-) I will remove all the not required null checks in my latest contributions. Thank you for your suggestions :-) Add query all capabilities in hazelcast map producers - Key: CAMEL-8729 URL: https://issues.apache.org/jira/browse/CAMEL-8729 Project: Camel Issue Type: Improvement Components: camel-hazelcast Affects Versions: 2.15.1 Reporter: Juan Jose Vazquez Delgado Assignee: Andrea Cosentino Fix For: 2.16.0 Currently, it's not possible to get all map entries. In the current implementation, get operation requires some key specified. Also, query operation requires a non-empty sql predicate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)