[jira] [Updated] (CAMEL-12643) camel-rabbitmq - Inadequate information for handling catch clauses

2018-07-12 Thread Willem Jiang (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated CAMEL-12643:
-
Description: 
There are some situations that different exception types are caught, but the 
handling of those exceptions cannot show the differences between those types. 
Here are the code snippets which have this problem:
{code}
org.apache.camel.component.rabbitmq.*RabbitConsumer*.handleShutdownSignal, 
*Line 271*

catch (IOException | TimeoutException e)

{   log.warn("Unable to obtain a RabbitMQ channel. Will try again");     ...    
  }
{code}

It may cause confusions to the person who is reading the log, the person can 
not know what exception happened here and cannot distinguish if the exception 
type is IOException or TimeoutException. Simply adding a full stack trace is 
able to improve it.

 

  was:
There are some situations that different exception types are caught, but the 
handling of those exceptions cannot show the differences between those types. 
Here are the code snippets which have this problem:

org.apache.camel.component.rabbitmq.*RabbitConsumer*.handleShutdownSignal, 
*Line 271*

catch (IOException | TimeoutException e)

{   log.warn("Unable to obtain a RabbitMQ channel. Will try again");     ...    
  }

It may cause confusions to the person who is reading the log, the person can 
not know what exception happened here and cannot distinguish if the exception 
type is IOException or TimeoutException. Simply adding a full stack trace is 
able to improve it.

 


> camel-rabbitmq - Inadequate information for handling catch clauses
> --
>
> Key: CAMEL-12643
> URL: https://issues.apache.org/jira/browse/CAMEL-12643
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-rabbitmq
>Reporter: Zhenhao Li
>Priority: Minor
>
> There are some situations that different exception types are caught, but the 
> handling of those exceptions cannot show the differences between those types. 
> Here are the code snippets which have this problem:
> {code}
> org.apache.camel.component.rabbitmq.*RabbitConsumer*.handleShutdownSignal, 
> *Line 271*
> catch (IOException | TimeoutException e)
> {   log.warn("Unable to obtain a RabbitMQ channel. Will try again");     ...  
>     }
> {code}
> It may cause confusions to the person who is reading the log, the person can 
> not know what exception happened here and cannot distinguish if the exception 
> type is IOException or TimeoutException. Simply adding a full stack trace is 
> able to improve it.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CAMEL-12643) camel-rabbitmq - Inadequate information for handling catch clauses

2018-07-12 Thread Claus Ibsen (JIRA)


 [ 
https://issues.apache.org/jira/browse/CAMEL-12643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-12643:

Summary: camel-rabbitmq - Inadequate information for handling catch clauses 
 (was: Inadequate information for handling catch clauses)

> camel-rabbitmq - Inadequate information for handling catch clauses
> --
>
> Key: CAMEL-12643
> URL: https://issues.apache.org/jira/browse/CAMEL-12643
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-rabbitmq
>Reporter: Zhenhao Li
>Priority: Minor
>
> There are some situations that different exception types are caught, but the 
> handling of those exceptions cannot show the differences between those types. 
> Here are the code snippets which have this problem:
> org.apache.camel.component.rabbitmq.*RabbitConsumer*.handleShutdownSignal, 
> *Line 271*
> catch (IOException | TimeoutException e)
> {   log.warn("Unable to obtain a RabbitMQ channel. Will try again");     ...  
>     }
> It may cause confusions to the person who is reading the log, the person can 
> not know what exception happened here and cannot distinguish if the exception 
> type is IOException or TimeoutException. Simply adding a full stack trace is 
> able to improve it.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)