[jira] [Created] (CAMEL-10334) Use of whitespaces in remotePath

2016-09-21 Thread Alexander Friedrichs (JIRA)
Alexander Friedrichs created CAMEL-10334:


 Summary: Use of whitespaces in remotePath
 Key: CAMEL-10334
 URL: https://issues.apache.org/jira/browse/CAMEL-10334
 Project: Camel
  Issue Type: Improvement
Affects Versions: 2.17.3
Reporter: Alexander Friedrichs
Priority: Minor


With DropBox it is possible to use filepaths and filenames with whitespaces in 
it. The attribute remotePath can't support this yet.

Camel translate a remotePath like this:
{{to("dropbox://search?accessToken=&clientIdentifier=&remotePath=/path+with+spaces")}}
to {{/path with spaces}} and this hits the DropboxConfigurationValidator.

One possible solution, replace whitespaces with plus.

I created a patch with a unit test and will make a pull request for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (CAMEL-10332) Define netty version in dependency management

2016-09-21 Thread Claus Ibsen (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen resolved CAMEL-10332.
-
Resolution: Fixed
  Assignee: Claus Ibsen

> Define netty version in dependency management
> -
>
> Key: CAMEL-10332
> URL: https://issues.apache.org/jira/browse/CAMEL-10332
> Project: Camel
>  Issue Type: Task
>Reporter: Thomas Diesler
>Assignee: Claus Ibsen
> Fix For: 2.18.0
>
>
> The version of netty-all required by vertx and other components is not 
> properly exposed through the BOM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-10334) Use of whitespaces in remotePath

2016-09-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508997#comment-15508997
 ] 

ASF GitHub Bot commented on CAMEL-10334:


GitHub user undso opened a pull request:

https://github.com/apache/camel/pull/1184

CAMEL-10334 Use of whitespaces in remotePath

https://issues.apache.org/jira/browse/CAMEL-10334

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/undso/camel master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/camel/pull/1184.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1184


commit aa9d508bd3d21f0ff914f08b5772a2507f2e220e
Author: Alexander Friedrichs 
Date:   2016-09-21T06:03:12Z

Handle whitespaces in remotePath




> Use of whitespaces in remotePath
> 
>
> Key: CAMEL-10334
> URL: https://issues.apache.org/jira/browse/CAMEL-10334
> Project: Camel
>  Issue Type: Improvement
>Affects Versions: 2.17.3
>Reporter: Alexander Friedrichs
>Priority: Minor
>  Labels: camel, dropbox
>
> With DropBox it is possible to use filepaths and filenames with whitespaces 
> in it. The attribute remotePath can't support this yet.
> Camel translate a remotePath like this:
> {{to("dropbox://search?accessToken=&clientIdentifier=&remotePath=/path+with+spaces")}}
> to {{/path with spaces}} and this hits the DropboxConfigurationValidator.
> One possible solution, replace whitespaces with plus.
> I created a patch with a unit test and will make a pull request for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CAMEL-10331) Camel Docker Consumer

2016-09-21 Thread Claus Ibsen (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-10331:

Assignee: Fabrizio Spataro

> Camel Docker Consumer
> -
>
> Key: CAMEL-10331
> URL: https://issues.apache.org/jira/browse/CAMEL-10331
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-docker
>Affects Versions: 2.18.0
>Reporter: Fabrizio Spataro
>Assignee: Fabrizio Spataro
>
> Today, through the work of the CAMEL-10307 the docker-java library it has 
> been updated deleting camel consumer.
> A open this jira to restore it.
> Note: I am working to it soon as possible!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-10330) Complete support to API Docker

2016-09-21 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509012#comment-15509012
 ] 

Claus Ibsen commented on CAMEL-10330:
-

Fabrizio, you can now self assign tickets in JIRA

> Complete support to API Docker
> --
>
> Key: CAMEL-10330
> URL: https://issues.apache.org/jira/browse/CAMEL-10330
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-docker
>Affects Versions: 2.18.0
>Reporter: Fabrizio Spataro
>  Labels: docker
>
> Today, through the work of the CAMEL-10307 the docker-java library it has 
> been updated. 
> A open this jira to complete work by covering the services still not 
> available (for example "docker swarm")
> Note: i will do it soon as possible



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CAMEL-10321) New Component camel-asterisk

2016-09-21 Thread Claus Ibsen (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-10321:

Assignee: Fabrizio Spataro

> New Component camel-asterisk
> 
>
> Key: CAMEL-10321
> URL: https://issues.apache.org/jira/browse/CAMEL-10321
> Project: Camel
>  Issue Type: New Feature
>Reporter: Fabrizio Spataro
>Assignee: Fabrizio Spataro
>
> Hello,
> i wrote a component to send and receive event from an asterisk VOIP server.
> Can i send my PR? Is it compatible with apache camel code license?
> King Regard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-10222) camel-spring-boot - New starters and BOMs

2016-09-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509031#comment-15509031
 ] 

ASF GitHub Bot commented on CAMEL-10222:


Github user asfgit closed the pull request at:

https://github.com/apache/camel/pull/1182


> camel-spring-boot - New starters and BOMs
> -
>
> Key: CAMEL-10222
> URL: https://issues.apache.org/jira/browse/CAMEL-10222
> Project: Camel
>  Issue Type: New Feature
>  Components: camel-spring-boot
>Reporter: Nicola Ferraro
>Assignee: Nicola Ferraro
> Fix For: 2.18.0
>
>
> It would be great if all camel components could be mixed-in in a spring-boot 
> application without having to worry about dependencies.
> This would allow users to choose the camel components in a tool like forge on 
> fabric8 or spring initializr to produce a base artifact. Writing camel routes 
> will be the only task left to the user. 
> Unfortunately, integration tests have shown that there are many (small, 
> trivial) issues that need to be fixed before people can use a component with 
> spring-boot (list follows).
> A possible solution that will provide a better experience with spring-boot 
> would be:
> - Providing a new spring-boot bom
> - Providing a spring-boot-starter project for each camel component
> A user application pom will look like the following:
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
>  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> com.company
> myapp
> 1.0
> 
> 
> 
> org.springframework.boot
> spring-boot-dependencies
> xxx
> pom
> import
> 
> 
> org.apache.camel
> camel-spring-boot-dependencies
> xxx
> pom
> import
> 
> 
> 
> 
> 
> org.apache.camel
> camel-starter-docker
> 
> 
> 
> 
> org.apache.camel
> camel-starter-http
> 
> 
> 
> {code}
> As suggested by [~chirino], the creation of such starters (and of the bom) 
> could be automated. Rules for creating such artifacts will be (at least) the 
> following:
> *0) Basic*
> The spring-boot-bom will be derived from _camel-parent_, with some exceptions 
> to solve particular issues. Most of the starters will just include a 
> dependency on the artifact they refer to.
> *1) Logging*
> Logging issues have been found during integration tests, but they will be 
> solved on the main artifacts (see CAMEL-10217). The starter generator will 
> just check that logging implementation are missing from the artifact to 
> prevent conflicts with slf4j-logback (used by spring-boot-starter).
> *2) Transitive overrides*
> Using the current implementation (with _camel-parent_ in the BOM), whenever a 
> component requires a library that is different from the one declared in 
> _camel-parent_, some hacks should be done, because the definition in the BOM 
> takes precedence.
> Eg. An user wants to use camel-jclouds, but instead of the pretty:
> {code:xml}
> 
>   org.apache.camel
>   camel-jclouds
> 
> {code}
> He will end up with the following declaration in his application pom:
> {code:xml}
> 
>   org.apache.camel
>   camel-jclouds
>   
> 
>   org.slf4j
>   slf4j-log4j12
> 
>   
> 
> 
>   com.google.guava
>   guava
>   16.0.1 
> 
> 
>   com.google.inject
>   guice
>   3.0 
> 
> {code}
> As a solution to this problem, if there are at least two components requiring 
> eg. a different version of guava, guava will not be included in the 
> spring-boot bom, instead the specific version will be enforced on each 
> starter (for all components using guava).
> Of course, this will not prevent issues when two components requiring 
> different versions of guava will be used in the same user application. I 
> think this issue cannot be avoided in applications with a standard 
> classloader.
> *3) API implementations*
> In many cases, spring-boot detects the presence of a particular api in the 
> classpath and expects an implementation is present. This happens for example 
> with the bean validation api:
> {noformat}
> ***
> APPLICATION FAILED TO START
> ***
> Description:
> The Bean Validation API is on the classpath but no implementation could be 
> found
> Action:
> Add an implementation, such as Hibernate Validator, to the classpath
> {noformat}
> The starters will include eg. the Hibernate Validator each time it is 
> required to start the applicat

[jira] [Commented] (CAMEL-10332) Define netty version in dependency management

2016-09-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509070#comment-15509070
 ] 

ASF GitHub Bot commented on CAMEL-10332:


Github user tdiesler closed the pull request at:

https://github.com/apache/camel/pull/1183


> Define netty version in dependency management
> -
>
> Key: CAMEL-10332
> URL: https://issues.apache.org/jira/browse/CAMEL-10332
> Project: Camel
>  Issue Type: Task
>Reporter: Thomas Diesler
>Assignee: Claus Ibsen
> Fix For: 2.18.0
>
>
> The version of netty-all required by vertx and other components is not 
> properly exposed through the BOM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-10334) Use of whitespaces in remotePath

2016-09-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509089#comment-15509089
 ] 

ASF GitHub Bot commented on CAMEL-10334:


Github user undso closed the pull request at:

https://github.com/apache/camel/pull/1184


> Use of whitespaces in remotePath
> 
>
> Key: CAMEL-10334
> URL: https://issues.apache.org/jira/browse/CAMEL-10334
> Project: Camel
>  Issue Type: Improvement
>Affects Versions: 2.17.3
>Reporter: Alexander Friedrichs
>Priority: Minor
>  Labels: camel, dropbox
>
> With DropBox it is possible to use filepaths and filenames with whitespaces 
> in it. The attribute remotePath can't support this yet.
> Camel translate a remotePath like this:
> {{to("dropbox://search?accessToken=&clientIdentifier=&remotePath=/path+with+spaces")}}
> to {{/path with spaces}} and this hits the DropboxConfigurationValidator.
> One possible solution, replace whitespaces with plus.
> I created a patch with a unit test and will make a pull request for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (CAMEL-10334) Use of whitespaces in remotePath

2016-09-21 Thread Andrea Cosentino (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-10334.
--
Resolution: Fixed

> Use of whitespaces in remotePath
> 
>
> Key: CAMEL-10334
> URL: https://issues.apache.org/jira/browse/CAMEL-10334
> Project: Camel
>  Issue Type: Improvement
>Affects Versions: 2.17.3
>Reporter: Alexander Friedrichs
>Assignee: Andrea Cosentino
>Priority: Minor
>  Labels: camel, dropbox
> Fix For: 2.18.0
>
>
> With DropBox it is possible to use filepaths and filenames with whitespaces 
> in it. The attribute remotePath can't support this yet.
> Camel translate a remotePath like this:
> {{to("dropbox://search?accessToken=&clientIdentifier=&remotePath=/path+with+spaces")}}
> to {{/path with spaces}} and this hits the DropboxConfigurationValidator.
> One possible solution, replace whitespaces with plus.
> I created a patch with a unit test and will make a pull request for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (CAMEL-10334) Use of whitespaces in remotePath

2016-09-21 Thread Andrea Cosentino (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino reassigned CAMEL-10334:


Assignee: Andrea Cosentino

> Use of whitespaces in remotePath
> 
>
> Key: CAMEL-10334
> URL: https://issues.apache.org/jira/browse/CAMEL-10334
> Project: Camel
>  Issue Type: Improvement
>Affects Versions: 2.17.3
>Reporter: Alexander Friedrichs
>Assignee: Andrea Cosentino
>Priority: Minor
>  Labels: camel, dropbox
> Fix For: 2.18.0
>
>
> With DropBox it is possible to use filepaths and filenames with whitespaces 
> in it. The attribute remotePath can't support this yet.
> Camel translate a remotePath like this:
> {{to("dropbox://search?accessToken=&clientIdentifier=&remotePath=/path+with+spaces")}}
> to {{/path with spaces}} and this hits the DropboxConfigurationValidator.
> One possible solution, replace whitespaces with plus.
> I created a patch with a unit test and will make a pull request for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CAMEL-10334) Use of whitespaces in remotePath

2016-09-21 Thread Andrea Cosentino (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-10334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino updated CAMEL-10334:
-
Fix Version/s: 2.18.0

> Use of whitespaces in remotePath
> 
>
> Key: CAMEL-10334
> URL: https://issues.apache.org/jira/browse/CAMEL-10334
> Project: Camel
>  Issue Type: Improvement
>Affects Versions: 2.17.3
>Reporter: Alexander Friedrichs
>Assignee: Andrea Cosentino
>Priority: Minor
>  Labels: camel, dropbox
> Fix For: 2.18.0
>
>
> With DropBox it is possible to use filepaths and filenames with whitespaces 
> in it. The attribute remotePath can't support this yet.
> Camel translate a remotePath like this:
> {{to("dropbox://search?accessToken=&clientIdentifier=&remotePath=/path+with+spaces")}}
> to {{/path with spaces}} and this hits the DropboxConfigurationValidator.
> One possible solution, replace whitespaces with plus.
> I created a patch with a unit test and will make a pull request for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-10197) camel-spring-boot - Extend the configuration hints to nested properties

2016-09-21 Thread Nicola Ferraro (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509243#comment-15509243
 ] 

Nicola Ferraro commented on CAMEL-10197:


I pushed a quick fix to restore the build.
I just fixed the boxing of long types and blacklisted some types that cannot be 
nested properties.

Basically, the spring-boot annotation processor goes in StackOverflow when a 
property of type _ApplicationContext_ is marked as _@NestedProperty_.
It does the same with recursive properties: properties containing a subproperty 
of the same type.

For now I just blacklisted the types, but we should prevent problems in the 
future. Probably we should also add a filter to exclude from nested properties 
objects that cannot be configured.

> camel-spring-boot - Extend the configuration hints to nested properties
> ---
>
> Key: CAMEL-10197
> URL: https://issues.apache.org/jira/browse/CAMEL-10197
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-spring-boot
>Reporter: Nicola Ferraro
>Assignee: Dhiraj Bokde
>
> Support for spring-boot configuration allows users to configure the component 
> properties but does not give any hint on nested properties.
> There are many components that declare properties on nested beans.
> Eg. camel-docker has only one property named _configuration_ .  I found this 
> pattern in components that allow users to specify a default value on the 
> component and override it on each endpoint, if necessary.
> Setting the property:
> {code}
> camel.component.docker.configuration.host=172.28.128.4
> {code}
> allows a user to specify the docker host, but the tooling does not give 
> suggestions about that property.
> A way to allow the users to view the nested properties is using the 
> {{NestedConfigurationProperty}} annotation on the spring-boot configuration 
> class. The spring-boot inspector will scan the nested class for properties.
> The drawback is that the javadoc is not read from setters. Another drawback 
> is that we will be using a different approach respect to the "read-the-json" 
> one.
> We need to figure out how to add these properties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-10197) camel-spring-boot - Extend the configuration hints to nested properties

2016-09-21 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509344#comment-15509344
 ] 

Claus Ibsen commented on CAMEL-10197:
-

Yeah its a bit drastic change this ticket / code commits.

We should blaclist some of the core Camel types such as HeaderFilterStrategy 
which is now marked as nested but it has no options to configure (there is no 
getter/setter on it etc.). 

> camel-spring-boot - Extend the configuration hints to nested properties
> ---
>
> Key: CAMEL-10197
> URL: https://issues.apache.org/jira/browse/CAMEL-10197
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-spring-boot
>Reporter: Nicola Ferraro
>Assignee: Dhiraj Bokde
>
> Support for spring-boot configuration allows users to configure the component 
> properties but does not give any hint on nested properties.
> There are many components that declare properties on nested beans.
> Eg. camel-docker has only one property named _configuration_ .  I found this 
> pattern in components that allow users to specify a default value on the 
> component and override it on each endpoint, if necessary.
> Setting the property:
> {code}
> camel.component.docker.configuration.host=172.28.128.4
> {code}
> allows a user to specify the docker host, but the tooling does not give 
> suggestions about that property.
> A way to allow the users to view the nested properties is using the 
> {{NestedConfigurationProperty}} annotation on the spring-boot configuration 
> class. The spring-boot inspector will scan the nested class for properties.
> The drawback is that the javadoc is not read from setters. Another drawback 
> is that we will be using a different approach respect to the "read-the-json" 
> one.
> We need to figure out how to add these properties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CAMEL-10197) camel-spring-boot - Extend the configuration hints to nested properties

2016-09-21 Thread Claus Ibsen (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-10197:

Fix Version/s: 2.18.0

> camel-spring-boot - Extend the configuration hints to nested properties
> ---
>
> Key: CAMEL-10197
> URL: https://issues.apache.org/jira/browse/CAMEL-10197
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-spring-boot
>Reporter: Nicola Ferraro
>Assignee: Dhiraj Bokde
> Fix For: 2.18.0
>
>
> Support for spring-boot configuration allows users to configure the component 
> properties but does not give any hint on nested properties.
> There are many components that declare properties on nested beans.
> Eg. camel-docker has only one property named _configuration_ .  I found this 
> pattern in components that allow users to specify a default value on the 
> component and override it on each endpoint, if necessary.
> Setting the property:
> {code}
> camel.component.docker.configuration.host=172.28.128.4
> {code}
> allows a user to specify the docker host, but the tooling does not give 
> suggestions about that property.
> A way to allow the users to view the nested properties is using the 
> {{NestedConfigurationProperty}} annotation on the spring-boot configuration 
> class. The spring-boot inspector will scan the nested class for properties.
> The drawback is that the javadoc is not read from setters. Another drawback 
> is that we will be using a different approach respect to the "read-the-json" 
> one.
> We need to figure out how to add these properties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CAMEL-10301) NullPointerException in Netty4 component's ClientChannelHandler causes async processor to wait forever

2016-09-21 Thread Claus Ibsen (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-10301:

Fix Version/s: (was: 2.18.0)
   2.19.0
   2.18.1

> NullPointerException in Netty4 component's ClientChannelHandler causes async 
> processor to wait forever
> --
>
> Key: CAMEL-10301
> URL: https://issues.apache.org/jira/browse/CAMEL-10301
> Project: Camel
>  Issue Type: Bug
>  Components: camel-netty4
>Affects Versions: 2.17.2
>Reporter: Alex Cheng
> Fix For: 2.19.0, 2.18.1
>
>
> When sending messages using camel netty4 component, in a rare case, a 
> NullPointerException thrown in {{ClientChannelHandler}} caused 
> {{org.apache.camel.impl.DefaultAsyncProcessorAwaitManager}} to wait forever. 
> From the stacktrace, the NPE occurred in line 116 of {{channelInactive}} 
> method and the {{exchange}} is null.
> {code}
> boolean doneUoW = exchange.getUnitOfWork() == null;
> {code}
> From {{getExchange}} method, it looks like it cannot get {{NettyCamelState}} 
> from {{NettyProducer}}. In {{NettyProducer}}'s {{process}} method, it's 
> possible that a Netty channel is closed before line 
> {code}
> putState(channel, new NettyCamelState(producerCallback, exchange));
> {code}
>  is executed, which triggers {{channelInactive}} and causes the NPE.
> So the flow looks like below:
> 1) Netty channel opened in {{NettyProducer}}
> 2) Before {{putState}} is invoked, the channel is closed
> 3) {{channelInactive}} method in {{ClientChannelHandler}} is called and 
> throws NPE, the worker thread dies
> 4) {{NettyProducer}} not mark the async processor as done
> In line 303 of {{NettyProducer}}, it simply returns if the channel future is 
> not success, but the {{ClientChannelHandler#exceptionCaught}} won't do any 
> thing if {{exchange}} is null and will never run again as the worker thread 
> already died.
> {code}
> if (!channelFuture.isSuccess()) {
> // no success then exit, (any exception has been handled 
> by ClientChannelHandler#exceptionCaught)
> return;
> }
> {code}
> The potential fix would be:
> 1) Add null check in {{ClientChannelHandler}}'s {{channelInactive}} method
> 2) Call {{producerCallback.done(false)}} in {{NettyProducer}}'s {{process}} 
> method when channel future is not success. This should be safe as 
> {{AsyncCallback}}'s {{done}} method can be called multiple times.
> Note, 2.18.0 version changed some implementation details of {{NettyProducer}} 
> but still has the same issue.
> Stacktrace:
> {code}
> 2016-09-08 00:26:11,843 | TRACE [-threads-1855599236)]
> org.apache.camel.component.netty4.NettyProducer : Pool[active=0, idle=0]
> 2016-09-08 00:26:11,843 | DEBUG [-threads-1855599236)]
> org.apache.camel.component.netty4.NettyProducer : Created new TCP client 
> bootstrap connecting to 172.25.0.100:15050 with options: 
> Bootstrap(BootstrapConfig(group: NioEventLoopGroup, channelFactory: 
> NioSocketChannel.class, options: {SO_KEEPALIVE=true, TCP_NODELAY=true, 
> SO_REUSEADDR=true, CONNECT_TIMEOUT_MILLIS=1}, handler: 
> org.apache.camel.component.netty4.DefaultClientInitializerFactory@297c237, 
> resolver: io.netty.resolver.DefaultAddressResolverGroup@6eb474f1))
> 2016-09-08 00:26:11,843 | TRACE [-threads-1855599236)]
> org.apache.camel.component.netty4.NettyProducer : Waiting for operation to 
> complete AbstractBootstrap$PendingRegistrationPromise@637319e7(incomplete) 
> for 1 millis
> 2016-09-08 00:26:11,844 | TRACE [NettyClientTCPWorker] 
> o.a.c.c.netty4.DefaultClientInitializerFactory : Using request timeout 5000 
> millis
> 2016-09-08 00:26:11,844 | TRACE [NettyClientTCPWorker] 
> o.a.c.c.netty4.DefaultClientInitializerFactory : Created ChannelPipeline: 
> DefaultChannelPipeline{(DefaultClientInitializerFactory#0 = 
> org.apache.camel.component.netty4.DefaultClientInitializerFactory), 
> (decoder-0 = xxx), (encoder-0 = 
> org.apache.camel.component.hl7.HL7MLLPNettyEncoder), (timeout = 
> io.netty.handler.timeout.ReadTimeoutHandler), (handler = 
> org.apache.camel.component.netty4.handlers.ClientChannelHandler)}
> 2016-09-08 00:26:11,845 | DEBUG [-threads-1855599236)]
> org.apache.camel.component.netty4.NettyProducer : Creating connector to 
> address: 172.25.0.100:15050
> 2016-09-08 00:26:11,845 | TRACE [NettyClientTCPWorker]
> org.apache.camel.component.netty4.NettyProducer : Channel open: [id: 
> 0x40064baa, L:/172.25.0.103:55662 - R:/172.25.0.100:15050]
> 2016-09-08 00:26:11,845 | TRACE [-threads-1855599236)]
> org.apache.camel.component.netty4.NettyProducer : Created channel: [id: 
> 0x40064baa, L:/172.25.0.103:55662 - R:/172.25.0.100:15050]
> 2016-09-08 00:26:11,845 | TRACE [-

[jira] [Commented] (CAMEL-10250) spring boot - SpringBootStarterMojo should not use internal API

2016-09-21 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509356#comment-15509356
 ] 

Claus Ibsen commented on CAMEL-10250:
-

Nicola is this still the case? Wonder if you have time to fix this too, or 
should we move this to 2.19 release?

> spring boot - SpringBootStarterMojo should not use internal API
> ---
>
> Key: CAMEL-10250
> URL: https://issues.apache.org/jira/browse/CAMEL-10250
> Project: Camel
>  Issue Type: Task
>  Components: tooling
>Reporter: Claus Ibsen
>Assignee: Nicola Ferraro
> Fix For: 2.18.0
>
>
> It uses some com.sun internal API. We should use some other XML library / 
> formatter to output using indent.
> {code}
> [INFO] Compiling 24 source files to 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/target/classes
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[47,48]
>  OutputFormat is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[48,48]
>  XMLSerializer is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,8]
>  OutputFormat is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,34]
>  OutputFormat is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,8]
>  XMLSerializer is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,39]
>  XMLSerializer is internal proprietary API and may be removed in a future 
> release
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-6132) camel-test-karaf - To allow end users more easily do Camel and Karaf integration test

2016-09-21 Thread Claus Ibsen (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509364#comment-15509364
 ] 

Claus Ibsen commented on CAMEL-6132:


For 2.18 this is a kind of preview module and then we will get community 
feedback and work to improved this for 2.19.0 release.

> camel-test-karaf - To allow end users more easily do Camel and Karaf 
> integration test
> -
>
> Key: CAMEL-6132
> URL: https://issues.apache.org/jira/browse/CAMEL-6132
> Project: Camel
>  Issue Type: New Feature
>  Components: karaf
>Reporter: Claus Ibsen
>Assignee: Quinn Stevenson
> Fix For: 2.18.0, 2.19.0
>
>
> We should introduce a proper camel-test-karaf component that *end users* can 
> use to do Camel and Karaf integration tests.
> The code we have in tests/camel-itest-karaf is for internal usage and testing 
> of Camel. The code is not polished and intended for end users.
> We should create a new module for that, and take the good parts of 
> camel-itest-karaf and make it user friendly etc. And of course have docs to 
> go with as well.
> And when its good, we can use that in camel-itest-karaf also (eat our own dog 
> food)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CAMEL-6132) camel-test-karaf - To allow end users more easily do Camel and Karaf integration test

2016-09-21 Thread Claus Ibsen (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-6132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-6132:
---
Fix Version/s: 2.19.0

> camel-test-karaf - To allow end users more easily do Camel and Karaf 
> integration test
> -
>
> Key: CAMEL-6132
> URL: https://issues.apache.org/jira/browse/CAMEL-6132
> Project: Camel
>  Issue Type: New Feature
>  Components: karaf
>Reporter: Claus Ibsen
>Assignee: Quinn Stevenson
> Fix For: 2.18.0, 2.19.0
>
>
> We should introduce a proper camel-test-karaf component that *end users* can 
> use to do Camel and Karaf integration tests.
> The code we have in tests/camel-itest-karaf is for internal usage and testing 
> of Camel. The code is not polished and intended for end users.
> We should create a new module for that, and take the good parts of 
> camel-itest-karaf and make it user friendly etc. And of course have docs to 
> go with as well.
> And when its good, we can use that in camel-itest-karaf also (eat our own dog 
> food)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-10250) spring boot - SpringBootStarterMojo should not use internal API

2016-09-21 Thread Nicola Ferraro (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509494#comment-15509494
 ] 

Nicola Ferraro commented on CAMEL-10250:


Yes, I have a fix but still didn't push it to avoid confusion with the BOM 
issue (all xmls changed because of small changes). I can merge it now.

> spring boot - SpringBootStarterMojo should not use internal API
> ---
>
> Key: CAMEL-10250
> URL: https://issues.apache.org/jira/browse/CAMEL-10250
> Project: Camel
>  Issue Type: Task
>  Components: tooling
>Reporter: Claus Ibsen
>Assignee: Nicola Ferraro
> Fix For: 2.18.0
>
>
> It uses some com.sun internal API. We should use some other XML library / 
> formatter to output using indent.
> {code}
> [INFO] Compiling 24 source files to 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/target/classes
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[47,48]
>  OutputFormat is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[48,48]
>  XMLSerializer is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,8]
>  OutputFormat is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,34]
>  OutputFormat is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,8]
>  XMLSerializer is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,39]
>  XMLSerializer is internal proprietary API and may be removed in a future 
> release
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (CAMEL-8830) Upgrade to Saxon HE 9.7

2016-09-21 Thread Luca Burgazzoli (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-8830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Luca Burgazzoli resolved CAMEL-8830.

Resolution: Fixed

> Upgrade to Saxon HE 9.7
> ---
>
> Key: CAMEL-8830
> URL: https://issues.apache.org/jira/browse/CAMEL-8830
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-saxon
>Affects Versions: 2.15.2
>Reporter: Kartik
>Assignee: Luca Burgazzoli
> Fix For: 2.18.0
>
>
> Upgrade to Saxon HE 9.6 which uses XQuery 3.0 by default, allowing to use 
> powerful new XQuery 3.0 features such as 'group by'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CAMEL-10335) Improve Saxon customization

2016-09-21 Thread Luca Burgazzoli (JIRA)
Luca Burgazzoli created CAMEL-10335:
---

 Summary: Improve Saxon customization
 Key: CAMEL-10335
 URL: https://issues.apache.org/jira/browse/CAMEL-10335
 Project: Camel
  Issue Type: Improvement
  Components: camel-saxon, camel-xslt
Reporter: Luca Burgazzoli
Priority: Minor
 Fix For: 2.18.1


Add the possibility to

- set net.sf.saxon.Configuration's properties:
{code:java}
config.setConfigurationProperty(key, value);
{code}

- lookup net.sf.saxon.Configuration from registry



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (CAMEL-10250) spring boot - SpringBootStarterMojo should not use internal API

2016-09-21 Thread Nicola Ferraro (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-10250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicola Ferraro resolved CAMEL-10250.

Resolution: Fixed

> spring boot - SpringBootStarterMojo should not use internal API
> ---
>
> Key: CAMEL-10250
> URL: https://issues.apache.org/jira/browse/CAMEL-10250
> Project: Camel
>  Issue Type: Task
>  Components: tooling
>Reporter: Claus Ibsen
>Assignee: Nicola Ferraro
> Fix For: 2.18.0
>
>
> It uses some com.sun internal API. We should use some other XML library / 
> formatter to output using indent.
> {code}
> [INFO] Compiling 24 source files to 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/target/classes
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[47,48]
>  OutputFormat is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[48,48]
>  XMLSerializer is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,8]
>  OutputFormat is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[489,34]
>  OutputFormat is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,8]
>  XMLSerializer is internal proprietary API and may be removed in a future 
> release
> [WARNING] 
> /Users/davsclaus/workspace/camel/tooling/maven/camel-package-maven-plugin/src/main/java/org/apache/camel/maven/packaging/SpringBootStarterMojo.java:[495,39]
>  XMLSerializer is internal proprietary API and may be removed in a future 
> release
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-10304) Apache Camel Docker component not working in OSGi environment

2016-09-21 Thread Philip Andrew (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509725#comment-15509725
 ] 

Philip Andrew commented on CAMEL-10304:
---

Looking forward to see the new component.

> Apache Camel Docker component not working in OSGi environment
> -
>
> Key: CAMEL-10304
> URL: https://issues.apache.org/jira/browse/CAMEL-10304
> Project: Camel
>  Issue Type: Bug
>  Components: camel-docker
>Affects Versions: 2.17.3
> Environment: Windows
>Reporter: Philip Andrew
>Priority: Minor
>
> I can not use camel-docker in the OSGi environment, exception is thrown.
> java.lang.RuntimeException: java.lang.ClassNotFoundException: Provider 
> org.glass fish.jersey.internal.RuntimeDelegateImpl could not be instantiated: 
> java.lang.Il legalStateException: No generator was provided and there is no 
> default generator registered
> If I do the following workaround then it can work
> RuntimeDelegate.setInstance(new 
> org.glassfish.jersey.server.internal.RuntimeDelegateImpl())
> http://stackoverflow.com/questions/39382056/how-to-get-apache-camel-docker-component-to-work-in-osgi-or-jersey-does-not-wo



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (CAMEL-10321) New Component camel-asterisk

2016-09-21 Thread Andrea Cosentino (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Cosentino resolved CAMEL-10321.
--
Resolution: Fixed

> New Component camel-asterisk
> 
>
> Key: CAMEL-10321
> URL: https://issues.apache.org/jira/browse/CAMEL-10321
> Project: Camel
>  Issue Type: New Feature
>Reporter: Fabrizio Spataro
>Assignee: Fabrizio Spataro
>
> Hello,
> i wrote a component to send and receive event from an asterisk VOIP server.
> Can i send my PR? Is it compatible with apache camel code license?
> King Regard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-10197) camel-spring-boot - Extend the configuration hints to nested properties

2016-09-21 Thread Dhiraj Bokde (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509942#comment-15509942
 ] 

Dhiraj Bokde commented on CAMEL-10197:
--

Sorry about the broken build guys. I was weary about the omni commit, but there 
was no way around it. I thought I had built the components-starter project 
locally, must have forgot to do it right before pushing the final changes. 

I had added a check for properties with no fields, but {{HeaderFilterStrategy}} 
seems to have slipped through somehow. The recursive properties case cab be 
automatically handled too. I'll fix those issues today. 

> camel-spring-boot - Extend the configuration hints to nested properties
> ---
>
> Key: CAMEL-10197
> URL: https://issues.apache.org/jira/browse/CAMEL-10197
> Project: Camel
>  Issue Type: Improvement
>  Components: camel-spring-boot
>Reporter: Nicola Ferraro
>Assignee: Dhiraj Bokde
> Fix For: 2.18.0
>
>
> Support for spring-boot configuration allows users to configure the component 
> properties but does not give any hint on nested properties.
> There are many components that declare properties on nested beans.
> Eg. camel-docker has only one property named _configuration_ .  I found this 
> pattern in components that allow users to specify a default value on the 
> component and override it on each endpoint, if necessary.
> Setting the property:
> {code}
> camel.component.docker.configuration.host=172.28.128.4
> {code}
> allows a user to specify the docker host, but the tooling does not give 
> suggestions about that property.
> A way to allow the users to view the nested properties is using the 
> {{NestedConfigurationProperty}} annotation on the spring-boot configuration 
> class. The spring-boot inspector will scan the nested class for properties.
> The drawback is that the javadoc is not read from setters. Another drawback 
> is that we will be using a different approach respect to the "read-the-json" 
> one.
> We need to figure out how to add these properties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (CAMEL-10321) New Component camel-asterisk

2016-09-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CAMEL-10321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510052#comment-15510052
 ] 

ASF GitHub Bot commented on CAMEL-10321:


Github user Fabryprog closed the pull request at:

https://github.com/apache/camel/pull/1180


> New Component camel-asterisk
> 
>
> Key: CAMEL-10321
> URL: https://issues.apache.org/jira/browse/CAMEL-10321
> Project: Camel
>  Issue Type: New Feature
>Reporter: Fabrizio Spataro
>Assignee: Fabrizio Spataro
>
> Hello,
> i wrote a component to send and receive event from an asterisk VOIP server.
> Can i send my PR? Is it compatible with apache camel code license?
> King Regard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CAMEL-10336) Complete AMI features

2016-09-21 Thread Fabrizio Spataro (JIRA)
Fabrizio Spataro created CAMEL-10336:


 Summary: Complete AMI features
 Key: CAMEL-10336
 URL: https://issues.apache.org/jira/browse/CAMEL-10336
 Project: Camel
  Issue Type: New Feature
Affects Versions: 2.18.0
Reporter: Fabrizio Spataro
Assignee: Fabrizio Spataro
 Fix For: 2.18.1


After resolution of CAMEL-10321 apache camel have a new component: 
"camel-asterisk".

This initial release support a little subset of AMI API

This issue to remember me to insert new functionalities.

http://www.voip-info.org/wiki/view/Asterisk+manager+API



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (CAMEL-10327) New Apache drill component

2016-09-21 Thread Fabrizio Spataro (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-10327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fabrizio Spataro reassigned CAMEL-10327:


Assignee: Fabrizio Spataro

> New Apache drill component
> --
>
> Key: CAMEL-10327
> URL: https://issues.apache.org/jira/browse/CAMEL-10327
> Project: Camel
>  Issue Type: New Feature
>Reporter: Fabrizio Spataro
>Assignee: Fabrizio Spataro
>Priority: Minor
>
> Hello,
> the main idea is to create a producer to run queries on the apache drill 
> cluster. Can i start to develop this "simple" producer?
> kings regards



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (CAMEL-10337) camel-asterix - Endpoint should be singleton

2016-09-21 Thread Claus Ibsen (JIRA)

 [ 
https://issues.apache.org/jira/browse/CAMEL-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Claus Ibsen updated CAMEL-10337:

Assignee: Fabrizio Spataro

> camel-asterix - Endpoint should be singleton
> 
>
> Key: CAMEL-10337
> URL: https://issues.apache.org/jira/browse/CAMEL-10337
> Project: Camel
>  Issue Type: Improvement
>Reporter: Claus Ibsen
>Assignee: Fabrizio Spataro
>Priority: Minor
> Fix For: 2.18.0
>
>
> We should favor to not store state on the endpoint but keep them as plain 
> configuration.
> I added a TODO in the endpoint source code. 
> Also is the hostname option required to be configured? I think so, and if so 
> then add required=true to the UriParam. And also add some logic to check its 
> configured.
> And also when the consumer stops, then the listener should be removed, eg 
> when you add a listetener, you should consider to also remove it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (CAMEL-10337) camel-asterix - Endpoint should be singleton

2016-09-21 Thread Claus Ibsen (JIRA)
Claus Ibsen created CAMEL-10337:
---

 Summary: camel-asterix - Endpoint should be singleton
 Key: CAMEL-10337
 URL: https://issues.apache.org/jira/browse/CAMEL-10337
 Project: Camel
  Issue Type: Improvement
Reporter: Claus Ibsen
Priority: Minor
 Fix For: 2.18.0


We should favor to not store state on the endpoint but keep them as plain 
configuration.

I added a TODO in the endpoint source code. 

Also is the hostname option required to be configured? I think so, and if so 
then add required=true to the UriParam. And also add some logic to check its 
configured.

And also when the consumer stops, then the listener should be removed, eg when 
you add a listetener, you should consider to also remove it.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)