[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2555 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6054/ ---
[GitHub] carbondata issue #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2574 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6053/ ---
[GitHub] carbondata issue #2567: [CARBONDATA-2790][BloomDataMap]Optimize default para...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2567 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6052/ ---
[GitHub] carbondata issue #2564: [CARBONDATA-2785][ExternalFormat] Optimize table pru...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2564 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6051/ ---
[GitHub] carbondata issue #2441: [CARBONDATA-2625] optimize CarbonReader performance
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2441 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6050/ ---
[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...
Github user dhatchayani commented on the issue: https://github.com/apache/carbondata/pull/2555 Retest sdv please ---
[GitHub] carbondata issue #2552: [CARBONDATA-2781] Added fix for Null Pointer Excpeti...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2552 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6049/ ---
[GitHub] carbondata issue #2546: [CARBONDATA-2775] Adaptive encoding fails for Unsafe...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2546 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6048/ ---
[GitHub] carbondata issue #2561: [CARBONDATA-2784][CARBONDATA-2786][SDK writer] Fixed...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2561 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6047/ ---
[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2555 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6046/ ---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2575 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6045/ ---
[GitHub] carbondata issue #2565: WIP: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bug...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6345/ ---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2573 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6044/ ---
[GitHub] carbondata issue #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2574 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6346/ ---
[GitHub] carbondata issue #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/2574 @xuchuanyin ...It is better that we should go with PR #2565 as it contains the proper code which handles the bugs. ---
[GitHub] carbondata pull request #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix b...
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2574#discussion_r205948912
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
---
@@ -542,48 +551,48 @@ protected void
createSummaryDMStore(BlockletDataMapModel blockletDataMapModel)
List blocklets = new ArrayList<>();
CarbonRowSchema[] schema = getFileFooterEntrySchema();
String filePath = getFilePath();
-int numBlocklets = 0;
-if (filterExp == null) {
- numBlocklets = memoryDMStore.getRowCount();
- for (int i = 0; i < numBlocklets; i++) {
-DataMapRow safeRow = memoryDMStore.getDataMapRow(schema,
i).convertToSafeRow();
-blocklets.add(createBlocklet(safeRow,
getFileNameWithFilePath(safeRow, filePath),
-getBlockletId(safeRow), false));
- }
-} else {
- // Remove B-tree jump logic as start and end key prepared is not
- // correct for old store scenarios
- int startIndex = 0;
- numBlocklets = memoryDMStore.getRowCount();
- FilterExecuter filterExecuter = FilterUtil
- .getFilterExecuterTree(filterExp, getSegmentProperties(), null,
getMinMaxCacheColumns());
- // flag to be used for deciding whether use min/max in executor
pruning for BlockletDataMap
- boolean useMinMaxForPruning = useMinMaxForExecutorPruning(filterExp);
- // min and max for executor pruning
- while (startIndex < numBlocklets) {
-DataMapRow safeRow = memoryDMStore.getDataMapRow(schema,
startIndex).convertToSafeRow();
-String fileName = getFileNameWithFilePath(safeRow, filePath);
-short blockletId = getBlockletId(safeRow);
-boolean isValid =
-addBlockBasedOnMinMaxValue(filterExecuter,
getMinMaxValue(safeRow, MAX_VALUES_INDEX),
-getMinMaxValue(safeRow, MIN_VALUES_INDEX), fileName,
blockletId);
-if (isValid) {
- blocklets.add(createBlocklet(safeRow, fileName, blockletId,
useMinMaxForPruning));
+ByteBuffer byteBuffer =
ByteBuffer.wrap(getBlockletRowCountForEachBlock());
--- End diff --
In case of legacy store (store in version < = 1.1), we are not storing the
blocklet count as the index file footer does not contain the blocklet
information...so this code will throw exception
---
[GitHub] carbondata pull request #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix b...
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2574#discussion_r205948964
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
@@ -223,17 +222,15 @@ protected short getBlockletId(DataMapRow dataMapRow) {
return dataMapRow.getShort(BLOCKLET_ID_INDEX);
}
- protected ExtendedBlocklet createBlocklet(DataMapRow row, String
fileName, short blockletId,
- boolean useMinMaxForPruning) {
+ protected ExtendedBlocklet createBlocklet(DataMapRow row, String
fileName, short blockletId) {
if (isLegacyStore) {
- return super.createBlocklet(row, fileName, blockletId,
useMinMaxForPruning);
+ return super.createBlocklet(row, fileName, blockletId);
--- End diff --
useMinMaxForPruning flag is added to handle a different scenario where
cache_level = blocklet and the filter column min max in not cached in driver.
In that case the blocklet pruning for min/max needs to be done in each executor
which is identified using this flag.
---
[GitHub] carbondata issue #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2574 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7591/ ---
[GitHub] carbondata issue #2567: [CARBONDATA-2790][BloomDataMap]Optimize default para...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2567 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6344/ ---
[GitHub] carbondata issue #2565: WIP: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bug...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7590/ ---
[GitHub] carbondata issue #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2574 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6043/ ---
[GitHub] carbondata issue #2567: [CARBONDATA-2790][BloomDataMap]Optimize default para...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2567 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7589/ ---
[GitHub] carbondata issue #2441: [CARBONDATA-2625] optimize CarbonReader performance
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2441 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6343/ ---
[GitHub] carbondata issue #2561: [CARBONDATA-2784][CARBONDATA-2786][SDK writer] Fixed...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2561 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6341/ ---
[GitHub] carbondata issue #2441: [CARBONDATA-2625] optimize CarbonReader performance
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2441 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7588/ ---
[GitHub] carbondata issue #2546: [CARBONDATA-2775] Adaptive encoding fails for Unsafe...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2546 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6342/ ---
[GitHub] carbondata pull request #2575: [WIP] fixed for ModularPlan exception during ...
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2575#discussion_r205946534
--- Diff:
datamap/mv/core/src/main/scala/org/apache/carbondata/mv/datamap/MVAnalyzerRule.scala
---
@@ -80,7 +80,7 @@ class MVAnalyzerRule(sparkSession: SparkSession) extends
Rule[LogicalPlan] {
}
def isValidPlan(plan: LogicalPlan, catalog: SummaryDatasetCatalog):
Boolean = {
-!plan.isInstanceOf[Command] && !isDataMapExists(plan,
catalog.listAllSchema()) &&
+!plan.isInstanceOf[Command] && isDataMapExists(plan,
catalog.listAllSchema()) &&
--- End diff --
This check is wrong. what exactly the problem you are facing? can you add
some test case
---
[GitHub] carbondata issue #2546: [CARBONDATA-2775] Adaptive encoding fails for Unsafe...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2546 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7587/ ---
[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2555 LGTM ---
[GitHub] carbondata issue #2561: [CARBONDATA-2784][CARBONDATA-2786][SDK writer] Fixed...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2561 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7586/ ---
[GitHub] carbondata issue #2565: WIP: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bug...
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2565 PR2574 is to replace this PR ---
[GitHub] carbondata issue #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2574 refactored the pruning procedure for BlockDataMap ---
[GitHub] carbondata issue #2561: [CARBONDATA-2784][CARBONDATA-2786][SDK writer] Fixed...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2561 LGTM ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2565 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6042/ ---
[GitHub] carbondata issue #2567: [CARBONDATA-2790][BloomDataMap]Optimize default para...
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/2567 retest sdv please ---
[GitHub] carbondata issue #2567: [CARBONDATA-2790][BloomDataMap]Optimize default para...
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/2567 retest this please ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/2565 retest this please ---
[GitHub] carbondata issue #2564: [CARBONDATA-2785][ExternalFormat] Optimize table pru...
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/2564 retest sdv please ---
[GitHub] carbondata issue #2441: [CARBONDATA-2625] optimize CarbonReader performance
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/2441 retest sdv please ---
[GitHub] carbondata issue #2552: [CARBONDATA-2781] Added fix for Null Pointer Excpeti...
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/2552 retest sdv please ---
[GitHub] carbondata issue #2546: [CARBONDATA-2775] Adaptive encoding fails for Unsafe...
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/2546 retest sdv please ---
[GitHub] carbondata issue #2546: [CARBONDATA-2775] Adaptive encoding fails for Unsafe...
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/2546 retest this please ---
[GitHub] carbondata issue #2561: [CARBONDATA-2784][CARBONDATA-2786][SDK writer] Fixed...
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/2561 retest sdv please ---
[GitHub] carbondata issue #2561: [CARBONDATA-2784][CARBONDATA-2786][SDK writer] Fixed...
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/2561 retest this please ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2565 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6041/ ---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2573 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6340/ ---
[GitHub] carbondata issue #2555: [CARBONDATA-2753][Compatibility] Row count of page i...
Github user dhatchayani commented on the issue: https://github.com/apache/carbondata/pull/2555 retest sdv please ---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2573 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7585/ ---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2575 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6339/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2565 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6040/ ---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Github user Indhumathi27 commented on the issue: https://github.com/apache/carbondata/pull/2573 Retest this please ---
[GitHub] carbondata issue #2575: [WIP] fixed for ModularPlan exception during update ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2575 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7584/ ---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2573 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6338/ ---
[GitHub] carbondata issue #2573: [CARBONDATA-2794]Distinct count fails on ArrayOfStru...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2573 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7583/ ---
[GitHub] carbondata issue #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2574 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6337/ ---
[GitHub] carbondata pull request #2575: [WIP] fixed for ModularPlan exception during ...
GitHub user rahulforallp opened a pull request: https://github.com/apache/carbondata/pull/2575 [WIP] fixed for ModularPlan exception during update query update query is failing in spark-2.2 cluster if mv jars are available because catalogs are not empty if datamap are created for other table also and returns true from isValidPlan() inside MVAnalyzerRule. - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rahulforallp/incubator-carbondata mv_fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2575.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2575 commit 043898b523ed26a4de04b18af257223a0a918d6b Author: rahul Date: 2018-07-28T10:55:07Z fixed for ModularPlan exception during update query ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2565 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6039/ ---
[GitHub] carbondata issue #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2574 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7582/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2565 Hi, all @jackylk @ravipesala @manishgupta88 @chenliang613 I raised another PR #2574 as another implementation for this PR, please check it also ---
[GitHub] carbondata pull request #2573: [CARBONDATA-2794]Distinct count fails on Arra...
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2573#discussion_r205938933
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonLateDecodeRule.scala
---
@@ -743,7 +743,7 @@ class CarbonLateDecodeRule extends Rule[LogicalPlan]
with PredicateHelper {
attrName.contains(n)
})
case ar : ArrayType =>
- attrName.contains(a.name + "[")
+ attrName.contains(a.name + "[") ||
ar.elementType.isInstanceOf[StructType]
--- End diff --
Don't check on the outut,
Add as below to check the child types also.
`attrName.contains(a.name + "[") || attrName.contains(a.name + ".")`
---
[GitHub] carbondata issue #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2574 hi @ravipesala can you check this PR also. It contains three problems, you can refer to the description of the PR for more information ---
[GitHub] carbondata issue #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2574 hi @manishgupta88, can you check this PR. It is intended to replace PR #2565 ---
[GitHub] carbondata pull request #2574: [HotFix][CARBONDATA-2788][BloomDataMap] Fix b...
GitHub user xuchuanyin opened a pull request: https://github.com/apache/carbondata/pull/2574 [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in incorrect query result with bloom datamap This PR solve three problems which will affect the correctness of the query on bloom. 1. optimize blockletId in rebuilding datamap After review the code, we found that modification in PR2539 is not needed, so we revert that PR. 2. bugs in overflow for blocklet count Carbondata stores blocklet count for each block in byte data type, when a block contains more than 128 blocklets, it will overflow the byte limits. Here we change the data type to short. 3. Fix bug in querying with bloom datamap with block cache level enabled In block cache level scenario, previously the main BlockDataMap return block as pruned blocklet with its blockletId=-1; However, other index datamap such as BloomDataMap return actual blocklet with correct blockletId. Due to the behaviour of Blocklet's hashcode, some blocklets will be uncorrectly marked as duplicated and dropped. Thus cause incorrect query result. To fix this problem, we will return all blocklets with correct blockletId for the block instead of returning a fake blocklet with blockletId=-1. This will not affect the following procedure. Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xuchuanyin/carbondata 0728_fix_bug_query_bloom_opt Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2574.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2574 commit cba17975affad343d555f49cb255043b556310f7 Author: xuchuanyin Date: 2018-07-27T13:13:51Z Fix bugs in overflow for blocklet count Carbondata stores blocklet count for each block in byte data type, when a block contains more than 128 blocklets, it will overflow the byte limits. Here we change the data type to short. commit 7e41d9533dae86ab26e102a0342c128cbab03d1c Author: xuchuanyin Date: 2018-07-28T07:37:38Z Revert optimize blockletId in rebuilding datamap We found querying huge data with rebuilding bloom datamap will give incorrect result. The root cause is that the blockletId in ResultCollector is wrong. (This was introduced in PR2539) We will revert the previous modification for this. Now it is checked and works fine. commit e418018e05cb0a15c996c5bb58debb0486252f84 Author: xuchuanyin Date: 2018-07-28T09:08:52Z Fix bug in querying with bloom datamap with block cache level enabled In block cache level scenario, previously the main BlockDataMap return block as pruned blocklet with its blockletId=-1; However, other index datamap such as BloomDataMap return actual blocklet with correct blockletId. Due to the behaviour of Blocklet's hashcode, some blocklets will be uncorrectly marked as duplicated and dropped. Thus cause incorrect query result. To fix this problem, we will return all blocklets with correct blockletId for the block instead of returning a fake blocklet with blockletId=-1. This will not affect the following procedure. ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6336/ ---
[GitHub] carbondata issue #2517: [CARBONDATA-2749][dataload] In HDFS Empty tablestatu...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2517 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6038/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2565 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7581/ ---
[GitHub] carbondata issue #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix bugs in ...
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2565 retest this please ---
[GitHub] carbondata issue #2570: [wip]disable local dictionary by default
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2570 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6036/ ---
[GitHub] carbondata pull request #2565: [HotFix][CARBONDATA-2788][BloomDataMap] Fix b...
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2565#discussion_r205934275 --- Diff: datamap/bloom/src/main/java/org/apache/carbondata/datamap/bloom/BloomCoarseGrainDataMap.java --- @@ -165,9 +180,11 @@ public void initIndexColumnConverters(CarbonTable carbonTable, List
