[GitHub] carbondata issue #2725: [WIP] Added code to support storing min max for stri...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2725 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/302/ ---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2726 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/301/ ---
[GitHub] carbondata issue #2719: [HOTFIX] changed AbstractDFSFileSystem to use existi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2719 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/474/ ---
[GitHub] carbondata issue #2691: [CARBONDATA-2912] Support CSV table load csv data wi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2691 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/475/ ---
[GitHub] carbondata issue #2719: [HOTFIX] changed AbstractDFSFileSystem to use existi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2719 Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8544/ ---
[GitHub] carbondata issue #2691: [CARBONDATA-2912] Support CSV table load csv data wi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2691 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/300/ ---
[GitHub] carbondata issue #2725: [WIP] Added code to support storing min max for stri...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2725 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/473/ ---
[GitHub] carbondata issue #2725: [WIP] Added code to support storing min max for stri...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2725 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8543/ ---
[GitHub] carbondata issue #2691: [CARBONDATA-2912] Support CSV table load csv data wi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2691 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8545/ ---
[GitHub] carbondata issue #2691: [CARBONDATA-2912] Support CSV table load csv data wi...
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2691 retest this please ---
[GitHub] carbondata pull request #2665: [CARBONDATA-2897][DataMap] Optimize datamap c...
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2665#discussion_r217945289
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/DataMapChooser.java ---
@@ -268,23 +238,38 @@ private ExpressionTuple selectDataMap(Expression
expression, List
private void extractColumnExpression(Expression expression,
List columnExpressions) {
-if (expression instanceof ColumnExpression) {
- columnExpressions.add((ColumnExpression) expression);
-} else if (expression instanceof MatchExpression) {
- // this is a special case for lucene
- // build a fake ColumnExpression to filter datamaps which contain
target column
- // a Lucene query string is alike "column:query term"
- String[] queryItems = expression.getString().split(":", 2);
- if (queryItems.length == 2) {
-columnExpressions.add(new ColumnExpression(queryItems[0], null));
- }
-} else if (expression != null) {
- List children = expression.getChildren();
- if (children != null && children.size() > 0) {
-for (Expression exp : children) {
- extractColumnExpression(exp, columnExpressions);
+switch (expression.getFilterExpressionType()) {
--- End diff --
I think these operation should not be in DataMapChooser.
DataMapChooser is for common logic and should not handle specific datamap's
logic.
If you want to decide which expression will be supported by the specific
datamap, here I do propose you to refactor the 'SUPPORTED_EXPRESSION' in the
specific datamap. In that place, the datamap should declare what kind of
operand and operator it will support and in DataMapChooser we just need to call
that method and decide which expression will be handled by that datamap.
---
[GitHub] carbondata issue #2719: [HOTFIX] changed AbstractDFSFileSystem to use existi...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2719 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/299/ ---
[GitHub] carbondata issue #2719: [HOTFIX] changed AbstractDFSFileSystem to use existi...
Github user brijoobopanna commented on the issue: https://github.com/apache/carbondata/pull/2719 retest this please ---
[GitHub] carbondata issue #2725: [WIP] Added code to support storing min max for stri...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2725 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/298/ ---
[GitHub] carbondata issue #2715: [CARBONDATA-2930] Support customize column compresso...
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/2715 @ravipesala yeah, we do have a test "test create table with customize compressor" for this 'User can specify the customize compressor while creating table'. ---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2726 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/297/ ---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2726 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8542/ ---
[GitHub] carbondata issue #2726: [WIP] Float and Byte DataType support
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2726 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/472/ ---
[GitHub] carbondata pull request #2726: [WIP] Float and Byte DataType support
GitHub user kunal642 opened a pull request: https://github.com/apache/carbondata/pull/2726 [WIP] Float and Byte DataType support Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kunal642/carbondata float_support Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2726.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2726 commit aca611a18070b1db61e66e011fc7064848d1f083 Author: kunal642 Date: 2018-09-14T09:56:10Z added support for float data type commit a4c976f77f2c40f334236b49e3949f66ea38c4e3 Author: kunal642 Date: 2018-09-16T22:52:55Z addede support for byte type ---
[GitHub] carbondata issue #2725: [WIP] Added code to support storing min max for stri...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2725 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/471/ ---
[GitHub] carbondata issue #2725: [WIP] Added code to support storing min max for stri...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2725 Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8541/ ---
[GitHub] carbondata issue #2725: [WIP] Added code to support storing min max for stri...
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2725 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/296/ ---
[GitHub] carbondata pull request #2725: [WIP] Added code to support storing min max f...
GitHub user manishgupta88 opened a pull request: https://github.com/apache/carbondata/pull/2725 [WIP] Added code to support storing min max for string columns based on number of characacters - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manishgupta88/carbondata string_min_max_decision Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2725.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2725 commit 6ef6d880e68aa3bfc1c704659c916b384e5d545a Author: manishgupta88 Date: 2018-09-14T05:13:20Z Modified code to support writing the min max flag for all the columns in the metadata. This will help in deciding whether min max for a column is written or not commit 4ed24f3972cb4c03133912ba8a1c9d35b3122e7a Author: manishgupta88 Date: 2018-09-15T06:20:03Z Modified code to support filter query using min max flag for a column ---
